Skip to content

chore(confirmations): set the MM Pay custom amount input in Grotzec Hero cp-13.57.0 - #47565

Merged
georgewrmarshall merged 8 commits into
mainfrom
cursor/grotzec-custom-amount-input-f3b4
Nov 5, 2026
Merged

georgewrmarshall merged 8 commits into
mainfrom
cursor/grotzec-custom-amount-input-f3b4

Conversation

@georgewrmarshall

@georgewrmarshall georgewrmarshall commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Stacked on #47564 (shared font-size helper) — merge that first.

Description

This is the @MetaMask/confirmations slice of the Grotzec large number amount inputs. It was split from the UAT build in #47557.

Depends on #47564 (the shared amount scale and useAmountInputFontSize hook). This PR is stacked on #47564's branch (cursor/grotzec-amount-input-scale-f3b4) and does not carry its own copy of the helper, so its diff shows only this slice. Merge #47564 first, then retarget this PR to main.

What is the reason for the change? CustomAmount (ui/pages/confirmations/components/transactions/custom-amount/custom-amount.tsx) is the MM Pay hero amount. It is used by Perps deposit, the Perps withdraw confirmation, mUSD conversion and Money account deposit and withdraw. It was still Inter at weight 500, sized 64/40/30/20px with line heights 70/44/33/22px, using legacy component-library Text and a raw <input> sized in ch. Mobile moves the same component to Grotzec in #38135.

What is the improvement?

  • MMDS Input. The <input> is now the MMDS Input (textVariant={AmountDisplayLg}, font-hero, isStateStylesDisabled). The symbol is MMDS Text AmountDisplayLg + FontFamily.Hero.
  • Width. The ch estimate is replaced with the hidden measuring Text that its Perps twin (PerpsFiatHeroAmountInput) uses. The measuring Text is set in the same font, so the input width is exact for Grotzec and for fallback symbols.
  • Sizing. Sizes come from the shared scale in feat: add a HeroAmountInput component for large amount inputs #47564: 88, 72, 60, 48, 40, 32, 24, 20px, taking the largest step at which the symbol and amount fit the input's measured width (useAmountInputFontSize, one ResizeObserver per input; 328px is only the fallback before the first measurement). Line height equals font size. In the expanded view long amounts stay large instead of shrinking early. At the 328px popup width, $25 is 88px, $1234567.89 is 72px and a 20-digit amount is 32px. The row and the rounded-lg skeleton are both 88px, as in Mobile [Bug]: Balances are not updating on extension after signup #38135.
  • Unchanged. Test IDs (custom-amount-input, custom-amount-symbol, custom-amount-skeleton), cents-only display, the 2-decimal input pattern, autoFocus and the alert and disabled colours are unchanged. The E2E page objects use the same test IDs.

Risks

  • This changes the hero on five confirmation flows at once: Perps deposit, Perps withdraw, mUSD conversion, and Money deposit and withdraw.
  • Symbols Grotzec lacks (₹ ₩ ₿ …) render in the fallback family. The shared scale budgets for their extra width.
  • The weight changes from 500 Inter to the Bold Grotzec cut.

Changelog

CHANGELOG entry: Updated the MetaMask Pay amount input to the Grotzec typeface

Related issues

Epic: TMCU-1741. A child ticket is still to be created.
Depends on: #47564
Split from: #47557

Manual testing steps

  1. Load this branch in the extension.
  2. Start a Perps deposit. Confirm the amount is Grotzec at 88px for 25. Then type 123456789012.34 one key at a time and confirm it steps down 88 → 72 → 60 → 48px and stays centred.
  3. Click Max or a percentage and confirm the amount shows at most 2 decimals.
  4. Enter more than the balance and confirm the amount turns red.
  5. Repeat the short and long amount check in mUSD conversion and in Money account deposit and withdraw.
  6. Repeat in the expanded view, where long amounts stay larger instead of shrinking early, and in the side panel, where they step down smoothly as the width narrows.

Screenshots/Recordings

Before / After by code owner

Before is main @adeaf9ad59 and After is the UAT head (#47557) @28a7077e43, both recorded with the same typing script (type 5, then 500000000000000000, then clear).

MM Pay custom amount

Before After
MM Pay custom amount before, side panel MM Pay custom amount after, side panel
MM Pay custom amount before, expanded view MM Pay custom amount after, expanded view

Full MP4s: Side panel before · Side panel after · Expanded before · Expanded after

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Open in Web Open in Cursor 

Note

Medium Risk
The same hero control drives several MM Pay confirmation flows; visual and sizing behavior change via the shared component, though fiat display rules and input constraints stay equivalent.

Reviewed by Cursor Bugbot for commit 30842bf. Bugbot is set up for automated code reviews on this repo. Configure here.

@metamask-ci

metamask-ci Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations (2 files, +105 -161)
  • 📁 ui/
    • 📁 pages/
      • 📁 confirmations/
        • 📁 components/
          • 📁 transactions/
            • 📁 custom-amount/
              • 📄 custom-amount.test.tsx +86 -26
              • 📄 custom-amount.tsx +19 -135

@metamask-ci

metamask-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
Builds ready [7a15149]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 3 warn · 🔴 4 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41560447436 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↑ loadNewAccount/fcp: +12%
  • ↑ loadNewAccount/cls: +1195%
  • ↑ confirmTx/longTaskTotalDuration: +74%
  • ↑ confirmTx/longTaskMaxDuration: +105%
  • ↑ confirmTx/tbt: +130%
  • ↑ confirmTx/fcp: +14%
  • ↑ confirmTx/lcp: +24%
  • ↑ bridgeUserActions/bridge_load_page: +101%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +50%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +144%
  • ↑ bridgeUserActions/longTaskMaxDuration: +70%
  • ↑ bridgeUserActions/tbt: +307%
  • ↑ bridgeUserActions/total: +14%
  • ↑ bridgeUserActions/fcp: +11%
  • ↑ bridgeUserActions/cls: +1181%
  • ↑ loadNewAccount/load_new_account: +420%
  • ↑ loadNewAccount/total: +420%
  • ↓ loadNewAccount/inp: -24%
  • ↓ loadNewAccount/fcp: -30%
  • ↑ loadNewAccount/lcp: +1313%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -17%
  • ↓ confirmTx/fcp: -34%
  • ↑ confirmTx/lcp: +1334%
  • ↑ bridgeUserActions/bridge_load_page: +349%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +119%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +51%
  • ↑ bridgeUserActions/inp: +62%
  • ↑ bridgeUserActions/fcp: +18%
  • ↑ bridgeUserActions/lcp: +1290%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -10%
  • ↓ startupStandardHome/load: -12%
  • ↓ startupStandardHome/domContentLoaded: -12%
  • ↓ startupStandardHome/backgroundConnect: -15%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↓ startupStandardHome/loadScripts: -13%
  • ↑ startupStandardHome/setupStore: +74%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -21%
  • ↓ startupStandardHome/longTaskMaxDuration: -16%
  • ↓ startupStandardHome/tbt: -17%
  • ↓ startupStandardHome/fcp: -13%
  • ↓ startupStandardHome/uiStartup: -40%
  • ↓ startupStandardHome/load: -36%
  • ↓ startupStandardHome/domContentLoaded: -38%
  • ↓ startupStandardHome/domInteractive: -55%
  • ↓ startupStandardHome/backgroundConnect: -38%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -36%
  • ↑ startupStandardHome/setupStore: +29%
  • ↓ startupStandardHome/fcp: -43%
  • ↓ startupStandardHome/lcp: -34%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +49%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +40%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +40%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +37%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +42%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +36%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +24%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +25%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -78%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -74%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -38%
  • ↓ onboardingNewWallet/tbt: -83%
  • ↓ onboardingNewWallet/total: -74%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -54%
  • ↓ dappPageLoad/firstPaint: -32%
  • ↓ dappPageLoad/firstContentfulPaint: -32%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.26 MiB +137 Bytes 0.00%
🚨 ui 19.33 MiB +1.11 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +7 Bytes 0.00%
✅ content scripts 3.23 MiB +14 Bytes 0.00%
🚨 unzipped 79.89 MiB +1.27 KiB 0.00%
✅ zip 24.07 MiB +496 Bytes 0.00%

@cursor
cursor Bot force-pushed the cursor/grotzec-custom-amount-input-f3b4 branch from 6eee458 to 5e6c93a Compare November 3, 2026 20:08
@cursor
cursor Bot changed the base branch from main to cursor/grotzec-amount-input-scale-f3b4 November 3, 2026 20:11
@metamask-ci

metamask-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
Builds ready [5e6c93a] [reused from 6eee458]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 1 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 41709807852 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -25%
  • ↓ loadNewAccount/fcp: -21%
  • ↑ loadNewAccount/cls: +278%
  • ↑ confirmTx/longTaskMaxDuration: +24%
  • ↑ confirmTx/tbt: +14%
  • ↓ confirmTx/inp: -29%
  • ↓ confirmTx/fcp: -24%
  • ↓ confirmTx/lcp: -14%
  • ↓ bridgeUserActions/bridge_load_asset_picker: -16%
  • ↓ bridgeUserActions/longTaskTotalDuration: -26%
  • ↓ bridgeUserActions/longTaskMaxDuration: -27%
  • ↓ bridgeUserActions/tbt: -52%
  • ↓ bridgeUserActions/inp: -12%
  • ↓ bridgeUserActions/fcp: -26%
  • ↓ bridgeUserActions/lcp: -16%
  • ↑ bridgeUserActions/cls: +281%
  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↑ loadNewAccount/inp: +49%
  • ↓ loadNewAccount/fcp: -29%
  • ↑ loadNewAccount/lcp: +1269%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -21%
  • ↑ confirmTx/fcp: +21%
  • ↑ confirmTx/lcp: +1352%
  • ↑ bridgeUserActions/bridge_load_page: +244%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +102%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +40%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -35%
  • ↑ bridgeUserActions/lcp: +1284%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 confirmTx/FCP: p75 2.1s
Startup Benchmarks · Samples: 100

⚠️ Missing data: firefox/webpack/startupStandardHome

Benchmarkchrome-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -17%
  • ↓ startupStandardHome/load: -20%
  • ↓ startupStandardHome/domContentLoaded: -20%
  • ↓ startupStandardHome/backgroundConnect: -20%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↓ startupStandardHome/loadScripts: -21%
  • ↑ startupStandardHome/setupStore: +82%
  • ↓ startupStandardHome/longTaskCount: -29%
  • ↓ startupStandardHome/longTaskTotalDuration: -24%
  • ↓ startupStandardHome/longTaskMaxDuration: -24%
  • ↓ startupStandardHome/tbt: -24%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -19%
  • ↑ startupStandardHome/cls: +400%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +36%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +30%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +28%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +19%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -79%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -75%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -52%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.26 MiB +107 Bytes 0.00%
🚨 ui 19.33 MiB +3.41 KiB +0.02%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +14 Bytes 0.00%
✅ content scripts 3.23 MiB +28 Bytes 0.00%
🚨 unzipped 79.9 MiB +6.66 KiB +0.01%
🚨 zip 24.07 MiB +2.64 KiB +0.01%

@cursor
cursor Bot force-pushed the cursor/grotzec-custom-amount-input-f3b4 branch from 39f41ac to 4b1fe3c Compare November 3, 2026 22:17
@metamask-ci

metamask-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
Builds ready [4b1fe3c]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 1 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 41729458726 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +179%
  • ↑ loadNewAccount/total: +179%
  • ↓ loadNewAccount/inp: -25%
  • ↓ loadNewAccount/fcp: -24%
  • ↑ loadNewAccount/cls: +278%
  • ↑ confirmTx/longTaskMaxDuration: +17%
  • ↑ confirmTx/tbt: +18%
  • ↓ confirmTx/inp: -44%
  • ↓ confirmTx/fcp: -24%
  • ↓ confirmTx/lcp: -11%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +54%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↓ bridgeUserActions/longTaskMaxDuration: -29%
  • ↓ bridgeUserActions/tbt: -48%
  • ↓ bridgeUserActions/inp: -19%
  • ↓ bridgeUserActions/fcp: -29%
  • ↓ bridgeUserActions/lcp: -19%
  • ↑ bridgeUserActions/cls: +281%
  • ↑ loadNewAccount/load_new_account: +184%
  • ↑ loadNewAccount/total: +184%
  • ↓ loadNewAccount/inp: -33%
  • ↓ loadNewAccount/fcp: -56%
  • ↑ loadNewAccount/lcp: +1041%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -29%
  • ↓ confirmTx/fcp: -64%
  • ↑ confirmTx/lcp: +1097%
  • ↑ bridgeUserActions/bridge_load_page: +114%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +149%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +22%
  • ↑ bridgeUserActions/inp: +18%
  • ↓ bridgeUserActions/fcp: -50%
  • ↑ bridgeUserActions/lcp: +998%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +19%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/setupStore: +121%
  • ↓ startupStandardHome/longTaskCount: -29%
  • ↑ startupStandardHome/cls: +400%
  • ↑ startupStandardHome/domInteractive: +23%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +143%
  • ↑ startupStandardHome/fcp: +26%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +43%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +37%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +44%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +17%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -73%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -78%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -74%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -53%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.26 MiB +144 Bytes 0.00%
🚨 ui 19.33 MiB +2.44 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +14 Bytes 0.00%
✅ content scripts 3.23 MiB +28 Bytes 0.00%
🚨 unzipped 79.89 MiB +2.63 KiB 0.00%
✅ zip 24.07 MiB +925 Bytes 0.00%

@georgewrmarshall
georgewrmarshall force-pushed the cursor/grotzec-custom-amount-input-f3b4 branch from 4b1fe3c to 0ee9e24 Compare November 4, 2026 19:14
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci

metamask-ci Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor
Builds ready [0ee9e24]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 4 warn · 🔴 1 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 41895117154 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🟢 [CI log]

Regressions (🔴 1 failure)

Interaction Benchmarks · Samples: 5 🔴 1
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🟢 [CI log]
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -18%
  • ↑ loadNewAccount/lcp: +13%
  • ↑ loadNewAccount/cls: +282%
  • ↑ confirmTx/longTaskTotalDuration: +57%
  • ↑ confirmTx/longTaskMaxDuration: +79%
  • ↑ confirmTx/tbt: +97%
  • ↑ confirmTx/fcp: +12%
  • ↑ bridgeUserActions/bridge_load_page: +72%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +56%
  • ↑ bridgeUserActions/longTaskCount: +82%
  • ↑ bridgeUserActions/longTaskTotalDuration: +49%
  • ↑ bridgeUserActions/tbt: +68%
  • ↑ bridgeUserActions/total: +14%
  • ↑ bridgeUserActions/inp: +18%
  • ↑ bridgeUserActions/lcp: +11%
  • ↑ bridgeUserActions/cls: +281%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -23%
  • ↓ startupStandardHome/load: -25%
  • ↓ startupStandardHome/domContentLoaded: -26%
  • ↓ startupStandardHome/domInteractive: -19%
  • ↓ startupStandardHome/firstPaint: -13%
  • ↓ startupStandardHome/backgroundConnect: -28%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↓ startupStandardHome/loadScripts: -27%
  • ↑ startupStandardHome/setupStore: +43%
  • ↓ startupStandardHome/longTaskCount: -29%
  • ↓ startupStandardHome/longTaskTotalDuration: -33%
  • ↓ startupStandardHome/longTaskMaxDuration: -31%
  • ↓ startupStandardHome/tbt: -34%
  • ↓ startupStandardHome/inp: -18%
  • ↓ startupStandardHome/fcp: -26%
  • ↓ startupStandardHome/lcp: -12%
  • ↑ startupStandardHome/cls: +400%
  • ↓ startupStandardHome/domInteractive: -11%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +138%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +35%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +29%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +26%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +26%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -91%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +146%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -79%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -74%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -50%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.26 MiB +144 Bytes 0.00%
🚨 ui 19.33 MiB +2.45 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +14 Bytes 0.00%
✅ content scripts 3.23 MiB +28 Bytes 0.00%
🚨 unzipped 79.89 MiB +3.02 KiB 0.00%
🚨 zip 24.07 MiB +1012 Bytes 0.00%

@metamask-ci

metamask-ci Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor
Builds ready [e071461]
⚡ Performance Benchmarks (Total: 🟢 11 pass · 🟡 0 warn · 🔴 1 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 41900103668 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🟢 [CI log]

Regressions (🔴 1 failure)

Interaction Benchmarks · Samples: 5 🔴 1
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🟢 [CI log]
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +178%
  • ↑ loadNewAccount/total: +178%
  • ↓ loadNewAccount/inp: -33%
  • ↓ loadNewAccount/fcp: -34%
  • ↓ loadNewAccount/lcp: -30%
  • ↑ loadNewAccount/cls: +278%
  • ↓ confirmTx/longTaskTotalDuration: -14%
  • ↓ confirmTx/tbt: -21%
  • ↓ confirmTx/inp: -52%
  • ↓ confirmTx/fcp: -35%
  • ↓ confirmTx/lcp: -24%
  • ↓ bridgeUserActions/bridge_load_page: -13%
  • ↓ bridgeUserActions/bridge_load_asset_picker: -32%
  • ↓ bridgeUserActions/longTaskTotalDuration: -37%
  • ↓ bridgeUserActions/longTaskMaxDuration: -36%
  • ↓ bridgeUserActions/tbt: -80%
  • ↓ bridgeUserActions/total: -14%
  • ↓ bridgeUserActions/inp: -34%
  • ↓ bridgeUserActions/fcp: -35%
  • ↓ bridgeUserActions/lcp: -19%
  • ↑ bridgeUserActions/cls: +281%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +14%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/setupStore: +147%
  • ↓ startupStandardHome/longTaskCount: -29%
  • ↑ startupStandardHome/cls: +400%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +38%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +32%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +25%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +18%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -31%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -27%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -29%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -51%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -76%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -73%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -50%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.26 MiB +144 Bytes 0.00%
🚨 ui 19.33 MiB +2.62 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +14 Bytes 0.00%
✅ content scripts 3.23 MiB +28 Bytes 0.00%
🚨 unzipped 79.89 MiB +3.19 KiB 0.00%
🚨 zip 24.07 MiB +1.08 KiB 0.00%

@cursor
cursor Bot force-pushed the cursor/grotzec-amount-input-scale-f3b4 branch from 37e9091 to 1eeca2c Compare November 4, 2026 23:25
amandaye0h
amandaye0h previously approved these changes Nov 5, 2026
Base automatically changed from cursor/grotzec-amount-input-scale-f3b4 to main November 5, 2026 16:56
@georgewrmarshall
georgewrmarshall dismissed stale reviews from pedronfigueiredo and amandaye0h November 5, 2026 16:56

The base branch was changed.

@metamask-ci

metamask-ci Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor
Builds ready [30842bf]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 5 warn · 🔴 2 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42075945993 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -10%
  • ↑ loadNewAccount/lcp: +977%
  • ↑ loadNewAccount/cls: +532%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +62%
  • ↑ confirmTx/longTaskMaxDuration: +49%
  • ↑ confirmTx/tbt: +83%
  • ↑ confirmTx/lcp: +996%
  • ↓ confirmTx/cls: -10%
  • ↑ bridgeUserActions/bridge_load_page: +147%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +41%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +92%
  • ↑ bridgeUserActions/longTaskMaxDuration: +41%
  • ↑ bridgeUserActions/tbt: +168%
  • ↑ bridgeUserActions/total: +19%
  • ↑ bridgeUserActions/inp: +10%
  • ↑ bridgeUserActions/lcp: +954%
  • ↑ bridgeUserActions/cls: +594%
  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -10%
  • ↓ loadNewAccount/fcp: -59%
  • ↑ loadNewAccount/lcp: +1098%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -13%
  • ↓ confirmTx/fcp: -46%
  • ↑ confirmTx/lcp: +1137%
  • ↑ bridgeUserActions/bridge_load_page: +249%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +141%
  • ↑ bridgeUserActions/bridge_search_token: +11%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +51%
  • ↑ bridgeUserActions/inp: +40%
  • ↑ bridgeUserActions/lcp: +1057%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +43%
  • ↑ startupStandardHome/load: +71%
  • ↑ startupStandardHome/domContentLoaded: +72%
  • ↓ startupStandardHome/firstPaint: -55%
  • ↓ startupStandardHome/backgroundConnect: -19%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +70%
  • ↑ startupStandardHome/setupStore: +88%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +66%
  • ↑ startupStandardHome/longTaskMaxDuration: +81%
  • ↑ startupStandardHome/tbt: +80%
  • ↓ startupStandardHome/inp: -24%
  • ↓ startupStandardHome/fcp: -59%
  • ↑ startupStandardHome/lcp: +83%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/domInteractive: -24%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/fcp: -21%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -14%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -12%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -17%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -16%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -32%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -79%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -75%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -59%
  • ↓ dappPageLoad/domContentLoaded: -17%
  • ↓ dappPageLoad/firstPaint: -42%
  • ↓ dappPageLoad/firstContentfulPaint: -42%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.26 MiB +164 Bytes 0.00%
🚨 ui 19.4 MiB +6.57 KiB +0.03%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +34 Bytes 0.00%
✅ content scripts 3.23 MiB +68 Bytes 0.00%
🚨 unzipped 79.74 MiB +6.83 KiB +0.01%
🚨 zip 23.83 MiB +2.31 KiB +0.01%

@sonarqubecloud

sonarqubecloud Bot commented Nov 5, 2026

Copy link
Copy Markdown

@georgewrmarshall
georgewrmarshall added this pull request to the merge queue Nov 5, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 5, 2026
@georgewrmarshall
georgewrmarshall added this pull request to the merge queue Nov 5, 2026
@georgewrmarshall georgewrmarshall changed the title chore(confirmations): set the MM Pay custom amount input in Grotzec Hero chore(confirmations): set the MM Pay custom amount input in Grotzec Hero cp-13.57.0 Nov 5, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 5, 2026
@georgewrmarshall
georgewrmarshall added this pull request to the merge queue Nov 5, 2026
runway-github Bot pushed a commit that referenced this pull request Nov 5, 2026
…3.57.0 (#47560)

<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
Stacked on #47564 (shared font-size helper) — merge that first.

## **Description**

This is the @MetaMask/perps slice of the Grotzec large number amount
inputs. It was split from the UAT build in #47557, which has the full
plan, the input inventory and the risks.

- Ticket:
[TMCU-1744](https://consensyssoftware.atlassian.net/browse/TMCU-1744)
- Epic: [TMCU-1741 [Extension] Update large number amount inputs with
Grotzec](https://consensyssoftware.atlassian.net/browse/TMCU-1741)

**Depends on #47564** (the shared amount scale and
`useAmountInputFontSize` hook). This PR is stacked on #47564's branch
(`cursor/grotzec-amount-input-scale-f3b4`) and does not carry its own
copy of the helper, so its diff shows only this slice. Merge #47564
first, then retarget this PR to `main`.

**What is the reason for the change?** The Perps withdraw amount was
Inter at weight 500 and 64/40/30/20px. Perps balances and prices moved
to Grotzec in #47465. This input is the twin of the MM Pay
`CustomAmount`, which Mobile moves to Grotzec at 88px in
[#38135](MetaMask/metamask-mobile#38135).

**What is the improvement?**
- **MMDS `Input`.** The `<input>` is now the MMDS `Input`
(`textVariant={AmountDisplayLg}`, `font-hero`). The hidden-text
measuring pattern stays. The symbol and measuring element are MMDS
`Text` (`AmountDisplayLg` + `FontFamily.Hero`), so all three share the
same family, weight and size. The explicit `fontWeight: 500` is dropped,
as on Mobile.
- **Sizing: shared scale.** The withdraw amount uses the scale in #47564
(`ui/helpers/utils/amount-input-font-size.ts`), the same one used by
Swap/Bridge, Ramps Buy and the MM Pay amount. It has steps of 88, 72,
60, 48, 40, 32, 24 and 20px, takes the largest step at which `$` and the
amount fit the input's measured width (`useAmountInputFontSize`, one
`ResizeObserver` per input; 328px is only the fallback before the first
measurement), and sets line height equal to font size. In the expanded
view long amounts stay large instead of shrinking early. At the 328px
popup width, `$25` is 88px, `$1234567.89` is 72px and `$123456789012.34`
is 48px.
- **Mobile reference.** The 88px start, 88px row, 88px `rounded-lg`
skeleton and 20px floor match Mobile #38135. Mobile's MM Pay drops
straight from 88px to 40px; Extension steps down gradually so mid-length
amounts stay larger.
- **Twin stays in sync.** The local length-based `getFontSize` is
removed. Its twin, the confirmations `CustomAmount`, moves to the same
scale in #47565, so the two can no longer drift.

**Risks**
- The weight changes from 500 Inter to the Bold Grotzec cut. Perps is
USD only, and Grotzec has `$`, so there is no glyph fallback.

## **Changelog**

CHANGELOG entry: Updated the Perps withdraw amount input to the Grotzec
typeface

## **Related issues**

Fixes:
[TMCU-1744](https://consensyssoftware.atlassian.net/browse/TMCU-1744)

Epic:
[TMCU-1741](https://consensyssoftware.atlassian.net/browse/TMCU-1741)
Depends on: #47564
Related: #47565 (MM Pay custom amount twin)
Split from: #47557

## **Manual testing steps**

1. Load this branch in the extension, open Perps and choose Withdraw.
2. Confirm the loading skeleton is 88px tall with rounded corners.
3. Enter `25` and confirm it renders in Grotzec at 88px.
4. Type `123456789012.34` one key at a time and confirm the amount steps
down 88 → 72 → 60 → 48px and stays centred.
5. Enter more than the available balance and confirm the amount turns
red.
6. Repeat in the expanded view, where long amounts stay larger instead
of shrinking early, and in the side panel, where they step down smoothly
as the width narrows.

## **Screenshots/Recordings**

### Before / After by code owner

Before is `main` @adeaf9ad59 and After is the UAT head (#47557)
@28a7077e43, both recorded with the same typing script (type 5, then
500000000000000000, then clear).

#### Perps withdraw

| Before | After |
| --- | --- |
| <img width="360"
src="https://github.com/user-attachments/assets/bde0cc8d-a0a6-493e-81cd-6754ac6a0a82"
alt="Perps withdraw before, side panel"> | <img width="360"
src="https://github.com/user-attachments/assets/87e17271-f2a9-4b2e-824f-92456a58a3eb"
alt="Perps withdraw after, side panel"> |
| <img width="360"
src="https://github.com/user-attachments/assets/2c539038-48c1-4f5b-9ef4-85b21391df3b"
alt="Perps withdraw before, expanded view"> | <img width="360"
src="https://github.com/user-attachments/assets/cc7c54af-42e1-4bf9-bffc-92bd98312ead"
alt="Perps withdraw after, expanded view"> |

Full MP4s: [Side panel
before](https://github.com/user-attachments/assets/49c2722c-88e1-41fb-8ff3-1fda48319b85)
· [Side panel
after](https://github.com/user-attachments/assets/573cd199-f321-4b96-aab8-790349a292a6)
· [Expanded
before](https://github.com/user-attachments/assets/0595640d-d948-4c3f-9ec8-fb505f8f01f7)
· [Expanded
after](https://github.com/user-attachments/assets/85f918b1-09ec-4359-927d-705da4ed3405)

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_AGENT_PR_BODY_END -->

<div><a
href="https://cursor.com/agents/bc-b3180cce-a244-5330-95e3-35b5951ff3b4?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/background-agent?bcId=bc-b3180cce-a244-5330-95e3-35b5951ff3b4&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div>



[TMCU-1744]:
https://consensyssoftware.atlassian.net/browse/TMCU-1744?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[TMCU-1744]:
https://consensyssoftware.atlassian.net/browse/TMCU-1744?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Scoped UI swap on the Perps withdraw amount field with no changes to
withdrawal submission, balance guards, or backend calls.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
52d1e02. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
runway-github Bot added a commit that referenced this pull request Nov 5, 2026
…3.57.0 (#47560)

<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
Stacked on #47564 (shared font-size helper) — merge that first.

## **Description**

This is the @MetaMask/perps slice of the Grotzec large number amount
inputs. It was split from the UAT build in #47557, which has the full
plan, the input inventory and the risks.

- Ticket:
[TMCU-1744](https://consensyssoftware.atlassian.net/browse/TMCU-1744)
- Epic: [TMCU-1741 [Extension] Update large number amount inputs with
Grotzec](https://consensyssoftware.atlassian.net/browse/TMCU-1741)

**Depends on #47564** (the shared amount scale and
`useAmountInputFontSize` hook). This PR is stacked on #47564's branch
(`cursor/grotzec-amount-input-scale-f3b4`) and does not carry its own
copy of the helper, so its diff shows only this slice. Merge #47564
first, then retarget this PR to `main`.

**What is the reason for the change?** The Perps withdraw amount was
Inter at weight 500 and 64/40/30/20px. Perps balances and prices moved
to Grotzec in #47465. This input is the twin of the MM Pay
`CustomAmount`, which Mobile moves to Grotzec at 88px in
[#38135](MetaMask/metamask-mobile#38135).

**What is the improvement?**
- **MMDS `Input`.** The `<input>` is now the MMDS `Input`
(`textVariant={AmountDisplayLg}`, `font-hero`). The hidden-text
measuring pattern stays. The symbol and measuring element are MMDS
`Text` (`AmountDisplayLg` + `FontFamily.Hero`), so all three share the
same family, weight and size. The explicit `fontWeight: 500` is dropped,
as on Mobile.
- **Sizing: shared scale.** The withdraw amount uses the scale in #47564
(`ui/helpers/utils/amount-input-font-size.ts`), the same one used by
Swap/Bridge, Ramps Buy and the MM Pay amount. It has steps of 88, 72,
60, 48, 40, 32, 24 and 20px, takes the largest step at which `$` and the
amount fit the input's measured width (`useAmountInputFontSize`, one
`ResizeObserver` per input; 328px is only the fallback before the first
measurement), and sets line height equal to font size. In the expanded
view long amounts stay large instead of shrinking early. At the 328px
popup width, `$25` is 88px, `$1234567.89` is 72px and `$123456789012.34`
is 48px.
- **Mobile reference.** The 88px start, 88px row, 88px `rounded-lg`
skeleton and 20px floor match Mobile #38135. Mobile's MM Pay drops
straight from 88px to 40px; Extension steps down gradually so mid-length
amounts stay larger.
- **Twin stays in sync.** The local length-based `getFontSize` is
removed. Its twin, the confirmations `CustomAmount`, moves to the same
scale in #47565, so the two can no longer drift.

**Risks**
- The weight changes from 500 Inter to the Bold Grotzec cut. Perps is
USD only, and Grotzec has `$`, so there is no glyph fallback.

## **Changelog**

CHANGELOG entry: Updated the Perps withdraw amount input to the Grotzec
typeface

## **Related issues**

Fixes:
[TMCU-1744](https://consensyssoftware.atlassian.net/browse/TMCU-1744)

Epic:
[TMCU-1741](https://consensyssoftware.atlassian.net/browse/TMCU-1741)
Depends on: #47564
Related: #47565 (MM Pay custom amount twin)
Split from: #47557

## **Manual testing steps**

1. Load this branch in the extension, open Perps and choose Withdraw.
2. Confirm the loading skeleton is 88px tall with rounded corners.
3. Enter `25` and confirm it renders in Grotzec at 88px.
4. Type `123456789012.34` one key at a time and confirm the amount steps
down 88 → 72 → 60 → 48px and stays centred.
5. Enter more than the available balance and confirm the amount turns
red.
6. Repeat in the expanded view, where long amounts stay larger instead
of shrinking early, and in the side panel, where they step down smoothly
as the width narrows.

## **Screenshots/Recordings**

### Before / After by code owner

Before is `main` @adeaf9ad59 and After is the UAT head (#47557)
@28a7077e43, both recorded with the same typing script (type 5, then
500000000000000000, then clear).

#### Perps withdraw

| Before | After |
| --- | --- |
| <img width="360"
src="https://github.com/user-attachments/assets/bde0cc8d-a0a6-493e-81cd-6754ac6a0a82"
alt="Perps withdraw before, side panel"> | <img width="360"
src="https://github.com/user-attachments/assets/87e17271-f2a9-4b2e-824f-92456a58a3eb"
alt="Perps withdraw after, side panel"> |
| <img width="360"
src="https://github.com/user-attachments/assets/2c539038-48c1-4f5b-9ef4-85b21391df3b"
alt="Perps withdraw before, expanded view"> | <img width="360"
src="https://github.com/user-attachments/assets/cc7c54af-42e1-4bf9-bffc-92bd98312ead"
alt="Perps withdraw after, expanded view"> |

Full MP4s: [Side panel
before](https://github.com/user-attachments/assets/49c2722c-88e1-41fb-8ff3-1fda48319b85)
· [Side panel
after](https://github.com/user-attachments/assets/573cd199-f321-4b96-aab8-790349a292a6)
· [Expanded
before](https://github.com/user-attachments/assets/0595640d-d948-4c3f-9ec8-fb505f8f01f7)
· [Expanded
after](https://github.com/user-attachments/assets/85f918b1-09ec-4359-927d-705da4ed3405)

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_AGENT_PR_BODY_END -->

<div><a
href="https://cursor.com/agents/bc-b3180cce-a244-5330-95e3-35b5951ff3b4?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/background-agent?bcId=bc-b3180cce-a244-5330-95e3-35b5951ff3b4&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div>

[TMCU-1744]:
https://consensyssoftware.atlassian.net/browse/TMCU-1744?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[TMCU-1744]:
https://consensyssoftware.atlassian.net/browse/TMCU-1744?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Scoped UI swap on the Perps withdraw amount field with no changes to
withdrawal submission, balance guards, or backend calls.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
52d1e02. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
runway-github Bot pushed a commit that referenced this pull request Nov 5, 2026
…put in Grotzec Hero cp-13.57.0 (#47560)

<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
Stacked on #47564 (shared font-size helper) — merge that first.

## **Description**

This is the @MetaMask/perps slice of the Grotzec large number amount
inputs. It was split from the UAT build in #47557, which has the full
plan, the input inventory and the risks.

- Ticket:
[TMCU-1744](https://consensyssoftware.atlassian.net/browse/TMCU-1744)
- Epic: [TMCU-1741 [Extension] Update large number amount inputs with
Grotzec](https://consensyssoftware.atlassian.net/browse/TMCU-1741)

**Depends on #47564** (the shared amount scale and
`useAmountInputFontSize` hook). This PR is stacked on #47564's branch
(`cursor/grotzec-amount-input-scale-f3b4`) and does not carry its own
copy of the helper, so its diff shows only this slice. Merge #47564
first, then retarget this PR to `main`.

**What is the reason for the change?** The Perps withdraw amount was
Inter at weight 500 and 64/40/30/20px. Perps balances and prices moved
to Grotzec in #47465. This input is the twin of the MM Pay
`CustomAmount`, which Mobile moves to Grotzec at 88px in
[#38135](MetaMask/metamask-mobile#38135).

**What is the improvement?**
- **MMDS `Input`.** The `<input>` is now the MMDS `Input`
(`textVariant={AmountDisplayLg}`, `font-hero`). The hidden-text
measuring pattern stays. The symbol and measuring element are MMDS
`Text` (`AmountDisplayLg` + `FontFamily.Hero`), so all three share the
same family, weight and size. The explicit `fontWeight: 500` is dropped,
as on Mobile.
- **Sizing: shared scale.** The withdraw amount uses the scale in #47564
(`ui/helpers/utils/amount-input-font-size.ts`), the same one used by
Swap/Bridge, Ramps Buy and the MM Pay amount. It has steps of 88, 72,
60, 48, 40, 32, 24 and 20px, takes the largest step at which `$` and the
amount fit the input's measured width (`useAmountInputFontSize`, one
`ResizeObserver` per input; 328px is only the fallback before the first
measurement), and sets line height equal to font size. In the expanded
view long amounts stay large instead of shrinking early. At the 328px
popup width, `$25` is 88px, `$1234567.89` is 72px and `$123456789012.34`
is 48px.
- **Mobile reference.** The 88px start, 88px row, 88px `rounded-lg`
skeleton and 20px floor match Mobile #38135. Mobile's MM Pay drops
straight from 88px to 40px; Extension steps down gradually so mid-length
amounts stay larger.
- **Twin stays in sync.** The local length-based `getFontSize` is
removed. Its twin, the confirmations `CustomAmount`, moves to the same
scale in #47565, so the two can no longer drift.

**Risks**
- The weight changes from 500 Inter to the Bold Grotzec cut. Perps is
USD only, and Grotzec has `$`, so there is no glyph fallback.

## **Changelog**

CHANGELOG entry: Updated the Perps withdraw amount input to the Grotzec
typeface

## **Related issues**

Fixes:
[TMCU-1744](https://consensyssoftware.atlassian.net/browse/TMCU-1744)

Epic:
[TMCU-1741](https://consensyssoftware.atlassian.net/browse/TMCU-1741)
Depends on: #47564
Related: #47565 (MM Pay custom amount twin)
Split from: #47557

## **Manual testing steps**

1. Load this branch in the extension, open Perps and choose Withdraw.
2. Confirm the loading skeleton is 88px tall with rounded corners.
3. Enter `25` and confirm it renders in Grotzec at 88px.
4. Type `123456789012.34` one key at a time and confirm the amount steps
down 88 → 72 → 60 → 48px and stays centred.
5. Enter more than the available balance and confirm the amount turns
red.
6. Repeat in the expanded view, where long amounts stay larger instead
of shrinking early, and in the side panel, where they step down smoothly
as the width narrows.

## **Screenshots/Recordings**

### Before / After by code owner

Before is `main` @adeaf9ad59 and After is the UAT head (#47557)
@28a7077e43, both recorded with the same typing script (type 5, then
500000000000000000, then clear).

#### Perps withdraw

| Before | After |
| --- | --- |
| <img width="360"
src="https://github.com/user-attachments/assets/bde0cc8d-a0a6-493e-81cd-6754ac6a0a82"
alt="Perps withdraw before, side panel"> | <img width="360"
src="https://github.com/user-attachments/assets/87e17271-f2a9-4b2e-824f-92456a58a3eb"
alt="Perps withdraw after, side panel"> |
| <img width="360"
src="https://github.com/user-attachments/assets/2c539038-48c1-4f5b-9ef4-85b21391df3b"
alt="Perps withdraw before, expanded view"> | <img width="360"
src="https://github.com/user-attachments/assets/cc7c54af-42e1-4bf9-bffc-92bd98312ead"
alt="Perps withdraw after, expanded view"> |

Full MP4s: [Side panel
before](https://github.com/user-attachments/assets/49c2722c-88e1-41fb-8ff3-1fda48319b85)
· [Side panel
after](https://github.com/user-attachments/assets/573cd199-f321-4b96-aab8-790349a292a6)
· [Expanded
before](https://github.com/user-attachments/assets/0595640d-d948-4c3f-9ec8-fb505f8f01f7)
· [Expanded
after](https://github.com/user-attachments/assets/85f918b1-09ec-4359-927d-705da4ed3405)

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_AGENT_PR_BODY_END -->

<div><a
href="https://cursor.com/agents/bc-b3180cce-a244-5330-95e3-35b5951ff3b4?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/background-agent?bcId=bc-b3180cce-a244-5330-95e3-35b5951ff3b4&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div>



[TMCU-1744]:
https://consensyssoftware.atlassian.net/browse/TMCU-1744?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[TMCU-1744]:
https://consensyssoftware.atlassian.net/browse/TMCU-1744?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Scoped UI swap on the Perps withdraw amount field with no changes to
withdrawal submission, balance guards, or backend calls.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
52d1e02. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
Merged via the queue into main with commit d8e24a8 Nov 5, 2026
143 checks passed
@georgewrmarshall
georgewrmarshall deleted the cursor/grotzec-custom-amount-input-f3b4 branch November 5, 2026 20:37
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 5, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026

This branch was previously deployed

1 inactive deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-M team-design-system All issues relating to design system in Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants