Skip to content

fix(swaps): stay in swaps after transaction submission - #47591

Merged
bfullam merged 19 commits into
mainfrom
swaps-5212-stay-in-swaps
Nov 6, 2026
Merged

bfullam merged 19 commits into
mainfrom
swaps-5212-stay-in-swaps

Conversation

@bfullam

@bfullam bfullam commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Description

After submitting any swap or bridge, users were sent back to the Home page. They now stay in Swaps, with the token pair kept and the amount cleared so the submitted quote can't be resubmitted.

Each submit path is handled where it happens:

  • Software wallets (useSubmitBridgeTransaction): there's no navigation. On success the amount is cleared and the user stays on the Swaps page. A failed submit leaves the page and amount untouched.
  • Hardware wallets (useHwSwapNavigation): the signing page is opened on top of Swaps. After signing, the hook clears the amount, resets the bridge controller and goes back one history entry. The reset must happen before going back, because the remounted Swaps page restores the amount from the controller's active quote. The token pair is unaffected, since it lives in the Redux bridge slice rather than the controller.

Transaction Shield:

  • Swaps opened from Transaction Shield return to Transaction Shield after submitting, for both software and hardware wallets.
  • This is a fix for hardware wallets. On main they went Home, because the signing page's URL dropped the isFromTransactionShield param. navigateToHwSigningPage now carries that param over, so post-signing navigation returns to Shield.

Unchanged behaviour:

  • Hardware wallet sends (sendBundle) still go Home.
  • If the hardware wallet signing page is the first history entry, it falls back to Home as before.
  • Post-trade toasts (EVM and Solana) are unaffected.

Analytics side effect:

  • No metrics code changed, but which Input Changed events fire changes for users who leave Swaps with Back after submitting. Back resets the bridge controller, which it always has. When Swaps is reopened, the source token is already the default (native), so a chain_source event fires instead of token_source. The e2e expectation in test/e2e/tests/bridge/constants.ts (resetPage) is updated to match.

Test changes:

  • Unit tests for both hooks now expect users to stay in Swaps and check that the amount is cleared. They also cover: hardware wallet sends going Home; Transaction Shield returns for both software and hardware wallets; a failed submit keeping the amount; and the hardware wallet controller reset happening before navigating back.
  • The swap and bridge e2e tests assumed users land on Home after submitting. A new goBackAfterSubmit() page-object step waits for the amount to clear, which confirms the new behaviour, then presses Back to reach Home before the Activity checks. It is called from the shared verifySubmittedSwapTransaction flow and from the specs that submit directly: gasless, bridge failure cases, BTC, Solana, smart transactions and Ledger. The "View activity" clicks and clickViewActivity were removed because that status page is no longer shown.

Changelog

CHANGELOG entry: Users now stay on the Swaps page after submitting a swap or bridge, instead of being sent to the Home page

Related issues

Fixes: SWAPS-5212

Manual testing steps

  1. Run the extension and open the popup.
  2. Start a swap on an EVM network (e.g. Mainnet or Linea), enter an amount, and submit.
  3. Verify you stay on the Swaps page, the same token pair is selected, and the amount is empty.
  4. Verify the "Transaction submitted" toast appears and changes to "Transaction confirmed".
  5. Press Back and verify you leave Swaps (no duplicate Swaps entry).
  6. Repeat steps 2–5 with a Solana swap.
  7. Repeat steps 2–5 with a Ledger account, signing on the device.
  8. With the Ledger account, send a token and verify you land on the Home page after signing.
  9. Open Swaps from Transaction Shield, submit a swap, and verify you are returned to Transaction Shield.
  10. Repeat step 9 with the Ledger account and verify you are returned to Transaction Shield after signing.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches core swap submission navigation for software and hardware wallets plus Transaction Shield routing, so regressions could strand users on wrong screens; mitigated by broad unit/e2e updates but still warrants careful QA.

Overview
Navigation + submission flow tweaks

  • Software swap/bridge submissions now avoid bouncing to Home unless the flow originated from Transaction Shield; successful submits stay on Swaps while clearing the source amount, failed submits leave the page untouched, and Transaction Shield launches still replace-route back to Shield.
  • navigateToHwSigningPage threads the isFromTransactionShield query param through hardware wallet signing URLs, and hardware-wallet post-signing navigation differentiates send-bundle, Shield, and standard histories (resetting the bridge controller or popping history as needed while clearing amounts).

Tests & tooling

  • Page-object helpers add goBackAfterSubmit and update bridge/swap e2e suites (gasless, BTC, Solana, smart transactions, ledger, negative cases, shared flows) to wait for a cleared amount before backing out, assert smart-tx toasts, refresh analytics expectations, and drop the obsolete “View activity” path.
  • Unit tests expand for useBridgeNavigation, useSubmitBridgeTransaction, and useHwSwapNavigation to cover the new navigation matrix.

This is a behavior change across swap submission UX and hardware-wallet routing; mostly covered by updated unit/e2e tests but regression risk remains if any edge navigation path is missing coverage.

Reviewed by Cursor Bugbot for commit c79cf8d. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the size-M label Nov 3, 2026
@metamask-ci

metamask-ci Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (4 files, +135 -4)
  • 📁 test/
    • 📁 e2e/
      • 📁 tests/
        • 📁 hardware-wallets/
          • 📁 ledger/
            • 📄 ledger-swap.spec.ts +1 -0
  • 📁 ui/
    • 📁 hooks/
      • 📁 hardware-wallets/
        • 📄 useHwSwapNavigation.test.ts +91 -0
        • 📄 useHwSwapNavigation.ts +42 -3
    • 📁 pages/
      • 📁 hardware-wallets/
        • 📁 swap/
          • 📁 hooks/
            • 📄 useHardwareWalletSignatures.ts +1 -1

🧪 @MetaMask/qa (3 files, +13 -9)
  • 📁 test/
    • 📁 e2e/
      • 📁 page-objects/
        • 📁 flows/
          • 📄 bridge.flow.ts +1 -0
        • 📁 pages/
          • 📁 bridge/
            • 📄 quote-page.ts +8 -0
          • 📁 swap/
            • 📄 swap-page.ts +4 -9

🔄 @MetaMask/swaps-engineers (8 files, +104 -60)
  • 📁 test/
    • 📁 e2e/
      • 📁 page-objects/
        • 📁 pages/
          • 📁 bridge/
            • 📄 quote-page.ts +8 -0
      • 📁 tests/
        • 📁 bridge/
          • 📄 bridge-negative-cases.spec.ts +3 -1
          • 📄 constants.ts +1 -1
          • 📄 swap-gasless.spec.ts +3 -0
  • 📁 ui/
    • 📁 hooks/
      • 📁 bridge/
        • 📄 useBridgeNavigation.test.ts +18 -0
        • 📄 useBridgeNavigation.ts +21 -12
        • 📄 useSubmitBridgeTransaction.test.tsx +38 -45
        • 📄 useSubmitBridgeTransaction.ts +12 -1

@metamask-ci metamask-ci Bot added the team-swaps-and-bridge Swaps and Bridge team label Nov 3, 2026
@bfullam
bfullam marked this pull request as ready for review November 3, 2026 16:12
@bfullam
bfullam requested review from a team as code owners November 3, 2026 16:12

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread ui/hooks/bridge/useBridgeNavigation.ts Resolved

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread ui/hooks/bridge/useBridgeNavigation.ts Resolved
@metamask-ci

metamask-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
Builds ready [9190149]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 41676473656 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -10%
  • ↑ loadNewAccount/fcp: +12%
  • ↑ loadNewAccount/cls: +278%
  • ↑ confirmTx/longTaskTotalDuration: +56%
  • ↑ confirmTx/longTaskMaxDuration: +81%
  • ↑ confirmTx/tbt: +95%
  • ↑ confirmTx/fcp: +13%
  • ↑ confirmTx/lcp: +12%
  • ↑ bridgeUserActions/bridge_load_page: +81%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +109%
  • ↑ bridgeUserActions/longTaskCount: +82%
  • ↑ bridgeUserActions/longTaskTotalDuration: +121%
  • ↑ bridgeUserActions/longTaskMaxDuration: +49%
  • ↑ bridgeUserActions/tbt: +168%
  • ↑ bridgeUserActions/total: +24%
  • ↑ bridgeUserActions/inp: +25%
  • ↑ bridgeUserActions/fcp: +11%
  • ↑ bridgeUserActions/cls: +281%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -33%
  • ↓ loadNewAccount/fcp: -63%
  • ↑ loadNewAccount/lcp: +1052%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -29%
  • ↓ confirmTx/fcp: -62%
  • ↑ confirmTx/lcp: +1068%
  • ↑ bridgeUserActions/bridge_load_page: +130%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +46%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +23%
  • ↑ bridgeUserActions/inp: +18%
  • ↓ bridgeUserActions/fcp: -53%
  • ↑ bridgeUserActions/lcp: +990%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -29%
  • ↓ startupStandardHome/load: -31%
  • ↓ startupStandardHome/domContentLoaded: -31%
  • ↓ startupStandardHome/domInteractive: -23%
  • ↓ startupStandardHome/firstPaint: -20%
  • ↓ startupStandardHome/backgroundConnect: -33%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -64%
  • ↓ startupStandardHome/loadScripts: -32%
  • ↑ startupStandardHome/setupStore: +49%
  • ↓ startupStandardHome/longTaskCount: -29%
  • ↓ startupStandardHome/longTaskTotalDuration: -36%
  • ↓ startupStandardHome/longTaskMaxDuration: -34%
  • ↓ startupStandardHome/tbt: -38%
  • ↓ startupStandardHome/inp: -24%
  • ↓ startupStandardHome/fcp: -31%
  • ↓ startupStandardHome/lcp: -17%
  • ↑ startupStandardHome/cls: +400%
  • ↓ startupStandardHome/domInteractive: -36%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +132%
  • ↓ startupStandardHome/fcp: -34%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -27%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -26%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -26%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -39%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -75%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -72%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -60%
  • ↓ dappPageLoad/domContentLoaded: -19%
  • ↓ dappPageLoad/firstPaint: -47%
  • ↓ dappPageLoad/firstContentfulPaint: -47%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +130 Bytes 0.00%
✅ ui 19.33 MiB +707 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
🚨 unzipped 79.89 MiB +1.81 KiB 0.00%
✅ zip 24.07 MiB +444 Bytes 0.00%

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread ui/hooks/bridge/useBridgeNavigation.ts Resolved
montelaidev
montelaidev previously approved these changes Nov 4, 2026
# Conflicts:
#	ui/hooks/bridge/useSubmitBridgeTransaction.test.tsx

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 86f2933. Configure here.

@metamask-ci

metamask-ci Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor
Builds ready [86f2933]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42020472760 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +179%
  • ↑ loadNewAccount/total: +179%
  • ↓ loadNewAccount/inp: -40%
  • ↓ loadNewAccount/fcp: -29%
  • ↑ loadNewAccount/lcp: +596%
  • ↓ loadNewAccount/cls: -76%
  • ↓ confirmTx/longTaskTotalDuration: -12%
  • ↓ confirmTx/tbt: -11%
  • ↓ confirmTx/inp: -44%
  • ↓ confirmTx/fcp: -29%
  • ↑ confirmTx/lcp: +613%
  • ↓ confirmTx/cls: -14%
  • ↓ bridgeUserActions/bridge_load_page: -12%
  • ↓ bridgeUserActions/bridge_load_asset_picker: -19%
  • ↓ bridgeUserActions/longTaskTotalDuration: -34%
  • ↓ bridgeUserActions/longTaskMaxDuration: -27%
  • ↓ bridgeUserActions/tbt: -70%
  • ↓ bridgeUserActions/inp: -26%
  • ↓ bridgeUserActions/fcp: -29%
  • ↑ bridgeUserActions/lcp: +601%
  • ↑ bridgeUserActions/cls: +594%
  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/inp: -18%
  • ↓ loadNewAccount/fcp: -28%
  • ↑ loadNewAccount/lcp: +1349%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/fcp: +26%
  • ↑ confirmTx/lcp: +1426%
  • ↑ bridgeUserActions/bridge_load_page: +340%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +160%
  • ↑ bridgeUserActions/bridge_search_token: +26%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +68%
  • ↑ bridgeUserActions/inp: +62%
  • ↑ bridgeUserActions/fcp: +27%
  • ↑ bridgeUserActions/lcp: +1328%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/LCP: p75 2.6s
  • 🟡 confirmTx/FCP: p75 2.2s
  • 🟡 confirmTx/LCP: p75 2.6s
  • 🟡 bridgeUserActions/FCP: p75 2.2s
  • 🟡 bridgeUserActions/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +20%
  • ↑ startupStandardHome/load: +42%
  • ↑ startupStandardHome/domContentLoaded: +42%
  • ↓ startupStandardHome/domInteractive: -13%
  • ↓ startupStandardHome/firstPaint: -43%
  • ↓ startupStandardHome/backgroundConnect: -26%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -64%
  • ↑ startupStandardHome/loadScripts: +41%
  • ↑ startupStandardHome/setupStore: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +37%
  • ↑ startupStandardHome/longTaskMaxDuration: +62%
  • ↑ startupStandardHome/tbt: +49%
  • ↓ startupStandardHome/inp: -30%
  • ↑ startupStandardHome/fcp: +38%
  • ↑ startupStandardHome/lcp: +518%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -37%
  • ↓ startupStandardHome/load: -33%
  • ↓ startupStandardHome/domContentLoaded: -35%
  • ↓ startupStandardHome/domInteractive: -50%
  • ↓ startupStandardHome/backgroundConnect: -32%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -33%
  • ↑ startupStandardHome/setupStore: +30%
  • ↓ startupStandardHome/fcp: -34%
  • ↓ startupStandardHome/lcp: -31%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +14%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +29%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +35%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +24%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +38%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +17%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -73%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -74%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -38%
  • ↓ onboardingNewWallet/tbt: -99%
  • ↓ onboardingNewWallet/total: -69%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -51%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.24 MiB +130 Bytes 0.00%
✅ ui 19.34 MiB +908 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.22 MiB 0 Bytes 0.00%
🚨 unzipped 79.65 MiB +1.02 KiB 0.00%
✅ zip 23.82 MiB +354 Bytes 0.00%

@github-actions github-actions Bot removed the retry-ci Tells GitHub Actions to retry failed jobs, label removed automatically before the retry label Nov 5, 2026
@metamask-ci

metamask-ci Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor
Builds ready [3dc7a81]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42031200666 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -18%
  • ↑ loadNewAccount/lcp: +936%
  • ↑ loadNewAccount/cls: +589%
  • ↑ confirmTx/longTaskTotalDuration: +34%
  • ↑ confirmTx/longTaskMaxDuration: +49%
  • ↑ confirmTx/tbt: +58%
  • ↓ confirmTx/inp: -21%
  • ↑ confirmTx/lcp: +975%
  • ↓ confirmTx/cls: -12%
  • ↑ bridgeUserActions/bridge_load_page: +90%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +30%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +30%
  • ↑ bridgeUserActions/tbt: +23%
  • ↑ bridgeUserActions/lcp: +934%
  • ↑ bridgeUserActions/cls: +594%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/fcp: -57%
  • ↑ loadNewAccount/lcp: +1037%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -29%
  • ↓ confirmTx/fcp: -58%
  • ↑ confirmTx/lcp: +1145%
  • ↑ bridgeUserActions/bridge_load_page: +234%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +91%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +37%
  • ↑ bridgeUserActions/inp: +143%
  • ↓ bridgeUserActions/fcp: -48%
  • ↑ bridgeUserActions/lcp: +1075%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.8s
  • 🟡 bridgeUserActions/INP: p75 264ms
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +26%
  • ↑ startupStandardHome/load: +48%
  • ↑ startupStandardHome/domContentLoaded: +48%
  • ↓ startupStandardHome/firstPaint: -38%
  • ↓ startupStandardHome/backgroundConnect: -21%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -64%
  • ↑ startupStandardHome/loadScripts: +47%
  • ↑ startupStandardHome/setupStore: +62%
  • ↑ startupStandardHome/longTaskTotalDuration: +43%
  • ↑ startupStandardHome/longTaskMaxDuration: +67%
  • ↑ startupStandardHome/tbt: +53%
  • ↓ startupStandardHome/inp: -30%
  • ↑ startupStandardHome/fcp: +42%
  • ↑ startupStandardHome/lcp: +538%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -19%
  • ↓ onboardingImportWallet/confirmSrpToPwForm: -15%
  • ↓ onboardingImportWallet/pwFormToMetricsScreen: -11%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -32%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -86%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -17%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -13%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -31%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -78%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -74%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -49%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.25 MiB +4.79 KiB +0.03%
🚨 ui 19.38 MiB +38.61 KiB +0.19%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +115 Bytes 0.00%
✅ content scripts 3.23 MiB +230 Bytes +0.01%
🚨 unzipped 79.7 MiB +44.46 KiB +0.05%
🚨 zip 23.82 MiB +8.23 KiB +0.03%

# Conflicts:
#	test/e2e/page-objects/pages/bridge/quote-page.ts
@metamask-ci

metamask-ci Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor
Builds ready [c79cf8d]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 0 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42205639572 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +179%
  • ↑ loadNewAccount/total: +179%
  • ↓ loadNewAccount/inp: -55%
  • ↓ loadNewAccount/fcp: -34%
  • ↑ loadNewAccount/lcp: +544%
  • ↑ loadNewAccount/cls: +297%
  • ↓ confirmTx/inp: -44%
  • ↓ confirmTx/fcp: -34%
  • ↑ confirmTx/lcp: +559%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +17%
  • ↓ bridgeUserActions/longTaskTotalDuration: -26%
  • ↓ bridgeUserActions/longTaskMaxDuration: -31%
  • ↓ bridgeUserActions/tbt: -52%
  • ↓ bridgeUserActions/inp: -26%
  • ↓ bridgeUserActions/fcp: -33%
  • ↑ bridgeUserActions/lcp: +565%
  • ↑ bridgeUserActions/cls: +636%
  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↑ loadNewAccount/inp: +34%
  • ↓ loadNewAccount/fcp: -45%
  • ↑ loadNewAccount/lcp: +1074%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -29%
  • ↑ confirmTx/lcp: +1054%
  • ↑ bridgeUserActions/bridge_load_page: +275%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +148%
  • ↑ bridgeUserActions/bridge_search_token: +12%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +32%
  • ↑ bridgeUserActions/inp: +25%
  • ↓ bridgeUserActions/fcp: -51%
  • ↑ bridgeUserActions/lcp: +1009%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +90%
  • ↑ startupStandardHome/load: +125%
  • ↑ startupStandardHome/domContentLoaded: +125%
  • ↑ startupStandardHome/domInteractive: +29%
  • ↓ startupStandardHome/firstPaint: -50%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +123%
  • ↑ startupStandardHome/setupStore: +114%
  • ↑ startupStandardHome/longTaskCount: +79%
  • ↑ startupStandardHome/longTaskTotalDuration: +123%
  • ↑ startupStandardHome/longTaskMaxDuration: +123%
  • ↑ startupStandardHome/tbt: +145%
  • ↓ startupStandardHome/fcp: -49%
  • ↑ startupStandardHome/lcp: +131%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -27%
  • ↓ startupStandardHome/load: -20%
  • ↓ startupStandardHome/domContentLoaded: -22%
  • ↓ startupStandardHome/domInteractive: -45%
  • ↓ startupStandardHome/backgroundConnect: -11%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -21%
  • ↓ startupStandardHome/setupStore: -24%
  • ↓ startupStandardHome/fcp: -33%
  • ↓ startupStandardHome/lcp: -19%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +11%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +31%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +60%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +23%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -91%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -94%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -91%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -11%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +27%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -77%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -75%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -40%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -73%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -49%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +130 Bytes 0.00%
✅ ui 19.42 MiB +908 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
🚨 unzipped 79.78 MiB +1.02 KiB 0.00%
✅ zip 23.86 MiB +359 Bytes 0.00%

@sonarqubecloud

sonarqubecloud Bot commented Nov 6, 2026

Copy link
Copy Markdown

@bfullam
bfullam enabled auto-merge November 6, 2026 13:13
@bfullam
bfullam added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit 414c75f Nov 6, 2026
140 checks passed
@bfullam
bfullam deleted the swaps-5212-stay-in-swaps branch November 6, 2026 16:33
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 6, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.58.0 on PR, as PR was added to branch 13.58.0 when release was cut.

This branch had an error being deployed

1 failed (outdated) and 1 inactive deployments
pr-comment — c79cf8d1 Deployed Nov 6, 2026 by bfullam via Publish prerelease / Publish prerelease #173240
segment-schema — 080f02dc Deployed Nov 4, 2026 by bfullam via propose #3135
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-M team-swaps-and-bridge Swaps and Bridge team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants