Skip to content

feat: add money deposit deeplink - #47592

Merged
Jwhiles merged 3 commits into
mainfrom
add-money-deposit-deeplink
Nov 6, 2026
Merged

Jwhiles merged 3 commits into
mainfrom
add-money-deposit-deeplink

Conversation

@Jwhiles

@Jwhiles Jwhiles commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Description

Adds money deposit deeplink, to achieve parity with mobile

Changelog

CHANGELOG entry: add money deposit deeplink

Related issues

Fixes: n/a

Manual testing steps

  1. Run the extension
  2. Visit https://link.metamask.io/money-account-deposit in the browser
  3. You should see the deposit modal

Screenshots/Recordings

Before

n/a

After

Screen.Recording.2026-11-03.at.16.33.01.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Introduces a new entry into the Money deposit confirmation flow and changes navigation/history behavior for that path, though eligibility checks and failure fallbacks mirror existing Money patterns.

Overview
Adds https://link.metamask.io/money-account-deposit for extension parity with mobile. The new deep link maps to /money-home/deposit, a bridge page that waits for Money account availability, starts a deposit, and replaces itself with the deposit confirmation so back returns to Money home; ineligible users or failed setup go to wallet home.

Supporting changes: useMoneyAccountDeposit.initiateDeposit now resolves true/false, accepts replaceConfirmation and goBackTo, and ignores duplicate in-flight calls; navigateToTransaction supports replace for history. The path is on the interstitial-protected list and includes locale copy for the link title.

Reviewed by Cursor Bugbot for commit 8c2e98f. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the size-M label Nov 3, 2026
@metamask-ci metamask-ci Bot added the team-earn label Nov 3, 2026
@Jwhiles
Jwhiles marked this pull request as ready for review November 3, 2026 16:34
@Jwhiles
Jwhiles requested a review from a team as a code owner November 3, 2026 16:34
@metamask-ci

metamask-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
Builds ready [c702767]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 3 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 41675457449 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↑ loadNewAccount/inp: +19%
  • ↑ loadNewAccount/fcp: +13%
  • ↑ loadNewAccount/lcp: +12%
  • ↑ loadNewAccount/cls: +282%
  • ↑ confirmTx/longTaskTotalDuration: +53%
  • ↑ confirmTx/longTaskMaxDuration: +73%
  • ↑ confirmTx/tbt: +89%
  • ↑ confirmTx/fcp: +11%
  • ↑ confirmTx/lcp: +21%
  • ↑ bridgeUserActions/bridge_load_page: +73%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +48%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +85%
  • ↑ bridgeUserActions/longTaskMaxDuration: +44%
  • ↑ bridgeUserActions/tbt: +163%
  • ↑ bridgeUserActions/total: +15%
  • ↑ bridgeUserActions/inp: +18%
  • ↑ bridgeUserActions/fcp: +13%
  • ↑ bridgeUserActions/cls: +281%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -33%
  • ↓ loadNewAccount/fcp: -58%
  • ↑ loadNewAccount/lcp: +1382%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -37%
  • ↑ confirmTx/lcp: +997%
  • ↑ bridgeUserActions/bridge_load_page: +152%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +77%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +29%
  • ↑ bridgeUserActions/inp: +18%
  • ↓ bridgeUserActions/fcp: -59%
  • ↑ bridgeUserActions/lcp: +1031%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
  • 🟡 loadNewAccount/LCP: p75 2.6s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +11%
  • ↑ startupStandardHome/domInteractive: +17%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/setupStore: +166%
  • ↓ startupStandardHome/longTaskCount: -29%
  • ↑ startupStandardHome/cls: +400%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +149%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +31%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +39%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +31%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +29%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +37%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +23%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +21%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +12%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -74%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -73%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -36%
  • ↓ onboardingNewWallet/tbt: -96%
  • ↓ onboardingNewWallet/total: -70%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -48%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.26 MiB +796 Bytes 0.00%
🚨 ui 19.33 MiB +2.22 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +21 Bytes 0.00%
✅ content scripts 3.23 MiB +42 Bytes 0.00%
🚨 unzipped 79.9 MiB +6.07 KiB +0.01%
🚨 zip 24.07 MiB +2 KiB +0.01%

Matt561
Matt561 previously approved these changes Nov 3, 2026
Comment on lines +8 to +11
* It navigates to the Money home, which starts the deposit once the Money
* account is available. Users who are ineligible for a Money account are
* redirected to the wallet home by the Money page.
* - https://link.metamask.io/money-account-deposit

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jwhiles is it mandatory that we navigate to Money home first before initiating the deposit? Is it feasible to navigate directly to the Money deposit screen?

I might be missing some extension context!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically I think we need to have a route for the deposit to open from, since it isn't really a route per se - and the money home makes sense for that.

I think the alternative would be to make something akin to the deeplink bridge that you added to mobile. Happy to do that, but it will make the PR a bit bigger!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally up to you @Jwhiles. I'm happy to approve either approach.

@metamask-ci

metamask-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations (2 files, +33 -6)
  • 📁 ui/
    • 📁 pages/
      • 📁 confirmations/
        • 📁 hooks/
          • 📄 useConfirmationNavigation.test.ts +18 -0
          • 📄 useConfirmationNavigation.ts +15 -6

@metamask-ci

metamask-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
Builds ready [611b156]
⚡ Performance Benchmarks (Total: 🟢 4 pass · 🟡 5 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 41707799185 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -10%
  • ↑ loadNewAccount/fcp: +12%
  • ↑ loadNewAccount/lcp: +12%
  • ↑ loadNewAccount/cls: +282%
  • ↑ confirmTx/longTaskTotalDuration: +48%
  • ↑ confirmTx/longTaskMaxDuration: +72%
  • ↑ confirmTx/tbt: +80%
  • ↑ confirmTx/fcp: +13%
  • ↑ confirmTx/lcp: +20%
  • ↑ bridgeUserActions/bridge_load_page: +67%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +150%
  • ↑ bridgeUserActions/longTaskCount: +82%
  • ↑ bridgeUserActions/longTaskTotalDuration: +92%
  • ↑ bridgeUserActions/longTaskMaxDuration: +43%
  • ↑ bridgeUserActions/tbt: +177%
  • ↑ bridgeUserActions/total: +24%
  • ↑ bridgeUserActions/inp: +10%
  • ↑ bridgeUserActions/fcp: +11%
  • ↑ bridgeUserActions/lcp: +17%
  • ↑ bridgeUserActions/cls: +281%
  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/inp: -25%
  • ↓ loadNewAccount/fcp: -36%
  • ↑ loadNewAccount/lcp: +1253%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -21%
  • ↑ confirmTx/fcp: +26%
  • ↑ confirmTx/lcp: +1312%
  • ↑ bridgeUserActions/bridge_load_page: +230%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +132%
  • ↑ bridgeUserActions/bridge_search_token: +34%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +54%
  • ↑ bridgeUserActions/inp: +54%
  • ↑ bridgeUserActions/fcp: +18%
  • ↑ bridgeUserActions/lcp: +1270%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 2.2s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +17%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/setupStore: +147%
  • ↓ startupStandardHome/longTaskCount: -29%
  • ↑ startupStandardHome/cls: +400%
  • ↑ startupStandardHome/domInteractive: +39%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +138%
  • ↑ startupStandardHome/fcp: +44%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -10%
  • ↓ onboardingImportWallet/confirmSrpToPwForm: -16%
  • ↓ onboardingImportWallet/pwFormToMetricsScreen: -19%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -39%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -86%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -20%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -18%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -45%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -78%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -75%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -48%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.26 MiB +790 Bytes 0.00%
🚨 ui 19.34 MiB +4.5 KiB +0.02%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +33 Bytes 0.00%
✅ content scripts 3.23 MiB +66 Bytes 0.00%
🚨 unzipped 79.9 MiB +8.54 KiB +0.01%
🚨 zip 24.07 MiB +3.2 KiB +0.01%

@Matt561
Matt561 self-requested a review November 3, 2026 20:22
Matt561
Matt561 previously approved these changes Nov 3, 2026
@Jwhiles Jwhiles added the retry-ci Tells GitHub Actions to retry failed jobs, label removed automatically before the retry label Nov 4, 2026
@metamask-ci

metamask-ci Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor
Builds ready [d46420a]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 4 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 41844130312 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -10%
  • ↑ loadNewAccount/cls: +282%
  • ↑ confirmTx/longTaskTotalDuration: +45%
  • ↑ confirmTx/longTaskMaxDuration: +58%
  • ↑ confirmTx/tbt: +76%
  • ↑ bridgeUserActions/bridge_load_page: +64%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +80%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +50%
  • ↑ bridgeUserActions/tbt: +73%
  • ↑ bridgeUserActions/total: +14%
  • ↑ bridgeUserActions/cls: +281%
  • ↑ loadNewAccount/load_new_account: +184%
  • ↑ loadNewAccount/total: +184%
  • ↓ loadNewAccount/inp: -18%
  • ↑ loadNewAccount/fcp: +27%
  • ↑ loadNewAccount/lcp: +1300%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -21%
  • ↑ confirmTx/fcp: +22%
  • ↑ confirmTx/lcp: +1377%
  • ↑ bridgeUserActions/bridge_load_page: +289%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +115%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +71%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -27%
  • ↑ bridgeUserActions/lcp: +1291%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.8s
  • 🟡 loadNewAccount/FCP: p75 2.2s
  • 🟡 confirmTx/FCP: p75 2.1s
  • 🟡 confirmTx/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -26%
  • ↓ startupStandardHome/load: -28%
  • ↓ startupStandardHome/domContentLoaded: -28%
  • ↓ startupStandardHome/domInteractive: -18%
  • ↓ startupStandardHome/firstPaint: -15%
  • ↓ startupStandardHome/backgroundConnect: -30%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -64%
  • ↓ startupStandardHome/loadScripts: -28%
  • ↑ startupStandardHome/setupStore: +56%
  • ↓ startupStandardHome/longTaskCount: -29%
  • ↓ startupStandardHome/longTaskTotalDuration: -35%
  • ↓ startupStandardHome/longTaskMaxDuration: -33%
  • ↓ startupStandardHome/tbt: -36%
  • ↓ startupStandardHome/inp: -18%
  • ↓ startupStandardHome/fcp: -27%
  • ↓ startupStandardHome/lcp: -15%
  • ↑ startupStandardHome/cls: +400%
  • ↑ startupStandardHome/load: +11%
  • ↑ startupStandardHome/domInteractive: +43%
  • ↑ startupStandardHome/backgroundConnect: +11%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/loadScripts: +10%
  • ↑ startupStandardHome/setupStore: +159%
  • ↑ startupStandardHome/fcp: +46%
  • ↑ startupStandardHome/lcp: +13%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +36%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +56%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +34%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +10%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +45%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +31%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +30%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +12%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -71%
  • ↓ onboardingNewWallet/longTaskCount: -23%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -47%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -32%
  • ↓ onboardingNewWallet/tbt: -75%
  • ↓ onboardingNewWallet/total: -67%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -49%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.26 MiB +820 Bytes +0.01%
🚨 ui 19.34 MiB +2.49 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +26 Bytes 0.00%
✅ content scripts 3.23 MiB +52 Bytes 0.00%
🚨 unzipped 79.64 MiB +3.45 KiB 0.00%
🚨 zip 23.81 MiB +1.15 KiB 0.00%

OGPoyraz
OGPoyraz previously approved these changes Nov 5, 2026
ffmcgee725
ffmcgee725 previously approved these changes Nov 5, 2026
@metamask-ci

metamask-ci Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor
Builds ready [b97c89c]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 4 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42021652843 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -18%
  • ↑ loadNewAccount/lcp: +974%
  • ↑ loadNewAccount/cls: +556%
  • ↑ confirmTx/longTaskTotalDuration: +36%
  • ↑ confirmTx/longTaskMaxDuration: +47%
  • ↑ confirmTx/tbt: +61%
  • ↓ confirmTx/inp: -21%
  • ↑ confirmTx/fcp: +12%
  • ↑ confirmTx/lcp: +1029%
  • ↓ confirmTx/cls: -12%
  • ↑ bridgeUserActions/bridge_load_page: +147%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +46%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +65%
  • ↑ bridgeUserActions/longTaskMaxDuration: +23%
  • ↑ bridgeUserActions/tbt: +113%
  • ↑ bridgeUserActions/total: +19%
  • ↑ bridgeUserActions/inp: +10%
  • ↑ bridgeUserActions/fcp: +11%
  • ↑ bridgeUserActions/lcp: +993%
  • ↑ bridgeUserActions/cls: +540%
  • ↑ loadNewAccount/load_new_account: +184%
  • ↑ loadNewAccount/total: +184%
  • ↑ loadNewAccount/fcp: +17%
  • ↑ loadNewAccount/lcp: +1760%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -13%
  • ↓ confirmTx/fcp: -35%
  • ↑ confirmTx/lcp: +1342%
  • ↑ bridgeUserActions/bridge_load_page: +249%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +111%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +36%
  • ↑ bridgeUserActions/inp: +62%
  • ↑ bridgeUserActions/fcp: +22%
  • ↑ bridgeUserActions/lcp: +1285%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 loadNewAccount/LCP: p75 3.3s
  • 🟡 bridgeUserActions/FCP: p75 2.1s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +20%
  • ↑ startupStandardHome/load: +41%
  • ↑ startupStandardHome/domContentLoaded: +41%
  • ↓ startupStandardHome/firstPaint: -50%
  • ↓ startupStandardHome/backgroundConnect: -26%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -64%
  • ↑ startupStandardHome/loadScripts: +40%
  • ↑ startupStandardHome/setupStore: +36%
  • ↑ startupStandardHome/longTaskTotalDuration: +35%
  • ↑ startupStandardHome/longTaskMaxDuration: +59%
  • ↑ startupStandardHome/tbt: +47%
  • ↓ startupStandardHome/inp: -30%
  • ↑ startupStandardHome/fcp: +38%
  • ↑ startupStandardHome/lcp: +520%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/fcp: +11%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +27%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +30%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +41%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +21%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -93%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -86%
  • ↓ onboardingImportWallet/tbt: -96%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +25%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +14%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -78%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -74%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -49%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.24 MiB -14.33 KiB -0.09%
🚨 ui 19.34 MiB +6.96 KiB +0.04%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB -632 Bytes -0.01%
✅ content scripts 3.22 MiB -1.23 KiB -0.04%
🚨 unzipped 79.66 MiB +18.45 KiB +0.02%
🚨 zip 23.82 MiB +3.35 KiB +0.01%

@github-actions github-actions Bot removed the retry-ci Tells GitHub Actions to retry failed jobs, label removed automatically before the retry label Nov 5, 2026
@Jwhiles Jwhiles added the retry-ci Tells GitHub Actions to retry failed jobs, label removed automatically before the retry label Nov 5, 2026
@Jwhiles
Jwhiles dismissed stale reviews from ffmcgee725 and OGPoyraz via 8c2e98f November 5, 2026 16:21
@Jwhiles
Jwhiles force-pushed the add-money-deposit-deeplink branch from b97c89c to 8c2e98f Compare November 5, 2026 16:21
@metamask-ci

metamask-ci Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor
Builds ready [8c2e98f]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42063576320 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -18%
  • ↑ loadNewAccount/lcp: +947%
  • ↑ loadNewAccount/cls: +556%
  • ↑ confirmTx/longTaskTotalDuration: +38%
  • ↑ confirmTx/longTaskMaxDuration: +46%
  • ↑ confirmTx/tbt: +64%
  • ↓ confirmTx/inp: -21%
  • ↑ confirmTx/lcp: +975%
  • ↓ confirmTx/cls: -12%
  • ↑ bridgeUserActions/bridge_load_page: +75%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +35%
  • ↑ bridgeUserActions/longTaskTotalDuration: +11%
  • ↑ bridgeUserActions/tbt: +44%
  • ↑ bridgeUserActions/total: +13%
  • ↑ bridgeUserActions/lcp: +957%
  • ↑ bridgeUserActions/cls: +570%
  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/fcp: -56%
  • ↑ loadNewAccount/lcp: +1009%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/fcp: -57%
  • ↑ confirmTx/lcp: +1088%
  • ↑ bridgeUserActions/bridge_load_page: +142%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +292%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +48%
  • ↑ bridgeUserActions/inp: +25%
  • ↑ bridgeUserActions/lcp: +1076%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +13%
  • ↑ startupStandardHome/load: +34%
  • ↑ startupStandardHome/domContentLoaded: +35%
  • ↓ startupStandardHome/domInteractive: -17%
  • ↓ startupStandardHome/firstPaint: -58%
  • ↓ startupStandardHome/backgroundConnect: -32%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -64%
  • ↑ startupStandardHome/loadScripts: +34%
  • ↑ startupStandardHome/setupStore: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +29%
  • ↑ startupStandardHome/longTaskMaxDuration: +48%
  • ↑ startupStandardHome/tbt: +34%
  • ↓ startupStandardHome/inp: -37%
  • ↑ startupStandardHome/lcp: +304%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -21%
  • ↓ startupStandardHome/load: -15%
  • ↓ startupStandardHome/domContentLoaded: -16%
  • ↑ startupStandardHome/domInteractive: +18%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -15%
  • ↓ startupStandardHome/setupStore: -19%
  • ↑ startupStandardHome/fcp: +20%
  • ↓ startupStandardHome/lcp: -14%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -13%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -23%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -10%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -16%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -79%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -75%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -60%
  • ↓ dappPageLoad/domContentLoaded: -19%
  • ↓ dappPageLoad/firstPaint: -42%
  • ↓ dappPageLoad/firstContentfulPaint: -42%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.25 MiB +820 Bytes +0.01%
🚨 ui 19.39 MiB +2.49 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +26 Bytes 0.00%
✅ content scripts 3.23 MiB +52 Bytes 0.00%
🚨 unzipped 79.72 MiB +3.53 KiB 0.00%
🚨 zip 23.83 MiB +1.16 KiB 0.00%

@sonarqubecloud

sonarqubecloud Bot commented Nov 5, 2026

Copy link
Copy Markdown

@github-actions github-actions Bot removed the retry-ci Tells GitHub Actions to retry failed jobs, label removed automatically before the retry label Nov 5, 2026

@MajorLift MajorLift left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deeplink diligence: #47592 (feat: add money deposit deeplink)
head 8c2e98fc23c · range 7c3f8348f7c..8c2e98fc23c

✅ Signature boundary holds — the new /money-account-deposit route reads no link parameter and always lands on /money-home/deposit with an empty query (money-account-deposit.ts L14-L19).

Check Holds because Where
The signature binds the sig_params list canonicalize appends sig_params itself to the signed string, so a rewritten list fails verification. canonicalize.ts is not in the range canonicalize.ts L43
Canonical is not read as validated The handler takes _params, reads nothing from it and returns a new empty URLSearchParams, so it makes no difference whether "canonical" is the signed subset or the whole query money-account-deposit.ts L14-L19
Nothing past canonical reaches a handler or destination parse hands the handler canonicalUrl.searchParams (not in the range). The bridge page reads no location, search or hash, and passes only constants to initiateDeposit parse.ts L81-L85, money-deposit-deeplink-page.tsx L21-L49
Attribution is forwarded only from what the handler received The destination query is empty, so the route forwards nothing. DeepLinkUsed reads the original URL in the background, unchanged money-account-deposit.ts L17, metrics.ts L52-L75
What consumes the value after the handoff refuses what it cannot match Nothing is handed off. The bridge overrides the hook's location-derived goBackTo with MONEY_HOME_ROUTE, and the confirmation's query is built only from those options money-deposit-deeplink-page.tsx L34-L37, useMoneyAccountDeposit.ts L179, useConfirmationNavigation.ts L220-L249
Empty sig_params The signed string is the origin, the path and sig_params=, and canonicalization drops every unlisted parameter before the handler runs, so appended unsigned values never reach it, whatever the handler does canonicalize.ts L26-L46, parse.ts L81-L85
A parameter twice canonicalize collects listed values with getAll, but the route reads no parameter, so no reader can disagree with it canonicalize.ts L36, money-account-deposit.ts L14-L19
Path binding The signed string includes url.pathname, so a signature made for another route does not verify on /money-account-deposit canonicalize.ts L56
The path is protected by the deep-link interstitial (PR description summary) shouldShowDeepLinkInterstitial takes no route. It skips only for https://metamask.io or https://app.metamask.io, or for a valid signature with the user's opt-out, on every path security-policy.ts L19-L22, L61-L75
Parity with mobile (PR description) Holds for the path and for taking no parameters. It differs on the interstitial: mobile lists this action in WHITELISTED_ACTIONS and skips it, while the extension shows it under the policy above, which needs the Extension Security team's approval to loosen mobile handleUniversalLink.ts L159-L192, security-policy.ts L10-L13

Not reached: a built extension, because the boundary ends at the destination, which parse() with a real P-256 key returned as /money-home/deposit with no query for signed, unsigned, empty-sig_params and duplicate-parameter links; the interstitial page and the bridge's navigation were read at head, not run.

@Matt561
Matt561 self-requested a review November 5, 2026 19:59
@Jwhiles
Jwhiles added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit 88571e5 Nov 6, 2026
259 of 261 checks passed
@Jwhiles
Jwhiles deleted the add-money-deposit-deeplink branch November 6, 2026 10:15
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 6, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.58.0 on PR, as PR was added to branch 13.58.0 when release was cut.

This branch had an error being deployed

1 failed (outdated) and 1 inactive deployments
pr-comment — 8c2e98fc Deployed Nov 5, 2026 by Jwhiles via Publish prerelease / Publish prerelease #173061
segment-schema — d46420a8 Deployed Nov 4, 2026 by Jwhiles via propose #3071
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-M team-earn

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants