Repository navigation
feat: add money deposit deeplink - #47592
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [c702767]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 3 warn · 🔴 4 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
| * It navigates to the Money home, which starts the deposit once the Money | ||
| * account is available. Users who are ineligible for a Money account are | ||
| * redirected to the wallet home by the Money page. | ||
| * - https://link.metamask.io/money-account-deposit |
There was a problem hiding this comment.
@Jwhiles is it mandatory that we navigate to Money home first before initiating the deposit? Is it feasible to navigate directly to the Money deposit screen?
I might be missing some extension context!
There was a problem hiding this comment.
basically I think we need to have a route for the deposit to open from, since it isn't really a route per se - and the money home makes sense for that.
I think the alternative would be to make something akin to the deeplink bridge that you added to mobile. Happy to do that, but it will make the PR a bit bigger!
There was a problem hiding this comment.
Totally up to you @Jwhiles. I'm happy to approve either approach.
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (2 files, +33 -6)
|
Builds ready [611b156]
⚡ Performance Benchmarks (Total: 🟢 4 pass · 🟡 5 warn · 🔴 4 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [d46420a]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 4 warn · 🔴 4 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [b97c89c]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 4 warn · 🔴 4 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
b97c89c to
8c2e98f
Compare
Builds ready [8c2e98f]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
|
MajorLift
left a comment
There was a problem hiding this comment.
Deeplink diligence: #47592 (feat: add money deposit deeplink)
head 8c2e98fc23c · range 7c3f8348f7c..8c2e98fc23c
✅ Signature boundary holds — the new /money-account-deposit route reads no link parameter and always lands on /money-home/deposit with an empty query (money-account-deposit.ts L14-L19).
| Check | Holds because | Where |
|---|---|---|
The signature binds the sig_params list |
canonicalize appends sig_params itself to the signed string, so a rewritten list fails verification. canonicalize.ts is not in the range |
canonicalize.ts L43 |
| Canonical is not read as validated | The handler takes _params, reads nothing from it and returns a new empty URLSearchParams, so it makes no difference whether "canonical" is the signed subset or the whole query |
money-account-deposit.ts L14-L19 |
| Nothing past canonical reaches a handler or destination | parse hands the handler canonicalUrl.searchParams (not in the range). The bridge page reads no location, search or hash, and passes only constants to initiateDeposit |
parse.ts L81-L85, money-deposit-deeplink-page.tsx L21-L49 |
| Attribution is forwarded only from what the handler received | The destination query is empty, so the route forwards nothing. DeepLinkUsed reads the original URL in the background, unchanged |
money-account-deposit.ts L17, metrics.ts L52-L75 |
| What consumes the value after the handoff refuses what it cannot match | Nothing is handed off. The bridge overrides the hook's location-derived goBackTo with MONEY_HOME_ROUTE, and the confirmation's query is built only from those options |
money-deposit-deeplink-page.tsx L34-L37, useMoneyAccountDeposit.ts L179, useConfirmationNavigation.ts L220-L249 |
Empty sig_params |
The signed string is the origin, the path and sig_params=, and canonicalization drops every unlisted parameter before the handler runs, so appended unsigned values never reach it, whatever the handler does |
canonicalize.ts L26-L46, parse.ts L81-L85 |
| A parameter twice | canonicalize collects listed values with getAll, but the route reads no parameter, so no reader can disagree with it |
canonicalize.ts L36, money-account-deposit.ts L14-L19 |
| Path binding | The signed string includes url.pathname, so a signature made for another route does not verify on /money-account-deposit |
canonicalize.ts L56 |
| The path is protected by the deep-link interstitial (PR description summary) | shouldShowDeepLinkInterstitial takes no route. It skips only for https://metamask.io or https://app.metamask.io, or for a valid signature with the user's opt-out, on every path |
security-policy.ts L19-L22, L61-L75 |
| Parity with mobile (PR description) | Holds for the path and for taking no parameters. It differs on the interstitial: mobile lists this action in WHITELISTED_ACTIONS and skips it, while the extension shows it under the policy above, which needs the Extension Security team's approval to loosen |
mobile handleUniversalLink.ts L159-L192, security-policy.ts L10-L13 |
Not reached: a built extension, because the boundary ends at the destination, which parse() with a real P-256 key returned as /money-home/deposit with no query for signed, unsigned, empty-sig_params and duplicate-parameter links; the interstitial page and the bridge's navigation were read at head, not run.
|
No release label on PR. Adding release label release-13.58.0 on PR, as PR was added to branch 13.58.0 when release was cut. |



Description
Adds money deposit deeplink, to achieve parity with mobile
Changelog
CHANGELOG entry: add money deposit deeplink
Related issues
Fixes: n/a
Manual testing steps
Screenshots/Recordings
Before
n/a
After
Screen.Recording.2026-11-03.at.16.33.01.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Introduces a new entry into the Money deposit confirmation flow and changes navigation/history behavior for that path, though eligibility checks and failure fallbacks mirror existing Money patterns.
Overview
Adds
https://link.metamask.io/money-account-depositfor extension parity with mobile. The new deep link maps to/money-home/deposit, a bridge page that waits for Money account availability, starts a deposit, and replaces itself with the deposit confirmation so back returns to Money home; ineligible users or failed setup go to wallet home.Supporting changes:
useMoneyAccountDeposit.initiateDepositnow resolvestrue/false, acceptsreplaceConfirmationandgoBackTo, and ignores duplicate in-flight calls;navigateToTransactionsupportsreplacefor history. The path is on the interstitial-protected list and includes locale copy for the link title.Reviewed by Cursor Bugbot for commit 8c2e98f. Bugbot is set up for automated code reviews on this repo. Configure here.