Repository navigation
chore: remove unused onboarding flow styles - #47598
Conversation
✨ Files requiring CODEOWNER review ✨🔐 @MetaMask/web3auth (7 files, +0 -84)
|
Builds ready [ec1c404]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 2 fail)
Bundle Size Diffs
|
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
ec1c404 to
3ac1120
Compare
Builds ready [3ac1120]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 2 warn · 🔴 3 fail)
Bundle Size Diffs
|
|
|
No release label on PR. Adding release label release-13.58.0 on PR, as PR was added to branch 13.58.0 when release was cut. |



Description
Audit of every
.scssfile underui/pages/onboarding-flow/(7 files), removing CSS that nothing references. No visual change intended. Net: 84 lines deleted, 0 added, 7 files touched; no file became empty, so no@importlines changed. No routes, deep-link handlers or URL-reachable screens were touched.Method: for every compiled class name I searched the whole repo (
ui/,test/incl. e2e page objects/specs,shared/,app/, snapshots), both the full BEM name and its fragments (e.g.__weak,welcome--banner,quiz-word,create-password__${), and reviewed everyclassnames()/ template-stringclassNameinui/pages/onboarding-flow. I also compiledui/pages/onboarding-flow/index.scsswith Sass before and after: the CSS diff consists only of deletions of the rules below; every surviving rule is byte-identical.Removed selectors (with evidence)
.onboarding-flow__x-button__icon(index.scss)x-buttonanywhere outside this SCSS.welcome-container__wordmark-container,--complete(welcome/index.scss)riv-animation__wordmark-container*(metamask-wordmark-animation.tsx)..welcome-containeritself is kept (used).welcome-login__mascot--image(welcome/index.scss)welcome-login__mascotormascot--@keyframes fadeInUp(welcome/index.scss)animation: fadeInUpanywhere inui//app//shared/(onlyfadeInUpSmooth, which is kept). The sole other hit is an unrelated third-party test-dapp CSS mock.onboarding-app-header__dropdown--welcome--banner(+ nested.dropdown__select,.dropdown__icon-caret-down) (onboarding-app-header/index.scss)__dropdown--welcome--login. Leftover of the welcome banner removed in #47561.recovery-phrase__chips .mm-text-field.mm-text-field--quiz-word(+ nested.mm-input) (recovery-phrase/index.scss)TextFieldnever emits--quiz-word(it only emits--size-*,--focused,--error,--disabled,--truncate);recovery-phrase-chips.tsxpasses no such class. Onlydata-quiz-wordsattribute exists.recovery-phrase__chips .mm-text-field.mm-text-field--target-index(dropped from a selector list) (recovery-phrase/index.scss)styleinrecovery-phrase-chips.tsx.privacy-settings__network(privacy-settings/index.scss).onboarding-metametrics__checkbox-label(metametrics/index.scss)metametrics.tsxuses__checkboxand__user-controlonly).onboarding-metametrics__terms(+ nesteda) (metametrics/index.scss)onboarding-metametrics__terms.create-password__weak,__average,__strong(create-password/index.scss)create-password__${…}construction anywhereNo image/font assets were referenced by the removed rules (none of these files contain
url(...)), and none of the files define local SCSS variables/mixins.Kept, uncertain
.recovery-phrase__chips .mm-text-field:not(.mm-text-field--quiz-word):--quiz-wordis never emitted, but the:not()makes this rule match every.mm-text-fieldin the chips, so it's live. Simplifying it would change specificity, so I left it as is..recovery-phrase__chips .mm-text-field.mm-text-field--focused:--focusedis emitted byTextField, but only when!disabled, and the chips'TextFields aredisabled. Kept because it's a real runtime modifier..privacy-settings .hidden: applied viaclassnames('detail-view', { hidden: !showDetail && hiddenClass }). Generic name, kept..onboarding-metametrics p/ul,.privacy-settings__header a,.privacy-settings__settings a): can't be reliably attributed by grep, so I kept them..privacy-settings .container/.list-view/.detail-view/.show-detail/.show-list/.categories-item: all referenced inprivacy-settings.tsx. Kept.Changelog
CHANGELOG entry: null
Related issues
Follow-up to #47561
Manual testing steps
yarn start), then start a fresh onboarding.Screenshots/Recordings
No visual regressions
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Stylesheet-only deletions with no route or logic changes; risk is limited to a missed reference causing a subtle styling regression on onboarding screens.
Reviewed by Cursor Bugbot for commit 3ac1120. Bugbot is set up for automated code reviews on this repo. Configure here.