Skip to content

chore: remove unused onboarding flow styles - #47598

Merged
georgewrmarshall merged 1 commit into
mainfrom
cursor/remove-unused-onboarding-styles-ee5f
Nov 6, 2026
Merged

georgewrmarshall merged 1 commit into
mainfrom
cursor/remove-unused-onboarding-styles-ee5f

Conversation

@georgewrmarshall

@georgewrmarshall georgewrmarshall commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Description

Audit of every .scss file under ui/pages/onboarding-flow/ (7 files), removing CSS that nothing references. No visual change intended. Net: 84 lines deleted, 0 added, 7 files touched; no file became empty, so no @import lines changed. No routes, deep-link handlers or URL-reachable screens were touched.

Method: for every compiled class name I searched the whole repo (ui/, test/ incl. e2e page objects/specs, shared/, app/, snapshots), both the full BEM name and its fragments (e.g. __weak, welcome--banner, quiz-word, create-password__${), and reviewed every classnames() / template-string className in ui/pages/onboarding-flow. I also compiled ui/pages/onboarding-flow/index.scss with Sass before and after: the CSS diff consists only of deletions of the rules below; every surviving rule is byte-identical.

Removed selectors (with evidence)

Selector (file) Evidence it's unused
.onboarding-flow__x-button__icon (index.scss) 0 references to x-button anywhere outside this SCSS
.welcome-container__wordmark-container, --complete (welcome/index.scss) 0 refs; the wordmark uses riv-animation__wordmark-container* (metamask-wordmark-animation.tsx). .welcome-container itself is kept (used)
.welcome-login__mascot--image (welcome/index.scss) 0 refs to welcome-login__mascot or mascot--
@keyframes fadeInUp (welcome/index.scss) No animation: fadeInUp anywhere in ui//app//shared/ (only fadeInUpSmooth, which is kept). The sole other hit is an unrelated third-party test-dapp CSS mock
.onboarding-app-header__dropdown--welcome--banner (+ nested .dropdown__select, .dropdown__icon-caret-down) (onboarding-app-header/index.scss) 0 refs; component only applies __dropdown--welcome--login. Leftover of the welcome banner removed in #47561
.recovery-phrase__chips .mm-text-field.mm-text-field--quiz-word (+ nested .mm-input) (recovery-phrase/index.scss) TextField never emits --quiz-word (it only emits --size-*, --focused, --error, --disabled, --truncate); recovery-phrase-chips.tsx passes no such class. Only data-quiz-words attribute exists
.recovery-phrase__chips .mm-text-field.mm-text-field--target-index (dropped from a selector list) (recovery-phrase/index.scss) Never emitted; target index styling is applied via inline style in recovery-phrase-chips.tsx
.privacy-settings__network (privacy-settings/index.scss) 0 refs
.onboarding-metametrics__checkbox-label (metametrics/index.scss) 0 refs (metametrics.tsx uses __checkbox and __user-control only)
.onboarding-metametrics__terms (+ nested a) (metametrics/index.scss) 0 refs to onboarding-metametrics__terms
.create-password__weak, __average, __strong (create-password/index.scss) 0 refs, no create-password__${…} construction anywhere

No image/font assets were referenced by the removed rules (none of these files contain url(...)), and none of the files define local SCSS variables/mixins.

Kept, uncertain

  • .recovery-phrase__chips .mm-text-field:not(.mm-text-field--quiz-word): --quiz-word is never emitted, but the :not() makes this rule match every .mm-text-field in the chips, so it's live. Simplifying it would change specificity, so I left it as is.
  • .recovery-phrase__chips .mm-text-field.mm-text-field--focused: --focused is emitted by TextField, but only when !disabled, and the chips' TextFields are disabled. Kept because it's a real runtime modifier.
  • .privacy-settings .hidden: applied via classnames('detail-view', { hidden: !showDetail && hiddenClass }). Generic name, kept.
  • Element selectors (.onboarding-metametrics p/ul, .privacy-settings__header a, .privacy-settings__settings a): can't be reliably attributed by grep, so I kept them.
  • Generic class selectors .privacy-settings .container/.list-view/.detail-view/.show-detail/.show-list/.categories-item: all referenced in privacy-settings.tsx. Kept.

Changelog

CHANGELOG entry: null

Related issues

Follow-up to #47561

Manual testing steps

  1. Build and run the extension (yarn start), then start a fresh onboarding.
  2. On the welcome screen, verify the wordmark/fox animations, the login options sheet (social icons, "or" divider, plain buttons) and the language dropdown look unchanged.
  3. Create a new wallet: verify the create-password screen (link text) looks unchanged.
  4. On the Secret Recovery Phrase screen, verify the blurred chips, "tap to reveal", and the confirm/quiz step chips look unchanged.
  5. Verify the MetaMetrics screen (checkbox, user-control image, lists) and Privacy settings (list/detail slide, customizable network rows) look unchanged.

Screenshots/Recordings

No visual regressions

Screen Before After
Welcome Welcome before Welcome after
Create password Create password before Create password after
Secret Recovery Phrase SRP before SRP after
SRP confirm / quiz SRP confirm before SRP confirm after
MetaMetrics MetaMetrics before MetaMetrics after
Privacy settings Privacy settings before Privacy settings after

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Open in Web Open in Cursor 

Note

Low Risk
Stylesheet-only deletions with no route or logic changes; risk is limited to a missed reference causing a subtle styling regression on onboarding screens.

Reviewed by Cursor Bugbot for commit 3ac1120. Bugbot is set up for automated code reviews on this repo. Configure here.

@metamask-ci

metamask-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

🔐 @MetaMask/web3auth (7 files, +0 -84)
  • 📁 ui/
    • 📁 pages/
      • 📁 onboarding-flow/
        • 📁 create-password/
          • 📄 index.scss +0 -12
        • 📁 metametrics/
          • 📄 index.scss +0 -13
        • 📁 onboarding-app-header/
          • 📄 index.scss +0 -13
        • 📁 privacy-settings/
          • 📄 index.scss +0 -4
        • 📁 recovery-phrase/
          • 📄 index.scss +0 -9
        • 📁 welcome/
          • 📄 index.scss +0 -29
          • 📄 index.scss +0 -4

@metamask-ci metamask-ci Bot added the team-design-system All issues relating to design system in Extension label Nov 3, 2026
@metamask-ci

metamask-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
Builds ready [ec1c404]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 2 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 41708266659 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -18%
  • ↑ loadNewAccount/cls: +282%
  • ↑ confirmTx/longTaskTotalDuration: +42%
  • ↑ confirmTx/longTaskMaxDuration: +60%
  • ↑ confirmTx/tbt: +72%
  • ↑ bridgeUserActions/bridge_load_page: +65%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +102%
  • ↑ bridgeUserActions/longTaskCount: +82%
  • ↑ bridgeUserActions/longTaskTotalDuration: +84%
  • ↑ bridgeUserActions/longTaskMaxDuration: +40%
  • ↑ bridgeUserActions/tbt: +151%
  • ↑ bridgeUserActions/total: +23%
  • ↑ bridgeUserActions/inp: +10%
  • ↑ bridgeUserActions/cls: +281%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -18%
  • ↓ loadNewAccount/fcp: -36%
  • ↑ loadNewAccount/lcp: +1260%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -21%
  • ↓ confirmTx/fcp: -38%
  • ↑ confirmTx/lcp: +1277%
  • ↑ bridgeUserActions/bridge_load_page: +249%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +152%
  • ↑ bridgeUserActions/bridge_search_token: +50%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +80%
  • ↑ bridgeUserActions/inp: +47%
  • ↑ bridgeUserActions/fcp: +19%
  • ↑ bridgeUserActions/lcp: +1230%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 2.1s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +11%
  • ↑ startupStandardHome/domInteractive: +20%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/setupStore: +147%
  • ↓ startupStandardHome/longTaskCount: -29%
  • ↑ startupStandardHome/tbt: +11%
  • ↑ startupStandardHome/cls: +400%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -21%
  • ↓ onboardingImportWallet/confirmSrpToPwForm: -22%
  • ↓ onboardingImportWallet/pwFormToMetricsScreen: -18%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -30%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -86%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +34%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +19%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +16%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +12%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -80%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -73%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -36%
  • ↓ onboardingNewWallet/tbt: -99%
  • ↓ onboardingNewWallet/total: -75%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -59%
  • ↓ dappPageLoad/domContentLoaded: -17%
  • ↓ dappPageLoad/firstPaint: -42%
  • ↓ dappPageLoad/firstContentfulPaint: -42%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +25 Bytes 0.00%
✅ ui 19.33 MiB -40 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB -84 Bytes 0.00%
✅ content scripts 3.23 MiB -168 Bytes 0.00%
✅ unzipped 79.63 MiB -267.52 KiB -0.33%
✅ zip 23.81 MiB -265.46 KiB -1.08%

Base automatically changed from cursor/remove-mm-poly-mm-sans-fonts-2ca6 to main November 4, 2026 03:21
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
@cursor
cursor Bot force-pushed the cursor/remove-unused-onboarding-styles-ee5f branch from ec1c404 to 3ac1120 Compare November 5, 2026 05:42
@metamask-ci

metamask-ci Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor
Builds ready [3ac1120]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 2 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 41975751432 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +179%
  • ↑ loadNewAccount/total: +179%
  • ↓ loadNewAccount/inp: -18%
  • ↓ loadNewAccount/fcp: -28%
  • ↓ loadNewAccount/lcp: -22%
  • ↑ loadNewAccount/cls: +278%
  • ↑ confirmTx/longTaskMaxDuration: +15%
  • ↑ confirmTx/tbt: +18%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -26%
  • ↓ confirmTx/lcp: -14%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +65%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +10%
  • ↓ bridgeUserActions/longTaskMaxDuration: -25%
  • ↓ bridgeUserActions/tbt: -28%
  • ↓ bridgeUserActions/inp: -12%
  • ↓ bridgeUserActions/fcp: -24%
  • ↑ bridgeUserActions/cls: +281%
  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/inp: -10%
  • ↑ loadNewAccount/fcp: +24%
  • ↑ loadNewAccount/lcp: +1410%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/fcp: -32%
  • ↑ confirmTx/lcp: +1355%
  • ↑ bridgeUserActions/bridge_load_page: +284%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +109%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +55%
  • ↑ bridgeUserActions/inp: +62%
  • ↑ bridgeUserActions/fcp: +26%
  • ↑ bridgeUserActions/lcp: +1421%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.2s
  • 🟡 loadNewAccount/LCP: p75 2.7s
  • 🟡 bridgeUserActions/FCP: p75 2.2s
  • 🟡 bridgeUserActions/LCP: p75 2.7s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +11%
  • ↑ startupStandardHome/domInteractive: +22%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/setupStore: +134%
  • ↑ startupStandardHome/tbt: +12%
  • ↑ startupStandardHome/cls: +400%
  • ↓ startupStandardHome/uiStartup: -21%
  • ↓ startupStandardHome/load: -15%
  • ↓ startupStandardHome/domContentLoaded: -17%
  • ↑ startupStandardHome/domInteractive: +29%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -15%
  • ↓ startupStandardHome/setupStore: -14%
  • ↑ startupStandardHome/fcp: +23%
  • ↓ startupStandardHome/lcp: -13%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -19%
  • ↓ onboardingImportWallet/confirmSrpToPwForm: -18%
  • ↓ onboardingImportWallet/pwFormToMetricsScreen: -18%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -36%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -86%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -27%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -27%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -18%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -50%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -77%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -73%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -67%
  • ↓ dappPageLoad/domContentLoaded: -32%
  • ↓ dappPageLoad/firstPaint: -47%
  • ↓ dappPageLoad/firstContentfulPaint: -47%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.24 MiB +130 Bytes 0.00%
✅ ui 19.33 MiB +65 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.22 MiB 0 Bytes 0.00%
✅ unzipped 79.65 MiB -1.17 KiB 0.00%
✅ zip 23.81 MiB -110 Bytes 0.00%

@sonarqubecloud

sonarqubecloud Bot commented Nov 5, 2026

Copy link
Copy Markdown

@georgewrmarshall
georgewrmarshall marked this pull request as ready for review November 5, 2026 13:13
@georgewrmarshall
georgewrmarshall requested a review from a team as a code owner November 5, 2026 13:13
@georgewrmarshall georgewrmarshall self-assigned this Nov 5, 2026

@smgv smgv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@georgewrmarshall
georgewrmarshall added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit 7585b3a Nov 6, 2026
155 checks passed
@georgewrmarshall
georgewrmarshall deleted the cursor/remove-unused-onboarding-styles-ee5f branch November 6, 2026 18:54
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 6, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.58.0 on PR, as PR was added to branch 13.58.0 when release was cut.

This branch was previously deployed

1 inactive deployment
pr-comment — 3ac1120f Deployed Nov 5, 2026 by georgewrmarshall via identify-codeowners #88733
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-S team-design-system All issues relating to design system in Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants