Repository navigation
chore(batch-sell): remove unused batch sell imports and locals - #47635
Merged
georgewrmarshall merged 1 commit intoNov 6, 2026
Merged
Conversation
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
georgewrmarshall
temporarily deployed
to
pr-comment
November 5, 2026 09:27 — with
GitHub Actions
Inactive
georgewrmarshall
temporarily deployed
to
pr-comment
November 5, 2026 09:43 — with
GitHub Actions
Inactive
Contributor
Builds ready [0fe01f8]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 1 warn · 🔴 4 fail)
Bundle Size Diffs
|
|
georgewrmarshall
enabled auto-merge
November 5, 2026 18:56
n3ps
approved these changes
Nov 6, 2026
amandaye0h
approved these changes
Nov 6, 2026
georgewrmarshall
deleted the
cursor/remove-dead-code-batch-sell-locals-20261105
branch
November 6, 2026 07:32
Contributor
|
No release label on PR. Adding release label release-13.58.0 on PR, as PR was added to branch 13.58.0 when release was cut. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Removes unused imports and locals in the batch-sell review flow and the batch-sell selector tests, as reported by
tsc --noUnusedLocals. The helpershasAnyEnabledAssetandhasAtLeastOneQuoteAvailablestay; only an unused import of them intotal-received-modal.tsxis removed. The modal still receivesanyEnabledAssetandatLeastOneQuoteAvailableas props.Owner set: none (no CODEOWNERS match for any touched file).
ui/pages/batch-sell/pages/review/components/total-received-modal.tsxuseMemo,hasAnyEnabledAsset,hasAtLeastOneQuoteAvailableimportsui/pages/batch-sell/pages/review/hooks/useBatchSellAggregateValidation.tsBigNumber,getNativeAssetForChainIdimportsui/pages/batch-sell/pages/review/hooks/useBatchSellQuotesFetching.tsCaipAssetTypeimportui/pages/batch-sell/pages/review/utils/buildQuoteRequest.test.tsASSET_IDui/ducks/batch-sell/selectors.test.tsMOCK_SOLANA_ACCOUNT,ALL_NETWORKS,MOCK_SOLANA_NETWORKMOCK_SOLANA_NETWORKis a cascade: its only reader wasALL_NETWORKS)Every removed item was proven with a whole-repo whole-word search. Other
MOCK_SOLANA_ACCOUNThits are a different export intest/data/bridge/mock-bridge-store.ts. Other*_ASSET_IDnames in the selector test are different locals.hasAnyEnabledAssetandhasAtLeastOneQuoteAvailableremain used by the review page. Checked against the diffs of all 562 open PRs: none edit these files. Declaration blame is June–July 2026, outside the 60-day window, and these files last changed before the 30-day window. No user-facing behavior change.Checks passed:
yarn lint:tsc, eslint on the touched files, andyarn test:unit --coverage=falseforui/ducks/batch-sellplus the touched review tests (96 tests, no snapshot updates).Docs/comments updated: none
Changelog
CHANGELOG entry: null
Related issues
Refs: proactive dead-code cleanup (extension counterpart of metamask-mobile#37948)
Manual testing steps
N/A — deletes unreachable code. There is no user-facing behavior to click through.
Screenshots/Recordings
N/A — no UI change
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Import and test-fixture deletions only; batch-sell logic and UI props are unchanged.
Overview
Dead-code cleanup in the batch-sell review flow and selector tests so
tsc --noUnusedLocalsstays clean. No runtime or UI behavior changes.Review flow: Drops unused imports from
total-received-modal.tsx(useMemo,hasAnyEnabledAsset,hasAtLeastOneQuoteAvailable); the modal still usesanyEnabledAssetandatLeastOneQuoteAvailablefrom props.useBatchSellAggregateValidationanduseBatchSellQuotesFetchinglose unusedBigNumber,getNativeAssetForChainId, andCaipAssetTypeimports.buildQuoteRequest.test.tsremoves an unusedASSET_IDconstant.Tests:
selectors.test.tsremoves unused Solana fixtures (MOCK_SOLANA_ACCOUNT,MOCK_SOLANA_NETWORK,ALL_NETWORKS) that nothing referenced after other test setup.Reviewed by Cursor Bugbot for commit 0fe01f8. Bugbot is set up for automated code reviews on this repo. Configure here.