Skip to content

chore(hyperliquid): remove unused Hex type import - #47636

Merged
georgewrmarshall merged 1 commit into
mainfrom
cursor/remove-dead-code-hyperliquid-hex-20261105
Nov 6, 2026
Merged

georgewrmarshall merged 1 commit into
mainfrom
cursor/remove-dead-code-hyperliquid-hex-20261105

Conversation

@georgewrmarshall

@georgewrmarshall georgewrmarshall commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Description

Removes the unused Hex type import from the Hyperliquid deposit constants. CaipAssetType stays. Reported by tsc --noUnusedLocals (TS6196).

Owner set: none (no CODEOWNERS match).

path removed (file / symbol / class) why dead
app/scripts/lib/hyperliquid-deposit/constants.ts Hex type import unused local

Whole-repo whole-word search: other Hex hits are unrelated identifiers (the @metamask/utils type and local variables). No open PR edits this file. Import blame and the file's last change are both 2026-09-03, outside the 60-day and 30-day windows. No user-facing behavior change.

Checks passed: yarn lint:tsc, eslint on the touched file, and yarn test:unit --coverage=false app/scripts/lib/hyperliquid-deposit with no snapshot updates.

Docs/comments updated: none

Changelog

CHANGELOG entry: null

Related issues

Refs: proactive dead-code cleanup (extension counterpart of metamask-mobile#37948)

Manual testing steps

N/A — deletes unreachable code. There is no user-facing behavior to click through.

Screenshots/Recordings

N/A — no UI change

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Dead import removal only; constants and Hyperliquid deposit behavior are unchanged.

Overview
Removes the unused Hex type from the @metamask/utils import in Hyperliquid deposit constants.ts, leaving CaipAssetType unchanged. This is a TypeScript noUnusedLocals cleanup with no runtime or user-facing impact.

Reviewed by Cursor Bugbot for commit f5e3476. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
@georgewrmarshall georgewrmarshall added team-design-system All issues relating to design system in Extension and removed size-XS labels Nov 5, 2026 — with Cursor
@georgewrmarshall georgewrmarshall self-assigned this Nov 5, 2026
@metamask-ci

metamask-ci Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor
Builds ready [f5e3476]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42002570531 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -10%
  • ↑ loadNewAccount/cls: +282%
  • ↑ confirmTx/longTaskTotalDuration: +48%
  • ↑ confirmTx/longTaskMaxDuration: +67%
  • ↑ confirmTx/tbt: +82%
  • ↑ confirmTx/lcp: +13%
  • ↑ bridgeUserActions/bridge_load_page: +74%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +98%
  • ↑ bridgeUserActions/longTaskCount: +82%
  • ↑ bridgeUserActions/longTaskTotalDuration: +108%
  • ↑ bridgeUserActions/longTaskMaxDuration: +48%
  • ↑ bridgeUserActions/tbt: +152%
  • ↑ bridgeUserActions/total: +18%
  • ↑ bridgeUserActions/inp: +25%
  • ↑ bridgeUserActions/cls: +281%
  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/inp: -10%
  • ↑ loadNewAccount/fcp: +23%
  • ↑ loadNewAccount/lcp: +1296%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -13%
  • ↑ confirmTx/fcp: +26%
  • ↑ confirmTx/lcp: +1431%
  • ↑ bridgeUserActions/bridge_load_page: +177%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +113%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +52%
  • ↑ bridgeUserActions/inp: +54%
  • ↑ bridgeUserActions/fcp: +25%
  • ↑ bridgeUserActions/lcp: +1354%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 loadNewAccount/FCP: p75 2.1s
  • 🟡 confirmTx/FCP: p75 2.2s
  • 🟡 confirmTx/LCP: p75 2.6s
  • 🟡 bridgeUserActions/FCP: p75 2.2s
  • 🟡 bridgeUserActions/LCP: p75 2.6s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +15%
  • ↑ startupStandardHome/load: +12%
  • ↑ startupStandardHome/domContentLoaded: +12%
  • ↑ startupStandardHome/domInteractive: +27%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +11%
  • ↑ startupStandardHome/setupStore: +121%
  • ↑ startupStandardHome/longTaskMaxDuration: +12%
  • ↑ startupStandardHome/tbt: +15%
  • ↑ startupStandardHome/fcp: +12%
  • ↑ startupStandardHome/lcp: +12%
  • ↑ startupStandardHome/cls: +400%
  • ↓ startupStandardHome/uiStartup: -21%
  • ↓ startupStandardHome/load: -14%
  • ↓ startupStandardHome/domContentLoaded: -16%
  • ↑ startupStandardHome/domInteractive: +23%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -14%
  • ↓ startupStandardHome/setupStore: -14%
  • ↑ startupStandardHome/inp: +50%
  • ↑ startupStandardHome/fcp: +21%
  • ↓ startupStandardHome/lcp: -13%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +30%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +34%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +29%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +21%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -73%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -21%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -22%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -37%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -77%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -74%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -50%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.24 MiB +131 Bytes 0.00%
✅ ui 19.34 MiB +68 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +1 Bytes 0.00%
✅ content scripts 3.22 MiB +2 Bytes 0.00%
✅ unzipped 79.65 MiB +207 Bytes 0.00%
✅ zip 23.81 MiB -9 Bytes 0.00%

@sonarqubecloud

sonarqubecloud Bot commented Nov 5, 2026

Copy link
Copy Markdown

@georgewrmarshall
georgewrmarshall added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit c55527a Nov 6, 2026
266 of 269 checks passed
@georgewrmarshall
georgewrmarshall deleted the cursor/remove-dead-code-hyperliquid-hex-20261105 branch November 6, 2026 18:52
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 6, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026

This branch was previously deployed

1 inactive deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 team-design-system All issues relating to design system in Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants