Repository navigation
chore(selectors): remove unused selector imports - #47637
Merged
georgewrmarshall merged 1 commit intoNov 6, 2026
Merged
Conversation
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
georgewrmarshall
temporarily deployed
to
pr-comment
November 5, 2026 09:27 — with
GitHub Actions
Inactive
georgewrmarshall
temporarily deployed
to
pr-comment
November 5, 2026 09:40 — with
GitHub Actions
Inactive
Contributor
Builds ready [46b2290]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)
Bundle Size Diffs
|
|
georgewrmarshall
enabled auto-merge
November 5, 2026 18:56
n3ps
approved these changes
Nov 6, 2026
amandaye0h
approved these changes
Nov 6, 2026
georgewrmarshall
deleted the
cursor/remove-dead-code-selectors-imports-20261105
branch
November 6, 2026 07:32
Contributor
|
No release label on PR. Adding release label release-13.58.0 on PR, as PR was added to branch 13.58.0 when release was cut. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Removes two unused imports reported by
tsc --noUnusedLocals.infuraProjectIdremains the live constant inshared/constants/network.ts; only the unused import in the multichain network selectors is removed.ProductTyperemains used by subscription hooks; only the unused import inui/selectors/subscription/subscription.tsis removed.Owner set: none (no CODEOWNERS match for any touched file).
ui/selectors/multichain/networks.tsinfuraProjectIdimportui/selectors/subscription/subscription.tsProductTypeimportWhole-repo whole-word search: remaining
infuraProjectIdhits are the live constant, its callers, and docs/fixtures. RemainingProductTypehits are other files that import the type themselves. Open PRs mentioninfuraProjectIdin unrelated diffs; none edit these two files, and none mentionProductType.infuraProjectIdimport blame is 2026-03-02 (file last changed 2026-08-17).ProductTypeimport blame is 2025-09-24 (file last changed 2026-06-12). No user-facing behavior change.Checks passed:
yarn lint:tsc, eslint on the touched files, andyarn test:unit --coverage=falseforui/selectors/multichain/networks.test.tsandui/selectors/subscription/subscription.test.tswith no snapshot updates.Docs/comments updated: none
Changelog
CHANGELOG entry: null
Related issues
Refs: proactive dead-code cleanup (extension counterpart of metamask-mobile#37948)
Manual testing steps
N/A — deletes unreachable code. There is no user-facing behavior to click through.
Screenshots/Recordings
N/A — no UI change
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Import-only cleanup with no runtime or type surface changes beyond satisfying the compiler.
Overview
Removes unused imports flagged by
tsc --noUnusedLocalsin two selector modules, with no logic or export changes.In
ui/selectors/multichain/networks.ts, theinfuraProjectIdimport from shared network constants is dropped; the file still usesCHAIN_ID_TO_NETWORK_IMAGE_URL_MAP, andinfuraProjectIdremains defined and used elsewhere in the repo.In
ui/selectors/subscription/subscription.ts, the unusedProductTypeimport from@metamask/subscription-controlleris removed; subscription selectors still rely onPRODUCT_TYPES,Subscription, and related types.Reviewed by Cursor Bugbot for commit 46b2290. Bugbot is set up for automated code reviews on this repo. Configure here.