Repository navigation
chore(tabs): remove unused BoxBackgroundColor import - #47639
Merged
georgewrmarshall merged 1 commit intoNov 6, 2026
Merged
Conversation
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
georgewrmarshall
temporarily deployed
to
pr-comment
November 5, 2026 09:27 — with
GitHub Actions
Inactive
georgewrmarshall
temporarily deployed
to
pr-comment
November 5, 2026 09:40 — with
GitHub Actions
Inactive
Contributor
Builds ready [87f5669]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)
Bundle Size Diffs
|
|
georgewrmarshall
enabled auto-merge
November 5, 2026 19:22
amandaye0h
approved these changes
Nov 6, 2026
n3ps
approved these changes
Nov 6, 2026
georgewrmarshall
deleted the
cursor/remove-dead-code-tabs-import-20261105
branch
November 6, 2026 18:54
Contributor
|
No release label on PR. Adding release label release-13.58.0 on PR, as PR was added to branch 13.58.0 when release was cut. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Removes the unused
BoxBackgroundColorimport from the shared tabs component. The other design-system imports in that statement (Box,BoxFlexDirection,BoxJustifyContent,twMerge) are still used. Reported bytsc --noUnusedLocals.Owner set: none (no CODEOWNERS match).
ui/components/ui/is a reusable building block, so the 180-day window applies. The import line was last touched on 2025-09-18. The file changed on 2026-10-08 in unrelated lines (the tab layout), not this import.ui/components/ui/tabs/tabs.tsxBoxBackgroundColorimportWhole-repo whole-word search: other
BoxBackgroundColorhits are components that import and apply the prop themselves. Open PRs mention that design-system export in other files; none editui/components/ui/tabs/tabs.tsx. No user-facing behavior change.Checks passed:
yarn lint:tsc, eslint on the touched file, andyarn test:unit --coverage=false ui/components/ui/tabswith no snapshot updates.Docs/comments updated: none
Changelog
CHANGELOG entry: null
Related issues
Refs: proactive dead-code cleanup (extension counterpart of metamask-mobile#37948)
Manual testing steps
N/A — deletes unreachable code. There is no user-facing behavior to click through.
Screenshots/Recordings
N/A — no UI change
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Single-line import removal with no runtime or UI behavior change.
Overview
Removes the unused
BoxBackgroundColorimport from the sharedTabscomponent intabs.tsx. Remaining design-system imports (Box,BoxFlexDirection,BoxJustifyContent,twMerge) are unchanged and still drive layout and styling.This is dead-code cleanup flagged by
tsc --noUnusedLocals; tab behavior, animations, and keyboard handling are untouched.Reviewed by Cursor Bugbot for commit 87f5669. Bugbot is set up for automated code reviews on this repo. Configure here.