Skip to content

chore(tabs): remove unused BoxBackgroundColor import - #47639

Merged
georgewrmarshall merged 1 commit into
mainfrom
cursor/remove-dead-code-tabs-import-20261105
Nov 6, 2026
Merged

georgewrmarshall merged 1 commit into
mainfrom
cursor/remove-dead-code-tabs-import-20261105

Conversation

@georgewrmarshall

@georgewrmarshall georgewrmarshall commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Description

Removes the unused BoxBackgroundColor import from the shared tabs component. The other design-system imports in that statement (Box, BoxFlexDirection, BoxJustifyContent, twMerge) are still used. Reported by tsc --noUnusedLocals.

Owner set: none (no CODEOWNERS match). ui/components/ui/ is a reusable building block, so the 180-day window applies. The import line was last touched on 2025-09-18. The file changed on 2026-10-08 in unrelated lines (the tab layout), not this import.

path removed (file / symbol / class) why dead
ui/components/ui/tabs/tabs.tsx BoxBackgroundColor import unused local

Whole-repo whole-word search: other BoxBackgroundColor hits are components that import and apply the prop themselves. Open PRs mention that design-system export in other files; none edit ui/components/ui/tabs/tabs.tsx. No user-facing behavior change.

Checks passed: yarn lint:tsc, eslint on the touched file, and yarn test:unit --coverage=false ui/components/ui/tabs with no snapshot updates.

Docs/comments updated: none

Changelog

CHANGELOG entry: null

Related issues

Refs: proactive dead-code cleanup (extension counterpart of metamask-mobile#37948)

Manual testing steps

N/A — deletes unreachable code. There is no user-facing behavior to click through.

Screenshots/Recordings

N/A — no UI change

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Single-line import removal with no runtime or UI behavior change.

Overview
Removes the unused BoxBackgroundColor import from the shared Tabs component in tabs.tsx. Remaining design-system imports (Box, BoxFlexDirection, BoxJustifyContent, twMerge) are unchanged and still drive layout and styling.

This is dead-code cleanup flagged by tsc --noUnusedLocals; tab behavior, animations, and keyboard handling are untouched.

Reviewed by Cursor Bugbot for commit 87f5669. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Nov 5, 2026 — with Cursor
@georgewrmarshall georgewrmarshall self-assigned this Nov 5, 2026
@metamask-ci

metamask-ci Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor
Builds ready [87f5669]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42002584693 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -10%
  • ↑ loadNewAccount/cls: +282%
  • ↑ confirmTx/longTaskTotalDuration: +52%
  • ↑ confirmTx/longTaskMaxDuration: +70%
  • ↑ confirmTx/tbt: +87%
  • ↑ confirmTx/lcp: +12%
  • ↑ bridgeUserActions/bridge_load_page: +73%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +29%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +77%
  • ↑ bridgeUserActions/longTaskMaxDuration: +39%
  • ↑ bridgeUserActions/tbt: +144%
  • ↑ bridgeUserActions/total: +16%
  • ↑ bridgeUserActions/inp: +10%
  • ↑ bridgeUserActions/fcp: +10%
  • ↑ bridgeUserActions/cls: +281%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -18%
  • ↓ loadNewAccount/fcp: -48%
  • ↑ loadNewAccount/lcp: +1046%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -50%
  • ↑ confirmTx/lcp: +1061%
  • ↑ bridgeUserActions/bridge_load_page: +100%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +161%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +17%
  • ↑ bridgeUserActions/inp: +135%
  • ↓ bridgeUserActions/fcp: -47%
  • ↑ bridgeUserActions/lcp: +1115%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 bridgeUserActions/INP: p75 256ms
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -15%
  • ↓ startupStandardHome/load: -16%
  • ↓ startupStandardHome/domContentLoaded: -16%
  • ↓ startupStandardHome/domInteractive: -11%
  • ↓ startupStandardHome/firstPaint: -11%
  • ↓ startupStandardHome/backgroundConnect: -20%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↓ startupStandardHome/loadScripts: -16%
  • ↑ startupStandardHome/setupStore: +88%
  • ↓ startupStandardHome/longTaskCount: -29%
  • ↓ startupStandardHome/longTaskTotalDuration: -22%
  • ↓ startupStandardHome/longTaskMaxDuration: -18%
  • ↓ startupStandardHome/tbt: -21%
  • ↓ startupStandardHome/inp: -18%
  • ↓ startupStandardHome/fcp: -16%
  • ↑ startupStandardHome/cls: +400%
  • ↓ startupStandardHome/uiStartup: -40%
  • ↓ startupStandardHome/load: -37%
  • ↓ startupStandardHome/domContentLoaded: -38%
  • ↓ startupStandardHome/domInteractive: -58%
  • ↓ startupStandardHome/backgroundConnect: -30%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -37%
  • ↑ startupStandardHome/setupStore: +46%
  • ↓ startupStandardHome/fcp: -39%
  • ↓ startupStandardHome/lcp: -35%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +35%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +31%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +31%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +19%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -91%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +41%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +22%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +17%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -73%
  • ↓ onboardingNewWallet/longTaskCount: -23%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -49%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -28%
  • ↓ onboardingNewWallet/tbt: -84%
  • ↓ onboardingNewWallet/total: -70%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -61%
  • ↓ dappPageLoad/domContentLoaded: -20%
  • ↓ dappPageLoad/firstPaint: -47%
  • ↓ dappPageLoad/firstContentfulPaint: -47%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.24 MiB +131 Bytes 0.00%
✅ ui 19.34 MiB +68 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +1 Bytes 0.00%
✅ content scripts 3.22 MiB +2 Bytes 0.00%
✅ unzipped 79.65 MiB +207 Bytes 0.00%
✅ zip 23.81 MiB -9 Bytes 0.00%

@sonarqubecloud

sonarqubecloud Bot commented Nov 5, 2026

Copy link
Copy Markdown

@georgewrmarshall
georgewrmarshall added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit 0ebefe9 Nov 6, 2026
148 checks passed
@georgewrmarshall
georgewrmarshall deleted the cursor/remove-dead-code-tabs-import-20261105 branch November 6, 2026 18:54
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 6, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.58.0 on PR, as PR was added to branch 13.58.0 when release was cut.

This branch was previously deployed

1 inactive deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-XS team-design-system All issues relating to design system in Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants