Repository navigation
Conversation
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/perps (1 files, +6 -2)
|
Unik0rnMaggie
approved these changes
Nov 5, 2026
ameliejyc
approved these changes
Nov 5, 2026
Contributor
Builds ready [d164c33]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 3 warn · 🔴 4 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
These tests are very flaky and blocking other work. Skipping until perps team fixes.
Related thread: https://consensys.slack.com/archives/CTQAGKY5V/p1793866704552599?thread_ts=1793866551.482979&cid=CTQAGKY5V
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Test-only change with no production impact; it reduces automated coverage for Perps TP/SL close flows until the skipped specs are re-enabled.
Overview
Temporarily disables the two Perps take-profit and stop-loss E2E scenarios in
perps-tpsl.spec.tsby switching them toit.skip, with comments pointing to issue #47287 and an eslint waiver formocha/no-skipped-tests.The test bodies are unchanged; only execution is turned off so CI is not blocked by flakiness while the specs are fixed.
Reviewed by Cursor Bugbot for commit d164c33. Bugbot is set up for automated code reviews on this repo. Configure here.