Skip to content

test: temporarily skip Perps Take Profit / Stop Loss flaky tests - #47645

Closed
seaona wants to merge 1 commit into
mainfrom
tmp-skipe2e-perps-flaky
Closed

seaona wants to merge 1 commit into
mainfrom
tmp-skipe2e-perps-flaky

Conversation

@seaona

@seaona seaona commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Description

These tests are very flaky and blocking other work. Skipping until perps team fixes.
Related thread: https://consensys.slack.com/archives/CTQAGKY5V/p1793866704552599?thread_ts=1793866551.482979&cid=CTQAGKY5V

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. /

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Test-only change with no production impact; it reduces automated coverage for Perps TP/SL close flows until the skipped specs are re-enabled.

Overview
Temporarily disables the two Perps take-profit and stop-loss E2E scenarios in perps-tpsl.spec.ts by switching them to it.skip, with comments pointing to issue #47287 and an eslint waiver for mocha/no-skipped-tests.

The test bodies are unchanged; only execution is turned off so CI is not blocked by flakiness while the specs are fixed.

Reviewed by Cursor Bugbot for commit d164c33. Bugbot is set up for automated code reviews on this repo. Configure here.

@seaona
seaona requested a review from a team as a code owner November 5, 2026 12:02
@seaona seaona changed the title test: tmporarily skip perps flaky tests test: temporarily skip Perps Take Profit / Stop Loss flaky tests Nov 5, 2026
@metamask-ci metamask-ci Bot added the team-qa QA team label Nov 5, 2026
@metamask-ci

metamask-ci Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/perps (1 files, +6 -2)
  • 📁 test/
    • 📁 e2e/
      • 📁 tests/
        • 📁 perps/
          • 📄 perps-tpsl.spec.ts +6 -2

@metamask-ci

metamask-ci Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor
Builds ready [d164c33]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 3 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42023744926 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -10%
  • ↑ loadNewAccount/lcp: +979%
  • ↑ loadNewAccount/cls: +241%
  • ↑ confirmTx/longTaskTotalDuration: +42%
  • ↑ confirmTx/longTaskMaxDuration: +54%
  • ↑ confirmTx/tbt: +71%
  • ↓ confirmTx/inp: -13%
  • ↑ confirmTx/fcp: +13%
  • ↑ confirmTx/lcp: +1031%
  • ↓ confirmTx/cls: -11%
  • ↑ bridgeUserActions/bridge_load_page: +135%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +36%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +64%
  • ↑ bridgeUserActions/longTaskMaxDuration: +31%
  • ↑ bridgeUserActions/tbt: +61%
  • ↑ bridgeUserActions/total: +19%
  • ↑ bridgeUserActions/fcp: +10%
  • ↑ bridgeUserActions/lcp: +989%
  • ↑ bridgeUserActions/cls: +594%
  • ↑ loadNewAccount/load_new_account: +193%
  • ↑ loadNewAccount/total: +193%
  • ↓ loadNewAccount/inp: -18%
  • ↓ loadNewAccount/fcp: -34%
  • ↑ loadNewAccount/lcp: +1268%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -21%
  • ↓ confirmTx/fcp: -33%
  • ↑ confirmTx/lcp: +1331%
  • ↑ bridgeUserActions/bridge_load_page: +209%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +112%
  • ↑ bridgeUserActions/bridge_search_token: +26%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +59%
  • ↑ bridgeUserActions/inp: +54%
  • ↑ bridgeUserActions/fcp: +17%
  • ↑ bridgeUserActions/lcp: +1284%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +88%
  • ↑ startupStandardHome/load: +125%
  • ↑ startupStandardHome/domContentLoaded: +126%
  • ↑ startupStandardHome/domInteractive: +26%
  • ↓ startupStandardHome/firstPaint: -53%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +124%
  • ↑ startupStandardHome/setupStore: +127%
  • ↑ startupStandardHome/longTaskCount: +79%
  • ↑ startupStandardHome/longTaskTotalDuration: +123%
  • ↑ startupStandardHome/longTaskMaxDuration: +139%
  • ↑ startupStandardHome/tbt: +147%
  • ↓ startupStandardHome/fcp: -49%
  • ↑ startupStandardHome/lcp: +131%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -36%
  • ↓ startupStandardHome/load: -30%
  • ↓ startupStandardHome/domContentLoaded: -32%
  • ↓ startupStandardHome/domInteractive: -51%
  • ↓ startupStandardHome/backgroundConnect: -22%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -31%
  • ↓ startupStandardHome/setupStore: -35%
  • ↓ startupStandardHome/fcp: -36%
  • ↓ startupStandardHome/lcp: -29%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +28%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +42%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +55%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +50%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -73%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -95%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -91%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +13%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +25%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +15%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -80%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -71%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -30%
  • ↓ onboardingNewWallet/tbt: -88%
  • ↓ onboardingNewWallet/total: -75%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -48%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.24 MiB +478 Bytes 0.00%
🚨 ui 19.34 MiB +4.45 KiB +0.02%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +21 Bytes 0.00%
✅ content scripts 3.22 MiB +42 Bytes 0.00%
🚨 unzipped 79.66 MiB +5.7 KiB +0.01%
🚨 zip 23.82 MiB +1.66 KiB +0.01%

@seaona seaona added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Nov 5, 2026
@sonarqubecloud

sonarqubecloud Bot commented Nov 5, 2026

Copy link
Copy Markdown

@seaona seaona closed this Nov 10, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 10, 2026

This branch was previously deployed

1 inactive deployment
pr-comment — d164c33a Deployed Nov 5, 2026 by seaona via Publish prerelease / Publish prerelease #172993
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-XS team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants