Skip to content

feat(analytics): replace Error occured with Error Occurred via trackErrorAsAnalytics - #47657

Merged
gauthierpetetin merged 8 commits into
mainfrom
analytics/replace-error-occured-with-error-occurred
Nov 11, 2026
Merged

gauthierpetetin merged 8 commits into
mainfrom
analytics/replace-error-occured-with-error-occurred

Conversation

@gauthierpetetin

@gauthierpetetin gauthierpetetin commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Description

Replace the Extension Error occured MetaMetrics event with the standardized Error Occurred event from @metamask/analytics-controller, emitted through the new AnalyticsController:trackErrorAsAnalytics action.

Reason: Error occured is a one-off, typo'd Extension event with no category structure aligned with the new analytics system. Core added trackErrorAsAnalytics on AnalyticsController to report caught errors as Error Occurred events with a unique source and a sanitized error_message, bounded by sampling, deduplication, and a per-session cap. Aligning Extension on this event unifies error tracking across MetaMask clients.

Solution:

  • Bump @metamask/analytics-controller to ^4.2.0 (introduces trackErrorAsAnalytics).
  • Delegate AnalyticsController:trackErrorAsAnalytics on the analytics init messenger.
  • Expose a trackErrorAsAnalytics background helper, a MetaMask controller API entry, a UI store action, and a useAnalytics().trackErrorAsAnalytics hook method.
  • Migrate the two Error occured call sites (MetaMetrics data deletion flows) to trackErrorAsAnalytics with unique source values (clear-metametrics-data, delete-metametrics-modal).
  • Remove the obsolete MetaMetricsEventName.ErrorOccured enum entry.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

  1. Make sure SEGMENT_WRITE_KEY targets [MetaMask Extension [Dev]] Segment source
  2. Run the extension from this branch (yarn start).
  3. Opt in to MetaMetrics if not already opted in.
  4. Go to Settings, then Privacy.
  5. Under "Delete MetaMetrics data", trigger a deletion and confirm the success path still works.
  6. Confirm the data deletion request fails (it doesn't work for the dev environment).
  7. Open [MetaMask Extension [Dev]] Segment source's debugger, and confirm an anonymous Error Occurred event is emitted with source set to delete-metametrics-modal and a sanitized error_message.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Analytics-only change with consent gating and no changes to deletion or wallet logic; main risk is mis-tagged error telemetry if consent rules regress.

Overview
Upgrades @metamask/analytics-controller to ^4.3.0 and replaces the legacy Error occured MetaMetrics event with the controller’s Error Occurred flow via trackErrorAsAnalytics.

UI → background path: useAnalytics() exposes trackErrorAsAnalytics, gated like other analytics (skips when opted out; still sends when consent is undecided). The UI store action normalizes errors with getErrorMessage, maps excludeMetaMetricsId to anonymous reporting, adds environment_type, and RPCs AnalyticsController:trackErrorAsAnalytics (failures are swallowed).

Call sites: MetaMetrics data deletion modals (clear-metametrics-data, delete-metametrics-modal) now report failures with distinct source values instead of MetaMetricsEventName.ErrorOccured, which is removed from metametrics.ts.

Tests: Hooks, store action, mocks, and deletion UI tests cover forwarding, opt-out, serialization, and RPC error handling.

Reviewed by Cursor Bugbot for commit dee026c. Bugbot is set up for automated code reviews on this repo. Configure here.

…rrorAsAnalytics

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the size-M label Nov 5, 2026
@metamask-ci metamask-ci Bot added the team-extension-platform Extension Platform team label Nov 5, 2026
@metamask-ci

metamask-ci Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations (1 files, +1 -0)
  • 📁 ui/
    • 📁 pages/
      • 📁 confirmations/
        • 📁 components/
          • 📁 simulation-details/
            • 📄 useSimulationMetrics.test.ts +1 -0

👨‍🔧 @MetaMask/core-extension-ux (2 files, +7 -6)
  • 📁 ui/
    • 📁 pages/
      • 📁 settings/
        • 📁 privacy-tab/
          • 📄 delete-metametrics-data-item.test.tsx +1 -0
          • 📄 delete-metametrics-modal.tsx +6 -6

👨‍🔧 @MetaMask/product-safety (1 files, +5 -1)
  • 📁 ui/
    • 📁 components/
      • 📁 app/
        • 📁 product-safety/
          • 📁 scam-questionnaire/
            • 📄 useScamQuestionnaireMetrics.test.ts +5 -1

@socket-security

socket-security Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​analytics-controller@​4.2.0 ⏵ 4.3.0100 +110010098 +1100

View full report

@metamask-ci

metamask-ci Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor
Builds ready [fa767f5]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42063652548 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -18%
  • ↑ loadNewAccount/lcp: +940%
  • ↑ loadNewAccount/cls: +556%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +54%
  • ↑ confirmTx/longTaskMaxDuration: +53%
  • ↑ confirmTx/tbt: +71%
  • ↓ confirmTx/inp: -21%
  • ↑ confirmTx/lcp: +978%
  • ↓ confirmTx/cls: -12%
  • ↑ bridgeUserActions/bridge_load_page: +136%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +85%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +84%
  • ↑ bridgeUserActions/longTaskMaxDuration: +34%
  • ↑ bridgeUserActions/tbt: +161%
  • ↑ bridgeUserActions/total: +17%
  • ↑ bridgeUserActions/lcp: +943%
  • ↑ bridgeUserActions/cls: +594%
  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -25%
  • ↓ loadNewAccount/fcp: -46%
  • ↑ loadNewAccount/lcp: +1036%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -21%
  • ↓ confirmTx/fcp: -53%
  • ↑ confirmTx/lcp: +1016%
  • ↑ bridgeUserActions/bridge_load_page: +250%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +114%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +29%
  • ↑ bridgeUserActions/inp: +18%
  • ↓ bridgeUserActions/fcp: -52%
  • ↑ bridgeUserActions/lcp: +1028%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.8s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +93%
  • ↑ startupStandardHome/load: +131%
  • ↑ startupStandardHome/domContentLoaded: +132%
  • ↑ startupStandardHome/domInteractive: +27%
  • ↓ startupStandardHome/firstPaint: -53%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +130%
  • ↑ startupStandardHome/setupStore: +140%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +128%
  • ↑ startupStandardHome/longTaskMaxDuration: +138%
  • ↑ startupStandardHome/tbt: +152%
  • ↓ startupStandardHome/fcp: -52%
  • ↑ startupStandardHome/lcp: +113%
  • ↓ startupStandardHome/cls: -72%
  • ↑ startupStandardHome/domInteractive: +38%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/fcp: +43%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -12%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -10%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +11%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +30%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +18%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +12%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -72%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -68%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -24%
  • ↓ onboardingNewWallet/tbt: -81%
  • ↓ onboardingNewWallet/total: -66%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -50%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.25 MiB +1.68 KiB +0.01%
✅ ui 19.39 MiB +257 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
🚨 unzipped 79.72 MiB +1.94 KiB 0.00%
✅ zip 23.83 MiB +919 Bytes 0.00%

@gauthierpetetin

Copy link
Copy Markdown
Contributor Author

@metamaskbot update-policies

@metamask-ci

metamask-ci Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Policies updated.
👀 Please review the diff for suspicious new powers.

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.
🧠 Learn how to read policy diffs: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

👀 lavamoat/webpack/mv2/beta/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes
👀 lavamoat/webpack/mv2/experimental/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes
👀 lavamoat/webpack/mv2/flask/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes
👀 lavamoat/webpack/mv3/beta/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes
👀 lavamoat/webpack/mv3/experimental/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes
👀 lavamoat/webpack/mv3/flask/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes

…enerate LavaMoat policies

Co-authored-by: Cursor <cursoragent@cursor.com>
@metamask-ci

metamask-ci Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor
Builds ready [27f2327]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 2 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42109773115 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +184%
  • ↑ loadNewAccount/total: +184%
  • ↓ loadNewAccount/inp: -18%
  • ↑ loadNewAccount/lcp: +884%
  • ↑ loadNewAccount/cls: +297%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +53%
  • ↑ confirmTx/longTaskMaxDuration: +52%
  • ↑ confirmTx/tbt: +69%
  • ↓ confirmTx/inp: -21%
  • ↑ confirmTx/lcp: +924%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +144%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +54%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +79%
  • ↑ bridgeUserActions/longTaskMaxDuration: +45%
  • ↑ bridgeUserActions/tbt: +148%
  • ↑ bridgeUserActions/total: +22%
  • ↑ bridgeUserActions/lcp: +900%
  • ↑ bridgeUserActions/cls: +611%
  • ↑ loadNewAccount/load_new_account: +180%
  • ↑ loadNewAccount/total: +180%
  • ↓ loadNewAccount/fcp: -71%
  • ↑ loadNewAccount/lcp: +748%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -29%
  • ↓ confirmTx/fcp: -70%
  • ↑ confirmTx/lcp: +833%
  • ↑ bridgeUserActions/bridge_load_page: +132%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +47%
  • ↓ bridgeUserActions/bridge_search_token: -11%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +13%
  • ↑ bridgeUserActions/inp: +113%
  • ↓ bridgeUserActions/fcp: -70%
  • ↑ bridgeUserActions/lcp: +863%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 bridgeUserActions/INP: p75 232ms
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +49%
  • ↑ startupStandardHome/load: +73%
  • ↑ startupStandardHome/domContentLoaded: +74%
  • ↓ startupStandardHome/firstPaint: -50%
  • ↓ startupStandardHome/backgroundConnect: -14%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +73%
  • ↑ startupStandardHome/setupStore: +88%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +70%
  • ↑ startupStandardHome/longTaskMaxDuration: +100%
  • ↑ startupStandardHome/tbt: +86%
  • ↓ startupStandardHome/inp: -18%
  • ↑ startupStandardHome/fcp: +66%
  • ↑ startupStandardHome/lcp: +646%
  • ↓ startupStandardHome/cls: -72%
  • ↑ startupStandardHome/domInteractive: +39%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/fcp: +39%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +13%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -86%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +23%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -79%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -69%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -35%
  • ↓ onboardingNewWallet/tbt: -88%
  • ↓ onboardingNewWallet/total: -75%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -59%
  • ↓ dappPageLoad/domContentLoaded: -16%
  • ↓ dappPageLoad/firstPaint: -42%
  • ↓ dappPageLoad/firstContentfulPaint: -42%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.26 MiB +7.91 KiB +0.05%
🚨 ui 19.4 MiB +4.19 KiB +0.02%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +415 Bytes +0.01%
✅ content scripts 3.23 MiB +830 Bytes +0.02%
🚨 unzipped 79.73 MiB +14.27 KiB +0.02%
🚨 zip 23.85 MiB +24 KiB +0.10%

…tion

Co-authored-by: Cursor <cursoragent@cursor.com>
@gauthierpetetin gauthierpetetin self-assigned this Nov 10, 2026
@metamask-ci

metamask-ci Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor
Builds ready [308541d]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 1 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42792054461 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -40%
  • ↓ loadNewAccount/fcp: -21%
  • ↑ loadNewAccount/lcp: +677%
  • ↑ loadNewAccount/cls: +297%
  • ↑ confirmTx/longTaskMaxDuration: +15%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -22%
  • ↑ confirmTx/lcp: +688%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +16%
  • ↓ bridgeUserActions/longTaskTotalDuration: -20%
  • ↓ bridgeUserActions/longTaskMaxDuration: -27%
  • ↓ bridgeUserActions/tbt: -35%
  • ↓ bridgeUserActions/inp: -19%
  • ↓ bridgeUserActions/fcp: -20%
  • ↑ bridgeUserActions/lcp: +686%
  • ↑ bridgeUserActions/cls: +646%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -18%
  • ↑ loadNewAccount/fcp: +19%
  • ↑ loadNewAccount/lcp: +1278%
  • ↑ confirmTx/confirm_tx: +11%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/total: +11%
  • ↓ confirmTx/inp: -13%
  • ↓ confirmTx/fcp: -42%
  • ↑ confirmTx/lcp: +1300%
  • ↑ bridgeUserActions/bridge_load_page: +206%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +180%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +37%
  • ↑ bridgeUserActions/inp: +187%
  • ↓ bridgeUserActions/fcp: -34%
  • ↑ bridgeUserActions/lcp: +1332%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.1s
  • 🟡 bridgeUserActions/INP: p75 312ms
  • 🟡 bridgeUserActions/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +71%
  • ↑ startupStandardHome/load: +103%
  • ↑ startupStandardHome/domContentLoaded: +104%
  • ↑ startupStandardHome/domInteractive: +18%
  • ↓ startupStandardHome/firstPaint: -38%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +102%
  • ↑ startupStandardHome/setupStore: +108%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +99%
  • ↑ startupStandardHome/longTaskMaxDuration: +123%
  • ↑ startupStandardHome/tbt: +122%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -53%
  • ↑ startupStandardHome/lcp: +111%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/domInteractive: -38%
  • ↑ startupStandardHome/backgroundConnect: +14%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/fcp: -33%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +28%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +31%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +41%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +26%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -93%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -87%
  • ↓ onboardingImportWallet/tbt: -99%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +26%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +13%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -80%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -73%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -49%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.24 MiB +96 Bytes 0.00%
✅ ui 19.44 MiB +467 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB 0 Bytes 0.00%
✅ content scripts 3.22 MiB 0 Bytes 0.00%
✅ unzipped 79.91 MiB +568 Bytes 0.00%
✅ zip 24.01 MiB +225 Bytes 0.00%

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new hook test lacks coverage for consent gating, forwarding without an analytics ID, and isolation of rejected background requests.

1 open issue
What changed in this PR

Migrates MetaMetrics deletion-error reporting to the standardized Error Occurred event through AnalyticsController:trackErrorAsAnalytics.

Changes:

  • Updates @metamask/analytics-controller to ^4.3.0.
  • Adds UI action and hook support, including error serialization, consent checks, and background-request failure handling.
  • Migrates both deletion flows, removes the obsolete event name, and updates tests and mocks.
File Description
yarn.lock Locks analytics-controller to 4.3.0.
ui/​store/​actions.ts Adds error serialization and background forwarding.
ui/​store/​actions.track-error-as-analytics.test.ts Tests error serialization and forwarded properties.
ui/​pages/​settings/​privacy-tab/​delete-metametrics-modal.tsx Migrates privacy-modal error reporting.
ui/​pages/​settings/​privacy-tab/​delete-metametrics-data-item.test.tsx Extends the analytics mock.
ui/​pages/​confirmations/​components/​simulation-details/​useSimulationMetrics.test.ts Updates the hook mock interface.
ui/​hooks/​useAnalytics.ts Exposes consent-gated error reporting with failure isolation.
ui/​hooks/​useAnalytics.test.tsx Tests opted-in error forwarding.
ui/​components/​app/​product-safety/​scam-questionnaire/​useScamQuestionnaireMetrics.test.ts Updates the hook mock interface.
ui/​components/​app/​clear-metametrics-data/​clear-metametrics-data.tsx Migrates legacy deletion-modal error reporting.
ui/​components/​app/​clear-metametrics-data/​clear-metametrics-data.test.tsx Updates deletion-error tracking assertions.
ui/​__mocks__/​useAnalytics.ts Adds the shared error-reporting mock.
shared/​constants/​metametrics.ts Removes the obsolete ErrorOccured event.
package.json Raises the analytics-controller dependency to ^4.3.0.

Review effort: Balanced

Comment thread ui/hooks/useAnalytics.ts Resolved
…re isolation

Co-authored-by: Cursor <cursoragent@cursor.com>
@gauthierpetetin
gauthierpetetin marked this pull request as ready for review November 10, 2026 10:46
@gauthierpetetin
gauthierpetetin requested a review from a team as a code owner November 10, 2026 10:46
@metamask-ci

metamask-ci Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor
Builds ready [631d08d]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 2 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42801712465 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +180%
  • ↑ loadNewAccount/total: +180%
  • ↓ loadNewAccount/inp: -33%
  • ↑ loadNewAccount/lcp: +834%
  • ↑ loadNewAccount/cls: +594%
  • ↑ confirmTx/longTaskTotalDuration: +14%
  • ↑ confirmTx/longTaskMaxDuration: +15%
  • ↑ confirmTx/tbt: +17%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -18%
  • ↑ confirmTx/lcp: +720%
  • ↓ bridgeUserActions/longTaskTotalDuration: -23%
  • ↓ bridgeUserActions/longTaskMaxDuration: -25%
  • ↓ bridgeUserActions/tbt: -42%
  • ↓ bridgeUserActions/inp: -26%
  • ↑ bridgeUserActions/lcp: +800%
  • ↑ bridgeUserActions/cls: +632%
  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -10%
  • ↑ loadNewAccount/fcp: +17%
  • ↑ loadNewAccount/lcp: +1252%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -21%
  • ↓ confirmTx/fcp: -36%
  • ↑ confirmTx/lcp: +1283%
  • ↑ bridgeUserActions/bridge_load_page: +251%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +124%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +55%
  • ↑ bridgeUserActions/inp: +69%
  • ↑ bridgeUserActions/fcp: +17%
  • ↑ bridgeUserActions/lcp: +1262%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +91%
  • ↑ startupStandardHome/load: +126%
  • ↑ startupStandardHome/domContentLoaded: +127%
  • ↑ startupStandardHome/domInteractive: +29%
  • ↓ startupStandardHome/firstPaint: -53%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +126%
  • ↑ startupStandardHome/setupStore: +140%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +123%
  • ↑ startupStandardHome/longTaskMaxDuration: +129%
  • ↑ startupStandardHome/tbt: +147%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -49%
  • ↑ startupStandardHome/lcp: +131%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/domInteractive: -34%
  • ↑ startupStandardHome/backgroundConnect: +11%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/fcp: -28%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +14%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +43%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +37%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -94%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -89%
  • ↓ onboardingImportWallet/tbt: -99%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -12%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -15%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -13%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -12%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -76%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -73%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -52%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.24 MiB +210 Bytes 0.00%
🚨 ui 19.44 MiB +1.2 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB 0 Bytes 0.00%
✅ content scripts 3.22 MiB 0 Bytes 0.00%
🚨 unzipped 79.91 MiB +1.67 KiB 0.00%
✅ zip 24.01 MiB +467 Bytes 0.00%

Comment thread ui/hooks/useAnalytics.ts Outdated
Comment on lines +97 to +99
} catch {
// Swallow background RPC failures. Error reporting must not break UI.
}

@MajorLift MajorLift Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to move this try-catch block into the action definition if it's going to be required in every ui-side call site?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, it's now updated in this commit: 3ed067b

…e store action

Co-authored-by: Cursor <cursoragent@cursor.com>
@metamask-ci

metamask-ci Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor
Builds ready [3ed067b]
⚡ Performance Benchmarks (Total: 🟢 10 pass · 🟡 1 warn · 🔴 2 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42907217608 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -40%
  • ↓ loadNewAccount/fcp: -15%
  • ↑ loadNewAccount/lcp: +732%
  • ↑ loadNewAccount/cls: +294%
  • ↑ confirmTx/longTaskMaxDuration: +25%
  • ↑ confirmTx/tbt: +16%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -17%
  • ↑ confirmTx/lcp: +735%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +44%
  • ↓ bridgeUserActions/longTaskTotalDuration: -18%
  • ↓ bridgeUserActions/longTaskMaxDuration: -13%
  • ↓ bridgeUserActions/tbt: -30%
  • ↓ bridgeUserActions/inp: -19%
  • ↓ bridgeUserActions/fcp: -18%
  • ↑ bridgeUserActions/lcp: +713%
  • ↑ bridgeUserActions/cls: +506%
  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -40%
  • ↑ loadNewAccount/lcp: +974%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -29%
  • ↓ confirmTx/fcp: -47%
  • ↑ confirmTx/lcp: +1030%
  • ↑ bridgeUserActions/bridge_load_page: +141%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +113%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +44%
  • ↑ bridgeUserActions/inp: +25%
  • ↓ bridgeUserActions/fcp: -11%
  • ↑ bridgeUserActions/lcp: +1022%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +89%
  • ↑ startupStandardHome/load: +124%
  • ↑ startupStandardHome/domContentLoaded: +125%
  • ↑ startupStandardHome/domInteractive: +27%
  • ↓ startupStandardHome/firstPaint: -55%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +123%
  • ↑ startupStandardHome/setupStore: +114%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +121%
  • ↑ startupStandardHome/longTaskMaxDuration: +134%
  • ↑ startupStandardHome/tbt: +145%
  • ↓ startupStandardHome/fcp: -54%
  • ↑ startupStandardHome/lcp: +106%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -18%
  • ↓ startupStandardHome/load: -10%
  • ↓ startupStandardHome/domContentLoaded: -13%
  • ↑ startupStandardHome/domInteractive: +36%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -11%
  • ↓ startupStandardHome/setupStore: -19%
  • ↑ startupStandardHome/fcp: +39%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -13%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +15%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +42%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +20%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -72%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -74%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -37%
  • ↓ onboardingNewWallet/tbt: -97%
  • ↓ onboardingNewWallet/total: -68%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -61%
  • ↓ dappPageLoad/domContentLoaded: -20%
  • ↓ dappPageLoad/firstPaint: -47%
  • ↓ dappPageLoad/firstContentfulPaint: -47%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.21 MiB -22.95 KiB -0.15%
🚨 ui 19.48 MiB +36.65 KiB +0.18%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB -180 Bytes 0.00%
✅ content scripts 3.22 MiB -360 Bytes -0.01%
✅ unzipped 79.9 MiB -11.28 KiB -0.01%
🚨 zip 24.01 MiB +1.25 KiB +0.01%

Co-authored-by: Cursor <cursoragent@cursor.com>
@metamask-ci

metamask-ci Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor
Builds ready [dee026c]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42974115672 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +187%
  • ↑ loadNewAccount/total: +187%
  • ↓ loadNewAccount/inp: -18%
  • ↑ loadNewAccount/lcp: +927%
  • ↑ loadNewAccount/cls: +596%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +66%
  • ↑ confirmTx/longTaskMaxDuration: +56%
  • ↑ confirmTx/tbt: +85%
  • ↓ confirmTx/inp: -13%
  • ↑ confirmTx/lcp: +973%
  • ↑ bridgeUserActions/bridge_load_page: +147%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +27%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +125%
  • ↑ bridgeUserActions/longTaskMaxDuration: +55%
  • ↑ bridgeUserActions/tbt: +256%
  • ↑ bridgeUserActions/total: +21%
  • ↑ bridgeUserActions/inp: +47%
  • ↑ bridgeUserActions/lcp: +952%
  • ↑ bridgeUserActions/cls: +634%
  • ↑ loadNewAccount/load_new_account: +186%
  • ↑ loadNewAccount/total: +186%
  • ↑ loadNewAccount/inp: +139%
  • ↓ loadNewAccount/fcp: -53%
  • ↑ loadNewAccount/lcp: +974%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -29%
  • ↓ confirmTx/fcp: -54%
  • ↑ confirmTx/lcp: +991%
  • ↑ bridgeUserActions/bridge_load_page: +131%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +115%
  • ↓ bridgeUserActions/bridge_search_token: -11%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +22%
  • ↑ bridgeUserActions/inp: +25%
  • ↓ bridgeUserActions/fcp: -64%
  • ↑ bridgeUserActions/lcp: +985%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.8s
  • 🟡 loadNewAccount/INP: p75 256ms
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +44%
  • ↑ startupStandardHome/load: +68%
  • ↑ startupStandardHome/domContentLoaded: +69%
  • ↓ startupStandardHome/firstPaint: -53%
  • ↓ startupStandardHome/backgroundConnect: -18%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +67%
  • ↑ startupStandardHome/setupStore: +82%
  • ↑ startupStandardHome/longTaskTotalDuration: +65%
  • ↑ startupStandardHome/longTaskMaxDuration: +79%
  • ↑ startupStandardHome/tbt: +80%
  • ↓ startupStandardHome/inp: -24%
  • ↓ startupStandardHome/fcp: -60%
  • ↑ startupStandardHome/lcp: +81%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -23%
  • ↓ startupStandardHome/load: -17%
  • ↓ startupStandardHome/domContentLoaded: -19%
  • ↓ startupStandardHome/domInteractive: -43%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -17%
  • ↓ startupStandardHome/setupStore: -24%
  • ↓ startupStandardHome/fcp: -34%
  • ↓ startupStandardHome/lcp: -15%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -15%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -24%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -12%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -11%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -77%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -74%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -49%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.21 MiB -22.95 KiB -0.15%
🚨 ui 19.48 MiB +36.64 KiB +0.18%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB -184 Bytes 0.00%
✅ content scripts 3.22 MiB -360 Bytes -0.01%
✅ unzipped 79.9 MiB -11.62 KiB -0.01%
🚨 zip 24.01 MiB +1.19 KiB 0.00%

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Nov 11, 2026
@gauthierpetetin
gauthierpetetin added this pull request to the merge queue Nov 11, 2026
Merged via the queue into main with commit 8190582 Nov 11, 2026
139 of 140 checks passed
@gauthierpetetin
gauthierpetetin deleted the analytics/replace-error-occured-with-error-occurred branch November 11, 2026 19:45
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 11, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026

This branch was previously deployed

1 inactive deployment
pr-comment — dee026ce Deployed Nov 11, 2026 by gauthierpetetin via Publish prerelease / Publish prerelease #173961
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-M team-extension-platform Extension Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants