Repository navigation
chore(multichain): remove unused NFTInput component and asset-picker-amount styles - #47673
Merged
georgewrmarshall merged 1 commit intoNov 6, 2026
Conversation
…amount styles Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
georgewrmarshall
temporarily deployed
to
pr-comment
November 5, 2026 20:34 — with
GitHub Actions
Inactive
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (8 files, +0 -246)
|
georgewrmarshall
temporarily deployed
to
pr-comment
November 5, 2026 20:49 — with
GitHub Actions
Inactive
Contributor
Builds ready [8e88136]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 2 warn · 🔴 2 fail)
Bundle Size Diffs [🚀 Bundle size reduced!]
|
|
georgewrmarshall
marked this pull request as ready for review
November 5, 2026 23:14
georgewrmarshall
temporarily deployed
to
pr-comment
November 5, 2026 23:14 — with
GitHub Actions
Inactive
georgewrmarshall
enabled auto-merge
November 5, 2026 23:14
n3ps
approved these changes
Nov 6, 2026
AndyMBridges
approved these changes
Nov 6, 2026
georgewrmarshall
deleted the
cursor/remove-dead-code-asset-picker-amount-20261105-7b9e
branch
November 6, 2026 16:33
Contributor
|
No release label on PR. Adding release label release-13.58.0 on PR, as PR was added to branch 13.58.0 when release was cut. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Removes the unused
NFTInputcomponent (with its unit test and snapshot), the unusedasset-picker-amountbarrel and constants files, and theasset-picker-amountstylesheet, none of which production code can reach. Owner set:@MetaMask/core-extension-ux.AssetPickerAmountitself was removed earlier. What remained of the folder root was a barrel nobody imports, a constant nobody imports (currency-input.jshas its own localLARGE_SYMBOL_LENGTH), anNFTInputcomponent used only by its own test, and a stylesheet whose classes (asset-picker-amount,__balance,__input,__input-nft,__input__swap,__max-clear) are no longer applied by any component, test, snapshot, story, or e2e selector.asset-picker-modal/is untouched.ui/components/multichain/asset-picker-amount/nft-input/nft-input.tsxNFTInput)ui/components/multichain/asset-picker-amount/nft-input/nft-input.test.tsxNFTInputui/components/multichain/asset-picker-amount/nft-input/__snapshots__/nft-input.test.tsx.snapNFTInputui/components/multichain/asset-picker-amount/nft-input/index.tsui/components/multichain/asset-picker-amount/index.tsui/components/multichain/asset-picker-amount/constants.tsxLARGE_SYMBOL_LENGTH)ui/components/multichain/asset-picker-amount/index.scssui/components/multichain/multichain-components.scss@import 'asset-picker-amount'index.scssNo user-facing behavior change.
Checks:
yarn lint:tsc,yarn test:unit --coverage=false ui/components/multichain/asset-picker-amount(no snapshot updates),yarn lint:styles. ESLint had no remaining changed JS/TS files to lint.Docs/comments updated: none
Changelog
CHANGELOG entry: null
Related issues
Refs: proactive dead-code cleanup (extension counterpart of metamask-mobile#37948)
Manual testing steps
N/A — deletes unreachable code. There is no user-facing behavior to click through.
Screenshots/Recordings
N/A — no UI change
Before
N/A — no UI change
After
N/A — no UI change
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Deletes unused files and a stylesheet import with no remaining references in production code.
Overview
Removes leftover asset-picker-amount folder code after the main
AssetPickerAmountUI was deleted earlier: the unused root barrel,LARGE_SYMBOL_LENGTHconstant, and theindex.scssrules that no component still applies.Also deletes NFTInput and its unit test/snapshot/barrel, which were only referenced by that test.
asset-picker-modal/stays in place;multichain-components.scssdrops the@import 'asset-picker-amount'line while still importing the modal styles.No intended user-facing or runtime behavior change—unreachable code cleanup only.
Reviewed by Cursor Bugbot for commit 8e88136. Bugbot is set up for automated code reviews on this repo. Configure here.