Skip to content

chore(multichain): remove unused NFTInput component and asset-picker-amount styles - #47673

Merged
georgewrmarshall merged 1 commit into
mainfrom
cursor/remove-dead-code-asset-picker-amount-20261105-7b9e
Nov 6, 2026
Merged

georgewrmarshall merged 1 commit into
mainfrom
cursor/remove-dead-code-asset-picker-amount-20261105-7b9e

Conversation

@georgewrmarshall

@georgewrmarshall georgewrmarshall commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Description

Removes the unused NFTInput component (with its unit test and snapshot), the unused asset-picker-amount barrel and constants files, and the asset-picker-amount stylesheet, none of which production code can reach. Owner set: @MetaMask/core-extension-ux.

AssetPickerAmount itself was removed earlier. What remained of the folder root was a barrel nobody imports, a constant nobody imports (currency-input.js has its own local LARGE_SYMBOL_LENGTH), an NFTInput component used only by its own test, and a stylesheet whose classes (asset-picker-amount, __balance, __input, __input-nft, __input__swap, __max-clear) are no longer applied by any component, test, snapshot, story, or e2e selector. asset-picker-modal/ is untouched.

path removed why dead
ui/components/multichain/asset-picker-amount/nft-input/nft-input.tsx file (NFTInput) only own test
ui/components/multichain/asset-picker-amount/nft-input/nft-input.test.tsx file cascade from NFTInput
ui/components/multichain/asset-picker-amount/nft-input/__snapshots__/nft-input.test.tsx.snap file cascade from NFTInput
ui/components/multichain/asset-picker-amount/nft-input/index.ts file unused barrel
ui/components/multichain/asset-picker-amount/index.ts file unused barrel
ui/components/multichain/asset-picker-amount/constants.tsx file (LARGE_SYMBOL_LENGTH) zero refs
ui/components/multichain/asset-picker-amount/index.scss file (6 classes) unused class selectors
ui/components/multichain/multichain-components.scss @import 'asset-picker-amount' cascade from index.scss

No user-facing behavior change.

Checks: yarn lint:tsc, yarn test:unit --coverage=false ui/components/multichain/asset-picker-amount (no snapshot updates), yarn lint:styles. ESLint had no remaining changed JS/TS files to lint.

Docs/comments updated: none

Changelog

CHANGELOG entry: null

Related issues

Refs: proactive dead-code cleanup (extension counterpart of metamask-mobile#37948)

Manual testing steps

N/A — deletes unreachable code. There is no user-facing behavior to click through.

Screenshots/Recordings

N/A — no UI change

Before

N/A — no UI change

After

N/A — no UI change

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Deletes unused files and a stylesheet import with no remaining references in production code.

Overview
Removes leftover asset-picker-amount folder code after the main AssetPickerAmount UI was deleted earlier: the unused root barrel, LARGE_SYMBOL_LENGTH constant, and the index.scss rules that no component still applies.

Also deletes NFTInput and its unit test/snapshot/barrel, which were only referenced by that test. asset-picker-modal/ stays in place; multichain-components.scss drops the @import 'asset-picker-amount' line while still importing the modal styles.

No intended user-facing or runtime behavior change—unreachable code cleanup only.

Reviewed by Cursor Bugbot for commit 8e88136. Bugbot is set up for automated code reviews on this repo. Configure here.

…amount styles

Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
@github-actions github-actions Bot added the size-M label Nov 5, 2026
@georgewrmarshall georgewrmarshall added team-design-system All issues relating to design system in Extension no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed and removed size-M labels Nov 5, 2026 — with Cursor
@georgewrmarshall georgewrmarshall self-assigned this Nov 5, 2026
@metamask-ci

metamask-ci Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (8 files, +0 -246)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 asset-picker-amount/
          • 📁 nft-input/
            • 📁 __snapshots__/
              • 📄 nft-input.test.tsx.snap +0 -31
              • 📄 index.ts +0 -1
              • 📄 nft-input.test.tsx +0 -67
              • 📄 nft-input.tsx +0 -42
            • 📄 constants.tsx +0 -1
            • 📄 index.scss +0 -101
            • 📄 index.ts +0 -2
          • 📄 multichain-components.scss +0 -1

@metamask-ci

metamask-ci Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor
Builds ready [8e88136]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 2 warn · 🔴 2 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42104595117 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -40%
  • ↓ loadNewAccount/fcp: -11%
  • ↑ loadNewAccount/lcp: +777%
  • ↑ loadNewAccount/cls: +630%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +20%
  • ↑ confirmTx/longTaskMaxDuration: +19%
  • ↑ confirmTx/tbt: +24%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -19%
  • ↑ confirmTx/lcp: +716%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +16%
  • ↓ bridgeUserActions/longTaskTotalDuration: -17%
  • ↓ bridgeUserActions/longTaskMaxDuration: -18%
  • ↓ bridgeUserActions/tbt: -28%
  • ↓ bridgeUserActions/inp: -26%
  • ↓ bridgeUserActions/fcp: -17%
  • ↑ bridgeUserActions/lcp: +718%
  • ↑ bridgeUserActions/cls: +636%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↑ loadNewAccount/inp: +213%
  • ↓ loadNewAccount/fcp: -37%
  • ↑ loadNewAccount/lcp: +1246%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/fcp: -33%
  • ↑ confirmTx/lcp: +1288%
  • ↑ bridgeUserActions/bridge_load_page: +246%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +189%
  • ↑ bridgeUserActions/bridge_search_token: +25%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +54%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -38%
  • ↑ bridgeUserActions/lcp: +1260%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/INP: p75 336ms
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +86%
  • ↑ startupStandardHome/load: +121%
  • ↑ startupStandardHome/domContentLoaded: +122%
  • ↑ startupStandardHome/domInteractive: +26%
  • ↓ startupStandardHome/firstPaint: -55%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +120%
  • ↑ startupStandardHome/setupStore: +134%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +118%
  • ↑ startupStandardHome/longTaskMaxDuration: +129%
  • ↑ startupStandardHome/tbt: +141%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -51%
  • ↑ startupStandardHome/lcp: +121%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -29%
  • ↓ startupStandardHome/load: -23%
  • ↓ startupStandardHome/domContentLoaded: -25%
  • ↓ startupStandardHome/domInteractive: -51%
  • ↓ startupStandardHome/backgroundConnect: -16%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -24%
  • ↓ startupStandardHome/setupStore: -30%
  • ↓ startupStandardHome/fcp: -34%
  • ↓ startupStandardHome/lcp: -22%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +39%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -15%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +17%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +47%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +20%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -72%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -70%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -35%
  • ↓ onboardingNewWallet/tbt: -88%
  • ↓ onboardingNewWallet/total: -68%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -60%
  • ↓ dappPageLoad/domContentLoaded: -18%
  • ↓ dappPageLoad/firstPaint: -42%
  • ↓ dappPageLoad/firstContentfulPaint: -42%
Bundle Size Diffs [🚀 Bundle size reduced!]
Status Bundle Total Diff Change
✅ background 15.26 MiB +116 Bytes 0.00%
✅ ui 19.4 MiB -3.94 KiB -0.02%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB -14 Bytes 0.00%
✅ content scripts 3.23 MiB -28 Bytes 0.00%
✅ unzipped 79.73 MiB -6.07 KiB -0.01%
✅ zip 23.85 MiB -1.56 KiB -0.01%

@sonarqubecloud

sonarqubecloud Bot commented Nov 5, 2026

Copy link
Copy Markdown

@georgewrmarshall
georgewrmarshall marked this pull request as ready for review November 5, 2026 23:14
@georgewrmarshall
georgewrmarshall requested a review from a team as a code owner November 5, 2026 23:14
@georgewrmarshall
georgewrmarshall added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit 79b3eb9 Nov 6, 2026
269 of 275 checks passed
@georgewrmarshall
georgewrmarshall deleted the cursor/remove-dead-code-asset-picker-amount-20261105-7b9e branch November 6, 2026 16:33
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 6, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.58.0 on PR, as PR was added to branch 13.58.0 when release was cut.

This branch was previously deployed

1 inactive deployment
pr-comment — 8e881365 Deployed Nov 5, 2026 by georgewrmarshall via identify-codeowners #88860
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-13.58.0 Issue or pull request that will be included in release 13.58.0 team-design-system All issues relating to design system in Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants