Repository navigation
chore(multichain): remove unused PermissionsHeader, useNewRPC and barrel files - #47674
Merged
georgewrmarshall merged 1 commit intoNov 6, 2026
Conversation
…rel files Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
georgewrmarshall
temporarily deployed
to
pr-comment
November 5, 2026 20:34 — with
GitHub Actions
Inactive
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (5 files, +0 -126)
|
georgewrmarshall
temporarily deployed
to
pr-comment
November 5, 2026 20:50 — with
GitHub Actions
Inactive
Contributor
Builds ready [92634ed]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 2 warn · 🔴 3 fail)
Bundle Size Diffs [🚀 Bundle size reduced!]
|
|
georgewrmarshall
marked this pull request as ready for review
November 5, 2026 23:15
georgewrmarshall
temporarily deployed
to
pr-comment
November 5, 2026 23:15 — with
GitHub Actions
Inactive
georgewrmarshall
enabled auto-merge
November 5, 2026 23:15
n3ps
approved these changes
Nov 6, 2026
AndyMBridges
approved these changes
Nov 6, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 6, 2026
georgewrmarshall
deleted the
cursor/remove-dead-code-multichain-unused-files-20261105-7b9e
branch
November 6, 2026 18:34
Contributor
|
No release label on PR. Adding release label release-13.58.0 on PR, as PR was added to branch 13.58.0 when release was cut. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Removes five
@MetaMask/core-extension-uxfiles that nothing in the repo imports: thePermissionsHeadercomponent, theuseNewRPChook, and three barrelindex.tsfiles whose components are imported directly from their own modules. Owner set:@MetaMask/core-extension-ux.ui/components/multichain/permissions-header/permissions-header.tsxPermissionsHeader)ui/components/multichain/network-manager/hooks/useNewRPC.tsuseNewRPC)ui/components/multichain/global-menu/index.tsui/components/multichain/funding-method-modal/index.tsui/pages/settings/backup-and-sync-tab/index.tsGlobalMenuList,FundingMethodModal, and the backup and sync settings tab are still live; callers import them fromglobal-menu-list,funding-method-modal, andbackup-and-sync-tabdirectly. ThePermissionsHeaderfile uses no locale key that isn't used elsewhere.No user-facing behavior change.
Checks:
yarn lint:tsc,yarn test:unit --coverage=falseon the touched directories (no snapshot updates). ESLint had no remaining changed JS/TS files to lint.Docs/comments updated: none
Changelog
CHANGELOG entry: null
Related issues
Refs: proactive dead-code cleanup (extension counterpart of metamask-mobile#37948)
Manual testing steps
N/A — deletes unreachable code. There is no user-facing behavior to click through.
Screenshots/Recordings
N/A — no UI change
Before
N/A — no UI change
After
N/A — no UI change
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Deletes unreachable code only; live features remain wired through direct imports with no functional changes.
Overview
Removes dead multichain UI code with no import references in the extension: the
PermissionsHeadercomponent, theuseNewRPCnetwork-form hook, and three unusedindex.tsbarrel re-exports (funding-method-modal,global-menu,settings/backup-and-sync-tab).FundingMethodModal,GlobalMenuList, and the backup-and-sync settings tab stay in place; existing callers already import them from their concrete module files rather than these barrels. No user-facing behavior change—cleanup only.Reviewed by Cursor Bugbot for commit 92634ed. Bugbot is set up for automated code reviews on this repo. Configure here.