Repository navigation
chore(multichain): remove unused carousel, product tour and asset picker modal class selectors - #47677
Merged
georgewrmarshall merged 1 commit intoNov 6, 2026
Conversation
…ker modal class selectors Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
georgewrmarshall
temporarily deployed
to
pr-comment
November 5, 2026 20:34 — with
GitHub Actions
Inactive
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (3 files, +0 -73)
|
georgewrmarshall
temporarily deployed
to
pr-comment
November 5, 2026 20:50 — with
GitHub Actions
Inactive
Contributor
Builds ready [87a3b56]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 2 warn · 🔴 3 fail)
Bundle Size Diffs [🚀 Bundle size reduced!]
|
|
georgewrmarshall
marked this pull request as ready for review
November 5, 2026 23:15
georgewrmarshall
temporarily deployed
to
pr-comment
November 5, 2026 23:15 — with
GitHub Actions
Inactive
georgewrmarshall
enabled auto-merge
November 5, 2026 23:15
n3ps
approved these changes
Nov 6, 2026
AndyMBridges
approved these changes
Nov 6, 2026
georgewrmarshall
deleted the
cursor/remove-dead-code-multichain-class-selectors-20261105-7b9e
branch
November 6, 2026 16:02
Contributor
|
No release label on PR. Adding release label release-13.58.0 on PR, as PR was added to branch 13.58.0 when release was cut. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Removes unused class selectors from three
ui/components/multichainstylesheets. Owner set:@MetaMask/core-extension-ux.No component, HTML file, test, snapshot, story, or e2e selector applies these classes, and no stylesheet
@extends them. The carousel'sCSSTransitions use only thecardandnext-cardprefixes, so nothing generatesempty-state-exit*.mm-carouselis not rendered by this repo or by any@metamask/*dependency. Themodal-tab__wrapperrule in the asset picker modal is still applied and is kept.ui/components/multichain/carousel/index.scss.empty-state-exit,.empty-state-exit-activeui/components/multichain/carousel/index.scss.mm-carousel,.mm-carousel--single-slideui/components/multichain/product-tour-popover/index.scss.multichain-product-tour-menu__permissions-page-tour,__buttonui/components/multichain/asset-picker-amount/asset-picker-modal/index.scss.asset-picker-modal__autodetectui/components/multichain/asset-picker-amount/asset-picker-modal/index.scss.asset-picker-modal .modal-tab__main-view,__loading,__fetchingNo user-facing behavior change.
Checks:
yarn lint:styles, Sass compile of each file,yarn test:unit --coverage=falseon the three component directories (no snapshot updates). No JS/TS changed, soyarn lint:tscand ESLint were not needed.Docs/comments updated: none
Changelog
CHANGELOG entry: null
Related issues
Refs: proactive dead-code cleanup (extension counterpart of metamask-mobile#37948)
Manual testing steps
N/A — deletes unreachable code. There is no user-facing behavior to click through.
Screenshots/Recordings
N/A — no UI change
Before
N/A — no UI change
After
N/A — no UI change
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Stylesheet-only deletion of unreachable selectors; no logic, routing, or user-facing behavior changes.
Overview
Removes dead SCSS from three multichain UI stylesheets with no JS/TS or markup changes, so runtime behavior and layout for still-used rules (e.g.
modal-tab__wrapperin the asset picker modal) stay the same.In asset-picker-modal, drops
asset-picker-modal__autodetectand unused.modal-tabblocks (__main-view,__loading,__fetching). In carousel, removes legacymm-carouselheight rules and unusedempty-state-exit*transition classes that nothing in the repo applies. In product-tour-popover, removes permissions-page positioning overrides and__buttonhover/active styles that no component references.Reviewed by Cursor Bugbot for commit 87a3b56. Bugbot is set up for automated code reviews on this repo. Configure here.