Skip to content

chore(multichain): remove unused carousel, product tour and asset picker modal class selectors - #47677

Merged
georgewrmarshall merged 1 commit into
mainfrom
cursor/remove-dead-code-multichain-class-selectors-20261105-7b9e
Nov 6, 2026
Merged

georgewrmarshall merged 1 commit into
mainfrom
cursor/remove-dead-code-multichain-class-selectors-20261105-7b9e

Conversation

@georgewrmarshall

@georgewrmarshall georgewrmarshall commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Description

Removes unused class selectors from three ui/components/multichain stylesheets. Owner set: @MetaMask/core-extension-ux.

No component, HTML file, test, snapshot, story, or e2e selector applies these classes, and no stylesheet @extends them. The carousel's CSSTransitions use only the card and next-card prefixes, so nothing generates empty-state-exit*. mm-carousel is not rendered by this repo or by any @metamask/* dependency. The modal-tab__wrapper rule in the asset picker modal is still applied and is kept.

path removed why dead
ui/components/multichain/carousel/index.scss .empty-state-exit, .empty-state-exit-active unused class selector (no matching transition prefix)
ui/components/multichain/carousel/index.scss .mm-carousel, .mm-carousel--single-slide unused class selector
ui/components/multichain/product-tour-popover/index.scss .multichain-product-tour-menu__permissions-page-tour, __button unused class selector
ui/components/multichain/asset-picker-amount/asset-picker-modal/index.scss .asset-picker-modal__autodetect unused class selector
ui/components/multichain/asset-picker-amount/asset-picker-modal/index.scss .asset-picker-modal .modal-tab__main-view, __loading, __fetching unused class selector

No user-facing behavior change.

Checks: yarn lint:styles, Sass compile of each file, yarn test:unit --coverage=false on the three component directories (no snapshot updates). No JS/TS changed, so yarn lint:tsc and ESLint were not needed.

Docs/comments updated: none

Changelog

CHANGELOG entry: null

Related issues

Refs: proactive dead-code cleanup (extension counterpart of metamask-mobile#37948)

Manual testing steps

N/A — deletes unreachable code. There is no user-facing behavior to click through.

Screenshots/Recordings

N/A — no UI change

Before

N/A — no UI change

After

N/A — no UI change

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Stylesheet-only deletion of unreachable selectors; no logic, routing, or user-facing behavior changes.

Overview
Removes dead SCSS from three multichain UI stylesheets with no JS/TS or markup changes, so runtime behavior and layout for still-used rules (e.g. modal-tab__wrapper in the asset picker modal) stay the same.

In asset-picker-modal, drops asset-picker-modal__autodetect and unused .modal-tab blocks (__main-view, __loading, __fetching). In carousel, removes legacy mm-carousel height rules and unused empty-state-exit* transition classes that nothing in the repo applies. In product-tour-popover, removes permissions-page positioning overrides and __button hover/active styles that no component references.

Reviewed by Cursor Bugbot for commit 87a3b56. Bugbot is set up for automated code reviews on this repo. Configure here.

…ker modal class selectors

Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
@github-actions github-actions Bot added the size-S label Nov 5, 2026
@georgewrmarshall georgewrmarshall added team-design-system All issues relating to design system in Extension no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed and removed size-S labels Nov 5, 2026 — with Cursor
@georgewrmarshall georgewrmarshall self-assigned this Nov 5, 2026
@metamask-ci

metamask-ci Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (3 files, +0 -73)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 asset-picker-amount/
          • 📁 asset-picker-modal/
            • 📄 index.scss +0 -29
        • 📁 carousel/
          • 📄 index.scss +0 -28
        • 📁 product-tour-popover/
          • 📄 index.scss +0 -16

@metamask-ci

metamask-ci Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor
Builds ready [87a3b56]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 2 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42104599647 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +180%
  • ↑ loadNewAccount/total: +180%
  • ↓ loadNewAccount/inp: -55%
  • ↓ loadNewAccount/fcp: -32%
  • ↑ loadNewAccount/lcp: +564%
  • ↑ loadNewAccount/cls: +294%
  • ↓ confirmTx/longTaskTotalDuration: -13%
  • ↓ confirmTx/longTaskMaxDuration: -10%
  • ↓ confirmTx/tbt: -20%
  • ↓ confirmTx/inp: -52%
  • ↓ confirmTx/fcp: -35%
  • ↑ confirmTx/lcp: +550%
  • ↓ confirmTx/cls: -14%
  • ↓ bridgeUserActions/bridge_load_asset_picker: -22%
  • ↓ bridgeUserActions/longTaskTotalDuration: -33%
  • ↓ bridgeUserActions/longTaskMaxDuration: -22%
  • ↓ bridgeUserActions/tbt: -45%
  • ↓ bridgeUserActions/inp: -34%
  • ↓ bridgeUserActions/fcp: -35%
  • ↑ bridgeUserActions/lcp: +538%
  • ↑ bridgeUserActions/cls: +636%
  • ↑ loadNewAccount/load_new_account: +184%
  • ↑ loadNewAccount/total: +184%
  • ↓ loadNewAccount/fcp: -32%
  • ↑ loadNewAccount/lcp: +1317%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -13%
  • ↑ confirmTx/fcp: +24%
  • ↑ confirmTx/lcp: +1327%
  • ↑ bridgeUserActions/bridge_load_page: +230%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +163%
  • ↑ bridgeUserActions/bridge_search_token: +19%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +59%
  • ↑ bridgeUserActions/inp: +62%
  • ↓ bridgeUserActions/fcp: -39%
  • ↑ bridgeUserActions/lcp: +1280%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 confirmTx/FCP: p75 2.1s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +20%
  • ↑ startupStandardHome/load: +40%
  • ↑ startupStandardHome/domContentLoaded: +40%
  • ↓ startupStandardHome/domInteractive: -13%
  • ↓ startupStandardHome/firstPaint: -45%
  • ↓ startupStandardHome/backgroundConnect: -24%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -64%
  • ↑ startupStandardHome/loadScripts: +39%
  • ↑ startupStandardHome/setupStore: +49%
  • ↑ startupStandardHome/longTaskTotalDuration: +35%
  • ↑ startupStandardHome/longTaskMaxDuration: +57%
  • ↑ startupStandardHome/tbt: +45%
  • ↓ startupStandardHome/inp: -30%
  • ↑ startupStandardHome/fcp: +35%
  • ↑ startupStandardHome/lcp: +508%
  • ↓ startupStandardHome/cls: -72%
  • ↑ startupStandardHome/domInteractive: +41%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/fcp: +43%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +12%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -11%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +15%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -73%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -74%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -37%
  • ↓ onboardingNewWallet/tbt: -97%
  • ↓ onboardingNewWallet/total: -69%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -48%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs [🚀 Bundle size reduced!]
Status Bundle Total Diff Change
✅ background 15.26 MiB +116 Bytes 0.00%
✅ ui 19.4 MiB -3.94 KiB -0.02%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB -14 Bytes 0.00%
✅ content scripts 3.23 MiB -28 Bytes 0.00%
✅ unzipped 79.73 MiB -5.07 KiB -0.01%
✅ zip 23.85 MiB -1.45 KiB -0.01%

@sonarqubecloud

sonarqubecloud Bot commented Nov 5, 2026

Copy link
Copy Markdown

@georgewrmarshall
georgewrmarshall marked this pull request as ready for review November 5, 2026 23:15
@georgewrmarshall
georgewrmarshall requested a review from a team as a code owner November 5, 2026 23:15
@georgewrmarshall
georgewrmarshall added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit 71cd205 Nov 6, 2026
268 of 275 checks passed
@georgewrmarshall
georgewrmarshall deleted the cursor/remove-dead-code-multichain-class-selectors-20261105-7b9e branch November 6, 2026 16:02
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 6, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.58.0 on PR, as PR was added to branch 13.58.0 when release was cut.

This branch was previously deployed

1 inactive deployment
pr-comment — 87a3b567 Deployed Nov 5, 2026 by georgewrmarshall via identify-codeowners #88862
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-13.58.0 Issue or pull request that will be included in release 13.58.0 team-design-system All issues relating to design system in Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants