Skip to content

fix(onboarding): resume direct deep-link destinations - #47678

Merged
davidmurdoch merged 9 commits into
mainfrom
david/fix-deeplink-onboarding-return
Nov 12, 2026
Merged

davidmurdoch merged 9 commits into
mainfrom
david/fix-deeplink-onboarding-return

Conversation

@davidmurdoch

@davidmurdoch davidmurdoch commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Description

Opening an internal deep link before wallet onboarding is complete loses the intended destination and finishes on Home. Retain the internal route in the existing UI state before redirecting to onboarding, then resume and clear it when setup finishes.

The latest saved direct destination in the current UI session takes precedence over the install-time deferred destination. Preserve its query and fragment, and keep it in that UI when the side panel is enabled. No cross-tab synchronization is added. The social-import unlock path also retains its saved direct destination.

Keep install attribution and the deferred DeepLinkUsed event, including attribution and campaign parameters, even when a later direct link supplies the action. Without a saved direct destination, deferred navigation and its required interstitial remain the fallback. A saved direct destination also supersedes a pending deferred interstitial; the requester identified themselves as the Extension Security team and approved this behavior in the implementation conversation.

Validly signed direct links also skip the interstitial while local onboarding state is explicitly incomplete, matching the existing behavior for signed deferred links. Unsigned or invalidly signed links and links received after onboarding retain the existing policy. The requester identified themselves as a member of Extension Security and explicitly approved this pre-onboarding exception in the implementation conversation, clarifying that it applies only to valid signatures in both flows.

Validation: 94 tests passed across five onboarding, routing, and unlock suites; full TypeScript checking, changed-file lint, and circular dependency checks passed. Both social-import completion-failure regression cases failed before the retry fix and passed afterward; automatic completion retry is also covered. Earlier signed-link onboarding regressions remain covered. Manual testing is pending.

Changelog

CHANGELOG entry: Fixed direct deep-link destinations being lost during onboarding and removed the extra pre-onboarding warning for validly signed links.

Related issues

Fixes #47667

Jira: MWPE-805

Related: #47665. This fix does not depend on referral functionality.

Manual testing steps

  1. In a fresh extension profile, leave onboarding incomplete and open https://link.metamask.io/privacy. Continue through the existing security warning, then finish wallet setup. Verify Privacy & Security opens at the MetaMetrics section instead of Home.

  2. Start with an install-time deferred link containing attribution and campaign parameters. Before finishing onboarding, open a different direct destination in the same UI. Complete setup and verify the later destination opens. With metrics enabled, verify install attribution and the deferred DeepLinkUsed event retain the original link's attribution and campaign parameters.

  3. Repeat with a deferred link that would require an interstitial. Verify the later direct destination supersedes that deferred action, and the direct link's own security warning still appears when required.

  4. Repeat with the side-panel experience enabled. Verify the later destination opens in the UI that received it. Ordinary onboarding without a direct destination keeps its usual side-panel behavior.

  5. Repeat through social import, including unlock/rehydration, and verify the saved direct destination is retained. For a supported link with product parameters, verify its query and scroll fragment survive setup.

  6. Open another direct destination in the same UI before completion and verify the last one is used. Completing onboarding in a separate UI does not inherit that destination. If completion fails, retry and verify the destination remains available.

  7. Repeat the install-attribution deferred-link flow without a later direct destination. Verify its destination and any required security warning remain the fallback.

  8. With the interstitial opt-out disabled, open a validly signed direct link before onboarding is complete. Verify setup opens without a security warning and resumes the destination afterward. Repeat after onboarding and verify the normal warning appears. Repeat with unsigned and invalidly signed links before onboarding and verify the existing warning behavior remains.

Screenshots/Recordings

Not captured locally.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes onboarding navigation, deep-link interstitial policy, and security-boundary logic for signed links before onboarding completes; mistakes could mis-route users or weaken warnings.

Overview
Fixes direct deep links being dropped when the wallet is still onboarding by introducing session-scoped onboardingRedirect UI state. RequireAuthenticated saves the full internal path (query/hash) before sending users to onboarding; completion paths in useOnboardingCompletion, onboarding-flow, and unlock/social-import flows resume that route and clear it, with the saved direct destination beating install-time deferred deep links while still emitting deferred DeepLinkUsed attribution.

The deep-link security policy now consults completedOnboarding: valid signed intercepted links skip the interstitial only while onboarding is explicitly incomplete; unsigned/invalid links and post-onboarding behavior stay unchanged. The router lazily reads controller state once per intercept for this check.

Reviewed by Cursor Bugbot for commit c153a3b. Bugbot is set up for automated code reviews on this repo. Configure here.

@davidmurdoch davidmurdoch added the team-extension-platform Extension Platform team label Nov 5, 2026
@davidmurdoch davidmurdoch self-assigned this Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the size-M label Nov 5, 2026
@metamask-ci

metamask-ci Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

🕵️ @MetaMask/extension-privacy-reviewers (1 files, +1 -0)
  • 📁 test/
    • 📁 e2e/
      • 📁 tests/
        • 📁 settings/
          • 📄 state-logs.json +1 -0

🧪 @MetaMask/qa (1 files, +1 -0)
  • 📁 test/
    • 📁 e2e/
      • 📁 tests/
        • 📁 settings/
          • 📄 state-logs.json +1 -0

🔐 @MetaMask/web3auth (4 files, +350 -95)
  • 📁 ui/
    • 📁 pages/
      • 📁 onboarding-flow/
        • 📁 hooks/
          • 📄 useOnboardingCompletion.test.ts +131 -40
          • 📄 useOnboardingCompletion.ts +17 -4
          • 📄 onboarding-flow.test.tsx +182 -39
          • 📄 onboarding-flow.tsx +20 -12

@metamask-ci

metamask-ci Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor
Builds ready [582c814]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 0 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42104639839 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +179%
  • ↑ loadNewAccount/total: +179%
  • ↓ loadNewAccount/inp: -48%
  • ↓ loadNewAccount/fcp: -30%
  • ↑ loadNewAccount/lcp: +587%
  • ↑ loadNewAccount/cls: +573%
  • ↓ confirmTx/tbt: -10%
  • ↓ confirmTx/inp: -44%
  • ↓ confirmTx/fcp: -30%
  • ↑ confirmTx/lcp: +606%
  • ↓ bridgeUserActions/bridge_load_asset_picker: -14%
  • ↓ bridgeUserActions/longTaskTotalDuration: -27%
  • ↓ bridgeUserActions/longTaskMaxDuration: -29%
  • ↓ bridgeUserActions/tbt: -55%
  • ↓ bridgeUserActions/inp: -26%
  • ↓ bridgeUserActions/fcp: -31%
  • ↑ bridgeUserActions/lcp: +579%
  • ↑ bridgeUserActions/cls: +636%
  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↑ loadNewAccount/inp: +12%
  • ↓ loadNewAccount/fcp: -76%
  • ↑ loadNewAccount/lcp: +749%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/fcp: -73%
  • ↑ confirmTx/lcp: +771%
  • ↑ bridgeUserActions/bridge_load_page: +92%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +127%
  • ↓ bridgeUserActions/bridge_search_token: -15%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +17%
  • ↓ bridgeUserActions/inp: -12%
  • ↓ bridgeUserActions/fcp: -72%
  • ↑ bridgeUserActions/lcp: +744%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +47%
  • ↑ startupStandardHome/load: +72%
  • ↑ startupStandardHome/domContentLoaded: +73%
  • ↓ startupStandardHome/firstPaint: -53%
  • ↓ startupStandardHome/backgroundConnect: -13%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +72%
  • ↑ startupStandardHome/setupStore: +95%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +69%
  • ↑ startupStandardHome/longTaskMaxDuration: +76%
  • ↑ startupStandardHome/tbt: +82%
  • ↓ startupStandardHome/inp: -18%
  • ↓ startupStandardHome/fcp: -59%
  • ↑ startupStandardHome/lcp: +86%
  • ↓ startupStandardHome/cls: -72%
  • ↑ startupStandardHome/domInteractive: +34%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/fcp: +26%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -28%
  • ↓ onboardingImportWallet/confirmSrpToPwForm: -19%
  • ↓ onboardingImportWallet/pwFormToMetricsScreen: -12%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -38%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -86%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -11%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -31%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -14%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -50%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -77%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -73%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -49%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs [🚀 Bundle size reduced!]
Status Bundle Total Diff Change
✅ background 15.26 MiB +116 Bytes 0.00%
✅ ui 19.4 MiB -3.23 KiB -0.02%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB -14 Bytes 0.00%
✅ content scripts 3.23 MiB -28 Bytes 0.00%
✅ unzipped 79.73 MiB -3.15 KiB 0.00%
✅ zip 23.85 MiB -1.01 KiB 0.00%

@metamask-ci

metamask-ci Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor
Builds ready [8c130a8]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 2 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42876006950 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +180%
  • ↑ loadNewAccount/total: +180%
  • ↓ loadNewAccount/inp: -33%
  • ↓ loadNewAccount/fcp: -19%
  • ↑ loadNewAccount/lcp: +700%
  • ↑ loadNewAccount/cls: +640%
  • ↑ confirmTx/longTaskMaxDuration: +17%
  • ↑ confirmTx/tbt: +22%
  • ↓ confirmTx/inp: -44%
  • ↓ confirmTx/fcp: -19%
  • ↑ confirmTx/lcp: +709%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +11%
  • ↓ bridgeUserActions/longTaskTotalDuration: -19%
  • ↓ bridgeUserActions/longTaskMaxDuration: -24%
  • ↓ bridgeUserActions/tbt: -34%
  • ↓ bridgeUserActions/inp: -26%
  • ↓ bridgeUserActions/fcp: -19%
  • ↑ bridgeUserActions/lcp: +704%
  • ↑ bridgeUserActions/cls: +634%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -25%
  • ↓ loadNewAccount/fcp: -38%
  • ↑ loadNewAccount/lcp: +1221%
  • ↑ confirmTx/confirm_tx: +11%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/total: +11%
  • ↓ confirmTx/inp: -13%
  • ↓ confirmTx/fcp: -30%
  • ↑ confirmTx/lcp: +1357%
  • ↑ bridgeUserActions/bridge_load_page: +198%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +135%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +37%
  • ↑ bridgeUserActions/inp: +62%
  • ↑ bridgeUserActions/fcp: +16%
  • ↑ bridgeUserActions/lcp: +1259%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +91%
  • ↑ startupStandardHome/load: +127%
  • ↑ startupStandardHome/domContentLoaded: +128%
  • ↑ startupStandardHome/domInteractive: +27%
  • ↓ startupStandardHome/firstPaint: -53%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +126%
  • ↑ startupStandardHome/setupStore: +140%
  • ↑ startupStandardHome/longTaskCount: +79%
  • ↑ startupStandardHome/longTaskTotalDuration: +125%
  • ↑ startupStandardHome/longTaskMaxDuration: +129%
  • ↑ startupStandardHome/tbt: +148%
  • ↓ startupStandardHome/fcp: -49%
  • ↑ startupStandardHome/lcp: +131%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -19%
  • ↓ startupStandardHome/load: -14%
  • ↓ startupStandardHome/domContentLoaded: -16%
  • ↑ startupStandardHome/domInteractive: +31%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -15%
  • ↑ startupStandardHome/inp: +50%
  • ↑ startupStandardHome/fcp: +31%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +11%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +22%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +34%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +19%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -95%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -90%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +17%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +36%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +21%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +12%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -70%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -73%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -36%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -66%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -61%
  • ↓ dappPageLoad/domContentLoaded: -21%
  • ↓ dappPageLoad/firstPaint: -42%
  • ↓ dappPageLoad/firstContentfulPaint: -42%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.21 MiB -42.6 KiB -0.27%
🚨 ui 19.48 MiB +79.73 KiB +0.40%
✅ common 0 Bytes 0 Bytes 0.00%
🚨 other 4.46 MiB +17.91 KiB +0.39%
✅ content scripts 3.22 MiB -3.79 KiB -0.11%
🚨 unzipped 79.9 MiB +169.81 KiB +0.21%
🚨 zip 24.01 MiB +156.33 KiB +0.64%

Keep deferred attribution tracking while resuming the latest saved destination
in the current UI session. Avoid opening a side panel for the direct route.

Security approval: the requester identified themselves as the Extension
Security team and approved superseding a pending deferred interstitial in
the implementation conversation.
@metamask-ci

metamask-ci Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor
Builds ready [843dbd2]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 2 warn · 🔴 2 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42906236570 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +178%
  • ↑ loadNewAccount/total: +178%
  • ↓ loadNewAccount/inp: -55%
  • ↓ loadNewAccount/fcp: -38%
  • ↑ loadNewAccount/lcp: +505%
  • ↑ loadNewAccount/cls: +294%
  • ↓ confirmTx/confirm_tx: -11%
  • ↓ confirmTx/longTaskTotalDuration: -23%
  • ↓ confirmTx/longTaskMaxDuration: -17%
  • ↓ confirmTx/tbt: -36%
  • ↓ confirmTx/total: -11%
  • ↓ confirmTx/inp: -60%
  • ↓ confirmTx/fcp: -39%
  • ↑ confirmTx/lcp: +517%
  • ↓ confirmTx/cls: -14%
  • ↓ bridgeUserActions/bridge_load_page: -25%
  • ↓ bridgeUserActions/bridge_search_token: -11%
  • ↓ bridgeUserActions/longTaskTotalDuration: -44%
  • ↓ bridgeUserActions/longTaskMaxDuration: -48%
  • ↓ bridgeUserActions/tbt: -97%
  • ↓ bridgeUserActions/total: -12%
  • ↓ bridgeUserActions/inp: -49%
  • ↓ bridgeUserActions/fcp: -40%
  • ↑ bridgeUserActions/lcp: +490%
  • ↑ bridgeUserActions/cls: +610%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -18%
  • ↓ loadNewAccount/fcp: -33%
  • ↑ loadNewAccount/lcp: +1271%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -13%
  • ↓ confirmTx/fcp: -35%
  • ↑ confirmTx/lcp: +1350%
  • ↑ bridgeUserActions/bridge_load_page: +233%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +111%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +37%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -40%
  • ↑ bridgeUserActions/lcp: +1243%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +78%
  • ↑ startupStandardHome/load: +109%
  • ↑ startupStandardHome/domContentLoaded: +110%
  • ↑ startupStandardHome/domInteractive: +24%
  • ↓ startupStandardHome/firstPaint: -45%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +108%
  • ↑ startupStandardHome/setupStore: +121%
  • ↑ startupStandardHome/numNetworkReqs: +11%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +106%
  • ↑ startupStandardHome/longTaskMaxDuration: +117%
  • ↑ startupStandardHome/tbt: +128%
  • ↓ startupStandardHome/fcp: -49%
  • ↑ startupStandardHome/lcp: +129%
  • ↓ startupStandardHome/cls: -72%
  • ↑ startupStandardHome/domInteractive: +18%
  • ↑ startupStandardHome/backgroundConnect: +17%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/fcp: +20%
  • ↑ startupStandardHome/lcp: +12%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +29%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +39%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +35%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +27%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -95%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -91%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +10%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -19%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -81%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -65%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -15%
  • ↓ onboardingNewWallet/tbt: -96%
  • ↓ onboardingNewWallet/total: -75%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -68%
  • ↓ dappPageLoad/domContentLoaded: -36%
  • ↓ dappPageLoad/firstPaint: -52%
  • ↓ dappPageLoad/firstContentfulPaint: -52%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.21 MiB -42.67 KiB -0.27%
🚨 ui 19.48 MiB +81.36 KiB +0.41%
✅ common 0 Bytes 0 Bytes 0.00%
🚨 other 4.46 MiB +17.95 KiB +0.39%
✅ content scripts 3.22 MiB -3.72 KiB -0.11%
🚨 unzipped 79.9 MiB +171.29 KiB +0.21%
🚨 zip 24.01 MiB +156.83 KiB +0.64%

@metamask-ci

metamask-ci Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor
Builds ready [2088d58] [reused from 843dbd2]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 2 warn · 🔴 2 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42910876637 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +178%
  • ↑ loadNewAccount/total: +178%
  • ↓ loadNewAccount/inp: -55%
  • ↓ loadNewAccount/fcp: -38%
  • ↑ loadNewAccount/lcp: +505%
  • ↑ loadNewAccount/cls: +294%
  • ↓ confirmTx/confirm_tx: -11%
  • ↓ confirmTx/longTaskTotalDuration: -23%
  • ↓ confirmTx/longTaskMaxDuration: -17%
  • ↓ confirmTx/tbt: -36%
  • ↓ confirmTx/total: -11%
  • ↓ confirmTx/inp: -60%
  • ↓ confirmTx/fcp: -39%
  • ↑ confirmTx/lcp: +517%
  • ↓ confirmTx/cls: -14%
  • ↓ bridgeUserActions/bridge_load_page: -25%
  • ↓ bridgeUserActions/bridge_search_token: -11%
  • ↓ bridgeUserActions/longTaskTotalDuration: -44%
  • ↓ bridgeUserActions/longTaskMaxDuration: -48%
  • ↓ bridgeUserActions/tbt: -97%
  • ↓ bridgeUserActions/total: -12%
  • ↓ bridgeUserActions/inp: -49%
  • ↓ bridgeUserActions/fcp: -40%
  • ↑ bridgeUserActions/lcp: +490%
  • ↑ bridgeUserActions/cls: +610%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -18%
  • ↓ loadNewAccount/fcp: -33%
  • ↑ loadNewAccount/lcp: +1271%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -13%
  • ↓ confirmTx/fcp: -35%
  • ↑ confirmTx/lcp: +1350%
  • ↑ bridgeUserActions/bridge_load_page: +233%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +111%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +37%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -40%
  • ↑ bridgeUserActions/lcp: +1243%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +78%
  • ↑ startupStandardHome/load: +109%
  • ↑ startupStandardHome/domContentLoaded: +110%
  • ↑ startupStandardHome/domInteractive: +24%
  • ↓ startupStandardHome/firstPaint: -45%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +108%
  • ↑ startupStandardHome/setupStore: +121%
  • ↑ startupStandardHome/numNetworkReqs: +11%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +106%
  • ↑ startupStandardHome/longTaskMaxDuration: +117%
  • ↑ startupStandardHome/tbt: +128%
  • ↓ startupStandardHome/fcp: -49%
  • ↑ startupStandardHome/lcp: +129%
  • ↓ startupStandardHome/cls: -72%
  • ↑ startupStandardHome/domInteractive: +18%
  • ↑ startupStandardHome/backgroundConnect: +17%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/fcp: +20%
  • ↑ startupStandardHome/lcp: +12%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +29%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +39%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +35%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +27%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -95%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -91%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +10%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -19%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -81%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -65%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -15%
  • ↓ onboardingNewWallet/tbt: -96%
  • ↓ onboardingNewWallet/total: -75%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -68%
  • ↓ dappPageLoad/domContentLoaded: -36%
  • ↓ dappPageLoad/firstPaint: -52%
  • ↓ dappPageLoad/firstContentfulPaint: -52%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.21 MiB -42.67 KiB -0.27%
🚨 ui 19.48 MiB +81.36 KiB +0.41%
✅ common 0 Bytes 0 Bytes 0.00%
🚨 other 4.46 MiB +17.95 KiB +0.39%
✅ content scripts 3.22 MiB -3.72 KiB -0.11%
🚨 unzipped 79.9 MiB +171.29 KiB +0.21%
🚨 zip 24.01 MiB +156.83 KiB +0.64%

This reverts commit ac899f3 to keep this PR focused on deep-link onboarding.
@metamask-ci

metamask-ci Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor
Builds ready [bfbb913] [reused from ac899f3]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 2 warn · 🔴 1 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43049532606 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]–

Regressions (🔴 1 failure)

Interaction Benchmarks · Samples: 5 🔴 1

⚠️ Missing data: firefox/webpack/interactionUserActions

Benchmarkchrome-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/inp: -18%
  • ↑ loadNewAccount/lcp: +906%
  • ↑ loadNewAccount/cls: +297%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +56%
  • ↑ confirmTx/longTaskMaxDuration: +59%
  • ↑ confirmTx/tbt: +73%
  • ↓ confirmTx/inp: -21%
  • ↑ confirmTx/lcp: +938%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +90%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +36%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +84%
  • ↑ bridgeUserActions/longTaskMaxDuration: +37%
  • ↑ bridgeUserActions/tbt: +161%
  • ↑ bridgeUserActions/total: +15%
  • ↑ bridgeUserActions/lcp: +918%
  • ↑ bridgeUserActions/cls: +387%
Startup Benchmarks · Samples: 100

⚠️ Missing data: chrome/webpack/startupStandardHome, firefox/webpack/startupStandardHome

✅ No regressions detected

User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -12%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -18%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +21%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +46%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +26%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -74%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -66%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -18%
  • ↓ onboardingNewWallet/tbt: -96%
  • ↓ onboardingNewWallet/total: -69%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -70%
  • ↓ dappPageLoad/domContentLoaded: -38%
  • ↓ dappPageLoad/firstPaint: -57%
  • ↓ dappPageLoad/firstContentfulPaint: -57%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.22 MiB -37.42 KiB -0.24%
🚨 ui 19.48 MiB +87.02 KiB +0.44%
✅ common 0 Bytes 0 Bytes 0.00%
🚨 other 4.46 MiB +19.02 KiB +0.42%
✅ content scripts 3.22 MiB -1.57 KiB -0.05%
🚨 unzipped 79.91 MiB +184.91 KiB +0.23%
🚨 zip 24.01 MiB +159.15 KiB +0.65%

@davidmurdoch
davidmurdoch marked this pull request as ready for review November 11, 2026 16:10
@davidmurdoch
davidmurdoch requested review from a team as code owners November 11, 2026 16:10
@davidmurdoch
davidmurdoch requested a review from a team as a code owner November 11, 2026 16:56
@github-actions github-actions Bot added size-L and removed size-M labels Nov 11, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0cb6cb4. Configure here.

@metamask-ci

metamask-ci Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor
Builds ready [0cb6cb4]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43063231062 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -25%
  • ↑ loadNewAccount/lcp: +965%
  • ↑ loadNewAccount/cls: +297%
  • ↑ confirmTx/longTaskCount: +67%
  • ↑ confirmTx/longTaskTotalDuration: +76%
  • ↑ confirmTx/longTaskMaxDuration: +54%
  • ↑ confirmTx/tbt: +85%
  • ↓ confirmTx/inp: -13%
  • ↑ confirmTx/lcp: +987%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +123%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +48%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +79%
  • ↑ bridgeUserActions/longTaskMaxDuration: +19%
  • ↑ bridgeUserActions/tbt: +146%
  • ↑ bridgeUserActions/total: +19%
  • ↑ bridgeUserActions/lcp: +943%
  • ↑ bridgeUserActions/cls: +387%
  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -18%
  • ↓ loadNewAccount/fcp: -64%
  • ↑ loadNewAccount/lcp: +895%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/inp: +90%
  • ↓ confirmTx/fcp: -68%
  • ↑ confirmTx/lcp: +919%
  • ↑ bridgeUserActions/bridge_load_page: +146%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +43%
  • ↓ bridgeUserActions/bridge_search_token: -12%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +14%
  • ↓ bridgeUserActions/fcp: -66%
  • ↑ bridgeUserActions/lcp: +925%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.8s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +94%
  • ↑ startupStandardHome/load: +129%
  • ↑ startupStandardHome/domContentLoaded: +130%
  • ↑ startupStandardHome/domInteractive: +29%
  • ↓ startupStandardHome/firstPaint: -50%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +128%
  • ↑ startupStandardHome/setupStore: +140%
  • ↑ startupStandardHome/numNetworkReqs: +11%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +127%
  • ↑ startupStandardHome/longTaskMaxDuration: +144%
  • ↑ startupStandardHome/tbt: +155%
  • ↓ startupStandardHome/fcp: -49%
  • ↑ startupStandardHome/lcp: +131%
  • ↓ startupStandardHome/cls: -72%
  • ↑ startupStandardHome/domInteractive: +53%
  • ↑ startupStandardHome/backgroundConnect: +12%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/fcp: +56%
  • ↑ startupStandardHome/lcp: +12%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +12%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +24%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +36%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +16%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -95%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -90%
  • ↓ onboardingImportWallet/tbt: -99%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -11%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -23%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -10%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -13%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -46%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -80%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -76%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -55%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.22 MiB -34.52 KiB -0.22%
🚨 ui 19.5 MiB +99.28 KiB +0.50%
✅ common 0 Bytes 0 Bytes 0.00%
🚨 other 4.46 MiB +18.65 KiB +0.41%
✅ content scripts 3.22 MiB -2.31 KiB -0.07%
🚨 unzipped 79.93 MiB +199.63 KiB +0.24%
🚨 zip 24.01 MiB +164.68 KiB +0.67%

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

An onboarding-completion failure redirects to Home and clears the saved direct destination, so retrying setup loses the intended direct link.

1 open issue
What changed in this PR

This PR preserves direct internal deep-link destinations through onboarding, addressing #47667 without depending on referral functionality.

Changes:

  • Saves and restores the destination, including query parameters and fragments, within the receiving UI session.
  • Prioritizes saved direct destinations over deferred navigation while retaining install attribution and deferred-link metrics.
  • Allows validly signed direct links to skip the interstitial when onboarding is explicitly incomplete, with regression coverage.
File Description
ui/​store/​actionConstants.ts Adds the onboarding redirect action constant.
ui/​pages/​onboarding-flow/​onboarding-flow.tsx Restores saved destinations after onboarding and social import.
ui/​pages/​onboarding-flow/​onboarding-flow.test.tsx Covers destination restoration and clearing.
ui/​pages/​onboarding-flow/​hooks/​useOnboardingCompletion.ts Applies direct-link precedence and keeps navigation in the receiving UI.
ui/​pages/​onboarding-flow/​hooks/​useOnboardingCompletion.test.ts Tests precedence, attribution, side-panel behavior, and retries.
ui/​layouts/​require-authenticated.tsx Captures protected destinations before redirecting to onboarding.
ui/​layouts/​require-authenticated.test.tsx Tests route preservation and destination replacement.
ui/​ducks/​app/​app.ts Adds session-local redirect state, action, and selector.
ui/​ducks/​app/​app.test.js Tests redirect updates and clearing.
test/​e2e/​tests/​settings/​state-logs.json Updates the expected UI state shape.
test/​e2e/​tests/​metrics/​state-snapshots/​errors-after-init-opt-in-ui-state.json Includes redirect state in the metrics snapshot.
shared/​lib/​deep-links/​security-policy.ts Adds the valid-signature pre-onboarding exception.
shared/​lib/​deep-links/​security-policy.test.ts Tests signature and onboarding-state policy combinations.
app/​scripts/​lib/​deep-links/​deep-link.router.test.ts Covers signed direct-link routing across onboarding states.
app/​scripts/​lib/​deep-links/​deep-link-router.ts Supplies cached onboarding state to the security policy.

Review effort: Balanced

Comment thread ui/layouts/require-authenticated.tsx Resolved
@metamask-ci

metamask-ci Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor
Builds ready [c153a3b]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 1 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43080473620 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +179%
  • ↑ loadNewAccount/total: +179%
  • ↓ loadNewAccount/inp: -55%
  • ↓ loadNewAccount/fcp: -32%
  • ↑ loadNewAccount/lcp: +564%
  • ↑ loadNewAccount/cls: +294%
  • ↓ confirmTx/longTaskTotalDuration: -12%
  • ↓ confirmTx/tbt: -18%
  • ↓ confirmTx/inp: -52%
  • ↓ confirmTx/fcp: -34%
  • ↑ confirmTx/lcp: +562%
  • ↓ confirmTx/cls: -14%
  • ↓ bridgeUserActions/longTaskTotalDuration: -31%
  • ↓ bridgeUserActions/longTaskMaxDuration: -37%
  • ↓ bridgeUserActions/tbt: -65%
  • ↓ bridgeUserActions/inp: -34%
  • ↓ bridgeUserActions/fcp: -32%
  • ↑ bridgeUserActions/lcp: +574%
  • ↑ bridgeUserActions/cls: +634%
  • ↑ loadNewAccount/load_new_account: +180%
  • ↑ loadNewAccount/total: +180%
  • ↓ loadNewAccount/inp: -40%
  • ↓ loadNewAccount/fcp: -53%
  • ↑ loadNewAccount/lcp: +986%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -50%
  • ↑ confirmTx/lcp: +1019%
  • ↑ bridgeUserActions/bridge_load_page: +136%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +88%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +21%
  • ↑ bridgeUserActions/inp: +25%
  • ↓ bridgeUserActions/fcp: -62%
  • ↑ bridgeUserActions/lcp: +1083%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +47%
  • ↑ startupStandardHome/load: +72%
  • ↑ startupStandardHome/domContentLoaded: +73%
  • ↓ startupStandardHome/firstPaint: -60%
  • ↓ startupStandardHome/backgroundConnect: -17%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +71%
  • ↑ startupStandardHome/setupStore: +88%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +67%
  • ↑ startupStandardHome/longTaskMaxDuration: +70%
  • ↑ startupStandardHome/tbt: +79%
  • ↓ startupStandardHome/inp: -18%
  • ↓ startupStandardHome/fcp: -58%
  • ↑ startupStandardHome/lcp: +88%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -22%
  • ↓ startupStandardHome/load: -17%
  • ↓ startupStandardHome/domContentLoaded: -18%
  • ↓ startupStandardHome/domInteractive: -11%
  • ↓ startupStandardHome/backgroundConnect: -11%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -17%
  • ↓ startupStandardHome/setupStore: -19%
  • ↓ startupStandardHome/lcp: -14%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +11%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +31%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +35%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +18%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -16%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -12%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -41%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -80%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -76%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -60%
  • ↓ dappPageLoad/domContentLoaded: -18%
  • ↓ dappPageLoad/firstPaint: -42%
  • ↓ dappPageLoad/firstContentfulPaint: -42%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.22 MiB -34.52 KiB -0.22%
🚨 ui 19.5 MiB +99.27 KiB +0.50%
✅ common 0 Bytes 0 Bytes 0.00%
🚨 other 4.46 MiB +18.65 KiB +0.41%
✅ content scripts 3.22 MiB -2.31 KiB -0.07%
🚨 unzipped 79.93 MiB +199.62 KiB +0.24%
🚨 zip 24.01 MiB +164.67 KiB +0.67%

@sonarqubecloud

Copy link
Copy Markdown

source: 'intercepted',
signatureStatus: parsed.signature,
requestOrigin,
getCompletedOnboarding: () => getState().completedOnboarding,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before onboarding, a signed link to buy, card, onboarding, sell or top-traders skips the interstitial and opens its external page directly, with no onboarding in between to stand in for it.

Maybe we should leave redirect routes out of the pre-onboarding skip?

diff --git a/app/scripts/lib/deep-links/deep-link-router.ts b/app/scripts/lib/deep-links/deep-link-router.ts
--- a/app/scripts/lib/deep-links/deep-link-router.ts
+++ b/app/scripts/lib/deep-links/deep-link-router.ts
@@ -190,7 +190,10 @@ export class DeepLinkRouter extends EventEmitter<{
           source: 'intercepted',
           signatureStatus: parsed.signature,
           requestOrigin,
-          getCompletedOnboarding: () => getState().completedOnboarding,
+          getCompletedOnboarding:
+            'redirectTo' in parsed.destination
+              ? undefined
+              : () => getState().completedOnboarding,
           getSkipDeepLinkInterstitial: () =>
             Boolean(getState().preferences?.skipDeepLinkInterstitial),
         });
diff --git a/app/scripts/lib/deep-links/deep-link.router.test.ts b/app/scripts/lib/deep-links/deep-link.router.test.ts
--- a/app/scripts/lib/deep-links/deep-link.router.test.ts
+++ b/app/scripts/lib/deep-links/deep-link.router.test.ts
@@ -545,6 +545,31 @@ describe('DeepLinkRouter', () => {
       });
     });
 
+    it('shows the interstitial for signed redirecting routes before onboarding', async function () {
+      getState.mockReturnValueOnce({
+        completedOnboarding: false,
+        preferences: { skipDeepLinkInterstitial: false },
+      } as unknown as ReturnType<MetaMaskController['getState']>);
+      parseMock.mockResolvedValue({
+        signature: 'valid',
+        route: {
+          pathname: '/buy',
+        },
+        destination: {
+          redirectTo: new URL('https://example.com/internal-route'),
+        },
+      } as ParsedDeepLink);
+
+      await onBeforeRequest?.({
+        tabId: 1,
+        url: 'https://example.com/buy',
+      } as browser.WebRequest.OnBeforeRequestDetailsType);
+
+      expect(browser.tabs.update).toHaveBeenCalledWith(1, {
+        url: 'chrome-extension://extension-id/home.html#link?u=%2Fbuy',
+      });
+    });
+
     describe('resolveRequestOrigin', () => {
       it('prefers initiator over originUrl', () => {
         expect(

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. I don't think there is a good security reason to do it. And I don't know if there is a good UX reason to do it (or not do it).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have a strong reason other than keeping the interstitial's friction before onboarding, since a new user hasn't had the chance to turn it off. But in any case guess this is more of a nit, maybe for a follow-up where the interstitial prompts onboarding for redirect routes.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a redesign of how deferred deep links (and the deep links handled by this PR) are presented to the user after onboarding completed. its kind of silly right now. it works, but its quite jarring!

@seaona seaona left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e files LGTM

@davidmurdoch
davidmurdoch added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit 61ce0e7 Nov 12, 2026
143 checks passed
@davidmurdoch
davidmurdoch deleted the david/fix-deeplink-onboarding-return branch November 12, 2026 08:38
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 12, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026

This branch was previously deployed

1 inactive deployment
pr-comment — c153a3b0 Deployed Nov 11, 2026 by davidmurdoch via Publish prerelease / Publish prerelease #174161
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-L team-extension-platform Extension Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Direct deep links lose their destination when onboarding is incomplete

7 participants