Skip to content

refactor(ui): simplify bottom nav layout - #47685

Merged
n3ps merged 4 commits into
mainfrom
n3ps/simplify-bottom-nav
Nov 6, 2026
Merged

n3ps merged 4 commits into
mainfrom
n3ps/simplify-bottom-nav

Conversation

@n3ps

@n3ps n3ps commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Description

Simplify the bottom nav conditional logic. Use declarative layouts instead of custom helpers

Prep work for wide layout

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches global routing/layout composition for many authenticated screens, which can regress scroll behavior or chrome visibility if route groupings are wrong.

Overview
Conditionally rendered shell UI is replaced with route-declarative layouts, removing useBottomNavBar, isMainNavRoute, and their tests.

MainLayout always mounts AppHeader, scroll shell, outlet, and BottomNavBar, so tab routes keep a consistent frame without runtime toggles.

A new ContentLayout wraps secondary Money flows (MONEY_* beyond home) in a scrollable main region without the bottom nav/header chrome.

Home drops duplicate header rendering and split scroll behaviors, standardizing on the sticky DappConnectionControlBar pattern for all home states.

AppHeaderUnlockedContent always disables the account picker on cross-chain swap paths, since that flow no longer shares the bottom-nav shell.

Reviewed by Cursor Bugbot for commit 7cf1438. Bugbot is set up for automated code reviews on this repo. Configure here.

@n3ps
n3ps requested a review from a team as a code owner November 6, 2026 01:11
@n3ps
n3ps enabled auto-merge November 6, 2026 01:11
@github-actions github-actions Bot added the size-M label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci

metamask-ci Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (2 files, +19 -45)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 app-header/
          • 📄 app-header-unlocked-content.tsx +1 -4
    • 📁 pages/
      • 📁 home/
        • 📄 home.tsx +18 -41

@n3ps n3ps changed the title simplify bottom nav condition refactor(ui): simplify bottom nav layout Nov 6, 2026
@metamask-ci metamask-ci Bot added the team-core-extension-ux Core Extension UX team label Nov 6, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout / routing review

The route split (MainLayout vs ContentLayout) looks reasonable for replacing runtime useBottomNavBar checks. One regression to fix before merge.

No issues from the chrome extension (manifest / background) checklist — changes are UI-only.

Open in Web View Automation 

Sent by Cursor Automation: Modern web guidance

Comment thread ui/pages/routes/routes.component.tsx Resolved
Comment thread ui/hooks/useBottomNavBar.ts Outdated

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Remove this location-based logic

],
},
{
element: <ContentLayout />,

@n3ps n3ps Nov 6, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. And use declarative layouts instead

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5204bdf. Configure here.

Comment thread ui/pages/routes/routes.component.tsx Resolved
@metamask-ci

metamask-ci Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor
Builds ready [805f0a1]
⚡ Performance Benchmarks (Total: 🟢 10 pass · 🟡 1 warn · 🔴 2 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42142920690 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +180%
  • ↑ loadNewAccount/total: +180%
  • ↓ loadNewAccount/inp: -40%
  • ↑ loadNewAccount/lcp: +804%
  • ↑ loadNewAccount/cls: +297%
  • ↑ confirmTx/longTaskMaxDuration: +11%
  • ↑ confirmTx/tbt: +16%
  • ↓ confirmTx/inp: -44%
  • ↓ confirmTx/fcp: -19%
  • ↑ confirmTx/lcp: +711%
  • ↑ bridgeUserActions/bridge_load_page: +39%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskMaxDuration: +11%
  • ↑ bridgeUserActions/tbt: +37%
  • ↓ bridgeUserActions/inp: -26%
  • ↓ bridgeUserActions/fcp: -20%
  • ↑ bridgeUserActions/lcp: +693%
  • ↑ bridgeUserActions/cls: +636%
  • ↑ loadNewAccount/load_new_account: +180%
  • ↑ loadNewAccount/total: +180%
  • ↓ loadNewAccount/inp: -25%
  • ↓ loadNewAccount/fcp: -71%
  • ↑ loadNewAccount/lcp: +807%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -21%
  • ↓ confirmTx/fcp: -73%
  • ↑ confirmTx/lcp: +1124%
  • ↑ bridgeUserActions/bridge_load_page: +67%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +50%
  • ↓ bridgeUserActions/bridge_search_token: -12%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↓ bridgeUserActions/fcp: -72%
  • ↑ bridgeUserActions/lcp: +1263%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +96%
  • ↑ startupStandardHome/load: +133%
  • ↑ startupStandardHome/domContentLoaded: +134%
  • ↑ startupStandardHome/domInteractive: +32%
  • ↓ startupStandardHome/firstPaint: -50%
  • ↑ startupStandardHome/backgroundConnect: +15%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +131%
  • ↑ startupStandardHome/setupStore: +134%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +131%
  • ↑ startupStandardHome/longTaskMaxDuration: +143%
  • ↑ startupStandardHome/tbt: +157%
  • ↓ startupStandardHome/fcp: -46%
  • ↑ startupStandardHome/lcp: +141%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -38%
  • ↓ startupStandardHome/load: -33%
  • ↓ startupStandardHome/domContentLoaded: -35%
  • ↓ startupStandardHome/domInteractive: -55%
  • ↓ startupStandardHome/backgroundConnect: -27%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -34%
  • ↑ startupStandardHome/setupStore: +41%
  • ↓ startupStandardHome/fcp: -41%
  • ↓ startupStandardHome/lcp: -32%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +10%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +20%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +26%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +16%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -91%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -73%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -25%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -18%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -48%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -77%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -72%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -34%
  • ↓ onboardingNewWallet/tbt: -93%
  • ↓ onboardingNewWallet/total: -74%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -48%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +123 Bytes 0.00%
✅ ui 19.42 MiB -815 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB -7 Bytes 0.00%
✅ content scripts 3.23 MiB -14 Bytes 0.00%
✅ unzipped 79.77 MiB -708 Bytes 0.00%
✅ zip 23.86 MiB -382 Bytes 0.00%

@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Nov 6, 2026
@n3ps n3ps mentioned this pull request Nov 6, 2026
7 tasks
@metamask-ci

metamask-ci Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor
Builds ready [2095186]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42221724022 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -18%
  • ↑ loadNewAccount/lcp: +954%
  • ↑ loadNewAccount/cls: +294%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +60%
  • ↑ confirmTx/longTaskMaxDuration: +60%
  • ↑ confirmTx/tbt: +80%
  • ↓ confirmTx/inp: -21%
  • ↑ confirmTx/lcp: +982%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +120%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +148%
  • ↑ bridgeUserActions/longTaskCount: +82%
  • ↑ bridgeUserActions/longTaskTotalDuration: +104%
  • ↑ bridgeUserActions/longTaskMaxDuration: +15%
  • ↑ bridgeUserActions/tbt: +132%
  • ↑ bridgeUserActions/total: +32%
  • ↑ bridgeUserActions/inp: +18%
  • ↑ bridgeUserActions/lcp: +970%
  • ↑ bridgeUserActions/cls: +389%
  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/inp: -25%
  • ↑ loadNewAccount/fcp: +13%
  • ↑ loadNewAccount/lcp: +1275%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -21%
  • ↑ confirmTx/fcp: +20%
  • ↑ confirmTx/lcp: +1328%
  • ↑ bridgeUserActions/bridge_load_page: +355%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +130%
  • ↑ bridgeUserActions/bridge_search_token: +28%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +67%
  • ↑ bridgeUserActions/inp: +62%
  • ↓ bridgeUserActions/fcp: -31%
  • ↑ bridgeUserActions/lcp: +1262%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 confirmTx/FCP: p75 2.1s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +13%
  • ↑ startupStandardHome/load: +31%
  • ↑ startupStandardHome/domContentLoaded: +32%
  • ↓ startupStandardHome/domInteractive: -15%
  • ↓ startupStandardHome/firstPaint: -48%
  • ↓ startupStandardHome/backgroundConnect: -30%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -64%
  • ↑ startupStandardHome/loadScripts: +30%
  • ↑ startupStandardHome/setupStore: +10%
  • ↑ startupStandardHome/longTaskTotalDuration: +27%
  • ↑ startupStandardHome/longTaskMaxDuration: +47%
  • ↑ startupStandardHome/tbt: +32%
  • ↓ startupStandardHome/inp: -37%
  • ↑ startupStandardHome/fcp: +26%
  • ↑ startupStandardHome/lcp: +465%
  • ↓ startupStandardHome/cls: -72%
  • ↑ startupStandardHome/backgroundConnect: +11%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -13%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -30%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +12%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +39%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +12%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -70%
  • ↓ onboardingNewWallet/longTaskCount: -23%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -45%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -32%
  • ↓ onboardingNewWallet/tbt: -85%
  • ↓ onboardingNewWallet/total: -66%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -48%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.26 MiB +1.01 KiB +0.01%
🚨 ui 19.42 MiB +4.36 KiB +0.02%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +26 Bytes 0.00%
✅ content scripts 3.23 MiB +52 Bytes 0.00%
🚨 unzipped 79.78 MiB +6.08 KiB +0.01%
🚨 zip 23.86 MiB +1.73 KiB +0.01%

@metamask-ci

metamask-ci Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor
Builds ready [7cf1438]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42225330637 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↑ loadNewAccount/lcp: +968%
  • ↑ loadNewAccount/cls: +597%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +57%
  • ↑ confirmTx/longTaskMaxDuration: +58%
  • ↑ confirmTx/tbt: +74%
  • ↓ confirmTx/inp: -21%
  • ↑ confirmTx/lcp: +1003%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +87%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +68%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +47%
  • ↑ bridgeUserActions/tbt: +35%
  • ↑ bridgeUserActions/total: +15%
  • ↑ bridgeUserActions/lcp: +970%
  • ↑ bridgeUserActions/cls: +636%
  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/inp: -18%
  • ↑ loadNewAccount/fcp: +20%
  • ↑ loadNewAccount/lcp: +1226%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -13%
  • ↑ confirmTx/fcp: +29%
  • ↑ confirmTx/lcp: +1370%
  • ↑ bridgeUserActions/bridge_load_page: +300%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +152%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +52%
  • ↑ bridgeUserActions/inp: +69%
  • ↓ bridgeUserActions/fcp: -31%
  • ↑ bridgeUserActions/lcp: +1283%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 loadNewAccount/FCP: p75 2.1s
  • 🟡 confirmTx/FCP: p75 2.2s
  • 🟡 confirmTx/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +30%
  • ↑ startupStandardHome/load: +50%
  • ↑ startupStandardHome/domContentLoaded: +50%
  • ↓ startupStandardHome/firstPaint: -40%
  • ↓ startupStandardHome/backgroundConnect: -16%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -64%
  • ↑ startupStandardHome/loadScripts: +49%
  • ↑ startupStandardHome/setupStore: +69%
  • ↑ startupStandardHome/longTaskTotalDuration: +46%
  • ↑ startupStandardHome/longTaskMaxDuration: +64%
  • ↑ startupStandardHome/tbt: +56%
  • ↓ startupStandardHome/inp: -24%
  • ↑ startupStandardHome/fcp: +40%
  • ↑ startupStandardHome/lcp: +528%
  • ↓ startupStandardHome/cls: -72%
  • ↑ startupStandardHome/domInteractive: +43%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/fcp: +46%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +26%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +25%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +32%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +19%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -91%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -12%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +12%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -12%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -22%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -78%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -74%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -49%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +123 Bytes 0.00%
✅ ui 19.42 MiB -914 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB -7 Bytes 0.00%
✅ content scripts 3.23 MiB -14 Bytes 0.00%
✅ unzipped 79.78 MiB -807 Bytes 0.00%
✅ zip 23.86 MiB -388 Bytes 0.00%

@sonarqubecloud

sonarqubecloud Bot commented Nov 6, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Nov 6, 2026
@n3ps
n3ps added this pull request to the merge queue Nov 6, 2026
@n3ps n3ps added the retry-ci Tells GitHub Actions to retry failed jobs, label removed automatically before the retry label Nov 6, 2026
Merged via the queue into main with commit 50b4c75 Nov 6, 2026
144 of 145 checks passed
@n3ps
n3ps deleted the n3ps/simplify-bottom-nav branch November 6, 2026 15:46
@github-project-automation github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Nov 6, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 6, 2026
@github-actions github-actions Bot removed the retry-ci Tells GitHub Actions to retry failed jobs, label removed automatically before the retry label Nov 6, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.58.0 on PR, as PR was added to branch 13.58.0 when release was cut.

This branch was previously deployed

1 inactive deployment
pr-comment — 7cf14389 Deployed Nov 6, 2026 by n3ps via Publish prerelease / Publish prerelease #173265
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-M team-core-extension-ux Core Extension UX team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants