Repository navigation
refactor(ui): simplify bottom nav layout - #47685
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (2 files, +19 -45)
|
There was a problem hiding this comment.
Layout / routing review
The route split (MainLayout vs ContentLayout) looks reasonable for replacing runtime useBottomNavBar checks. One regression to fix before merge.
No issues from the chrome extension (manifest / background) checklist — changes are UI-only.
Sent by Cursor Automation: Modern web guidance
There was a problem hiding this comment.
- Remove this location-based logic
| ], | ||
| }, | ||
| { | ||
| element: <ContentLayout />, |
There was a problem hiding this comment.
- And use declarative layouts instead
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5204bdf. Configure here.
Builds ready [805f0a1]
⚡ Performance Benchmarks (Total: 🟢 10 pass · 🟡 1 warn · 🔴 2 fail)
Bundle Size Diffs
|
Builds ready [2095186]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 3 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [7cf1438]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)
Bundle Size Diffs
|
|
|
No release label on PR. Adding release label release-13.58.0 on PR, as PR was added to branch 13.58.0 when release was cut. |





Description
Simplify the bottom nav conditional logic. Use declarative layouts instead of custom helpers
Prep work for wide layout
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Touches global routing/layout composition for many authenticated screens, which can regress scroll behavior or chrome visibility if route groupings are wrong.
Overview
Conditionally rendered shell UI is replaced with route-declarative layouts, removing
useBottomNavBar,isMainNavRoute, and their tests.MainLayoutalways mountsAppHeader, scroll shell, outlet, andBottomNavBar, so tab routes keep a consistent frame without runtime toggles.A new
ContentLayoutwraps secondary Money flows (MONEY_*beyond home) in a scrollable main region without the bottom nav/header chrome.Homedrops duplicate header rendering and split scroll behaviors, standardizing on the stickyDappConnectionControlBarpattern for all home states.AppHeaderUnlockedContentalways disables the account picker on cross-chain swap paths, since that flow no longer shares the bottom-nav shell.Reviewed by Cursor Bugbot for commit 7cf1438. Bugbot is set up for automated code reviews on this repo. Configure here.