Skip to content

chore(multichain): remove unused modal stylesheets - #47718

Merged
georgewrmarshall merged 1 commit into
mainfrom
cursor/remove-dead-code-multichain-stylesheets-20261109
Nov 10, 2026
Merged

georgewrmarshall merged 1 commit into
mainfrom
cursor/remove-dead-code-multichain-stylesheets-20261109

Conversation

@georgewrmarshall

@georgewrmarshall georgewrmarshall commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Description

Deletes two multichain stylesheets whose every class selector is unused, and drops their @imports from ui/components/multichain/multichain-components.scss. Neither sheet defines a mixin, function, or placeholder. The Import NFTs form and Add block explorer modal components stay; they style themselves with Tailwind and other live classes (networks-form__footer).

Owner set: @MetaMask/core-extension-ux (ui/components/multichain/, including the stylesheet barrel).

path removed (file / symbol / class) why dead
ui/components/multichain/import-nfts-modal/index.scss file, .add-nft, .add-nft__close unused class selector
ui/components/multichain/network-list-menu/add-block-explorer-modal/index.scss file, .add-block-explorer-modal, .add-block-explorer-modal__footer unused class selector
ui/components/multichain/multichain-components.scss @import 'import-nfts-modal' and @import 'network-list-menu/add-block-explorer-modal' cascade from the deleted sheets

No user-facing behavior change.

Docs/comments updated: none

Checks: yarn lint:styles, yarn test:unit --coverage=false ui/components/multichain/import-nfts-modal ui/components/multichain/network-list-menu (no snapshot updates). No JS/TS files changed, so yarn lint:tsc was not required.

Changelog

CHANGELOG entry: null

Related issues

Refs: proactive dead-code cleanup (extension counterpart of metamask-mobile#37948).

Manual testing steps

N/A — deletes unreachable code. There is no user-facing behavior to click through.

Screenshots/Recordings

N/A — no UI change.

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Dead stylesheet deletion only; no JS/TS or user-facing behavior change.

Overview
Removes two multichain SCSS files whose BEM classes (.add-nft, .add-block-explorer-modal) are no longer referenced, and drops their @import lines from multichain-components.scss. Import NFTs and Add block explorer modals are unchanged; they already style via Tailwind and shared patterns like networks-form__footer.

Reviewed by Cursor Bugbot for commit e670bf0. Bugbot is set up for automated code reviews on this repo. Configure here.

The import NFT and add block explorer stylesheets only define class selectors nothing applies.

Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
@georgewrmarshall
georgewrmarshall requested a review from a team as a code owner November 9, 2026 09:51
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Nov 9, 2026 — with Cursor
@georgewrmarshall georgewrmarshall self-assigned this Nov 9, 2026
@github-actions github-actions Bot added the size-S label Nov 9, 2026
@metamask-ci

metamask-ci Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (3 files, +0 -20)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 import-nfts-modal/
          • 📄 index.scss +0 -9
        • 📁 network-list-menu/
          • 📁 add-block-explorer-modal/
            • 📄 index.scss +0 -9
          • 📄 multichain-components.scss +0 -2

@metamask-ci

metamask-ci Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor
Builds ready [e670bf0]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 1 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42598252359 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +178%
  • ↑ loadNewAccount/total: +178%
  • ↓ loadNewAccount/inp: -48%
  • ↓ loadNewAccount/fcp: -37%
  • ↑ loadNewAccount/lcp: +517%
  • ↑ loadNewAccount/cls: +294%
  • ↓ confirmTx/longTaskTotalDuration: -18%
  • ↓ confirmTx/tbt: -27%
  • ↓ confirmTx/inp: -52%
  • ↓ confirmTx/fcp: -37%
  • ↑ confirmTx/lcp: +529%
  • ↓ confirmTx/cls: -14%
  • ↓ bridgeUserActions/bridge_load_page: -13%
  • ↓ bridgeUserActions/bridge_load_asset_picker: -29%
  • ↓ bridgeUserActions/longTaskTotalDuration: -38%
  • ↓ bridgeUserActions/longTaskMaxDuration: -41%
  • ↓ bridgeUserActions/tbt: -82%
  • ↓ bridgeUserActions/total: -13%
  • ↓ bridgeUserActions/inp: -41%
  • ↓ bridgeUserActions/fcp: -36%
  • ↑ bridgeUserActions/lcp: +533%
  • ↑ bridgeUserActions/cls: +633%
  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↑ loadNewAccount/inp: +79%
  • ↓ loadNewAccount/fcp: -52%
  • ↑ loadNewAccount/lcp: +897%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -67%
  • ↑ confirmTx/lcp: +844%
  • ↑ bridgeUserActions/bridge_load_page: +91%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +69%
  • ↓ bridgeUserActions/bridge_search_token: -13%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +12%
  • ↓ bridgeUserActions/fcp: -72%
  • ↑ bridgeUserActions/lcp: +870%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/load: +26%
  • ↑ startupStandardHome/domContentLoaded: +26%
  • ↓ startupStandardHome/domInteractive: -20%
  • ↓ startupStandardHome/firstPaint: -55%
  • ↓ startupStandardHome/backgroundConnect: -30%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -64%
  • ↑ startupStandardHome/loadScripts: +25%
  • ↑ startupStandardHome/setupStore: +17%
  • ↑ startupStandardHome/longTaskTotalDuration: +22%
  • ↑ startupStandardHome/longTaskMaxDuration: +43%
  • ↑ startupStandardHome/tbt: +28%
  • ↓ startupStandardHome/inp: -43%
  • ↓ startupStandardHome/fcp: -15%
  • ↑ startupStandardHome/lcp: +282%
  • ↓ startupStandardHome/cls: -72%
  • ↑ startupStandardHome/domInteractive: +38%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/fcp: +41%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -31%
  • ↓ onboardingImportWallet/confirmSrpToPwForm: -27%
  • ↓ onboardingImportWallet/pwFormToMetricsScreen: -17%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -47%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -86%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +33%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +18%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -69%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -65%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -62%
  • ↓ dappPageLoad/domContentLoaded: -22%
  • ↓ dappPageLoad/firstPaint: -42%
  • ↓ dappPageLoad/firstContentfulPaint: -42%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +130 Bytes 0.00%
✅ ui 19.42 MiB -125 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.77 MiB -330 Bytes 0.00%
✅ zip 23.86 MiB -86 Bytes 0.00%

@sonarqubecloud

sonarqubecloud Bot commented Nov 9, 2026

Copy link
Copy Markdown

@georgewrmarshall
georgewrmarshall added this pull request to the merge queue Nov 10, 2026
Merged via the queue into main with commit 93f6c52 Nov 10, 2026
380 of 384 checks passed
@georgewrmarshall
georgewrmarshall deleted the cursor/remove-dead-code-multichain-stylesheets-20261109 branch November 10, 2026 23:32
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 10, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.58.0 on PR, as PR was added to branch 13.58.0 when release was cut.

This branch was previously deployed

1 inactive deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-S team-design-system All issues relating to design system in Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants