Repository navigation
chore(multichain): remove unused modal stylesheets - #47718
Merged
georgewrmarshall merged 1 commit intoNov 10, 2026
Merged
georgewrmarshall merged 1 commit into
georgewrmarshall merged 1 commit into
Conversation
The import NFT and add block explorer stylesheets only define class selectors nothing applies. Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
georgewrmarshall
temporarily deployed
to
pr-comment
November 9, 2026 10:05 — with
GitHub Actions
Inactive
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (3 files, +0 -20)
|
georgewrmarshall
temporarily deployed
to
pr-comment
November 9, 2026 10:19 — with
GitHub Actions
Inactive
Contributor
Builds ready [e670bf0]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 1 warn · 🔴 4 fail)
Bundle Size Diffs
|
|
georgewrmarshall
enabled auto-merge
November 10, 2026 19:00
n3ps
approved these changes
Nov 10, 2026
vinnyhoward
approved these changes
Nov 10, 2026
georgewrmarshall
deleted the
cursor/remove-dead-code-multichain-stylesheets-20261109
branch
November 10, 2026 23:32
Contributor
|
No release label on PR. Adding release label release-13.58.0 on PR, as PR was added to branch 13.58.0 when release was cut. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Deletes two multichain stylesheets whose every class selector is unused, and drops their
@imports fromui/components/multichain/multichain-components.scss. Neither sheet defines a mixin, function, or placeholder. The Import NFTs form and Add block explorer modal components stay; they style themselves with Tailwind and other live classes (networks-form__footer).Owner set:
@MetaMask/core-extension-ux(ui/components/multichain/, including the stylesheet barrel).ui/components/multichain/import-nfts-modal/index.scss.add-nft,.add-nft__closeui/components/multichain/network-list-menu/add-block-explorer-modal/index.scss.add-block-explorer-modal,.add-block-explorer-modal__footerui/components/multichain/multichain-components.scss@import 'import-nfts-modal'and@import 'network-list-menu/add-block-explorer-modal'No user-facing behavior change.
Docs/comments updated: none
Checks:
yarn lint:styles,yarn test:unit --coverage=false ui/components/multichain/import-nfts-modal ui/components/multichain/network-list-menu(no snapshot updates). No JS/TS files changed, soyarn lint:tscwas not required.Changelog
CHANGELOG entry: null
Related issues
Refs: proactive dead-code cleanup (extension counterpart of metamask-mobile#37948).
Manual testing steps
N/A — deletes unreachable code. There is no user-facing behavior to click through.
Screenshots/Recordings
N/A — no UI change.
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Dead stylesheet deletion only; no JS/TS or user-facing behavior change.
Overview
Removes two multichain SCSS files whose BEM classes (
.add-nft,.add-block-explorer-modal) are no longer referenced, and drops their@importlines frommultichain-components.scss. Import NFTs and Add block explorer modals are unchanged; they already style via Tailwind and shared patterns likenetworks-form__footer.Reviewed by Cursor Bugbot for commit e670bf0. Bugbot is set up for automated code reviews on this repo. Configure here.