Repository navigation
chore(permissions-connect): remove unused snap update scroll button class - #47720
Merged
georgewrmarshall merged 1 commit intoNov 10, 2026
Merged
Conversation
…lass The update screen applies snap-install__scroll-button, so snap-update__scroll-button is unused. Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
georgewrmarshall
temporarily deployed
to
pr-comment
November 9, 2026 09:51 — with
GitHub Actions
Inactive
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (1 files, +0 -9)
🫰 @MetaMask/core-platform (1 files, +0 -9)
|
georgewrmarshall
temporarily deployed
to
pr-comment
November 9, 2026 10:05 — with
GitHub Actions
Inactive
Contributor
Builds ready [a511fc8]
⚡ Performance Benchmarks (Total: 🟢 10 pass · 🟡 1 warn · 🔴 2 fail)
Bundle Size Diffs
|
|
amandaye0h
approved these changes
Nov 10, 2026
AndyMBridges
approved these changes
Nov 10, 2026
georgewrmarshall
deleted the
cursor/remove-dead-code-snap-update-styles-20261109
branch
November 10, 2026 19:32
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Removes the unused
.snap-update__scroll-buttonruleset. The snap update screen appliessnap-update__scroll-button-areaandsnap-install__scroll-button(the install stylesheet). JSX is unchanged.Owner set:
@MetaMask/core-extension-ux.ui/pages/permissions-connect/is the last matching CODEOWNERS rule and wins over**/snaps/**.ui/pages/permissions-connect/snaps/snap-update/index.scss.snap-update__scroll-buttonNo user-facing behavior change.
Docs/comments updated: none
Checks:
yarn stylelinton the stylesheet. The directory has no unit tests (yarn test:unit --coverage=false --passWithNoTestsreports none). No JS/TS files changed, soyarn lint:tscwas not required. No snapshots.Changelog
CHANGELOG entry: null
Related issues
Refs: proactive dead-code cleanup (extension counterpart of metamask-mobile#37948).
Manual testing steps
N/A — deletes unreachable code. There is no user-facing behavior to click through.
Screenshots/Recordings
N/A — no UI change.
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Stylesheet-only deletion of an unused selector; no runtime or behavioral impact.
Overview
Removes the dead
.snap-update__scroll-buttonruleset from the snap update stylesheet. The update flow still usessnap-update__scroll-button-areafor the sticky footer gradient and borrowssnap-install__scroll-buttonfrom the install snap styles for the actual control—no JSX or visible UI changes.Reviewed by Cursor Bugbot for commit a511fc8. Bugbot is set up for automated code reviews on this repo. Configure here.