Skip to content

chore(permissions-connect): remove unused snap update scroll button class - #47720

Merged
georgewrmarshall merged 1 commit into
mainfrom
cursor/remove-dead-code-snap-update-styles-20261109
Nov 10, 2026
Merged

georgewrmarshall merged 1 commit into
mainfrom
cursor/remove-dead-code-snap-update-styles-20261109

Conversation

@georgewrmarshall

@georgewrmarshall georgewrmarshall commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Description

Removes the unused .snap-update__scroll-button ruleset. The snap update screen applies snap-update__scroll-button-area and snap-install__scroll-button (the install stylesheet). JSX is unchanged.

Owner set: @MetaMask/core-extension-ux. ui/pages/permissions-connect/ is the last matching CODEOWNERS rule and wins over **/snaps/**.

path removed (file / symbol / class) why dead
ui/pages/permissions-connect/snaps/snap-update/index.scss .snap-update__scroll-button unused class selector

No user-facing behavior change.

Docs/comments updated: none

Checks: yarn stylelint on the stylesheet. The directory has no unit tests (yarn test:unit --coverage=false --passWithNoTests reports none). No JS/TS files changed, so yarn lint:tsc was not required. No snapshots.

Changelog

CHANGELOG entry: null

Related issues

Refs: proactive dead-code cleanup (extension counterpart of metamask-mobile#37948).

Manual testing steps

N/A — deletes unreachable code. There is no user-facing behavior to click through.

Screenshots/Recordings

N/A — no UI change.

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Stylesheet-only deletion of an unused selector; no runtime or behavioral impact.

Overview
Removes the dead .snap-update__scroll-button ruleset from the snap update stylesheet. The update flow still uses snap-update__scroll-button-area for the sticky footer gradient and borrows snap-install__scroll-button from the install snap styles for the actual control—no JSX or visible UI changes.

Reviewed by Cursor Bugbot for commit a511fc8. Bugbot is set up for automated code reviews on this repo. Configure here.

…lass

The update screen applies snap-install__scroll-button, so snap-update__scroll-button is unused.

Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
@georgewrmarshall
georgewrmarshall requested a review from a team as a code owner November 9, 2026 09:51
@georgewrmarshall georgewrmarshall added team-design-system All issues relating to design system in Extension and removed size-XS labels Nov 9, 2026 — with Cursor
@georgewrmarshall georgewrmarshall self-assigned this Nov 9, 2026
@metamask-ci

metamask-ci Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (1 files, +0 -9)
  • 📁 ui/
    • 📁 pages/
      • 📁 permissions-connect/
        • 📁 snaps/
          • 📁 snap-update/
            • 📄 index.scss +0 -9

🫰 @MetaMask/core-platform (1 files, +0 -9)
  • 📁 ui/
    • 📁 pages/
      • 📁 permissions-connect/
        • 📁 snaps/
          • 📁 snap-update/
            • 📄 index.scss +0 -9

@metamask-ci

metamask-ci Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor
Builds ready [a511fc8]
⚡ Performance Benchmarks (Total: 🟢 10 pass · 🟡 1 warn · 🔴 2 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42596573787 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -48%
  • ↓ loadNewAccount/fcp: -34%
  • ↑ loadNewAccount/lcp: +553%
  • ↑ loadNewAccount/cls: +294%
  • ↓ confirmTx/tbt: -13%
  • ↓ confirmTx/inp: -52%
  • ↓ confirmTx/fcp: -34%
  • ↑ confirmTx/lcp: +564%
  • ↓ confirmTx/cls: -14%
  • ↓ bridgeUserActions/bridge_load_asset_picker: -10%
  • ↓ bridgeUserActions/longTaskTotalDuration: -28%
  • ↓ bridgeUserActions/longTaskMaxDuration: -32%
  • ↓ bridgeUserActions/tbt: -56%
  • ↓ bridgeUserActions/total: -10%
  • ↓ bridgeUserActions/inp: -34%
  • ↓ bridgeUserActions/fcp: -34%
  • ↑ bridgeUserActions/lcp: +554%
  • ↑ bridgeUserActions/cls: +636%
  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/fcp: -54%
  • ↑ loadNewAccount/lcp: +962%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -48%
  • ↑ confirmTx/lcp: +1037%
  • ↑ bridgeUserActions/bridge_load_page: +135%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +80%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +21%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -61%
  • ↑ bridgeUserActions/lcp: +983%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +94%
  • ↑ startupStandardHome/load: +129%
  • ↑ startupStandardHome/domContentLoaded: +130%
  • ↑ startupStandardHome/domInteractive: +32%
  • ↓ startupStandardHome/firstPaint: -53%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +128%
  • ↑ startupStandardHome/setupStore: +114%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +127%
  • ↑ startupStandardHome/longTaskMaxDuration: +129%
  • ↑ startupStandardHome/tbt: +152%
  • ↓ startupStandardHome/fcp: -47%
  • ↑ startupStandardHome/lcp: +136%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -46%
  • ↓ startupStandardHome/load: -41%
  • ↓ startupStandardHome/domContentLoaded: -43%
  • ↓ startupStandardHome/domInteractive: -61%
  • ↓ startupStandardHome/backgroundConnect: -39%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -42%
  • ↓ startupStandardHome/setupStore: -41%
  • ↓ startupStandardHome/fcp: -57%
  • ↓ startupStandardHome/lcp: -40%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +20%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +35%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +36%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +26%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -91%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -73%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -94%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -89%
  • ↓ onboardingImportWallet/tbt: -98%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -13%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -28%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -14%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -22%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -49%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -77%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -74%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -50%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +130 Bytes 0.00%
✅ ui 19.42 MiB -125 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.77 MiB -101 Bytes 0.00%
✅ zip 23.86 MiB -42 Bytes 0.00%

@sonarqubecloud

sonarqubecloud Bot commented Nov 9, 2026

Copy link
Copy Markdown

@georgewrmarshall
georgewrmarshall added this pull request to the merge queue Nov 10, 2026
Merged via the queue into main with commit 6bf53c4 Nov 10, 2026
148 checks passed
@georgewrmarshall
georgewrmarshall deleted the cursor/remove-dead-code-snap-update-styles-20261109 branch November 10, 2026 19:32
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 10, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026

This branch was previously deployed

1 inactive deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 team-design-system All issues relating to design system in Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants