Skip to content

test: flaky violations of requests tmp - #47748

Merged
seaona merged 2 commits into
mainfrom
flaky-calls-violations
Nov 9, 2026
Merged

seaona merged 2 commits into
mainfrom
flaky-calls-violations

Conversation

@seaona

@seaona seaona commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Description

This PR was merged, but it seems we still cannot remove the bitcoin infura request, price as it happens intermittently. This PR adds it back. also the cdn from ff.
https://github.com/MetaMask/metamask-extension/pull/47662/changes#diff-9bffced4e0447f709fcc14d4df73b8f903aceabea52f0ca2bc45e7a4ec3da9e7L6

It also adds another flaky request made on the onboarding.

Issues should be prevented on the app side, but until then, we add this into exceptions, so tests don't flake.
#47486

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. ci passes

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Only updates e2e privacy JSON allowlists; no production or security logic changes.

Overview
Re-adds flaky privacy-test exceptions so e2e privacy checks stop failing on intermittent network calls.

basic-functionality-off-known-violations.json again lists bitcoin-mainnet.infura.io and price.api.cx.metamask.io as known violations (the Infura call still happens sporadically after a prior removal). onboarding-allowlist.json allows content-signature-2.cdn.mozilla.net during onboarding for another flaky request.

These are temporary test allowlists until the underlying app requests are fixed (see issue #47486).

Reviewed by Cursor Bugbot for commit ef25249. Bugbot is set up for automated code reviews on this repo. Configure here.

@metamask-ci

metamask-ci Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

🕵️ @MetaMask/extension-privacy-reviewers (2 files, +3 -0)
  • 📁 test/
    • 📁 e2e/
      • 📁 tests/
        • 📁 privacy/
          • 📄 basic-functionality-off-known-violations.json +2 -0
          • 📄 onboarding-allowlist.json +1 -0

🧪 @MetaMask/qa (2 files, +3 -0)
  • 📁 test/
    • 📁 e2e/
      • 📁 tests/
        • 📁 privacy/
          • 📄 basic-functionality-off-known-violations.json +2 -0
          • 📄 onboarding-allowlist.json +1 -0

@metamask-ci metamask-ci Bot added the team-qa QA team label Nov 9, 2026
@metamask-ci

metamask-ci Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor
Builds ready [1aefce9] [reused from 300f667]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 0 warn · 🔴 2 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42644367580 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
–🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 1

⚠️ Missing data: chrome/webpack/interactionUserActions

Benchmarkfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +180%
  • ↑ loadNewAccount/total: +180%
  • ↓ loadNewAccount/inp: -40%
  • ↓ loadNewAccount/fcp: -69%
  • ↑ loadNewAccount/lcp: +848%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -21%
  • ↓ confirmTx/fcp: -70%
  • ↑ confirmTx/lcp: +1133%
  • ↑ bridgeUserActions/bridge_load_page: +86%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +25%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +16%
  • ↓ bridgeUserActions/fcp: -70%
  • ↑ bridgeUserActions/lcp: +1112%
Startup Benchmarks · Samples: 100

⚠️ Missing data: firefox/webpack/startupStandardHome

Benchmarkchrome-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +31%
  • ↑ startupStandardHome/load: +53%
  • ↑ startupStandardHome/domContentLoaded: +54%
  • ↓ startupStandardHome/firstPaint: -38%
  • ↓ startupStandardHome/backgroundConnect: -24%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -64%
  • ↑ startupStandardHome/loadScripts: +53%
  • ↑ startupStandardHome/setupStore: +62%
  • ↑ startupStandardHome/longTaskTotalDuration: +49%
  • ↑ startupStandardHome/longTaskMaxDuration: +79%
  • ↑ startupStandardHome/tbt: +63%
  • ↓ startupStandardHome/inp: -24%
  • ↑ startupStandardHome/fcp: +52%
  • ↑ startupStandardHome/lcp: +583%
  • ↓ startupStandardHome/cls: -72%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +19%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -11%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -12%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -11%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -31%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -79%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -73%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -36%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -75%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -48%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.24 MiB 0 Bytes 0.00%
✅ ui 19.44 MiB 0 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.88 MiB 0 Bytes 0.00%
✅ zip 23.96 MiB 0 Bytes 0.00%

@seaona seaona self-assigned this Nov 9, 2026
@seaona seaona added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Nov 9, 2026
@seaona
seaona marked this pull request as ready for review November 9, 2026 15:28
@seaona
seaona requested review from a team as code owners November 9, 2026 15:28
@metamask-ci

metamask-ci Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor
Builds ready [ef25249]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 2 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42646997294 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +180%
  • ↑ loadNewAccount/total: +180%
  • ↓ loadNewAccount/inp: -40%
  • ↓ loadNewAccount/fcp: -17%
  • ↑ loadNewAccount/lcp: +718%
  • ↑ loadNewAccount/cls: +294%
  • ↑ confirmTx/longTaskTotalDuration: +11%
  • ↑ confirmTx/longTaskMaxDuration: +27%
  • ↑ confirmTx/tbt: +29%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -18%
  • ↑ confirmTx/lcp: +727%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +40%
  • ↓ bridgeUserActions/longTaskMaxDuration: -12%
  • ↓ bridgeUserActions/inp: -19%
  • ↓ bridgeUserActions/fcp: -17%
  • ↑ bridgeUserActions/lcp: +724%
  • ↑ bridgeUserActions/cls: +632%
  • ↑ loadNewAccount/load_new_account: +180%
  • ↑ loadNewAccount/total: +180%
  • ↑ loadNewAccount/inp: +12%
  • ↓ loadNewAccount/fcp: -64%
  • ↑ loadNewAccount/lcp: +844%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -29%
  • ↓ confirmTx/fcp: -67%
  • ↑ confirmTx/lcp: +917%
  • ↑ bridgeUserActions/bridge_load_page: +167%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +63%
  • ↓ bridgeUserActions/bridge_search_token: -12%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +17%
  • ↑ bridgeUserActions/inp: +99%
  • ↓ bridgeUserActions/fcp: -68%
  • ↑ bridgeUserActions/lcp: +1179%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 bridgeUserActions/INP: p75 216ms
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +33%
  • ↑ startupStandardHome/load: +55%
  • ↑ startupStandardHome/domContentLoaded: +56%
  • ↓ startupStandardHome/firstPaint: -40%
  • ↓ startupStandardHome/backgroundConnect: -23%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +55%
  • ↑ startupStandardHome/setupStore: +82%
  • ↑ startupStandardHome/longTaskTotalDuration: +52%
  • ↑ startupStandardHome/longTaskMaxDuration: +79%
  • ↑ startupStandardHome/tbt: +66%
  • ↓ startupStandardHome/inp: -24%
  • ↑ startupStandardHome/fcp: +51%
  • ↑ startupStandardHome/lcp: +578%
  • ↓ startupStandardHome/cls: -72%
  • ↑ startupStandardHome/load: +11%
  • ↓ startupStandardHome/domInteractive: -18%
  • ↑ startupStandardHome/backgroundConnect: +13%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/loadScripts: +11%
  • ↑ startupStandardHome/lcp: +13%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/confirmSrpToPwForm: +15%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +14%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +11%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +29%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +11%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -70%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -70%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -28%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -66%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -49%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.24 MiB -21.34 KiB -0.14%
🚨 ui 19.44 MiB +2.38 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB -323 Bytes -0.01%
✅ content scripts 3.23 MiB -654 Bytes -0.02%
🚨 unzipped 79.88 MiB +77.53 KiB +0.09%
🚨 zip 23.96 MiB +97.94 KiB +0.40%

@sonarqubecloud

sonarqubecloud Bot commented Nov 9, 2026

Copy link
Copy Markdown

@seaona
seaona added this pull request to the merge queue Nov 9, 2026
Merged via the queue into main with commit 2bf4fc8 Nov 9, 2026
148 checks passed
@seaona
seaona deleted the flaky-calls-violations branch November 9, 2026 17:02
@metamask-ci metamask-ci Bot mentioned this pull request Nov 13, 2026
10 of 18 tasks
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026

This branch was previously deployed

1 inactive deployment
pr-comment — ef252497 Deployed Nov 9, 2026 by seaona via Publish prerelease / Publish prerelease #173547
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flaky tests no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-XS team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants