You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Note
Low Risk
Only updates e2e privacy JSON allowlists; no production or security logic changes.
Overview Re-adds flaky privacy-test exceptions so e2e privacy checks stop failing on intermittent network calls.
basic-functionality-off-known-violations.json again lists bitcoin-mainnet.infura.io and price.api.cx.metamask.io as known violations (the Infura call still happens sporadically after a prior removal). onboarding-allowlist.json allows content-signature-2.cdn.mozilla.net during onboarding for another flaky request.
These are temporary test allowlists until the underlying app requests are fixed (see issue #47486).
Reviewed by Cursor Bugbot for commit ef25249. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaky testsno-changelogno-changelog Indicates no external facing user changes, therefore no changelog documentation neededrelease-13.58.0Issue or pull request that will be included in release 13.58.0size-XSteam-qaQA team
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR was merged, but it seems we still cannot remove the bitcoin infura request, price as it happens intermittently. This PR adds it back. also the cdn from ff.
https://github.com/MetaMask/metamask-extension/pull/47662/changes#diff-9bffced4e0447f709fcc14d4df73b8f903aceabea52f0ca2bc45e7a4ec3da9e7L6
It also adds another flaky request made on the onboarding.
Issues should be prevented on the app side, but until then, we add this into exceptions, so tests don't flake.
#47486
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Only updates e2e privacy JSON allowlists; no production or security logic changes.
Overview
Re-adds flaky privacy-test exceptions so e2e privacy checks stop failing on intermittent network calls.
basic-functionality-off-known-violations.jsonagain listsbitcoin-mainnet.infura.ioandprice.api.cx.metamask.ioas known violations (the Infura call still happens sporadically after a prior removal).onboarding-allowlist.jsonallowscontent-signature-2.cdn.mozilla.netduring onboarding for another flaky request.These are temporary test allowlists until the underlying app requests are fixed (see issue #47486).
Reviewed by Cursor Bugbot for commit ef25249. Bugbot is set up for automated code reviews on this repo. Configure here.