Skip to content

fix(carousel): keep banner slot from collapsing before the caught-up message - #47769

Merged
angelapotter merged 3 commits into
mainfrom
fix/ceux-1454-banner-dismiss-stutter
Nov 12, 2026
Merged

angelapotter merged 3 commits into
mainfrom
fix/ceux-1454-banner-dismiss-stutter

Conversation

@angelapotter

@angelapotter angelapotter commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Description

Dismissing the last home banner made the content below jump. The carousel unmounted as soon as the last slide was dismissed, then "You're all caught up!" mounted about 300ms later (after the exit animation delay) and folded away. The banner slot dropped to zero height, popped back, then collapsed again.

The caught-up message now mounts in the same render the last slide leaves, so the slot keeps its height until the fold. Nothing changes for the fold timing or for new slides arriving afterwards.

Changelog

CHANGELOG entry: Fixed content jumping when dismissing the last banner on the home screen

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/CEUX-1454

Manual testing steps

  1. Run a build with Contentful banners enabled (CONTENTFUL_ACCESS_SPACE_ID and CONTENTFUL_ACCESS_TOKEN) and unlock the wallet.
  2. On the home screen, dismiss each banner with its X until the last one.
  3. Watch the space below the banner when the last one is dismissed: "You're all caught up!" should already be in the slot, then fold once. It should not collapse, reappear, and collapse again.

Screenshots/Recordings

Before

Not captured.

After

Screen.Recording.2026-11-10.at.9.04.41.AM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
UI-only carousel empty-state timing with regression tests; no auth, data, or payment paths touched.

Overview
Fixes layout jump when the last home banner is dismissed by mounting the "all caught up" empty state in the same render the final slide disappears, instead of waiting for the carousel exit animation callback.

CarouselWithEmptyState now treats lastSlideDismissed like the fold path and renders EmptyStateComponent immediately so the banner slot stays at full height until the fold runs. useTransitionToEmpty stores onEmptyStateComplete in a ref so home-screen re-renders during the hold do not reset the 100ms stabilize → fold sequence.

Adds RTL tests in carousel-wrapper.test.tsx for never-had-slides, hold/collapse timing, and recovery when slides return.

Reviewed by Cursor Bugbot for commit be91769. Bugbot is set up for automated code reviews on this repo. Configure here.

…message

Dismissing the last banner removed the carousel immediately, then mounted the caught-up message after the exit animation delay. The slot dropped to zero height and popped back, so content below jumped up, down, then up again. Mount the caught-up message in the same render the last slide leaves so the slot holds its height until the fold.
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the size-M label Nov 9, 2026
@metamask-ci

metamask-ci Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (3 files, +129 -6)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 carousel/
          • 📁 __tests__/
            • 📄 carousel-wrapper.test.tsx +106 -0
          • 📁 animations/
            • 📄 useTransitionToEmpty.ts +14 -4
            • 📄 carousel-wrapper.tsx +9 -2

@metamask-ci metamask-ci Bot added the team-core-extension-ux Core Extension UX team label Nov 9, 2026
@metamask-ci

metamask-ci Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor
Builds ready [e2583da]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 1 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42694400799 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +179%
  • ↑ loadNewAccount/total: +179%
  • ↓ loadNewAccount/inp: -40%
  • ↓ loadNewAccount/fcp: -30%
  • ↑ loadNewAccount/lcp: +587%
  • ↑ loadNewAccount/cls: +297%
  • ↓ confirmTx/tbt: -14%
  • ↓ confirmTx/inp: -52%
  • ↓ confirmTx/fcp: -34%
  • ↑ confirmTx/lcp: +566%
  • ↓ bridgeUserActions/bridge_load_asset_picker: -16%
  • ↓ bridgeUserActions/longTaskTotalDuration: -29%
  • ↓ bridgeUserActions/longTaskMaxDuration: -35%
  • ↓ bridgeUserActions/tbt: -59%
  • ↓ bridgeUserActions/total: -11%
  • ↓ bridgeUserActions/inp: -34%
  • ↓ bridgeUserActions/fcp: -32%
  • ↑ bridgeUserActions/lcp: +572%
  • ↑ bridgeUserActions/cls: +634%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -18%
  • ↑ loadNewAccount/fcp: +16%
  • ↑ loadNewAccount/lcp: +1268%
  • ↑ confirmTx/confirm_tx: +10%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/total: +10%
  • ↓ confirmTx/inp: -13%
  • ↑ confirmTx/fcp: +22%
  • ↑ confirmTx/lcp: +1340%
  • ↑ bridgeUserActions/bridge_load_page: +229%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +109%
  • ↑ bridgeUserActions/bridge_search_token: +25%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +53%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -37%
  • ↑ bridgeUserActions/lcp: +1272%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 confirmTx/FCP: p75 2.1s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +50%
  • ↑ startupStandardHome/load: +76%
  • ↑ startupStandardHome/domContentLoaded: +76%
  • ↓ startupStandardHome/firstPaint: -58%
  • ↓ startupStandardHome/backgroundConnect: -12%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +75%
  • ↑ startupStandardHome/setupStore: +108%
  • ↑ startupStandardHome/longTaskTotalDuration: +71%
  • ↑ startupStandardHome/longTaskMaxDuration: +83%
  • ↑ startupStandardHome/tbt: +86%
  • ↓ startupStandardHome/inp: -18%
  • ↓ startupStandardHome/fcp: -57%
  • ↑ startupStandardHome/lcp: +93%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -27%
  • ↓ startupStandardHome/load: -21%
  • ↓ startupStandardHome/domContentLoaded: -24%
  • ↓ startupStandardHome/domInteractive: -48%
  • ↓ startupStandardHome/backgroundConnect: -16%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -22%
  • ↓ startupStandardHome/setupStore: -30%
  • ↓ startupStandardHome/fcp: -34%
  • ↓ startupStandardHome/lcp: -19%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -16%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -19%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -10%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +28%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -69%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -70%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -29%
  • ↓ onboardingNewWallet/tbt: -97%
  • ↓ onboardingNewWallet/total: -65%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -50%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.24 MiB +130 Bytes 0.00%
✅ ui 19.44 MiB -363 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.87 MiB -228 Bytes 0.00%
✅ zip 23.96 MiB -67 Bytes 0.00%

@angelapotter
angelapotter marked this pull request as ready for review November 10, 2026 17:07
@metamask-ci

metamask-ci Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor
Builds ready [fc3f3aa]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 2 warn · 🔴 2 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42861663723 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/inp: -18%
  • ↑ loadNewAccount/lcp: +970%
  • ↑ loadNewAccount/cls: +297%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +60%
  • ↑ confirmTx/longTaskMaxDuration: +58%
  • ↑ confirmTx/tbt: +80%
  • ↓ confirmTx/inp: -13%
  • ↑ confirmTx/lcp: +952%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +145%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +27%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +85%
  • ↑ bridgeUserActions/longTaskMaxDuration: +40%
  • ↑ bridgeUserActions/tbt: +162%
  • ↑ bridgeUserActions/total: +21%
  • ↑ bridgeUserActions/lcp: +907%
  • ↑ bridgeUserActions/cls: +610%
  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↑ loadNewAccount/inp: +72%
  • ↑ loadNewAccount/lcp: +1007%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -29%
  • ↓ confirmTx/fcp: -56%
  • ↑ confirmTx/lcp: +1083%
  • ↑ bridgeUserActions/bridge_load_page: +195%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +67%
  • ↑ bridgeUserActions/bridge_search_token: +19%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +33%
  • ↑ bridgeUserActions/inp: +62%
  • ↓ bridgeUserActions/fcp: -56%
  • ↑ bridgeUserActions/lcp: +1005%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +45%
  • ↑ startupStandardHome/load: +69%
  • ↑ startupStandardHome/domContentLoaded: +70%
  • ↓ startupStandardHome/firstPaint: -48%
  • ↓ startupStandardHome/backgroundConnect: -18%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -64%
  • ↑ startupStandardHome/loadScripts: +69%
  • ↑ startupStandardHome/setupStore: +82%
  • ↑ startupStandardHome/longTaskTotalDuration: +65%
  • ↑ startupStandardHome/longTaskMaxDuration: +72%
  • ↑ startupStandardHome/tbt: +79%
  • ↓ startupStandardHome/inp: -24%
  • ↑ startupStandardHome/lcp: +377%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +24%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +50%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +37%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +18%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -91%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -95%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -91%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +21%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +13%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -70%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -66%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -61%
  • ↓ dappPageLoad/domContentLoaded: -20%
  • ↓ dappPageLoad/firstPaint: -47%
  • ↓ dappPageLoad/firstContentfulPaint: -47%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.21 MiB +115 Bytes 0.00%
✅ ui 19.48 MiB -363 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB 0 Bytes 0.00%
✅ content scripts 3.22 MiB 0 Bytes 0.00%
✅ unzipped 79.9 MiB -243 Bytes 0.00%
✅ zip 24.01 MiB -49 Bytes 0.00%

react-hooks/refs rejects writing the ref during render, which failed lint.

Co-authored-by: Cursor <cursoragent@cursor.com>
@metamask-ci

metamask-ci Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor
Builds ready [be91769]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 2 warn · 🔴 2 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42878158944 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +179%
  • ↑ loadNewAccount/total: +179%
  • ↓ loadNewAccount/inp: -33%
  • ↓ loadNewAccount/fcp: -26%
  • ↑ loadNewAccount/lcp: +625%
  • ↑ loadNewAccount/cls: +297%
  • ↓ confirmTx/inp: -44%
  • ↓ confirmTx/fcp: -30%
  • ↑ confirmTx/lcp: +604%
  • ↓ confirmTx/cls: -14%
  • ↓ bridgeUserActions/bridge_load_page: -15%
  • ↓ bridgeUserActions/bridge_load_asset_picker: -18%
  • ↓ bridgeUserActions/longTaskTotalDuration: -35%
  • ↓ bridgeUserActions/longTaskMaxDuration: -35%
  • ↓ bridgeUserActions/tbt: -75%
  • ↓ bridgeUserActions/inp: -34%
  • ↓ bridgeUserActions/fcp: -33%
  • ↑ bridgeUserActions/lcp: +558%
  • ↑ bridgeUserActions/cls: +634%
  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -25%
  • ↓ loadNewAccount/fcp: -33%
  • ↑ loadNewAccount/lcp: +1219%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -13%
  • ↓ confirmTx/fcp: -35%
  • ↑ confirmTx/lcp: +1312%
  • ↑ bridgeUserActions/bridge_load_page: +278%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +139%
  • ↑ bridgeUserActions/bridge_search_token: +23%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +56%
  • ↑ bridgeUserActions/inp: +62%
  • ↑ bridgeUserActions/fcp: +14%
  • ↑ bridgeUserActions/lcp: +1255%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +14%
  • ↑ startupStandardHome/load: +34%
  • ↑ startupStandardHome/domContentLoaded: +34%
  • ↓ startupStandardHome/domInteractive: -14%
  • ↓ startupStandardHome/firstPaint: -53%
  • ↓ startupStandardHome/backgroundConnect: -30%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -64%
  • ↑ startupStandardHome/loadScripts: +33%
  • ↑ startupStandardHome/longTaskTotalDuration: +28%
  • ↑ startupStandardHome/longTaskMaxDuration: +52%
  • ↑ startupStandardHome/tbt: +36%
  • ↓ startupStandardHome/inp: -37%
  • ↑ startupStandardHome/fcp: +30%
  • ↑ startupStandardHome/lcp: +483%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -31%
  • ↓ startupStandardHome/load: -25%
  • ↓ startupStandardHome/domContentLoaded: -27%
  • ↓ startupStandardHome/domInteractive: -48%
  • ↓ startupStandardHome/backgroundConnect: -18%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -26%
  • ↓ startupStandardHome/setupStore: -35%
  • ↓ startupStandardHome/fcp: -33%
  • ↓ startupStandardHome/lcp: -24%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +16%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +26%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +36%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +20%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -94%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -90%
  • ↓ onboardingImportWallet/tbt: -99%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +18%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +33%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +12%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +11%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -71%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -74%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -38%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -66%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -65%
  • ↓ dappPageLoad/domContentLoaded: -30%
  • ↓ dappPageLoad/firstPaint: -47%
  • ↓ dappPageLoad/firstContentfulPaint: -47%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.21 MiB +47 Bytes 0.00%
✅ ui 19.48 MiB +789 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +36 Bytes 0.00%
✅ content scripts 3.22 MiB +72 Bytes 0.00%
🚨 unzipped 79.9 MiB +1.26 KiB 0.00%
✅ zip 24.01 MiB +200 Bytes 0.00%

@sonarqubecloud

Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cursoragent make a note that we don't usually put tests inside a __tests__ subfolder anymore

@cursor cursor Bot Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted. Tests should no longer be placed in a __tests__ subfolder in this codebase. I'll keep test files alongside the components they test (e.g., carousel-wrapper.test.tsx directly in the carousel/ directory) rather than in a separate __tests__/ subdirectory for future work.

Open in Web Open in Cursor 

@angelapotter
angelapotter added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit 6c3e692 Nov 12, 2026
140 checks passed
@angelapotter
angelapotter deleted the fix/ceux-1454-banner-dismiss-stutter branch November 12, 2026 17:11
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 12, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026

This branch was previously deployed

1 inactive deployment
pr-comment — be91769a Deployed Nov 10, 2026 by angelapotter via Publish prerelease / Publish prerelease #173885
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-M team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants