Skip to content

feat: instrument advanced chart interactions and empty state - #47772

Merged
sahar-fehri merged 65 commits into
mainfrom
feat/advanced-charts-analytics
Nov 12, 2026
Merged

sahar-fehri merged 65 commits into
mainfrom
feat/advanced-charts-analytics

Conversation

@sahar-fehri

@sahar-fehri sahar-fehri commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Description

The advanced chart on the token details page had no analytics, so we had no
visibility into how people use it: which chart type they pick, which timeframes
and granularities they switch to, which indicators they turn on, or how often
the chart renders with no data. Mobile already emits these events, so the
extension was the gap in the pair.

This adds Chart Interacted and Chart Empty Displayed, matching mobile's
property contract so both platforms report into the same Segment schema.

A new useChartAnalytics hook is the single place that builds both events. It
owns the two properties every Chart Interacted call shares (chart_type and
indicators_active) so call sites pass only what is specific to their
interaction, and it encodes the one mobile quirk in one spot: indicators_active
is omitted on timeframe_changed (coherent here too, since the range pills only
render in line mode, where indicators are hidden).

A few details worth a reviewer's attention:

  • Zoom, pan almost no new plumbing. The chart engine was
    already posting CHART_INTERACTED messages for these gestures and the iframe
    was discarding them. The message handler now forwards interaction_type up.
    They arrive pre-debounced by the engine, so there is no throttling on our side.
  • The TradingView attribution link already opens in this stack (the iframe
    sanitises the URL via toTradingViewUrl and opens it). This PR adds a
    tradingview_clicked event alongside that existing open — the same coupling
    mobile uses — rather than moving the tab-open to the host.
  • Chart Empty Displayed fires on genuinely empty data, not on errors. The
    condition is a completed candle fetch that returned zero bars, guarded to fire
    once per empty episode. Load timeouts and OHLCV failures are deliberately
    excluded, and it is scoped to candle mode, where the OHLCV series is what is on
    screen.

Coverage is all 9 interaction_type values in the schema: zoom, pan,
tooltip, chart_type_changed, timeframe_changed, granularity_changed,
indicator_toggled, indicator_selector_opened, and tradingview_clicked.

One intentional divergence from mobile: its ticket specifies that indicator
toggles fire on a Done button tap. The extension's indicator bar has no Done
button — the pills apply immediately — so this emits one indicator_toggled per
click, in both the on and off direction, reporting the post-toggle indicator set.

Note

This stacks on feat/advanced-charts-theming and targets that branch, not
main.

Important

The matching Consensys/segment-schema change is
Consensys/segment-schema#807,
which marks both events dual-platform (adds metamask-extension-globals) and
extends the chart_granularity enum with 4h and 1w. Until it merges, those
schema entries remain mobile-only, so the missing extension globals and the
extra granularity values are expected here and are not a bug in this PR.

Security note

The iframe validates the URL from a CHART_TRADINGVIEW_CLICKED message before
opening it (toTradingViewUrl): https only, and a hostname that is
tradingview.com or a subdomain of it, otherwise it falls back to the
TradingView homepage. The origin check on the incoming message only proves which
frame sent it, not where the URL points, so it is not sufficient on its own.
Lookalike hosts, non-https schemes, and unparseable URLs are covered by tests.

Changelog

CHANGELOG entry: null

Manual testing steps

  1. Enable the advanced charts flag and open a token's details page.
  2. With a dev MetaMetrics/Segment setup, switch the chart type (line ↔ candlestick) and confirm a Chart Interacted event with interaction_type: chart_type_changed and the newly selected chart_type.
  3. In line mode, pick a different time range — confirm a timeframe_changed event (no indicators_active).
  4. In candlestick mode, pick a different granularity — confirm a granularity_changed event with the lowercased interval.
  5. Toggle an indicator pill on and off — confirm one indicator_toggled event each time with the correct indicator_action and post-toggle indicators_active.
  6. Open the moving-average dropdown — confirm one indicator_selector_opened event (and none when closing it).
  7. Zoom, pan, and hover the crosshair — confirm zoom, pan, and tooltip events.
  8. Click the TradingView attribution link — confirm it opens a tab and emits tradingview_clicked.
  9. Open a token whose candles come back empty — confirm a single Chart Empty Displayed event, and confirm it does NOT fire on a chart that errored or is still loading.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Changes are additive analytics and UI callback guards on the token chart; TradingView tab opening still uses existing host sanitization with new tests for malicious URLs.

Overview
Adds MetaMetrics coverage for the token-details advanced chart, aligning with mobile’s Segment schema via new Chart Interacted and Chart Empty Displayed event names in metametrics.

A new useChartAnalytics hook centralizes event payloads (chart_type, indicators_active, interaction-specific fields). useAdvancedChartInteractions wraps chart toolbar and preference updates so each user action both mutates state and fires the matching interaction event; it also emits Chart Empty Displayed once per candle-mode episode when OHLCV finishes with zero bars (not on load errors or line mode).

The chart iframe now propagates engine CHART_INTERACTED messages (zoom/pan/tooltip) and invokes an analytics callback when the TradingView attribution link is opened (existing URL sanitization and openTab behavior unchanged). Interval pills and related handlers skip redundant callbacks when the same interval is clicked again, avoiding duplicate analytics and re-renders. The moving-average dropdown reports indicator_selector_opened only on open. Tests cover forwarding, URL sanitization, and the full interaction matrix.

Reviewed by Cursor Bugbot for commit 680f256. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci

metamask-ci Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor
Builds ready [34eb5b8]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 3 warn · 🔴 2 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42708975351 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↑ loadNewAccount/lcp: +952%
  • ↑ loadNewAccount/cls: +297%
  • ↑ confirmTx/longTaskCount: +67%
  • ↑ confirmTx/longTaskTotalDuration: +77%
  • ↑ confirmTx/longTaskMaxDuration: +52%
  • ↑ confirmTx/tbt: +88%
  • ↓ confirmTx/inp: -13%
  • ↑ confirmTx/lcp: +994%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +128%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +51%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +104%
  • ↑ bridgeUserActions/longTaskMaxDuration: +75%
  • ↑ bridgeUserActions/tbt: +211%
  • ↑ bridgeUserActions/total: +17%
  • ↑ bridgeUserActions/fcp: +10%
  • ↑ bridgeUserActions/lcp: +991%
  • ↑ bridgeUserActions/cls: +610%
  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -18%
  • ↓ loadNewAccount/fcp: -34%
  • ↑ loadNewAccount/lcp: +1255%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/fcp: -35%
  • ↑ confirmTx/lcp: +1270%
  • ↑ bridgeUserActions/bridge_load_page: +295%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +147%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +54%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -39%
  • ↑ bridgeUserActions/lcp: +1235%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +31%
  • ↑ startupStandardHome/load: +53%
  • ↑ startupStandardHome/domContentLoaded: +53%
  • ↓ startupStandardHome/firstPaint: -40%
  • ↓ startupStandardHome/backgroundConnect: -19%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +52%
  • ↑ startupStandardHome/setupStore: +75%
  • ↑ startupStandardHome/longTaskTotalDuration: +47%
  • ↑ startupStandardHome/longTaskMaxDuration: +69%
  • ↑ startupStandardHome/tbt: +61%
  • ↓ startupStandardHome/inp: -24%
  • ↑ startupStandardHome/fcp: +43%
  • ↑ startupStandardHome/lcp: +540%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/domInteractive: -29%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/fcp: -31%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +11%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +24%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +31%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +15%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -73%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +14%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +25%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +22%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +34%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -78%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -70%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -28%
  • ↓ onboardingNewWallet/tbt: -85%
  • ↓ onboardingNewWallet/total: -73%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -60%
  • ↓ dappPageLoad/domContentLoaded: -19%
  • ↓ dappPageLoad/firstPaint: -42%
  • ↓ dappPageLoad/firstContentfulPaint: -42%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.25 MiB +11.19 KiB +0.07%
🚨 ui 19.49 MiB +45.84 KiB +0.23%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +146 Bytes 0.00%
✅ content scripts 3.23 MiB +292 Bytes +0.01%
🚨 unzipped 79.93 MiB +58.82 KiB +0.07%
🚨 zip 23.98 MiB +18.15 KiB +0.07%

@metamask-ci

metamask-ci Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor
Builds ready [f9b7f7c]
⚡ Performance Benchmarks (Total: 🟢 4 pass · 🟡 5 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43190434703 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -10%
  • ↑ loadNewAccount/lcp: +936%
  • ↑ loadNewAccount/cls: +294%
  • ↑ confirmTx/longTaskCount: +67%
  • ↑ confirmTx/longTaskTotalDuration: +83%
  • ↑ confirmTx/longTaskMaxDuration: +55%
  • ↑ confirmTx/tbt: +91%
  • ↓ confirmTx/inp: -21%
  • ↑ confirmTx/lcp: +959%
  • ↑ bridgeUserActions/bridge_load_page: +109%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +48%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/tbt: +27%
  • ↑ bridgeUserActions/total: +13%
  • ↑ bridgeUserActions/lcp: +938%
  • ↑ bridgeUserActions/cls: +387%
  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/inp: -25%
  • ↓ loadNewAccount/fcp: -28%
  • ↑ loadNewAccount/lcp: +1338%
  • ↑ confirmTx/confirm_tx: +11%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/total: +11%
  • ↑ confirmTx/fcp: +27%
  • ↑ confirmTx/lcp: +1325%
  • ↑ bridgeUserActions/bridge_load_page: +269%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +148%
  • ↑ bridgeUserActions/bridge_search_token: +23%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +63%
  • ↑ bridgeUserActions/inp: +62%
  • ↑ bridgeUserActions/fcp: +29%
  • ↑ bridgeUserActions/lcp: +1343%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.8s
  • 🟡 loadNewAccount/LCP: p75 2.5s
  • 🟡 confirmTx/FCP: p75 2.2s
  • 🟡 bridgeUserActions/FCP: p75 2.2s
  • 🟡 bridgeUserActions/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +46%
  • ↑ startupStandardHome/load: +71%
  • ↑ startupStandardHome/domContentLoaded: +72%
  • ↓ startupStandardHome/firstPaint: -53%
  • ↓ startupStandardHome/backgroundConnect: -18%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +70%
  • ↑ startupStandardHome/setupStore: +95%
  • ↑ startupStandardHome/longTaskTotalDuration: +66%
  • ↑ startupStandardHome/longTaskMaxDuration: +76%
  • ↑ startupStandardHome/tbt: +83%
  • ↓ startupStandardHome/inp: -18%
  • ↓ startupStandardHome/fcp: -59%
  • ↑ startupStandardHome/lcp: +86%
  • ↓ startupStandardHome/cls: -72%
  • ↑ startupStandardHome/domInteractive: +41%
  • ↑ startupStandardHome/backgroundConnect: +20%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +14%
  • ↑ startupStandardHome/inp: +150%
  • ↑ startupStandardHome/fcp: +26%
  • ↑ startupStandardHome/lcp: +12%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +21%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +34%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +58%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +22%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -73%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -95%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -91%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -10%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -14%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -25%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -80%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -76%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -50%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.22 MiB +909 Bytes +0.01%
🚨 ui 19.55 MiB +48.4 KiB +0.24%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +90 Bytes 0.00%
✅ content scripts 3.22 MiB +180 Bytes +0.01%
🚨 unzipped 79.98 MiB +51.05 KiB +0.06%
🚨 zip 24.03 MiB +16.91 KiB +0.07%

@dawnseeker8

Copy link
Copy Markdown
Contributor

Base automatically changed from feat/advanced-charts-theming to main November 12, 2026 15:29

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5f90c98. Configure here.

@metamask-ci

metamask-ci Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor
Builds ready [5f90c98]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 1 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43250108556 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +179%
  • ↑ loadNewAccount/total: +179%
  • ↓ loadNewAccount/inp: -40%
  • ↓ loadNewAccount/fcp: -30%
  • ↑ loadNewAccount/lcp: +584%
  • ↑ loadNewAccount/cls: +294%
  • ↓ confirmTx/inp: -52%
  • ↓ confirmTx/fcp: -33%
  • ↑ confirmTx/lcp: +573%
  • ↓ confirmTx/cls: -14%
  • ↓ bridgeUserActions/bridge_load_asset_picker: -12%
  • ↓ bridgeUserActions/longTaskTotalDuration: -27%
  • ↓ bridgeUserActions/longTaskMaxDuration: -29%
  • ↓ bridgeUserActions/tbt: -45%
  • ↓ bridgeUserActions/inp: -26%
  • ↓ bridgeUserActions/fcp: -33%
  • ↑ bridgeUserActions/lcp: +560%
  • ↑ bridgeUserActions/cls: +387%
  • ↑ loadNewAccount/load_new_account: +180%
  • ↑ loadNewAccount/total: +180%
  • ↓ loadNewAccount/inp: -10%
  • ↓ loadNewAccount/fcp: -30%
  • ↑ loadNewAccount/lcp: +807%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -44%
  • ↓ confirmTx/fcp: -69%
  • ↑ confirmTx/lcp: +839%
  • ↑ bridgeUserActions/bridge_load_page: +143%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +35%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +12%
  • ↓ bridgeUserActions/fcp: -65%
  • ↑ bridgeUserActions/lcp: +915%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +80%
  • ↑ startupStandardHome/load: +113%
  • ↑ startupStandardHome/domContentLoaded: +114%
  • ↑ startupStandardHome/domInteractive: +19%
  • ↓ startupStandardHome/firstPaint: -55%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +112%
  • ↑ startupStandardHome/setupStore: +134%
  • ↑ startupStandardHome/longTaskCount: +79%
  • ↑ startupStandardHome/longTaskTotalDuration: +110%
  • ↑ startupStandardHome/longTaskMaxDuration: +121%
  • ↑ startupStandardHome/tbt: +131%
  • ↓ startupStandardHome/fcp: -51%
  • ↑ startupStandardHome/lcp: +119%
  • ↓ startupStandardHome/cls: -72%
  • ↑ startupStandardHome/load: +10%
  • ↑ startupStandardHome/domInteractive: +28%
  • ↑ startupStandardHome/backgroundConnect: +13%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +14%
  • ↑ startupStandardHome/fcp: +30%
  • ↑ startupStandardHome/lcp: +11%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +20%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +31%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +42%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +23%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -91%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +24%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +38%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +14%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -73%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -72%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -32%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -69%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -48%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.23 MiB +218 Bytes 0.00%
🚨 ui 19.52 MiB +4.92 KiB +0.02%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +14 Bytes 0.00%
✅ content scripts 3.2 MiB +28 Bytes 0.00%
🚨 unzipped 79.94 MiB +5.18 KiB +0.01%
🚨 zip 24.03 MiB +1.59 KiB +0.01%

@sahar-fehri
sahar-fehri enabled stacked auto-merge November 12, 2026 16:04
@metamask-ci

metamask-ci Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor
Builds ready [680f256]
⚡ Performance Benchmarks (Total: 🟢 10 pass · 🟡 0 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43254150517 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +180%
  • ↑ loadNewAccount/total: +180%
  • ↓ loadNewAccount/inp: -40%
  • ↓ loadNewAccount/fcp: -18%
  • ↑ loadNewAccount/lcp: +702%
  • ↑ loadNewAccount/cls: +297%
  • ↑ confirmTx/longTaskTotalDuration: +10%
  • ↑ confirmTx/longTaskMaxDuration: +23%
  • ↑ confirmTx/tbt: +19%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -17%
  • ↑ confirmTx/lcp: +739%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +21%
  • ↓ bridgeUserActions/longTaskTotalDuration: -11%
  • ↓ bridgeUserActions/longTaskMaxDuration: -14%
  • ↓ bridgeUserActions/tbt: -13%
  • ↓ bridgeUserActions/inp: -12%
  • ↓ bridgeUserActions/fcp: -20%
  • ↑ bridgeUserActions/lcp: +695%
  • ↑ bridgeUserActions/cls: +387%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -25%
  • ↓ loadNewAccount/fcp: -41%
  • ↑ loadNewAccount/lcp: +1104%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -21%
  • ↓ confirmTx/fcp: -43%
  • ↑ confirmTx/lcp: +1163%
  • ↑ bridgeUserActions/bridge_load_page: +260%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +117%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +31%
  • ↑ bridgeUserActions/inp: +40%
  • ↓ bridgeUserActions/fcp: -50%
  • ↑ bridgeUserActions/lcp: +1131%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +97%
  • ↑ startupStandardHome/load: +133%
  • ↑ startupStandardHome/domContentLoaded: +134%
  • ↑ startupStandardHome/domInteractive: +25%
  • ↓ startupStandardHome/firstPaint: -53%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +132%
  • ↑ startupStandardHome/setupStore: +127%
  • ↑ startupStandardHome/numNetworkReqs: +11%
  • ↑ startupStandardHome/longTaskCount: +79%
  • ↑ startupStandardHome/longTaskTotalDuration: +133%
  • ↑ startupStandardHome/longTaskMaxDuration: +137%
  • ↑ startupStandardHome/tbt: +156%
  • ↓ startupStandardHome/fcp: -55%
  • ↑ startupStandardHome/lcp: +103%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -33%
  • ↓ startupStandardHome/load: -27%
  • ↓ startupStandardHome/domContentLoaded: -29%
  • ↓ startupStandardHome/domInteractive: -51%
  • ↓ startupStandardHome/backgroundConnect: -17%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -28%
  • ↓ startupStandardHome/setupStore: -14%
  • ↓ startupStandardHome/fcp: -36%
  • ↓ startupStandardHome/lcp: -26%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +11%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +28%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +31%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +19%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -12%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -15%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -40%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -79%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -75%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -66%
  • ↓ dappPageLoad/domContentLoaded: -31%
  • ↓ dappPageLoad/firstPaint: -47%
  • ↓ dappPageLoad/firstContentfulPaint: -47%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.23 MiB +218 Bytes 0.00%
🚨 ui 19.52 MiB +4.92 KiB +0.02%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +14 Bytes 0.00%
✅ content scripts 3.2 MiB +28 Bytes 0.00%
🚨 unzipped 79.94 MiB +5.18 KiB +0.01%
🚨 zip 24.03 MiB +1.6 KiB +0.01%

@sonarqubecloud

Copy link
Copy Markdown

@sahar-fehri
sahar-fehri added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit 1b7c30b Nov 12, 2026
140 checks passed
@sahar-fehri
sahar-fehri deleted the feat/advanced-charts-analytics branch November 12, 2026 17:07
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 12, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026

This branch was previously deployed

1 inactive deployment
pr-comment — 680f256a Deployed Nov 12, 2026 by sahar-fehri via Publish prerelease / Publish prerelease #174378
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-L team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants