Skip to content

refactor(activity): use standard modal components - #47775

Merged
n3ps merged 8 commits into
mainfrom
n3ps/tweak-activity-modal
Nov 10, 2026
Merged

n3ps merged 8 commits into
mainfrom
n3ps/tweak-activity-modal

Conversation

@n3ps

@n3ps n3ps commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Description

Use standard modal components in the Activity templates

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

  1. Go to Activity
  2. Click on items in narrow and wide viewport

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
UI and layout refactor only; no auth, data, or transaction logic changes, though viewport-specific headers and modal structure could affect e2e selectors that assumed the old footer/back layout.

Overview
Activity transaction details now use the design-system modal shell instead of ad-hoc layout divs.

A new ResponsiveDialog wraps the activity list’s native <dialog> (full-screen on small viewports, centered modal on md+), and activity-list uses it instead of duplicating dialog markup.

Header switches from HeaderBase to ModalHeader: back arrow on mobile and a close icon on desktop (both call onBack), with a dedicated mobile back test id.

Every details template (send/swap/bridge/NFT/ramp/perps, etc.) replaces custom Footer / flex wrappers with ModalBody and ModalFooter; transaction-details and the standalone route shed extra scroll/padding wrappers and pick up minor background/layout tweaks so content fits the modal pattern.

Reviewed by Cursor Bugbot for commit 2ad380d. Bugbot is set up for automated code reviews on this repo. Configure here.

@n3ps
n3ps requested review from a team as code owners November 10, 2026 00:52
@n3ps
n3ps enabled auto-merge November 10, 2026 00:52
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci

metamask-ci Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (14 files, +104 -93)
  • 📁 ui/
    • 📁 pages/
      • 📁 activity/
        • 📄 activity-list.tsx +3 -9
      • 📁 details/
        • 📁 components/
          • 📄 header.tsx +14 -3
        • 📁 templates/
          • 📁 bridge/
            • 📄 bridge-details.tsx +8 -7
          • 📁 perps/
            • 📄 perps-details.tsx +8 -7
          • 📁 ramps/
            • 📄 ramp-order-details.tsx +9 -7
            • 📄 approval-details.tsx +8 -7
            • 📄 asset-activation-details.tsx +8 -7
            • 📄 default-details.tsx +8 -7
            • 📄 mm-pay-details-layout.tsx +7 -7
            • 📄 nft-details.tsx +8 -7
            • 📄 send-details.tsx +8 -7
            • 📄 swap-details.tsx +8 -7
          • 📄 transaction-details-route.tsx +1 -1
          • 📄 transaction-details.tsx +6 -10

👨‍🔧 @MetaMask/money-movement (1 files, +9 -7)
  • 📁 ui/
    • 📁 pages/
      • 📁 details/
        • 📁 templates/
          • 📁 ramps/
            • 📄 ramp-order-details.tsx +9 -7

👨‍🔧 @MetaMask/perps (1 files, +8 -7)
  • 📁 ui/
    • 📁 pages/
      • 📁 details/
        • 📁 templates/
          • 📁 perps/
            • 📄 perps-details.tsx +8 -7

🔄 @MetaMask/swaps-engineers (1 files, +8 -7)
  • 📁 ui/
    • 📁 pages/
      • 📁 details/
        • 📁 templates/
          • 📁 bridge/
            • 📄 bridge-details.tsx +8 -7

@metamask-ci metamask-ci Bot added the team-core-extension-ux Core Extension UX team label Nov 10, 2026
@n3ps n3ps changed the title use standard modal components refactor(activity): use standard modal components Nov 10, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modern web (modal layout)

Switching detail templates to ModalBody / ModalFooter matches the design-system modal pattern and restores horizontal padding via ModalBody (paddingHorizontal: 4). One layout gap to fix so the footer stays pinned when content is tall inside the native <dialog>.

Open in Web View Automation 

Sent by Cursor Automation: Modern web guidance

@metamask-ci

metamask-ci Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor
Builds ready [50b3dba]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 5 warn · 🔴 2 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42731671633 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↑ loadNewAccount/lcp: +968%
  • ↑ loadNewAccount/cls: +596%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +57%
  • ↑ confirmTx/longTaskMaxDuration: +56%
  • ↑ confirmTx/tbt: +76%
  • ↑ confirmTx/lcp: +971%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +93%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +45%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +73%
  • ↑ bridgeUserActions/longTaskMaxDuration: +22%
  • ↑ bridgeUserActions/tbt: +132%
  • ↑ bridgeUserActions/total: +14%
  • ↑ bridgeUserActions/lcp: +957%
  • ↑ bridgeUserActions/cls: +607%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/fcp: -34%
  • ↑ loadNewAccount/lcp: +1257%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -13%
  • ↓ confirmTx/fcp: -33%
  • ↑ confirmTx/lcp: +1296%
  • ↑ bridgeUserActions/bridge_load_page: +280%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +143%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +67%
  • ↑ bridgeUserActions/inp: +54%
  • ↑ bridgeUserActions/fcp: +17%
  • ↑ bridgeUserActions/lcp: +1290%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +93%
  • ↑ startupStandardHome/load: +129%
  • ↑ startupStandardHome/domContentLoaded: +130%
  • ↑ startupStandardHome/domInteractive: +33%
  • ↓ startupStandardHome/firstPaint: -53%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +128%
  • ↑ startupStandardHome/setupStore: +147%
  • ↑ startupStandardHome/numNetworkReqs: +11%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +126%
  • ↑ startupStandardHome/longTaskMaxDuration: +133%
  • ↑ startupStandardHome/tbt: +150%
  • ↓ startupStandardHome/fcp: -55%
  • ↑ startupStandardHome/lcp: +103%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -17%
  • ↓ startupStandardHome/domContentLoaded: -12%
  • ↑ startupStandardHome/domInteractive: +43%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/fcp: +46%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +14%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +21%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +34%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +16%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -95%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -90%
  • ↓ onboardingImportWallet/tbt: -99%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -11%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -24%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -16%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -39%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -78%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -74%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -38%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -74%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -60%
  • ↓ dappPageLoad/domContentLoaded: -19%
  • ↓ dappPageLoad/firstPaint: -47%
  • ↓ dappPageLoad/firstContentfulPaint: -47%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.24 MiB +39 Bytes 0.00%
🚨 ui 19.44 MiB +2.52 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +7 Bytes 0.00%
✅ content scripts 3.23 MiB +14 Bytes 0.00%
🚨 unzipped 79.88 MiB +3.55 KiB 0.00%
🚨 zip 23.97 MiB +1.19 KiB 0.00%

// eslint-disable-next-line react/no-unknown-property -- valid on <dialog>
closedby="any"
>
<ResponsiveDialog dialogRef={dialogRef} onClose={handleClose}>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Point of interest

@metamask-ci

metamask-ci Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor
Builds ready [fb9cfb2]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42749104150 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -40%
  • ↓ loadNewAccount/fcp: -19%
  • ↑ loadNewAccount/lcp: +693%
  • ↑ loadNewAccount/cls: +297%
  • ↑ confirmTx/longTaskMaxDuration: +21%
  • ↑ confirmTx/tbt: +15%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -18%
  • ↑ confirmTx/lcp: +727%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +31%
  • ↓ bridgeUserActions/longTaskTotalDuration: -18%
  • ↓ bridgeUserActions/longTaskMaxDuration: -18%
  • ↓ bridgeUserActions/tbt: -31%
  • ↓ bridgeUserActions/inp: -19%
  • ↓ bridgeUserActions/fcp: -16%
  • ↑ bridgeUserActions/lcp: +731%
  • ↑ bridgeUserActions/cls: +387%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -25%
  • ↑ loadNewAccount/fcp: +27%
  • ↑ loadNewAccount/lcp: +1253%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -13%
  • ↑ confirmTx/fcp: +26%
  • ↑ confirmTx/lcp: +1336%
  • ↑ bridgeUserActions/bridge_load_page: +312%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +130%
  • ↑ bridgeUserActions/bridge_search_token: +25%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +73%
  • ↑ bridgeUserActions/inp: +62%
  • ↓ bridgeUserActions/fcp: -33%
  • ↑ bridgeUserActions/lcp: +1320%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.2s
  • 🟡 confirmTx/FCP: p75 2.2s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +44%
  • ↑ startupStandardHome/load: +71%
  • ↑ startupStandardHome/domContentLoaded: +71%
  • ↓ startupStandardHome/firstPaint: -55%
  • ↓ startupStandardHome/backgroundConnect: -17%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +70%
  • ↑ startupStandardHome/setupStore: +88%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +67%
  • ↑ startupStandardHome/longTaskMaxDuration: +77%
  • ↑ startupStandardHome/tbt: +80%
  • ↓ startupStandardHome/inp: -24%
  • ↓ startupStandardHome/fcp: -61%
  • ↑ startupStandardHome/lcp: +76%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -12%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -13%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -11%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -27%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -80%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -76%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -61%
  • ↓ dappPageLoad/domContentLoaded: -19%
  • ↓ dappPageLoad/firstPaint: -42%
  • ↓ dappPageLoad/firstContentfulPaint: -42%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.24 MiB +39 Bytes 0.00%
🚨 ui 19.44 MiB +2.42 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +7 Bytes 0.00%
✅ content scripts 3.23 MiB +14 Bytes 0.00%
🚨 unzipped 79.88 MiB +3.6 KiB 0.00%
🚨 zip 23.96 MiB +1.06 KiB 0.00%

@n3ps
n3ps requested a review from a team as a code owner November 10, 2026 03:58

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b8d0d74. Configure here.

* navigation may have already closed the details view.
*/
async clickBackButtonIfPresent(): Promise<void> {
await this.driver.clickElementSafe(this.backButton, 1_000);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Escape dismiss skips details wait

Medium Severity

clickBackButton and clickBackButtonIfPresent now send Escape and return immediately, dropping the wait until /tx/ leaves the URL. Escape only closes the activity-list dialog, so the dedicated #/tx/ route never goes back, and later list or tab clicks can run while the overlay is still closing. clickBackButtonIfPresent also always sends Escape even when details are already gone.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit b8d0d74. Configure here.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@metamask-ci

metamask-ci Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor
Builds ready [2ad380d]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 4 warn · 🔴 2 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42754047178 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↑ loadNewAccount/lcp: +952%
  • ↑ loadNewAccount/cls: +297%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +54%
  • ↑ confirmTx/longTaskMaxDuration: +52%
  • ↑ confirmTx/tbt: +70%
  • ↓ confirmTx/inp: -13%
  • ↑ confirmTx/lcp: +992%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +129%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +46%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +75%
  • ↑ bridgeUserActions/longTaskMaxDuration: +35%
  • ↑ bridgeUserActions/tbt: +120%
  • ↑ bridgeUserActions/total: +17%
  • ↑ bridgeUserActions/lcp: +973%
  • ↑ bridgeUserActions/cls: +387%
  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -33%
  • ↓ loadNewAccount/fcp: -59%
  • ↑ loadNewAccount/lcp: +973%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -29%
  • ↑ confirmTx/lcp: +1037%
  • ↑ bridgeUserActions/bridge_load_page: +107%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +63%
  • ↓ bridgeUserActions/bridge_search_token: -11%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +26%
  • ↑ bridgeUserActions/inp: +40%
  • ↑ bridgeUserActions/lcp: +1002%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +45%
  • ↑ startupStandardHome/load: +70%
  • ↑ startupStandardHome/domContentLoaded: +71%
  • ↓ startupStandardHome/firstPaint: -45%
  • ↓ startupStandardHome/backgroundConnect: -11%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +69%
  • ↑ startupStandardHome/setupStore: +82%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +66%
  • ↑ startupStandardHome/longTaskMaxDuration: +96%
  • ↑ startupStandardHome/tbt: +83%
  • ↓ startupStandardHome/inp: -24%
  • ↓ startupStandardHome/fcp: -63%
  • ↑ startupStandardHome/lcp: +68%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/domInteractive: -13%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/fcp: -25%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +15%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +28%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +43%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +33%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -10%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +11%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +71%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -79%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -75%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -68%
  • ↓ dappPageLoad/domContentLoaded: -34%
  • ↓ dappPageLoad/firstPaint: -52%
  • ↓ dappPageLoad/firstContentfulPaint: -52%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.24 MiB +39 Bytes 0.00%
🚨 ui 19.44 MiB +2.42 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +7 Bytes 0.00%
✅ content scripts 3.23 MiB +14 Bytes 0.00%
🚨 unzipped 79.88 MiB +3.61 KiB 0.00%
🚨 zip 23.96 MiB +1.07 KiB 0.00%

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
47.1% Coverage on New Code (required ≥ 80%)
9.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@n3ps
n3ps added this pull request to the merge queue Nov 10, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 10, 2026
@n3ps
n3ps added this pull request to the merge queue Nov 10, 2026
@n3ps n3ps added the retry-ci Tells GitHub Actions to retry failed jobs, label removed automatically before the retry label Nov 10, 2026
Merged via the queue into main with commit 6c864f3 Nov 10, 2026
141 of 142 checks passed
@n3ps
n3ps deleted the n3ps/tweak-activity-modal branch November 10, 2026 18:20
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 10, 2026
@github-actions github-actions Bot removed the retry-ci Tells GitHub Actions to retry failed jobs, label removed automatically before the retry label Nov 10, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.58.0 on PR, as PR was added to branch 13.58.0 when release was cut.

This branch was previously deployed

1 inactive deployment
pr-comment — 2ad380dd Deployed Nov 10, 2026 by n3ps via Publish prerelease / Publish prerelease #173700
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-M team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants