Repository navigation
refactor(activity): use standard modal components - #47775
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (14 files, +104 -93)
👨🔧 @MetaMask/money-movement (1 files, +9 -7)
👨🔧 @MetaMask/perps (1 files, +8 -7)
🔄 @MetaMask/swaps-engineers (1 files, +8 -7)
|
There was a problem hiding this comment.
Modern web (modal layout)
Switching detail templates to ModalBody / ModalFooter matches the design-system modal pattern and restores horizontal padding via ModalBody (paddingHorizontal: 4). One layout gap to fix so the footer stays pinned when content is tall inside the native <dialog>.
Sent by Cursor Automation: Modern web guidance
Builds ready [50b3dba]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 5 warn · 🔴 2 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
| // eslint-disable-next-line react/no-unknown-property -- valid on <dialog> | ||
| closedby="any" | ||
| > | ||
| <ResponsiveDialog dialogRef={dialogRef} onClose={handleClose}> |
Builds ready [fb9cfb2]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b8d0d74. Configure here.
| * navigation may have already closed the details view. | ||
| */ | ||
| async clickBackButtonIfPresent(): Promise<void> { | ||
| await this.driver.clickElementSafe(this.backButton, 1_000); |
There was a problem hiding this comment.
Escape dismiss skips details wait
Medium Severity
clickBackButton and clickBackButtonIfPresent now send Escape and return immediately, dropping the wait until /tx/ leaves the URL. Escape only closes the activity-list dialog, so the dedicated #/tx/ route never goes back, and later list or tab clicks can run while the overlay is still closing. clickBackButtonIfPresent also always sends Escape even when details are already gone.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit b8d0d74. Configure here.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Builds ready [2ad380d]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 4 warn · 🔴 2 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
|
|
No release label on PR. Adding release label release-13.58.0 on PR, as PR was added to branch 13.58.0 when release was cut. |






Description
Use standard modal components in the Activity templates
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
UI and layout refactor only; no auth, data, or transaction logic changes, though viewport-specific headers and modal structure could affect e2e selectors that assumed the old footer/back layout.
Overview
Activity transaction details now use the design-system modal shell instead of ad-hoc layout divs.
A new
ResponsiveDialogwraps the activity list’s native<dialog>(full-screen on small viewports, centered modal onmd+), andactivity-listuses it instead of duplicating dialog markup.Headerswitches fromHeaderBasetoModalHeader: back arrow on mobile and a close icon on desktop (both callonBack), with a dedicated mobile back test id.Every details template (send/swap/bridge/NFT/ramp/perps, etc.) replaces custom
Footer/ flex wrappers withModalBodyandModalFooter;transaction-detailsand the standalone route shed extra scroll/padding wrappers and pick up minor background/layout tweaks so content fits the modal pattern.Reviewed by Cursor Bugbot for commit 2ad380d. Bugbot is set up for automated code reviews on this repo. Configure here.