Skip to content

feat(accounts): restyle Add wallet screen to match design - #47780

Merged
NidhiKJha merged 2 commits into
mainfrom
feat/add-wallet-design
Nov 10, 2026
Merged

NidhiKJha merged 2 commits into
mainfrom
feat/add-wallet-design

Conversation

@NidhiKJha

@NidhiKJha NidhiKJha commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Description

Restyles the Add wallet screen (choose-new-wallet-type) to match the Figma design (node 801:5647).

  • Rows are flat and full-width, with no card background or gaps. Each row has a minimum height of 56px and a hover and pressed state.
  • Each row starts with the design-system AvatarIcon (large, neutral) and ends with a right chevron.
  • The header now reads "Add wallet", which uses the existing addWallet key. The unused addAWallet key is removed from all locales.
  • Descriptions are updated to match the design:
    • Import a wallet: "Using a Secret Recovery Phrase"
    • Import an account: "Using a private key"
    • Hardware wallet: "Using USB or QR code"
  • The "Create a new wallet" row is not included. The extension has no flow for adding a new Secret Recovery Phrase to an existing wallet, so that row is left out for now.

Also fixes the back button on the Import a wallet screen (import-srp.tsx). It navigated to the home route, which exited the whole add-wallet flow. It now uses PREVIOUS_ROUTE, matching Import an account. The close button still returns home.

Reason for the change: align the Add wallet screen with the design and stop the back button from ending the flow.

Changelog

CHANGELOG entry: Updated the Add wallet screen design and fixed the back button on the Import a wallet screen, which closed the whole flow.

Related issues

Fixes:

Manual testing steps

  1. Run the extension and unlock the wallet.
  2. Open the account list and select Add wallet.
  3. Verify the header reads "Add wallet" and the rows are flat, with an icon on the left and a chevron on the right.
  4. Verify the descriptions read "Using a Secret Recovery Phrase", "Using a private key", and "Using USB or QR code".
  5. Select Import a wallet.
  6. Click the back arrow and verify you return to the Add wallet page.
  7. Select Import a wallet again and click the close (X) button, then verify you return to the home screen.

Screenshots/Recordings

Before

Screenshot 2026-11-10 at 12 32 18 PM

After

Screenshot 2026-11-10 at 12 31 57 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
UI copy and styling plus navigation routing in onboarding flows; no auth, vault, or payment logic changes.

Overview
Restyles the Add wallet chooser to match Figma: flat full-width rows with AvatarIcon, right chevrons, hover/pressed states, and the header string switched from addAWallet to addWallet. The unused addAWallet locale key is removed across languages, and related option copy is tightened (Secret Recovery Phrase, private key, USB or QR code).

On Import Secret Recovery Phrase, the back control now routes to PREVIOUS_ROUTE so users return to Add wallet instead of exiting the flow; close still goes home. Tests and snapshots cover the new data-testid hooks and navigation behavior.

Reviewed by Cursor Bugbot for commit 5969688. Bugbot is set up for automated code reviews on this repo. Configure here.

Restyle the Add wallet screen to the new design: flat full-width rows with AvatarIcon, an end chevron, and an Add wallet title. Update the Import a wallet copy and drop the unused addAWallet locale key.

The Import a wallet back button navigated to the home route, which exited the whole add-wallet flow. It now goes to the previous page, and the close button still returns home.

Co-authored-by: Cursor <cursoragent@cursor.com>
@metamask-ci

metamask-ci Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (2 files, +21 -19)
  • 📁 ui/
    • 📁 pages/
      • 📁 multichain-accounts/
        • 📁 choose-new-wallet-type/
          • 📄 choose-new-wallet-type-page.test.tsx +1 -1
          • 📄 choose-new-wallet-type-page.tsx +20 -18

@metamask-ci metamask-ci Bot added the team-core-extension-ux Core Extension UX team label Nov 10, 2026
@NidhiKJha
NidhiKJha marked this pull request as ready for review November 10, 2026 07:02
@NidhiKJha
NidhiKJha requested a review from a team as a code owner November 10, 2026 07:02
@metamask-ci

metamask-ci Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor
Builds ready [5969688]
⚡ Performance Benchmarks (Total: 🟢 10 pass · 🟡 0 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42772561665 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↑ loadNewAccount/inp: +12%
  • ↓ loadNewAccount/fcp: -19%
  • ↑ loadNewAccount/lcp: +698%
  • ↑ loadNewAccount/cls: +596%
  • ↑ confirmTx/longTaskMaxDuration: +15%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -12%
  • ↑ confirmTx/lcp: +781%
  • ↓ confirmTx/cls: -14%
  • ↓ bridgeUserActions/bridge_search_token: -10%
  • ↓ bridgeUserActions/longTaskTotalDuration: -19%
  • ↓ bridgeUserActions/longTaskMaxDuration: -23%
  • ↓ bridgeUserActions/tbt: -32%
  • ↓ bridgeUserActions/inp: -26%
  • ↓ bridgeUserActions/fcp: -17%
  • ↑ bridgeUserActions/lcp: +724%
  • ↑ bridgeUserActions/cls: +634%
  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/inp: -18%
  • ↓ loadNewAccount/fcp: -52%
  • ↑ loadNewAccount/lcp: +957%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -52%
  • ↑ confirmTx/lcp: +1072%
  • ↑ bridgeUserActions/bridge_load_page: +157%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +79%
  • ↓ bridgeUserActions/bridge_search_token: -10%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +17%
  • ↑ bridgeUserActions/inp: +32%
  • ↓ bridgeUserActions/fcp: -52%
  • ↑ bridgeUserActions/lcp: +997%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +17%
  • ↑ startupStandardHome/load: +37%
  • ↑ startupStandardHome/domContentLoaded: +37%
  • ↓ startupStandardHome/domInteractive: -14%
  • ↓ startupStandardHome/firstPaint: -48%
  • ↓ startupStandardHome/backgroundConnect: -28%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -64%
  • ↑ startupStandardHome/loadScripts: +36%
  • ↑ startupStandardHome/setupStore: +17%
  • ↑ startupStandardHome/longTaskTotalDuration: +32%
  • ↑ startupStandardHome/longTaskMaxDuration: +56%
  • ↑ startupStandardHome/tbt: +42%
  • ↓ startupStandardHome/inp: -37%
  • ↑ startupStandardHome/fcp: +34%
  • ↑ startupStandardHome/lcp: +500%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/domInteractive: -39%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/fcp: -34%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +21%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +32%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +34%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +20%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -95%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -91%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -12%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -31%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -20%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -14%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -51%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -76%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -73%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -69%
  • ↓ dappPageLoad/domContentLoaded: -37%
  • ↓ dappPageLoad/firstPaint: -52%
  • ↓ dappPageLoad/firstContentfulPaint: -52%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.24 MiB +68 Bytes 0.00%
✅ ui 19.44 MiB +147 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.92 MiB -700 Bytes 0.00%
✅ zip 24.01 MiB -84 Bytes 0.00%

@sonarqubecloud

Copy link
Copy Markdown

@NidhiKJha
NidhiKJha enabled auto-merge November 10, 2026 09:15
@NidhiKJha
NidhiKJha added this pull request to the merge queue Nov 10, 2026
Merged via the queue into main with commit fe06b7f Nov 10, 2026
143 checks passed
@NidhiKJha
NidhiKJha deleted the feat/add-wallet-design branch November 10, 2026 13:16
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 10, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.58.0 on PR, as PR was added to branch 13.58.0 when release was cut.

This branch was previously deployed

1 inactive deployment
pr-comment — 59696884 Deployed Nov 10, 2026 by NidhiKJha via Publish prerelease / Publish prerelease #173713
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-M team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants