Repository navigation
chore: point accounts support URLs at metamask.com - #47785
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (4 files, +51 -6)
|
Builds ready [5d6bca7]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)
Bundle Size Diffs
|
There was a problem hiding this comment.
🟡 Changes recommended
The change updates user-visible Snap keyring dialog URLs without tests asserting the new success and error payloads, leaving regressions in account creation and removal links undetected.
2 open issues
What changed in this PR
Updates accounts-related support URLs from support.metamask.io to support.metamask.com while preserving existing paths and query parameters.
Changes:
- Migrates Snap account creation and removal learn-more links.
- Migrates the MFA email-in-use error link.
- Updates the corresponding MFA test expectation.
| File | Description |
|---|---|
| ui/pages/mfa/steps/steps.test.tsx | Updates the expected MFA support URL to use the support.metamask.com domain. |
| ui/pages/mfa/labels.ts | Points the MFA email-in-use error link to the new support domain. |
| app/scripts/lib/snap-keyring/snap-keyring.ts | Updates Snap account creation and removal learn-more URLs to use the new support domain. |
Review effort: Lite
5d6bca7 to
a9863cc
Compare
Builds ready [a9863cc]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 3 warn · 🔴 2 fail)
Bundle Size Diffs
|
a9863cc to
794d367
Compare
Builds ready [dfc947d]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 2 warn · 🔴 4 fail)
Bundle Size Diffs
|
Co-authored-by: Cursor <cursoragent@cursor.com>
Builds ready [77d947a]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
|




Description
Part of the migration of MetaMask web properties to the
metamask.comdomain, scoped to files owned by the accounts team. Updates the support links in the snap keyring learn-more copy and in the MFA error link, with their tests.Changelog
CHANGELOG entry: null
Related issues
Fixes: N/A
Manual testing steps
yarn start.support.metamask.com.support.metamask.com/configure/wallet/email-in-use.Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
String-only URL updates plus test expectations; no auth, security, or data-handling logic changes.
Overview
Accounts-related support “learn more” URLs move from
support.metamask.iotosupport.metamask.comin snap keyring success/error dialogs (add and remove account) and in the MFA email already claimed error link.Tests are updated to match: snap keyring mocks now forward
showSuccess/showErrorarguments and assert the new URLs in those payloads; the MFA email-entry step test expects the newemail-in-usehref.Reviewed by Cursor Bugbot for commit 77d947a. Bugbot is set up for automated code reviews on this repo. Configure here.