Skip to content

feat(money): load Money home behind the FTUE splash - #47799

Merged
ffmcgee725 merged 2 commits into
mainfrom
feat/MUSD-1519-money-ftue-load-home
Nov 10, 2026
Merged

ffmcgee725 merged 2 commits into
mainfrom
feat/MUSD-1519-money-ftue-load-home

Conversation

@ffmcgee725

@ffmcgee725 ffmcgee725 commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Description

On the first Money visit, clicking the Money tab opened the FTUE splash without navigating, so Money Home only started loading after the splash closed. This opens the splash and navigates to /money-home in the same click, so the page mounts and fetches behind it. The CTA-triggered FTUE is unchanged, and Money Home's screen_viewed event now fires while the splash is visible.

Changelog

CHANGELOG entry: Improved the first Money visit so the home page is ready when the intro splash is dismissed.

Related issues

Fixes: MUSD-1519

Manual testing steps

  1. Run yarn start and load the extension with a wallet that has not opened Money before.
  2. Click the Money tab.
  3. Verify the splash appears while the hash is already #/money-home.
  4. Dismiss the splash and verify Money Home is fully loaded, with no skeleton.
  5. Reload, open Wallet Home, and click the token list Get X% APY CTA.
  6. Verify the splash opens over Wallet Home without navigating, and the deposit continues after acknowledging.

Screenshots/Recordings

Before

Screenshot 2026-11-09 at 09 53 49

After

Screenshot 2026-11-10 at 13 07 17

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Behavior change is limited to first-visit Money tab navigation and test helpers; no auth or payment logic touched.

Overview
On the first Money tab visit, clicking Money now navigates to /money-home while opening the FTUE splash, so Money Home mounts and loads behind the overlay instead of loading only after dismiss.

useMainNavItems removes the early return on unseen FTUE and always runs transitionForward(() => navigate(MONEY_HOME_ROUTE)) after dispatching openMoneyFtue. CTA-triggered FTUE behavior is unchanged.

E2E and unit tests reflect this: bottom nav clickMoney always asserts the money-home route (no optional assertRoute), and FTUE specs assert MoneyHomePage is loaded while the splash is still visible.

Reviewed by Cursor Bugbot for commit 6ecf4b2. Bugbot is set up for automated code reviews on this repo. Configure here.

@metamask-ci

metamask-ci Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

🧪 @MetaMask/qa (2 files, +3 -11)
  • 📁 test/
    • 📁 e2e/
      • 📁 page-objects/
        • 📁 flows/
          • 📄 money-account-deposit.flow.ts +1 -1
        • 📁 pages/
          • 📁 home/
            • 📄 bottom-nav-bar-page.ts +2 -10

@ffmcgee725
ffmcgee725 marked this pull request as ready for review November 10, 2026 12:14
@ffmcgee725
ffmcgee725 requested a review from a team as a code owner November 10, 2026 12:14
@metamask-ci

metamask-ci Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor
Builds ready [6ecf4b2]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 1 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42813850735 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -33%
  • ↓ loadNewAccount/fcp: -13%
  • ↑ loadNewAccount/lcp: +754%
  • ↑ loadNewAccount/cls: +297%
  • ↑ confirmTx/longTaskTotalDuration: +12%
  • ↑ confirmTx/longTaskMaxDuration: +25%
  • ↑ confirmTx/tbt: +23%
  • ↓ confirmTx/inp: -29%
  • ↓ confirmTx/fcp: -13%
  • ↑ confirmTx/lcp: +770%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +39%
  • ↓ bridgeUserActions/longTaskTotalDuration: -10%
  • ↓ bridgeUserActions/longTaskMaxDuration: -11%
  • ↓ bridgeUserActions/tbt: -11%
  • ↓ bridgeUserActions/inp: -12%
  • ↓ bridgeUserActions/fcp: -17%
  • ↑ bridgeUserActions/lcp: +720%
  • ↑ bridgeUserActions/cls: +387%
  • ↑ loadNewAccount/load_new_account: +180%
  • ↑ loadNewAccount/total: +180%
  • ↓ loadNewAccount/inp: -25%
  • ↑ loadNewAccount/lcp: +969%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -61%
  • ↑ confirmTx/lcp: +1053%
  • ↑ bridgeUserActions/bridge_load_page: +138%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +154%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +29%
  • ↑ bridgeUserActions/inp: +25%
  • ↑ bridgeUserActions/lcp: +969%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +47%
  • ↑ startupStandardHome/load: +72%
  • ↑ startupStandardHome/domContentLoaded: +72%
  • ↓ startupStandardHome/firstPaint: -58%
  • ↓ startupStandardHome/backgroundConnect: -16%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +70%
  • ↑ startupStandardHome/setupStore: +95%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +68%
  • ↑ startupStandardHome/longTaskMaxDuration: +76%
  • ↑ startupStandardHome/tbt: +80%
  • ↓ startupStandardHome/inp: -24%
  • ↓ startupStandardHome/fcp: -60%
  • ↑ startupStandardHome/lcp: +81%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -40%
  • ↓ startupStandardHome/load: -37%
  • ↓ startupStandardHome/domContentLoaded: -38%
  • ↓ startupStandardHome/domInteractive: -56%
  • ↓ startupStandardHome/backgroundConnect: -35%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -37%
  • ↑ startupStandardHome/setupStore: +41%
  • ↓ startupStandardHome/fcp: -46%
  • ↓ startupStandardHome/lcp: -35%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -11%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -31%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -12%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -23%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -41%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -78%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -75%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -40%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -74%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -69%
  • ↓ dappPageLoad/domContentLoaded: -37%
  • ↓ dappPageLoad/firstPaint: -52%
  • ↓ dappPageLoad/firstContentfulPaint: -52%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.24 MiB +115 Bytes 0.00%
✅ ui 19.44 MiB +55 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB 0 Bytes 0.00%
✅ content scripts 3.22 MiB 0 Bytes 0.00%
✅ unzipped 79.91 MiB +175 Bytes 0.00%
✅ zip 24.01 MiB +59 Bytes 0.00%

@sonarqubecloud

Copy link
Copy Markdown

@seaona seaona left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e LGTM

@ffmcgee725
ffmcgee725 enabled auto-merge November 10, 2026 13:30
@ffmcgee725
ffmcgee725 added this pull request to the merge queue Nov 10, 2026
Merged via the queue into main with commit 12efc4e Nov 10, 2026
156 checks passed
@ffmcgee725
ffmcgee725 deleted the feat/MUSD-1519-money-ftue-load-home branch November 10, 2026 15:23
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 10, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026

This branch was previously deployed

1 inactive deployment
pr-comment — 6ecf4b24 Deployed Nov 10, 2026 by ffmcgee725 via Publish prerelease / Publish prerelease #173788
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-S team-earn

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants