Repository navigation
feat(money): load Money home behind the FTUE splash - #47799
Merged
Merged
Conversation
ffmcgee725
temporarily deployed
to
pr-comment
November 10, 2026 12:13 — with
GitHub Actions
Inactive
Contributor
✨ Files requiring CODEOWNER review ✨🧪 @MetaMask/qa (2 files, +3 -11)
|
ffmcgee725
marked this pull request as ready for review
November 10, 2026 12:14
ffmcgee725
temporarily deployed
to
pr-comment
November 10, 2026 12:14 — with
GitHub Actions
Inactive
ffmcgee725
temporarily deployed
to
pr-comment
November 10, 2026 12:26 — with
GitHub Actions
Inactive
Contributor
Builds ready [6ecf4b2]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 1 warn · 🔴 3 fail)
Bundle Size Diffs
|
|
ffmcgee725
enabled auto-merge
November 10, 2026 13:30
shane-t
approved these changes
Nov 10, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
On the first Money visit, clicking the Money tab opened the FTUE splash without navigating, so Money Home only started loading after the splash closed. This opens the splash and navigates to
/money-homein the same click, so the page mounts and fetches behind it. The CTA-triggered FTUE is unchanged, and Money Home'sscreen_viewedevent now fires while the splash is visible.Changelog
CHANGELOG entry: Improved the first Money visit so the home page is ready when the intro splash is dismissed.
Related issues
Fixes: MUSD-1519
Manual testing steps
yarn startand load the extension with a wallet that has not opened Money before.#/money-home.Get X% APYCTA.Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Behavior change is limited to first-visit Money tab navigation and test helpers; no auth or payment logic touched.
Overview
On the first Money tab visit, clicking Money now navigates to
/money-homewhile opening the FTUE splash, so Money Home mounts and loads behind the overlay instead of loading only after dismiss.useMainNavItemsremoves the early return on unseen FTUE and always runstransitionForward(() => navigate(MONEY_HOME_ROUTE))after dispatchingopenMoneyFtue. CTA-triggered FTUE behavior is unchanged.E2E and unit tests reflect this: bottom nav
clickMoneyalways asserts the money-home route (no optionalassertRoute), and FTUE specs assertMoneyHomePageis loaded while the splash is still visible.Reviewed by Cursor Bugbot for commit 6ecf4b2. Bugbot is set up for automated code reviews on this repo. Configure here.