Skip to content

fix(accounts): show JSON import password errors under the password field - #47802

Merged
NidhiKJha merged 5 commits into
mainfrom
fix/json-import-password-error
Nov 12, 2026
Merged

NidhiKJha merged 5 commits into
mainfrom
fix/json-import-password-error

Conversation

@NidhiKJha

@NidhiKJha NidhiKJha commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Description

When a JSON keystore import fails because the password is missing or wrong, the error was shown under the JSON file picker. The password field is where the user needs to act, so the error now appears under the password field.

The keystore decrypt step (ethereumjs-wallet) throws the same Key derivation failed - possibly wrong passphrase error for a missing password and a wrong password, so the message is shown as "The password is missing or incorrect." That message is only applied to JSON imports. Private key imports keep their existing error placement.

File errors, such as a file that is not a keystore, still appear under the file picker.

No functional change to how imports are performed. This only changes where and how the error is shown.

Changelog

CHANGELOG entry: Fixed JSON account import showing a wrong-password error under the file picker instead of the password field

Related issues

Fixes:

Manual testing steps

  1. Go to the account list and open the add account flow, then choose Import account.
  2. Select the JSON file option.
  3. Select test/e2e/import-utc-json/test-json-import-account-file.json from the repo.
  4. Enter wrongpassword in the password field and click Import.
  5. Verify "The password is missing or incorrect." appears under the password field, the password field is outlined in the error color, and no error appears under the file picker.
  6. Clear the password field and click Import. Verify the same error appears under the password field.
  7. Enter foobarbazqux and click Import. Verify the account imports.
  8. Select a file that is not a keystore, such as a plain text file. Verify the error appears under the file picker and not under the password field.

Screenshots/Recordings

Before

After

Screen.Recording.2026-11-10.at.7.57.56.PM.mov
Screen.Recording.2026-11-12.at.3.23.34.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
UI-only error placement and messaging for JSON import; no change to import logic beyond how passphrase failures are interpreted for display.

Overview
JSON keystore import errors about missing or wrong passwords are now routed to the password field instead of the file picker, with clearer copy depending on whether the user left the password blank, entered one on the first try, or retried after a blank failure.

The import flow tracks blank-password failures for JSON imports when the backend reports a generic passphrase/MAC error, and JsonImportView splits password vs file validation messages with appropriate role="alert" / aria-describedby wiring. Non-password JSON errors stay on the file control; private-key import errors keep their existing placement but gain alert semantics on the field help text.

New locale strings and unit tests cover the password messaging and accessibility behavior.

Reviewed by Cursor Bugbot for commit 13d651c. Bugbot is set up for automated code reviews on this repo. Configure here.

@metamask-ci

metamask-ci Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (5 files, +221 -3)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 import-account/
          • 📄 import-account.js +23 -0
          • 📄 import-account.test.tsx +111 -1
          • 📄 json.js +36 -2
          • 📄 json.test.tsx +50 -0
          • 📄 private-key.js +1 -0

@metamask-ci metamask-ci Bot added the team-core-extension-ux Core Extension UX team label Nov 10, 2026
@metamask-ci

metamask-ci Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor
Builds ready [36fc439]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 1 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42827571044 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +179%
  • ↑ loadNewAccount/total: +179%
  • ↓ loadNewAccount/inp: -48%
  • ↓ loadNewAccount/fcp: -34%
  • ↑ loadNewAccount/lcp: +546%
  • ↑ loadNewAccount/cls: +297%
  • ↓ confirmTx/longTaskTotalDuration: -12%
  • ↓ confirmTx/tbt: -17%
  • ↓ confirmTx/inp: -52%
  • ↓ confirmTx/fcp: -34%
  • ↑ confirmTx/lcp: +566%
  • ↓ confirmTx/cls: -14%
  • ↓ bridgeUserActions/bridge_load_asset_picker: -18%
  • ↓ bridgeUserActions/longTaskTotalDuration: -32%
  • ↓ bridgeUserActions/longTaskMaxDuration: -36%
  • ↓ bridgeUserActions/tbt: -68%
  • ↓ bridgeUserActions/total: -11%
  • ↓ bridgeUserActions/inp: -34%
  • ↓ bridgeUserActions/fcp: -34%
  • ↑ bridgeUserActions/lcp: +554%
  • ↑ bridgeUserActions/cls: +387%
  • ↑ loadNewAccount/load_new_account: +184%
  • ↑ loadNewAccount/total: +184%
  • ↓ loadNewAccount/inp: -10%
  • ↑ loadNewAccount/fcp: +16%
  • ↑ loadNewAccount/lcp: +1216%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -21%
  • ↓ confirmTx/fcp: -35%
  • ↑ confirmTx/lcp: +1338%
  • ↑ bridgeUserActions/bridge_load_page: +170%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +135%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +74%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -41%
  • ↑ bridgeUserActions/lcp: +1233%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +90%
  • ↑ startupStandardHome/load: +126%
  • ↑ startupStandardHome/domContentLoaded: +127%
  • ↑ startupStandardHome/domInteractive: +28%
  • ↓ startupStandardHome/firstPaint: -55%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +125%
  • ↑ startupStandardHome/setupStore: +140%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +123%
  • ↑ startupStandardHome/longTaskMaxDuration: +136%
  • ↑ startupStandardHome/tbt: +147%
  • ↓ startupStandardHome/fcp: -48%
  • ↑ startupStandardHome/lcp: +134%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -39%
  • ↓ startupStandardHome/load: -36%
  • ↓ startupStandardHome/domContentLoaded: -37%
  • ↓ startupStandardHome/domInteractive: -58%
  • ↓ startupStandardHome/backgroundConnect: -35%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -36%
  • ↑ startupStandardHome/setupStore: +46%
  • ↓ startupStandardHome/fcp: -49%
  • ↓ startupStandardHome/lcp: -35%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/confirmSrpToPwForm: +24%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +29%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +17%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -10%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +30%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +15%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +12%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -69%
  • ↓ onboardingNewWallet/longTaskCount: -23%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -43%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -28%
  • ↓ onboardingNewWallet/tbt: -82%
  • ↓ onboardingNewWallet/total: -65%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -69%
  • ↓ dappPageLoad/domContentLoaded: -37%
  • ↓ dappPageLoad/firstPaint: -52%
  • ↓ dappPageLoad/firstContentfulPaint: -52%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.24 MiB +293 Bytes 0.00%
🚨 ui 19.44 MiB +1.89 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +7 Bytes 0.00%
✅ content scripts 3.22 MiB +14 Bytes 0.00%
🚨 unzipped 79.89 MiB +2.57 KiB 0.00%
✅ zip 24 MiB +963 Bytes 0.00%

@NidhiKJha
NidhiKJha marked this pull request as ready for review November 10, 2026 14:28
@NidhiKJha
NidhiKJha requested a review from a team as a code owner November 10, 2026 14:28

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8d705ec. Configure here.

@metamask-ci

metamask-ci Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor
Builds ready [8d705ec]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 2 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42834662480 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/inp: -18%
  • ↑ loadNewAccount/lcp: +945%
  • ↑ loadNewAccount/cls: +596%
  • ↑ confirmTx/longTaskCount: +67%
  • ↑ confirmTx/longTaskTotalDuration: +76%
  • ↑ confirmTx/longTaskMaxDuration: +54%
  • ↑ confirmTx/tbt: +86%
  • ↓ confirmTx/inp: -21%
  • ↑ confirmTx/lcp: +940%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +146%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +36%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +91%
  • ↑ bridgeUserActions/longTaskMaxDuration: +39%
  • ↑ bridgeUserActions/tbt: +179%
  • ↑ bridgeUserActions/total: +25%
  • ↑ bridgeUserActions/lcp: +918%
  • ↑ bridgeUserActions/cls: +634%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -25%
  • ↑ loadNewAccount/fcp: +23%
  • ↑ loadNewAccount/lcp: +1320%
  • ↑ confirmTx/confirm_tx: +10%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/total: +10%
  • ↑ confirmTx/inp: +11%
  • ↑ confirmTx/fcp: +23%
  • ↑ confirmTx/lcp: +1320%
  • ↑ bridgeUserActions/bridge_load_page: +255%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +133%
  • ↑ bridgeUserActions/bridge_search_token: +23%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +62%
  • ↑ bridgeUserActions/inp: +62%
  • ↑ bridgeUserActions/fcp: +17%
  • ↑ bridgeUserActions/lcp: +1282%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 loadNewAccount/FCP: p75 2.1s
  • 🟡 loadNewAccount/LCP: p75 2.5s
  • 🟡 confirmTx/FCP: p75 2.1s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +43%
  • ↑ startupStandardHome/load: +69%
  • ↑ startupStandardHome/domContentLoaded: +69%
  • ↓ startupStandardHome/firstPaint: -48%
  • ↓ startupStandardHome/backgroundConnect: -20%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +68%
  • ↑ startupStandardHome/setupStore: +75%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +64%
  • ↑ startupStandardHome/longTaskMaxDuration: +75%
  • ↑ startupStandardHome/tbt: +80%
  • ↓ startupStandardHome/inp: -24%
  • ↓ startupStandardHome/fcp: -60%
  • ↑ startupStandardHome/lcp: +81%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -33%
  • ↓ startupStandardHome/load: -28%
  • ↓ startupStandardHome/domContentLoaded: -29%
  • ↑ startupStandardHome/domInteractive: +21%
  • ↓ startupStandardHome/backgroundConnect: -22%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -28%
  • ↓ startupStandardHome/setupStore: -24%
  • ↑ startupStandardHome/fcp: +21%
  • ↓ startupStandardHome/lcp: -25%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -25%
  • ↓ onboardingImportWallet/pwFormToMetricsScreen: -11%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -37%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -86%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -12%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -14%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -18%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -78%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -74%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -49%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.24 MiB +299 Bytes 0.00%
✅ ui 19.44 MiB +605 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB 0 Bytes 0.00%
✅ content scripts 3.22 MiB 0 Bytes 0.00%
🚨 unzipped 79.89 MiB +1.28 KiB 0.00%
✅ zip 24 MiB +407 Bytes 0.00%

@metamask-ci

metamask-ci Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor
Builds ready [13d651c]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 1 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43195585749 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -25%
  • ↓ loadNewAccount/fcp: -18%
  • ↑ loadNewAccount/lcp: +705%
  • ↑ loadNewAccount/cls: +297%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +30%
  • ↑ confirmTx/longTaskMaxDuration: +23%
  • ↑ confirmTx/tbt: +30%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -13%
  • ↑ confirmTx/lcp: +774%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +16%
  • ↓ bridgeUserActions/fcp: -17%
  • ↑ bridgeUserActions/lcp: +715%
  • ↑ bridgeUserActions/cls: +387%
  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/inp: -10%
  • ↓ loadNewAccount/fcp: -37%
  • ↑ loadNewAccount/lcp: +1253%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -13%
  • ↓ confirmTx/fcp: -35%
  • ↑ confirmTx/lcp: +1342%
  • ↑ bridgeUserActions/bridge_load_page: +267%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +122%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +54%
  • ↑ bridgeUserActions/inp: +62%
  • ↓ bridgeUserActions/fcp: -35%
  • ↑ bridgeUserActions/lcp: +1304%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +22%
  • ↑ startupStandardHome/load: +42%
  • ↑ startupStandardHome/domContentLoaded: +42%
  • ↓ startupStandardHome/domInteractive: -11%
  • ↓ startupStandardHome/firstPaint: -35%
  • ↓ startupStandardHome/backgroundConnect: -23%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -64%
  • ↑ startupStandardHome/loadScripts: +41%
  • ↑ startupStandardHome/setupStore: +30%
  • ↑ startupStandardHome/numNetworkReqs: +11%
  • ↑ startupStandardHome/longTaskTotalDuration: +37%
  • ↑ startupStandardHome/longTaskMaxDuration: +62%
  • ↑ startupStandardHome/tbt: +47%
  • ↓ startupStandardHome/inp: -30%
  • ↑ startupStandardHome/fcp: +38%
  • ↑ startupStandardHome/lcp: +520%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -34%
  • ↓ startupStandardHome/load: -29%
  • ↓ startupStandardHome/domContentLoaded: -31%
  • ↓ startupStandardHome/domInteractive: -16%
  • ↓ startupStandardHome/backgroundConnect: -25%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -29%
  • ↓ startupStandardHome/setupStore: -24%
  • ↓ startupStandardHome/fcp: -20%
  • ↓ startupStandardHome/lcp: -27%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -15%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -32%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -12%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -30%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -10%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -46%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -76%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -72%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -55%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.22 MiB -19.03 KiB -0.12%
🚨 ui 19.5 MiB +61.56 KiB +0.31%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +173 Bytes 0.00%
✅ content scripts 3.22 MiB +350 Bytes +0.01%
🚨 unzipped 79.93 MiB +43.71 KiB +0.05%
🚨 zip 24.02 MiB +18.26 KiB +0.07%

@sonarqubecloud

Copy link
Copy Markdown

@NidhiKJha
NidhiKJha enabled auto-merge November 12, 2026 10:16
@NidhiKJha
NidhiKJha added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit 31fe638 Nov 12, 2026
140 checks passed
@NidhiKJha
NidhiKJha deleted the fix/json-import-password-error branch November 12, 2026 13:55
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 12, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026

This branch was previously deployed

1 inactive deployment
pr-comment — 13d651c9 Deployed Nov 12, 2026 by NidhiKJha via Publish prerelease / Publish prerelease #174263
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-M team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants