Skip to content

chore: Bump gas-fee-controller to 27.1.1 - #47821

Merged
mcmire merged 4 commits into
mainfrom
upgrade-gas-fee-controller
Nov 11, 2026
Merged

mcmire merged 4 commits into
mainfrom
upgrade-gas-fee-controller

Conversation

@mcmire

@mcmire mcmire commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Description

Currently, we are using @metamask/gas-fee-controller 26.1.0, when the latest version is 27.1.1. This blocks an initiative by the Core Platform team to streamline the background<->UI connection API so that it goes through the root messenger instead of a bespoke object (as not all GasFeeController methods that should be registered through the messenger actually are). This PR bumps gas-fee-controller accordingly.

The good news is that GasFeeController is initialized through the wallet package, which is already using 27.1.1. We do import some types through gas-fee-controller directly, but none of the breaking changes between 26.x and 27.x affect how they're used, so there's nothing we need to adapt to.

You can view the changelog for gas-fee-controller here.

Changelog

CHANGELOG entry: null

Related issues

https://consensyssoftware.atlassian.net/browse/WPC-1584

Manual testing steps

This PR should have no functional changes. All flows should work as-is.

Screenshots/Recordings

(N/A)

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Dependency version and LavaMoat policy updates only; no runtime code changes in the diff.

Overview
Bumps @metamask/gas-fee-controller from 26.1.0 to 27.1.1 in package.json and the lockfile, with no application source edits in this PR.

LavaMoat webpack policies (mv2/mv3 variants) are regenerated to match the new dependency graph: gas-fee-controller now uses package-scoped entries for its nested deps (e.g. @metamask/gas-fee-controller>@metamask/controller-utils, polling, uuid), duplicate nested policies for transaction-controller/wallet-specific gas-fee bundles are removed in favor of the shared @metamask/gas-fee-controller entry, and @metamask/user-operation-controller>@metamask/gas-fee-controller is added where that controller bundles its own copy.

This aligns the extension with the version already used via wallet so messenger-based background↔UI wiring for gas fees can move forward without a functional behavior change expected from the bump alone.

Reviewed by Cursor Bugbot for commit bb348ca. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci metamask-ci Bot added the team-core-platform Core Platform team label Nov 11, 2026
@mcmire
mcmire force-pushed the upgrade-gas-fee-controller branch from 6e283bd to 4e12042 Compare November 11, 2026 05:23
@mcmire

mcmire commented Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

@metamaskbot update-policies

@metamask-ci

metamask-ci Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Policies updated.
👀 Please review the diff for suspicious new powers.

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.
🧠 Learn how to read policy diffs: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

👀 lavamoat/webpack/mv2/beta/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes
👀 lavamoat/webpack/mv2/experimental/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes
👀 lavamoat/webpack/mv2/flask/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes
✅ lavamoat/webpack/mv3/beta/policy.json changes match lavamoat/webpack/mv3/main/policy.json changes
✅ lavamoat/webpack/mv3/experimental/policy.json changes match lavamoat/webpack/mv3/main/policy.json changes
✅ lavamoat/webpack/mv3/flask/policy.json changes match lavamoat/webpack/mv3/main/policy.json changes

@metamask-ci

metamask-ci Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

📜 @MetaMask/policy-reviewers (8 files, +296 -312)
  • 📁 lavamoat/
    • 📁 webpack/
      • 📁 mv2/
        • 📁 beta/
          • 📄 policy.json +37 -39
        • 📁 experimental/
          • 📄 policy.json +37 -39
        • 📁 flask/
          • 📄 policy.json +37 -39
        • 📁 main/
          • 📄 policy.json +37 -39
      • 📁 mv3/
        • 📁 beta/
          • 📄 policy.json +37 -39
        • 📁 experimental/
          • 📄 policy.json +37 -39
        • 📁 flask/
          • 📄 policy.json +37 -39
        • 📁 main/
          • 📄 policy.json +37 -39

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

@mcmire mcmire changed the title Bump gas-fee-controller to 27.1.1 chore: Bump gas-fee-controller to 27.1.1 Nov 11, 2026
@mcmire

mcmire commented Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

@metamaskbot update-policies

@metamask-ci

metamask-ci Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Policies updated.
👀 Please review the diff for suspicious new powers.

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.
🧠 Learn how to read policy diffs: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

👀 lavamoat/webpack/mv2/beta/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes
👀 lavamoat/webpack/mv2/experimental/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes
👀 lavamoat/webpack/mv2/flask/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes
👀 lavamoat/webpack/mv3/beta/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes
👀 lavamoat/webpack/mv3/experimental/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes
👀 lavamoat/webpack/mv3/flask/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes

@metamask-ci

metamask-ci Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor
Builds ready [6420530]
⚡ Performance Benchmarks (Total: 🟢 11 pass · 🟡 0 warn · 🔴 0 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42969049536 | Baseline logs

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -47%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs [🚀 Bundle size reduced!]
Status Bundle Total Diff Change
✅ background 15.21 MiB -8.72 KiB -0.06%
✅ ui 19.48 MiB -134 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB -1.72 KiB -0.04%
✅ content scripts 3.22 MiB -3.45 KiB -0.10%
✅ unzipped 79.89 MiB -14.02 KiB -0.02%
✅ zip 24 MiB -1.26 KiB -0.01%

@metamask-ci

metamask-ci Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor
Builds ready [bb348ca]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 2 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42971783412 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -40%
  • ↓ loadNewAccount/fcp: -16%
  • ↑ loadNewAccount/lcp: +720%
  • ↑ loadNewAccount/cls: +297%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +18%
  • ↑ confirmTx/longTaskMaxDuration: +17%
  • ↑ confirmTx/tbt: +11%
  • ↓ confirmTx/inp: -44%
  • ↓ confirmTx/fcp: -21%
  • ↑ confirmTx/lcp: +692%
  • ↑ bridgeUserActions/bridge_load_page: +33%
  • ↓ bridgeUserActions/longTaskTotalDuration: -18%
  • ↓ bridgeUserActions/longTaskMaxDuration: -24%
  • ↓ bridgeUserActions/tbt: -31%
  • ↓ bridgeUserActions/inp: -19%
  • ↓ bridgeUserActions/fcp: -20%
  • ↑ bridgeUserActions/lcp: +688%
  • ↑ bridgeUserActions/cls: +506%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↑ loadNewAccount/inp: +176%
  • ↓ loadNewAccount/fcp: -39%
  • ↑ loadNewAccount/lcp: +1213%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/fcp: +20%
  • ↑ confirmTx/lcp: +1344%
  • ↑ bridgeUserActions/bridge_load_page: +338%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +130%
  • ↑ bridgeUserActions/bridge_search_token: +48%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +79%
  • ↑ bridgeUserActions/inp: +54%
  • ↑ bridgeUserActions/fcp: +17%
  • ↑ bridgeUserActions/lcp: +1269%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/INP: p75 296ms
  • 🟡 confirmTx/FCP: p75 2.1s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +81%
  • ↑ startupStandardHome/load: +111%
  • ↑ startupStandardHome/domContentLoaded: +111%
  • ↑ startupStandardHome/domInteractive: +29%
  • ↓ startupStandardHome/firstPaint: -33%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +109%
  • ↑ startupStandardHome/setupStore: +140%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +108%
  • ↑ startupStandardHome/longTaskMaxDuration: +150%
  • ↑ startupStandardHome/tbt: +134%
  • ↑ startupStandardHome/fcp: +107%
  • ↑ startupStandardHome/lcp: +832%
  • ↓ startupStandardHome/cls: -72%
  • ↑ startupStandardHome/domInteractive: +13%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/fcp: +11%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +13%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -10%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -11%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -11%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -39%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -79%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -76%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -69%
  • ↓ dappPageLoad/domContentLoaded: -37%
  • ↓ dappPageLoad/firstPaint: -52%
  • ↓ dappPageLoad/firstContentfulPaint: -52%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.21 MiB -7.49 KiB -0.05%
🚨 ui 19.48 MiB +1.1 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB -502 Bytes -0.01%
✅ content scripts 3.22 MiB -1004 Bytes -0.03%
✅ unzipped 79.89 MiB -7.85 KiB -0.01%
✅ zip 24.01 MiB -863 Bytes 0.00%

@sonarqubecloud

Copy link
Copy Markdown

@mcmire
mcmire marked this pull request as ready for review November 11, 2026 06:53
@mcmire
mcmire requested a review from a team as a code owner November 11, 2026 06:53
@FrederikBolding
FrederikBolding added this pull request to the merge queue Nov 11, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 11, 2026
@mcmire
mcmire added this pull request to the merge queue Nov 11, 2026
Merged via the queue into main with commit 388b476 Nov 11, 2026
151 of 154 checks passed
@mcmire
mcmire deleted the upgrade-gas-fee-controller branch November 11, 2026 15:52
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 11, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.58.0 on PR, as PR was added to branch 13.58.0 when release was cut.

This branch was previously deployed

1 inactive deployment
pr-comment — bb348ca9 Deployed Nov 11, 2026 by mcmire via identify-codeowners #89521
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-XS team-core-platform Core Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants