Repository navigation
chore(multichain): remove unused permissions page stylesheets - #47825
Merged
georgewrmarshall merged 1 commit intoNov 11, 2026
Merged
georgewrmarshall merged 1 commit into
georgewrmarshall merged 1 commit into
Conversation
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
georgewrmarshall
temporarily deployed
to
pr-comment
November 11, 2026 09:13 — with
GitHub Actions
Inactive
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (2 files, +0 -8)
|
georgewrmarshall
temporarily deployed
to
pr-comment
November 11, 2026 09:28 — with
GitHub Actions
Inactive
Contributor
Builds ready [9171ab6]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 3 warn · 🔴 4 fail)
Bundle Size Diffs
|
|
georgewrmarshall
enabled auto-merge
November 11, 2026 18:59
amandaye0h
approved these changes
Nov 11, 2026
n3ps
approved these changes
Nov 11, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 11, 2026
georgewrmarshall
deleted the
cursor/remove-dead-code-permissions-page-styles-20261111-567b
branch
November 11, 2026 22:19
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Removes two stylesheets under
ui/components/multichain/pages/permissions-page/that no stylesheet barrel or component imports, so they are never compiled into any build.ui/components/multichain/pages/index.scssused to importpermissions-page/permissions-page, neverpermissions-page/index. #36052 removed that import too. As a result,index.scssand theconnection-list-item.scssit imports have not been part of the bundle since they were added in #24099.ConnectionListItemstill setsclassName="multichain-connection-list-item", and that is left unchanged, but the hover styles in this file never reached the UI.Owner set:
@MetaMask/core-extension-ux.ui/components/multichain/pages/permissions-page/index.scss@import/importof it anywhere)ui/components/multichain/pages/permissions-page/connection-list-item.scss.multichain-connection-list-itemhover rules)index.scss(only importer)No user-facing behavior change.
Checks passed:
yarn lint:styles,yarn test:unitforui/components/multichain/pages/permissions-pagewith no snapshot updates. No JS/TS changed, soyarn lint:tscand eslint are not affected.Docs/comments updated: none
Changelog
CHANGELOG entry: null
Related issues
Refs: proactive dead-code cleanup (extension counterpart of metamask-mobile#37948)
Manual testing steps
N/A — deletes unreachable code. There is no user-facing behavior to click through.
Screenshots/Recordings
N/A — no UI change
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Dead stylesheet removal only; no JS/TS or runtime styling path changes.
Overview
Deletes unused multichain permissions page SCSS that was never pulled into the build:
connection-list-item.scss(hover rules for.multichain-connection-list-item) andpermissions-page/index.scss, which only re-exported that file.ConnectionListItemstill applies the sameclassName; those rules were already absent from compiled styles, so behavior is unchanged.Reviewed by Cursor Bugbot for commit 9171ab6. Bugbot is set up for automated code reviews on this repo. Configure here.