Skip to content

feat: add wide screen token table sort controls - #47835

Merged
ameliejyc merged 10 commits into
mainfrom
add-sort-controls-token-table-wide-screen
Nov 11, 2026
Merged

ameliejyc merged 10 commits into
mainfrom
add-sort-controls-token-table-wide-screen

Conversation

@ameliejyc

@ameliejyc ameliejyc commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Description

This PR affects the new wide screen experience only, where the Token List renders as a new Token Table. This PR adds in sort controls to the 4 headers: Token, Price, 24h Change, Balance. When sorted, they stay local to the table and are not written to the saved sort preference (the existing tokenSortConfig). So the sort preference in state is unchanged, and DeFi still uses that preference, as well as non-widescreen Token List.

The down arrow is the default: A–Z, or the highest value first. The first click on a column selects that default. Another click reverses it. Missing and non-finite prices and 24h changes sort last in both directions. Equal prices and changes fall back to the token name. Low-balance tokens collapse only for a high-to-low balance sort. Changing the saved sort clears the header selection.

If a user hasn't sorted on the table, it will show the active sort currently being used in the tokenSortConfig i.e. Token (alphabetical) or Balance (descending).

Piece File Change
TokenTable, TokenTableHeader ui/components/app/assets/token-table/token-table.tsx Header buttons and the local sort state.
useTokenSortOverride ui/components/app/assets/hooks/useTokenSortOverride.ts New. Turns the header click into the sort override, and reads price or 24h only when that column is selected.
useTokenListData ui/components/app/assets/hooks/useTokenListData.ts Takes the override, filters before sorting, and collapses low-balance tokens only for a high-to-low balance sort.
sortTokenAssets ui/components/app/assets/util/sortAssetsWithPriority.ts New. Applies the header override. The saved-preference sort stays in sortAssetsWithPriority.
getCachedSpotPrice, getCachedPercentChange shared/lib/token-price.ts New. Shared price and 24h reads.
TokenCellPercentChange ui/components/app/assets/token-cell/cells/token-cell-percent-change.tsx 24h change now comes from getCachedPercentChange.
useCachedPrice ui/pages/asset/hooks/useCurrentPrice.ts Spot price now comes from getCachedSpotPrice.

Changelog

CHANGELOG entry: Adds sort controls to the wide screen Token Table

Related issues

Part fixes: https://consensyssoftware.atlassian.net/browse/CEUX-1482

Manual testing steps

  1. Open the home screen at least 768px wide, so the token table is shown.
  2. Click Price. The arrow points down and the highest price is first. Tokens with no price stay at the bottom.
  3. Click Price again. The arrow points up, the lowest price is first, and tokens with no price stay at the bottom.
  4. Widen the table until 24h change is its own column, and repeat those two clicks. The largest gain is first, then the largest loss. Missing changes stay at the bottom.
  5. Click Token, then Balance. The first click on Token is A–Z. Balance starts as the saved high-to-low sort, so the first click reverses it.
  6. With the balance arrow pointing down, confirm low-balance tokens are behind the collapsed section. Reverse the balance sort, or sort by price, and confirm those tokens appear in the list.
  7. Sort by price, then narrow the window below 768px. The token list replaces the table, and widening it again does not restore the price sort.
  8. Verify that one smaller screens there is no difference to the existing Token List sort behaviour

Screenshots/Recordings

Before

After

token.table.sort.behaviour.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
UI-only sorting and shared price read helpers with test coverage; saved global sort preference behavior is explicitly preserved.

Overview
Adds click-to-sort headers on the wide-screen Token Table for Token, Price, 24h Change, and Balance. Sorting is session-local (not written to tokenSortConfig); the UI reflects the saved preference until a header is clicked, then clears header sort when that preference changes. Headers show direction arrows and accessible sorted ascending/descending labels.

Sorting is driven by a new sortTokenAssets path (optional header override) wired through useTokenSortOverride and an optional sortOverride on useTokenListData. Price and 24h sorts use shared getCachedSpotPrice / getCachedPercentChange helpers (also used by useCachedPrice and token cell 24h display). Missing/non-finite values sort last; low-value token collapse still applies only for high-to-low balance sort.

Locale strings and broad unit/integration tests cover header toggling, preference reset, and sort ordering.

Reviewed by Cursor Bugbot for commit 3d99580. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci metamask-ci Bot added the team-core-extension-ux Core Extension UX team label Nov 11, 2026
@metamask-ci

metamask-ci Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

💎 @MetaMask/metamask-assets (8 files, +784 -117)
  • 📁 ui/
    • 📁 components/
      • 📁 app/
        • 📁 assets/
          • 📁 hooks/
            • 📄 useTokenListData.ts +45 -30
            • 📄 useTokenSortOverride.ts +73 -0
          • 📁 token-cell/
            • 📁 cells/
              • 📄 token-cell-percent-change.tsx +12 -16
          • 📁 token-list/
            • 📄 token-list.test.tsx +1 -0
          • 📁 token-table/
            • 📄 token-table.test.tsx +205 -6
            • 📄 token-table.tsx +158 -38
          • 📁 util/
            • 📄 sortAssetsWithPriority.test.ts +157 -11
            • 📄 sortAssetsWithPriority.ts +133 -16

Copy link
Copy Markdown

Accessibility (draft)

I know this is still a draft, so no rush. Just flagging for when you wrap up.

The new sort headers in token-table.tsx only show which column is sorted, and in which direction, through the little arrow icon (token-table.tsx:74-96). A screen reader user just hears "Token, button" or "Balance, button" and can't tell what's sorted or whether a press flipped it. Adding an aria-label that includes the state (something like "Balance, sorted descending") or giving the header cells role="columnheader" with aria-sort would fix it (WCAG 1.3.1, 4.1.2).

An AI accessibility agent posted this. If this is wrong, reply here.

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@metamask-ci

metamask-ci Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor
Builds ready [4dac669]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43015644753 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +180%
  • ↑ loadNewAccount/total: +180%
  • ↓ loadNewAccount/inp: -33%
  • ↓ loadNewAccount/fcp: -16%
  • ↑ loadNewAccount/lcp: +725%
  • ↑ loadNewAccount/cls: +294%
  • ↑ confirmTx/longTaskMaxDuration: +20%
  • ↑ confirmTx/tbt: +13%
  • ↓ confirmTx/inp: -29%
  • ↓ confirmTx/fcp: -13%
  • ↑ confirmTx/lcp: +774%
  • ↓ confirmTx/cls: -14%
  • ↓ bridgeUserActions/longTaskTotalDuration: -20%
  • ↓ bridgeUserActions/longTaskMaxDuration: -24%
  • ↓ bridgeUserActions/tbt: -35%
  • ↓ bridgeUserActions/inp: -19%
  • ↓ bridgeUserActions/fcp: -19%
  • ↑ bridgeUserActions/lcp: +697%
  • ↑ bridgeUserActions/cls: +621%
  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/fcp: -31%
  • ↑ loadNewAccount/lcp: +1319%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -13%
  • ↓ confirmTx/fcp: -28%
  • ↑ confirmTx/lcp: +1375%
  • ↑ bridgeUserActions/bridge_load_page: +188%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +331%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +70%
  • ↑ bridgeUserActions/inp: +62%
  • ↓ bridgeUserActions/fcp: -33%
  • ↑ bridgeUserActions/lcp: +1353%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/LCP: p75 2.5s
  • 🟡 confirmTx/LCP: p75 2.5s
  • 🟡 bridgeUserActions/LCP: p75 2.6s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +96%
  • ↑ startupStandardHome/load: +131%
  • ↑ startupStandardHome/domContentLoaded: +131%
  • ↑ startupStandardHome/domInteractive: +30%
  • ↓ startupStandardHome/firstPaint: -53%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +129%
  • ↑ startupStandardHome/setupStore: +127%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +132%
  • ↑ startupStandardHome/longTaskMaxDuration: +142%
  • ↑ startupStandardHome/tbt: +154%
  • ↓ startupStandardHome/fcp: -47%
  • ↑ startupStandardHome/lcp: +139%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -37%
  • ↓ startupStandardHome/load: -32%
  • ↓ startupStandardHome/domContentLoaded: -34%
  • ↓ startupStandardHome/domInteractive: -55%
  • ↓ startupStandardHome/backgroundConnect: -26%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -32%
  • ↑ startupStandardHome/setupStore: +30%
  • ↓ startupStandardHome/fcp: -39%
  • ↓ startupStandardHome/lcp: -30%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +14%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +39%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +44%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -91%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -95%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -91%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +36%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +11%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -74%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -69%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -67%
  • ↓ dappPageLoad/domContentLoaded: -33%
  • ↓ dappPageLoad/firstPaint: -52%
  • ↓ dappPageLoad/firstContentfulPaint: -52%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.21 MiB +61 Bytes 0.00%
🚨 ui 19.48 MiB +5.93 KiB +0.03%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +46 Bytes 0.00%
✅ content scripts 3.22 MiB +100 Bytes 0.00%
🚨 unzipped 79.9 MiB +5.97 KiB +0.01%
🚨 zip 24.01 MiB +1.92 KiB +0.01%

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@metamask-ci

metamask-ci Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor
Builds ready [47936eb]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 2 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43025178358 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +179%
  • ↑ loadNewAccount/total: +179%
  • ↓ loadNewAccount/inp: -48%
  • ↓ loadNewAccount/fcp: -28%
  • ↑ loadNewAccount/lcp: +612%
  • ↑ loadNewAccount/cls: +629%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +14%
  • ↓ confirmTx/inp: -44%
  • ↓ confirmTx/fcp: -32%
  • ↑ confirmTx/lcp: +587%
  • ↓ bridgeUserActions/longTaskTotalDuration: -28%
  • ↓ bridgeUserActions/longTaskMaxDuration: -30%
  • ↓ bridgeUserActions/tbt: -56%
  • ↓ bridgeUserActions/inp: -26%
  • ↓ bridgeUserActions/fcp: -31%
  • ↑ bridgeUserActions/lcp: +583%
  • ↑ bridgeUserActions/cls: +634%
  • ↑ loadNewAccount/load_new_account: +180%
  • ↑ loadNewAccount/total: +180%
  • ↓ loadNewAccount/inp: -10%
  • ↓ loadNewAccount/fcp: -63%
  • ↑ loadNewAccount/lcp: +842%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/inp: +98%
  • ↓ confirmTx/fcp: -71%
  • ↑ confirmTx/lcp: +943%
  • ↑ bridgeUserActions/bridge_load_page: +94%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +28%
  • ↓ bridgeUserActions/bridge_search_token: -10%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↓ bridgeUserActions/fcp: -71%
  • ↑ bridgeUserActions/lcp: +856%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +49%
  • ↑ startupStandardHome/load: +75%
  • ↑ startupStandardHome/domContentLoaded: +75%
  • ↓ startupStandardHome/firstPaint: -45%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +73%
  • ↑ startupStandardHome/setupStore: +82%
  • ↑ startupStandardHome/longTaskTotalDuration: +71%
  • ↑ startupStandardHome/longTaskMaxDuration: +82%
  • ↑ startupStandardHome/tbt: +87%
  • ↓ startupStandardHome/inp: -18%
  • ↑ startupStandardHome/lcp: +329%
  • ↓ startupStandardHome/cls: -72%
  • ↑ startupStandardHome/domInteractive: +18%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/inp: +100%
  • ↑ startupStandardHome/fcp: +20%
  • ↑ startupStandardHome/lcp: +12%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -17%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -12%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -34%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -19%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -10%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -47%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -77%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -74%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -60%
  • ↓ dappPageLoad/domContentLoaded: -19%
  • ↓ dappPageLoad/firstPaint: -42%
  • ↓ dappPageLoad/firstContentfulPaint: -42%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.22 MiB +355 Bytes 0.00%
🚨 ui 19.48 MiB +7.41 KiB +0.04%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +53 Bytes 0.00%
✅ content scripts 3.22 MiB +114 Bytes 0.00%
🚨 unzipped 79.91 MiB +8.4 KiB +0.01%
🚨 zip 24.01 MiB +2.57 KiB +0.01%

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a139be4. Configure here.

@metamask-ci

metamask-ci Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor
Builds ready [a139be4]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 3 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43033039716 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↑ loadNewAccount/lcp: +945%
  • ↑ loadNewAccount/cls: +596%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +51%
  • ↑ confirmTx/longTaskMaxDuration: +59%
  • ↑ confirmTx/tbt: +66%
  • ↓ confirmTx/inp: -13%
  • ↑ confirmTx/fcp: +11%
  • ↑ confirmTx/lcp: +1015%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +96%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +62%
  • ↑ bridgeUserActions/longTaskCount: +82%
  • ↑ bridgeUserActions/longTaskTotalDuration: +89%
  • ↑ bridgeUserActions/longTaskMaxDuration: +12%
  • ↑ bridgeUserActions/tbt: +92%
  • ↑ bridgeUserActions/total: +30%
  • ↑ bridgeUserActions/inp: +10%
  • ↑ bridgeUserActions/lcp: +954%
  • ↑ bridgeUserActions/cls: +634%
  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/inp: -10%
  • ↓ loadNewAccount/fcp: -41%
  • ↑ loadNewAccount/lcp: +1270%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -13%
  • ↑ confirmTx/fcp: +15%
  • ↑ confirmTx/lcp: +1279%
  • ↑ bridgeUserActions/bridge_load_page: +164%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +136%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +33%
  • ↑ bridgeUserActions/inp: +47%
  • ↓ bridgeUserActions/fcp: -38%
  • ↑ bridgeUserActions/lcp: +1253%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +25%
  • ↑ startupStandardHome/load: +46%
  • ↑ startupStandardHome/domContentLoaded: +46%
  • ↓ startupStandardHome/firstPaint: -45%
  • ↓ startupStandardHome/backgroundConnect: -22%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +45%
  • ↑ startupStandardHome/setupStore: +49%
  • ↑ startupStandardHome/numNetworkReqs: +11%
  • ↑ startupStandardHome/longTaskTotalDuration: +41%
  • ↑ startupStandardHome/longTaskMaxDuration: +66%
  • ↑ startupStandardHome/tbt: +52%
  • ↓ startupStandardHome/inp: -30%
  • ↑ startupStandardHome/fcp: +41%
  • ↑ startupStandardHome/lcp: +533%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -18%
  • ↓ startupStandardHome/load: -12%
  • ↓ startupStandardHome/domContentLoaded: -14%
  • ↑ startupStandardHome/domInteractive: +23%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -12%
  • ↑ startupStandardHome/fcp: +23%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +17%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +20%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +30%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +18%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +10%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -73%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -70%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -29%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -68%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -68%
  • ↓ dappPageLoad/domContentLoaded: -35%
  • ↓ dappPageLoad/firstPaint: -52%
  • ↓ dappPageLoad/firstContentfulPaint: -52%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.22 MiB +355 Bytes 0.00%
🚨 ui 19.48 MiB +7.79 KiB +0.04%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +53 Bytes 0.00%
✅ content scripts 3.22 MiB +114 Bytes 0.00%
🚨 unzipped 79.91 MiB +8.61 KiB +0.01%
🚨 zip 24.01 MiB +2.63 KiB +0.01%

@metamask-ci

metamask-ci Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor
Builds ready [effbca3]
⚡ Performance Benchmarks (Total: 🟢 10 pass · 🟡 1 warn · 🔴 2 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43037339934 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -40%
  • ↓ loadNewAccount/fcp: -13%
  • ↑ loadNewAccount/lcp: +757%
  • ↑ loadNewAccount/cls: +294%
  • ↑ confirmTx/longTaskMaxDuration: +15%
  • ↑ confirmTx/tbt: +15%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -13%
  • ↑ confirmTx/lcp: +772%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +39%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +58%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↓ bridgeUserActions/longTaskMaxDuration: -20%
  • ↓ bridgeUserActions/tbt: -30%
  • ↓ bridgeUserActions/inp: -19%
  • ↑ bridgeUserActions/lcp: +877%
  • ↑ bridgeUserActions/cls: +634%
  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↑ loadNewAccount/inp: +146%
  • ↓ loadNewAccount/fcp: -46%
  • ↑ loadNewAccount/lcp: +980%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -29%
  • ↓ confirmTx/fcp: -64%
  • ↑ confirmTx/lcp: +1045%
  • ↑ bridgeUserActions/bridge_load_page: +137%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +163%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +24%
  • ↑ bridgeUserActions/inp: +25%
  • ↓ bridgeUserActions/fcp: -61%
  • ↑ bridgeUserActions/lcp: +1014%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/INP: p75 264ms
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +11%
  • ↑ startupStandardHome/load: +31%
  • ↑ startupStandardHome/domContentLoaded: +31%
  • ↓ startupStandardHome/domInteractive: -15%
  • ↓ startupStandardHome/firstPaint: -43%
  • ↓ startupStandardHome/backgroundConnect: -28%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -64%
  • ↑ startupStandardHome/loadScripts: +30%
  • ↑ startupStandardHome/setupStore: +49%
  • ↑ startupStandardHome/longTaskTotalDuration: +27%
  • ↑ startupStandardHome/longTaskMaxDuration: +51%
  • ↑ startupStandardHome/tbt: +35%
  • ↓ startupStandardHome/inp: -37%
  • ↑ startupStandardHome/fcp: +28%
  • ↑ startupStandardHome/lcp: +475%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -23%
  • ↓ startupStandardHome/load: -19%
  • ↓ startupStandardHome/domContentLoaded: -21%
  • ↓ startupStandardHome/domInteractive: -43%
  • ↓ startupStandardHome/backgroundConnect: -12%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -19%
  • ↓ startupStandardHome/setupStore: -24%
  • ↓ startupStandardHome/fcp: -31%
  • ↓ startupStandardHome/lcp: -16%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -21%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -86%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -13%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -25%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -32%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -77%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -73%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -49%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.22 MiB +361 Bytes 0.00%
🚨 ui 19.49 MiB +9.68 KiB +0.05%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +59 Bytes 0.00%
✅ content scripts 3.22 MiB +126 Bytes 0.00%
🚨 unzipped 79.91 MiB +10.52 KiB +0.01%
🚨 zip 24.01 MiB +3.31 KiB +0.01%

@ameliejyc
ameliejyc marked this pull request as ready for review November 11, 2026 14:48
@ameliejyc
ameliejyc requested a review from a team as a code owner November 11, 2026 14:48
@metamask-ci

metamask-ci Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor
Builds ready [c6351b3]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43040417599 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +185%
  • ↑ loadNewAccount/total: +185%
  • ↓ loadNewAccount/inp: -18%
  • ↑ loadNewAccount/fcp: +22%
  • ↑ loadNewAccount/lcp: +1097%
  • ↑ loadNewAccount/cls: +297%
  • ↑ confirmTx/longTaskCount: +67%
  • ↑ confirmTx/longTaskTotalDuration: +68%
  • ↑ confirmTx/longTaskMaxDuration: +56%
  • ↑ confirmTx/tbt: +76%
  • ↑ confirmTx/lcp: +980%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +82%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +27%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +23%
  • ↑ bridgeUserActions/longTaskMaxDuration: +36%
  • ↑ bridgeUserActions/tbt: +44%
  • ↑ bridgeUserActions/lcp: +952%
  • ↑ bridgeUserActions/cls: +580%
  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/inp: -18%
  • ↓ loadNewAccount/fcp: -30%
  • ↑ loadNewAccount/lcp: +1381%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/fcp: -33%
  • ↑ confirmTx/lcp: +1419%
  • ↑ bridgeUserActions/bridge_load_page: +324%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +143%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +45%
  • ↑ bridgeUserActions/inp: +76%
  • ↓ bridgeUserActions/fcp: -33%
  • ↑ bridgeUserActions/lcp: +1392%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.1s
  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.8s
  • 🟡 loadNewAccount/LCP: p75 2.6s
  • 🟡 confirmTx/LCP: p75 2.6s
  • 🟡 bridgeUserActions/LCP: p75 2.6s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +31%
  • ↑ startupStandardHome/load: +56%
  • ↑ startupStandardHome/domContentLoaded: +56%
  • ↓ startupStandardHome/firstPaint: -35%
  • ↓ startupStandardHome/backgroundConnect: -24%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +55%
  • ↑ startupStandardHome/setupStore: +62%
  • ↑ startupStandardHome/longTaskTotalDuration: +50%
  • ↑ startupStandardHome/longTaskMaxDuration: +77%
  • ↑ startupStandardHome/tbt: +66%
  • ↓ startupStandardHome/inp: -24%
  • ↑ startupStandardHome/fcp: +51%
  • ↑ startupStandardHome/lcp: +578%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -39%
  • ↓ startupStandardHome/load: -35%
  • ↓ startupStandardHome/domContentLoaded: -37%
  • ↓ startupStandardHome/domInteractive: -58%
  • ↓ startupStandardHome/backgroundConnect: -29%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -35%
  • ↑ startupStandardHome/setupStore: +41%
  • ↓ startupStandardHome/fcp: -51%
  • ↓ startupStandardHome/lcp: -33%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +14%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +24%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +26%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +25%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +35%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +12%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +10%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -73%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -38%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -68%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -50%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.22 MiB +354 Bytes 0.00%
🚨 ui 19.49 MiB +9.35 KiB +0.05%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +52 Bytes 0.00%
✅ content scripts 3.22 MiB +112 Bytes 0.00%
🚨 unzipped 79.91 MiB +10.17 KiB +0.01%
🚨 zip 24.01 MiB +3.28 KiB +0.01%

@metamask-ci

metamask-ci Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor
Builds ready [3d99580]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43045028419 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/inp: -10%
  • ↑ loadNewAccount/fcp: +12%
  • ↑ loadNewAccount/lcp: +1004%
  • ↑ loadNewAccount/cls: +629%
  • ↑ confirmTx/longTaskCount: +67%
  • ↑ confirmTx/longTaskTotalDuration: +75%
  • ↑ confirmTx/longTaskMaxDuration: +64%
  • ↑ confirmTx/tbt: +86%
  • ↑ confirmTx/fcp: +10%
  • ↑ confirmTx/lcp: +1008%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +213%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +114%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +85%
  • ↑ bridgeUserActions/longTaskMaxDuration: +54%
  • ↑ bridgeUserActions/tbt: +163%
  • ↑ bridgeUserActions/total: +25%
  • ↑ bridgeUserActions/inp: +18%
  • ↑ bridgeUserActions/fcp: +11%
  • ↑ bridgeUserActions/lcp: +995%
  • ↑ bridgeUserActions/cls: +389%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -25%
  • ↑ loadNewAccount/fcp: +27%
  • ↑ loadNewAccount/lcp: +1338%
  • ↑ confirmTx/confirm_tx: +10%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/total: +10%
  • ↓ confirmTx/fcp: -51%
  • ↑ confirmTx/lcp: +1375%
  • ↑ bridgeUserActions/bridge_load_page: +230%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +143%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +31%
  • ↑ bridgeUserActions/inp: +62%
  • ↑ bridgeUserActions/fcp: +25%
  • ↑ bridgeUserActions/lcp: +1393%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 loadNewAccount/FCP: p75 2.2s
  • 🟡 loadNewAccount/LCP: p75 2.5s
  • 🟡 confirmTx/LCP: p75 2.5s
  • 🟡 bridgeUserActions/FCP: p75 2.2s
  • 🟡 bridgeUserActions/LCP: p75 2.6s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +93%
  • ↑ startupStandardHome/load: +128%
  • ↑ startupStandardHome/domContentLoaded: +129%
  • ↑ startupStandardHome/domInteractive: +30%
  • ↓ startupStandardHome/firstPaint: -53%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +127%
  • ↑ startupStandardHome/setupStore: +121%
  • ↑ startupStandardHome/longTaskCount: +79%
  • ↑ startupStandardHome/longTaskTotalDuration: +127%
  • ↑ startupStandardHome/longTaskMaxDuration: +136%
  • ↑ startupStandardHome/tbt: +152%
  • ↓ startupStandardHome/fcp: -49%
  • ↑ startupStandardHome/lcp: +131%
  • ↓ startupStandardHome/cls: -72%
  • ↑ startupStandardHome/domInteractive: +33%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/fcp: +41%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -15%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -24%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +11%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +63%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +19%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -68%
  • ↓ onboardingNewWallet/longTaskCount: -23%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -42%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -28%
  • ↓ onboardingNewWallet/tbt: -79%
  • ↓ onboardingNewWallet/total: -64%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -67%
  • ↓ dappPageLoad/domContentLoaded: -32%
  • ↓ dappPageLoad/firstPaint: -47%
  • ↓ dappPageLoad/firstContentfulPaint: -47%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.22 MiB +5.58 KiB +0.04%
🚨 ui 19.49 MiB +12.52 KiB +0.06%
✅ common 0 Bytes 0 Bytes 0.00%
🚨 other 4.46 MiB +1.12 KiB +0.02%
🚨 content scripts 3.22 MiB +2.24 KiB +0.07%
🚨 unzipped 79.92 MiB +21.78 KiB +0.03%
🚨 zip 24.01 MiB +4.8 KiB +0.02%

@sonarqubecloud

Copy link
Copy Markdown

Comment on lines +32 to +34
const marketData = useSelector(getMarketData);
const currencyRates = useSelector(getCurrencyRates);
const conversionRates = useSelector(getAssetsRates);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selectors I think you're using are okay. Long term we do want to get rid of these messy & complex selectors and have teams just rely on using the AssetsController object (no weird selector conversions needed).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this example I would love if we used directly a selector that uses AssetsController.assetPrices - right now I'm pretty sure these selectors come from some translation logic (mapping our new state to some legacy state)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh. Probably! Is that something your team is working on or you're mentioning as a general thought? I'm happy to consider that approach when I next touch these

@n3ps n3ps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ameliejyc
ameliejyc added this pull request to the merge queue Nov 11, 2026
Merged via the queue into main with commit 3f06885 Nov 11, 2026
139 of 140 checks passed
@ameliejyc
ameliejyc deleted the add-sort-controls-token-table-wide-screen branch November 11, 2026 16:25
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 11, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026

This branch was previously deployed

1 inactive deployment
pr-comment — 3d99580f Deployed Nov 11, 2026 by ameliejyc via Publish prerelease / Publish prerelease #174104
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-XL team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants