Skip to content

test: fix flaky test Deep Link - Parameter Handling & Security does not allow the loading screen over the deep link's component - #47837

Merged
seaona merged 1 commit into
mainfrom
flaky-privacy-snapsot-monad
Nov 12, 2026
Merged

seaona merged 1 commit into
mainfrom
flaky-privacy-snapsot-monad

Conversation

@seaona

@seaona seaona commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Description

Deep Link - Parameter Handling & Security does not allow the loading screen over the deep link's component is flaky in CI, failing with:

New hosts found: icy-attentive-sky.monad-mainnet.quiknode.pro

The test shuts down all local nodes so the network loading screen is shown. In e2e, Infura hosts (including monad-mainnet.infura.io) are redirected to localhost:8545, so every Monad RPC call fails. CI builds include QUICKNODE_MONAD_URL, so after enough failures the extension fails over to the Monad QuickNode endpoint. Whether that happens before the test ends depends on timing, which is why the test is flaky.
This adds the Monad QuickNode host to privacy-snapshot.json, the same way the existing QuickNode failover hosts (Ethereum mainnet, Base, Optimism, Polygon, Robinhood) are listed.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Check ci

Screenshots/Recordings

Before

image

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Test allowlist-only change with no runtime product logic; aligns with existing QuickNode entries in the same file.

Overview
Adds icy-attentive-sky.monad-mainnet.quiknode.pro to the privacy host allowlist in privacy-snapshot.json, matching other Monad/chain QuickNode failover endpoints already listed.

E2e privacy checks fail when CI builds with QUICKNODE_MONAD_URL and RPC failover hits that host after Infura redirects to localhost; including it stabilizes the flaky Deep Link - Parameter Handling & Security test.

Reviewed by Cursor Bugbot for commit 816a173. Bugbot is set up for automated code reviews on this repo. Configure here.

@seaona
seaona requested a review from a team as a code owner November 11, 2026 12:59
@seaona seaona changed the title test: add Monad QuickNode failover host to privacy snapshot test: fix flaky test Deep Link - Parameter Handling & Security does not allow the loading screen over the deep link's component Nov 11, 2026
@seaona seaona self-assigned this Nov 11, 2026
@metamask-ci metamask-ci Bot added the team-qa QA team label Nov 11, 2026
@seaona seaona added flaky tests no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed and removed team-qa QA team labels Nov 11, 2026
@metamask-ci

metamask-ci Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

🕵️ @MetaMask/extension-privacy-reviewers (1 files, +1 -0)
  • 📄 privacy-snapshot.json +1 -0

@metamask-ci

metamask-ci Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor
Builds ready [816a173] [reused from 68c107d]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 1 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43025390722 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +180%
  • ↑ loadNewAccount/total: +180%
  • ↓ loadNewAccount/inp: -40%
  • ↓ loadNewAccount/fcp: -17%
  • ↑ loadNewAccount/lcp: +718%
  • ↑ loadNewAccount/cls: +629%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskMaxDuration: +19%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -23%
  • ↑ confirmTx/lcp: +678%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +12%
  • ↓ bridgeUserActions/bridge_search_token: -11%
  • ↓ bridgeUserActions/longTaskTotalDuration: -19%
  • ↓ bridgeUserActions/longTaskMaxDuration: -19%
  • ↓ bridgeUserActions/tbt: -30%
  • ↓ bridgeUserActions/inp: -26%
  • ↓ bridgeUserActions/fcp: -23%
  • ↑ bridgeUserActions/lcp: +663%
  • ↑ bridgeUserActions/cls: +389%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↑ loadNewAccount/inp: +19%
  • ↓ loadNewAccount/fcp: -33%
  • ↑ loadNewAccount/lcp: +1259%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -21%
  • ↓ confirmTx/fcp: -36%
  • ↑ confirmTx/lcp: +1317%
  • ↑ bridgeUserActions/bridge_load_page: +193%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +128%
  • ↑ bridgeUserActions/bridge_search_token: +20%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +44%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -33%
  • ↑ bridgeUserActions/lcp: +1240%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +46%
  • ↑ startupStandardHome/load: +73%
  • ↑ startupStandardHome/domContentLoaded: +73%
  • ↓ startupStandardHome/firstPaint: -50%
  • ↓ startupStandardHome/backgroundConnect: -18%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +72%
  • ↑ startupStandardHome/setupStore: +95%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +68%
  • ↑ startupStandardHome/longTaskMaxDuration: +86%
  • ↑ startupStandardHome/tbt: +84%
  • ↓ startupStandardHome/inp: -24%
  • ↑ startupStandardHome/lcp: +377%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -44%
  • ↓ startupStandardHome/load: -40%
  • ↓ startupStandardHome/domContentLoaded: -42%
  • ↓ startupStandardHome/domInteractive: -60%
  • ↓ startupStandardHome/backgroundConnect: -34%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -40%
  • ↓ startupStandardHome/setupStore: -41%
  • ↓ startupStandardHome/fcp: -57%
  • ↓ startupStandardHome/lcp: -39%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/confirmSrpToPwForm: +24%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +37%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +12%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -11%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -28%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -20%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -15%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -51%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -76%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -73%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -50%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.21 MiB 0 Bytes 0.00%
✅ ui 19.48 MiB 0 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB 0 Bytes 0.00%
✅ content scripts 3.22 MiB 0 Bytes 0.00%
✅ unzipped 79.9 MiB 0 Bytes 0.00%
✅ zip 24.01 MiB 0 Bytes 0.00%

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 816a173. Configure here.

Comment thread privacy-snapshot.json
"goerli.infura.io",
"holy-convincing-diagram.optimism.quiknode.pro",
"i.seadn.io",
"icy-attentive-sky.monad-mainnet.quiknode.pro",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QuickNode failover host allowlisted

Medium Severity

privacy-snapshot.json now allowlists the Monad QuickNode failover host icy-attentive-sky.monad-mainnet.quiknode.pro. That host appears because e2e redirects Infura (including monad-mainnet.infura.io) to localhost:8545, Monad has no Anvil, and CI builds bake in QUICKNODE_MONAD_URL, so failed RPCs fail over to QuickNode. Adding a *.quiknode.pro failover to the snapshot treats a test-harness leak as expected traffic; known leaks belong in known-violations.json, not this allowlist.

Fix in Cursor Fix in Web

Triggered by learned rule: Do not flag defensive mocks or fixture configuration choices in E2E tests

Reviewed by Cursor Bugbot for commit 816a173. Configure here.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This follows the existing pattern for QuickNode failover hosts already in the snapshot (mainnet, Base, Optimism, Polygon, Robinhood). The suggested alternative doesn't apply here. The only known-violations file is basic-functionality-off-known-violations.json, which is used only by the basic-functionality-off privacy specs.
Moving the host there wouldn't fix the flake.

@Gudahtt Gudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seaona
seaona added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit cb75d04 Nov 12, 2026
138 of 145 checks passed
@seaona
seaona deleted the flaky-privacy-snapsot-monad branch November 12, 2026 08:05
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 12, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.58.0 on PR, as PR was added to branch 13.58.0 when release was cut.

This branch was previously deployed

1 inactive deployment
pr-comment — 816a1736 Deployed Nov 11, 2026 by seaona via Publish prerelease / Publish prerelease #174046
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

flaky tests no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants