Repository navigation
test: fix flaky test Deep Link - Parameter Handling & Security does not allow the loading screen over the deep link's component - #47837
Conversation
Deep Link - Parameter Handling & Security does not allow the loading screen over the deep link's component
✨ Files requiring CODEOWNER review ✨🕵️ @MetaMask/extension-privacy-reviewers (1 files, +1 -0)
|
Builds ready [816a173] [reused from 68c107d]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 1 warn · 🔴 3 fail)
Bundle Size Diffs
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 816a173. Configure here.
| "goerli.infura.io", | ||
| "holy-convincing-diagram.optimism.quiknode.pro", | ||
| "i.seadn.io", | ||
| "icy-attentive-sky.monad-mainnet.quiknode.pro", |
There was a problem hiding this comment.
QuickNode failover host allowlisted
Medium Severity
privacy-snapshot.json now allowlists the Monad QuickNode failover host icy-attentive-sky.monad-mainnet.quiknode.pro. That host appears because e2e redirects Infura (including monad-mainnet.infura.io) to localhost:8545, Monad has no Anvil, and CI builds bake in QUICKNODE_MONAD_URL, so failed RPCs fail over to QuickNode. Adding a *.quiknode.pro failover to the snapshot treats a test-harness leak as expected traffic; known leaks belong in known-violations.json, not this allowlist.
Triggered by learned rule: Do not flag defensive mocks or fixture configuration choices in E2E tests
Reviewed by Cursor Bugbot for commit 816a173. Configure here.
There was a problem hiding this comment.
This follows the existing pattern for QuickNode failover hosts already in the snapshot (mainnet, Base, Optimism, Polygon, Robinhood). The suggested alternative doesn't apply here. The only known-violations file is basic-functionality-off-known-violations.json, which is used only by the basic-functionality-off privacy specs.
Moving the host there wouldn't fix the flake.
|
No release label on PR. Adding release label release-13.58.0 on PR, as PR was added to branch 13.58.0 when release was cut. |


Description
Deep Link - Parameter Handling & Security does not allow the loading screen over the deep link's componentis flaky in CI, failing with:The test shuts down all local nodes so the network loading screen is shown. In e2e, Infura hosts (including
monad-mainnet.infura.io) are redirected tolocalhost:8545, so every Monad RPC call fails. CI builds includeQUICKNODE_MONAD_URL, so after enough failures the extension fails over to the Monad QuickNode endpoint. Whether that happens before the test ends depends on timing, which is why the test is flaky.This adds the Monad QuickNode host to
privacy-snapshot.json, the same way the existing QuickNode failover hosts (Ethereum mainnet, Base, Optimism, Polygon, Robinhood) are listed.Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Test allowlist-only change with no runtime product logic; aligns with existing QuickNode entries in the same file.
Overview
Adds
icy-attentive-sky.monad-mainnet.quiknode.proto the privacy host allowlist inprivacy-snapshot.json, matching other Monad/chain QuickNode failover endpoints already listed.E2e privacy checks fail when CI builds with
QUICKNODE_MONAD_URLand RPC failover hits that host after Infura redirects to localhost; including it stabilizes the flaky Deep Link - Parameter Handling & Security test.Reviewed by Cursor Bugbot for commit 816a173. Bugbot is set up for automated code reviews on this repo. Configure here.