Skip to content

chore: update wide layout spacing - #47863

Merged
ameliejyc merged 2 commits into
mainfrom
wide-screen-style-tweaks
Nov 12, 2026
Merged

ameliejyc merged 2 commits into
mainfrom
wide-screen-style-tweaks

Conversation

@ameliejyc

@ameliejyc ameliejyc commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Description

Increase spacing between Account overview items when wide layout view. Increase padding around Network Pill Selector. Non-wide layout views are unaffected.

Before:

image

After:

image

Changelog

CHANGELOG entry: Minor spacing updates to wide layout view account overview and network selector pills

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Cursor Bugbot is generating a summary for commit dd2ff64. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci

metamask-ci Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (1 files, +1 -1)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 account-overview/
          • 📄 account-overview-layout.tsx +1 -1

👨‍🔧 @MetaMask/core-extension-ux (2 files, +3 -3)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 account-overview/
          • 📄 account-overview-layout.tsx +1 -1
        • 📁 network-pill-selector/
          • 📄 network-pill-selector.tsx +2 -2

@metamask-ci metamask-ci Bot added the team-core-extension-ux Core Extension UX team label Nov 12, 2026
@ameliejyc
ameliejyc marked this pull request as ready for review November 12, 2026 09:04
@ameliejyc
ameliejyc requested review from a team as code owners November 12, 2026 09:04
@ameliejyc
ameliejyc enabled auto-merge November 12, 2026 09:09
@metamask-ci

metamask-ci Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor
Builds ready [dd2ff64]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43188145123 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -25%
  • ↑ loadNewAccount/lcp: +943%
  • ↑ loadNewAccount/cls: +294%
  • ↑ confirmTx/longTaskCount: +67%
  • ↑ confirmTx/longTaskTotalDuration: +81%
  • ↑ confirmTx/longTaskMaxDuration: +56%
  • ↑ confirmTx/tbt: +87%
  • ↓ confirmTx/inp: -21%
  • ↑ confirmTx/lcp: +985%
  • ↑ bridgeUserActions/bridge_load_page: +113%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +52%
  • ↑ bridgeUserActions/longTaskCount: +82%
  • ↑ bridgeUserActions/longTaskTotalDuration: +59%
  • ↑ bridgeUserActions/tbt: +25%
  • ↑ bridgeUserActions/total: +19%
  • ↑ bridgeUserActions/lcp: +948%
  • ↑ bridgeUserActions/cls: +387%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/fcp: -37%
  • ↑ loadNewAccount/lcp: +1181%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -21%
  • ↓ confirmTx/fcp: -41%
  • ↑ confirmTx/lcp: +1196%
  • ↑ bridgeUserActions/bridge_load_page: +255%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +120%
  • ↑ bridgeUserActions/bridge_search_token: +43%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +87%
  • ↑ bridgeUserActions/inp: +47%
  • ↑ bridgeUserActions/lcp: +1233%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +46%
  • ↑ startupStandardHome/load: +72%
  • ↑ startupStandardHome/domContentLoaded: +73%
  • ↓ startupStandardHome/firstPaint: -50%
  • ↓ startupStandardHome/backgroundConnect: -16%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +70%
  • ↑ startupStandardHome/setupStore: +69%
  • ↑ startupStandardHome/longTaskTotalDuration: +68%
  • ↑ startupStandardHome/longTaskMaxDuration: +79%
  • ↑ startupStandardHome/tbt: +84%
  • ↓ startupStandardHome/inp: -24%
  • ↓ startupStandardHome/fcp: -58%
  • ↑ startupStandardHome/lcp: +88%
  • ↓ startupStandardHome/cls: -72%
  • ↑ startupStandardHome/domInteractive: +24%
  • ↑ startupStandardHome/backgroundConnect: +11%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/fcp: +28%
  • ↑ startupStandardHome/lcp: +10%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -13%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +21%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -10%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -12%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -13%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -81%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -76%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -49%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.22 MiB +115 Bytes 0.00%
✅ ui 19.5 MiB +87 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB 0 Bytes 0.00%
✅ content scripts 3.22 MiB 0 Bytes 0.00%
✅ unzipped 79.93 MiB +447 Bytes 0.00%
✅ zip 24.01 MiB +105 Bytes 0.00%

@sonarqubecloud

Copy link
Copy Markdown

@ameliejyc
ameliejyc added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit 06a48a1 Nov 12, 2026
153 of 157 checks passed
@ameliejyc
ameliejyc deleted the wide-screen-style-tweaks branch November 12, 2026 10:12
@metamask-ci metamask-ci Bot mentioned this pull request Nov 13, 2026
12 of 18 tasks
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026

This branch was previously deployed

1 inactive deployment
pr-comment — dd2ff643 Deployed Nov 12, 2026 by ameliejyc via Publish prerelease / Publish prerelease #174249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-XS team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants