You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-up to #47682. Track the missing MMDS priority-overlay support in MetaMask/metamask-design-system#1685 and link it from ReferralDialog, including when the native adapter can return to the shared modal shell.
Split the combined dismissal test into separate mouse, Escape, and native-cancel cases. Each dismissal now explicitly expects one callback. The Escape case also asserts that the keydown default is prevented and background document listeners are not notified. Document why the keydown handler is needed.
This changes documentation and tests; dialog behavior stays the same.
Validation: the five ReferralDialog unit tests and yarn lint:changed:fix passed. git diff --check passed. Tests used the existing installed dependencies in a sparse worktree. Manual Extension verification was not performed for this follow-up.
Superseded by #47890, which now targets david/shared-modal-layer (#47682) directly and includes all changes from this PR: the separate mouse/Escape/native-cancellation tests and the MMDS tracking documentation. No commits or branches were deleted. The remaining ordinary PR chain is #47665 → #47682 → #47890; native stack metadata was removed to preserve the existing auto-merge on #47665.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #47682. Track the missing MMDS priority-overlay support in MetaMask/metamask-design-system#1685 and link it from
ReferralDialog, including when the native adapter can return to the shared modal shell.Split the combined dismissal test into separate mouse, Escape, and native-cancel cases. Each dismissal now explicitly expects one callback. The Escape case also asserts that the keydown default is prevented and background document listeners are not notified. Document why the keydown handler is needed.
This changes documentation and tests; dialog behavior stays the same.
Validation: the five
ReferralDialogunit tests andyarn lint:changed:fixpassed.git diff --checkpassed. Tests used the existing installed dependencies in a sparse worktree. Manual Extension verification was not performed for this follow-up.Changelog
CHANGELOG entry: null
Related issues
Related: #47682
Tracks: MetaMask/metamask-design-system#1685
Manual testing steps
Pre-merge author checklist
Pre-merge reviewer checklist