Skip to content

release(runway): cherry-pick fix(cashtag): skip when no market cap data - #47934

Merged
sleepytanya merged 3 commits into
release/13.58.0from
runway-cherry-pick-13.58.0-1794577070
Nov 13, 2026
Merged

sleepytanya merged 3 commits into
release/13.58.0from
runway-cherry-pick-13.58.0-1794577070

Conversation

@runway-github

@runway-github runway-github Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Description

The X widget still rendered when every matching token had a missing or
zero market cap. Those tickers now produce no result, so no pill or
popover are rendered.

Changelog

CHANGELOG entry: Hide the X widget when none of the matching tokens have
a market cap

Manual testing steps

  1. Enable the X widget feature flag and setting.
  2. On x.com, open a cashtag whose matches all have no market cap or a
    market cap of 0.
  3. Confirm no MetaMask pill or widget appears.
  4. Open a cashtag such as $ETH that has a market cap.
  5. Confirm the widget still appears.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Low Risk
Localized cashtag lookup guard with unit tests; no auth or payment
paths affected.

Overview
resolveTicker now returns null when the highest market-cap
match has a missing or zero market cap, so the X cashtag widget does not
render for tokens without usable cap data. Matches that include at least
one asset with cap > 0 behave as before, with zero/null-cap entries
still listed as similar options.

Tests cover the all-invalid-cap case and the mixed list where a priced
asset remains the primary.

Reviewed by Cursor Bugbot for commit
58a23cc. Bugbot is set up for automated
code reviews on this repo. Configure
here.

[416e0ec](https://github.com/MetaMask/metamask-extension/commit/416e0ecefa2147837d8d0c4fed74dd9d65d1d0ce)

…ta cp-13.58.0 (#47914)

## **Description**

The X widget still rendered when every matching token had a missing or
zero market cap. Those tickers now produce no result, so no pill or
popover are rendered.

## **Changelog**

CHANGELOG entry: Hide the X widget when none of the matching tokens have
a market cap

<!--
## **Related issues**

Fixes:
-->

## **Manual testing steps**

1. Enable the X widget feature flag and setting.
2. On x.com, open a cashtag whose matches all have no market cap or a
market cap of 0.
3. Confirm no MetaMask pill or widget appears.
4. Open a cashtag such as `$ETH` that has a market cap.
5. Confirm the widget still appears.

<!--
## **Screenshots/Recordings**
### **Before**
### **After**
-->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Localized cashtag lookup guard with unit tests; no auth or payment
paths affected.
> 
> **Overview**
> **`resolveTicker`** now returns **`null`** when the highest market-cap
match has a missing or zero market cap, so the X cashtag widget does not
render for tokens without usable cap data. Matches that include at least
one asset with cap **> 0** behave as before, with zero/null-cap entries
still listed as similar options.
> 
> Tests cover the all-invalid-cap case and the mixed list where a priced
asset remains the primary.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
58a23cc. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github
runway-github Bot force-pushed the runway-cherry-pick-13.58.0-1794577070 branch from b7dc426 to ca492d2 Compare November 13, 2026 13:38
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci metamask-ci Bot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Nov 13, 2026
@runway-github
runway-github Bot force-pushed the runway-cherry-pick-13.58.0-1794577070 branch from 581f97e to f56ca94 Compare November 13, 2026 13:38
@metamask-ci

metamask-ci Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor
Builds ready [f56ca94]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 3 warn · 🔴 2 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43435351173 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -40%
  • ↓ loadNewAccount/fcp: -20%
  • ↑ loadNewAccount/lcp: +686%
  • ↑ loadNewAccount/cls: +294%
  • ↑ confirmTx/longTaskMaxDuration: +19%
  • ↑ confirmTx/tbt: +15%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -20%
  • ↑ confirmTx/lcp: +704%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +42%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +10%
  • ↓ bridgeUserActions/longTaskMaxDuration: -17%
  • ↓ bridgeUserActions/inp: -19%
  • ↓ bridgeUserActions/fcp: -20%
  • ↑ bridgeUserActions/lcp: +695%
  • ↑ bridgeUserActions/cls: +387%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↑ loadNewAccount/inp: +19%
  • ↑ loadNewAccount/fcp: +20%
  • ↑ loadNewAccount/lcp: +1250%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -13%
  • ↓ confirmTx/fcp: -31%
  • ↑ confirmTx/lcp: +1331%
  • ↑ bridgeUserActions/bridge_load_page: +260%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +124%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +55%
  • ↑ bridgeUserActions/inp: +69%
  • ↑ bridgeUserActions/fcp: +16%
  • ↑ bridgeUserActions/lcp: +1304%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.1s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +44%
  • ↑ startupStandardHome/load: +70%
  • ↑ startupStandardHome/domContentLoaded: +71%
  • ↓ startupStandardHome/firstPaint: -45%
  • ↓ startupStandardHome/backgroundConnect: -18%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +70%
  • ↑ startupStandardHome/setupStore: +82%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +67%
  • ↑ startupStandardHome/longTaskMaxDuration: +75%
  • ↑ startupStandardHome/tbt: +81%
  • ↓ startupStandardHome/inp: -18%
  • ↓ startupStandardHome/fcp: -58%
  • ↑ startupStandardHome/lcp: +88%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -22%
  • ↓ startupStandardHome/load: -16%
  • ↓ startupStandardHome/domContentLoaded: -18%
  • ↑ startupStandardHome/domInteractive: +34%
  • ↓ startupStandardHome/backgroundConnect: -11%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -16%
  • ↓ startupStandardHome/setupStore: -19%
  • ↑ startupStandardHome/fcp: +38%
  • ↓ startupStandardHome/lcp: -15%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +14%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +28%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +31%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +22%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -91%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -94%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -89%
  • ↓ onboardingImportWallet/tbt: -98%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +20%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -10%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -81%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -77%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -68%
  • ↓ dappPageLoad/domContentLoaded: -34%
  • ↓ dappPageLoad/firstPaint: -52%
  • ↓ dappPageLoad/firstContentfulPaint: -52%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.23 MiB +147 Bytes 0.00%
✅ ui 19.55 MiB +70 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB 0 Bytes 0.00%
✅ content scripts 3.2 MiB 0 Bytes 0.00%
✅ unzipped 79.97 MiB +222 Bytes 0.00%
✅ zip 24.03 MiB +61 Bytes 0.00%

@metamask-ci

metamask-ci Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor
Builds ready [3794444] [reused from f56ca94]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 3 warn · 🔴 2 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43437987449 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -40%
  • ↓ loadNewAccount/fcp: -20%
  • ↑ loadNewAccount/lcp: +686%
  • ↑ loadNewAccount/cls: +294%
  • ↑ confirmTx/longTaskMaxDuration: +19%
  • ↑ confirmTx/tbt: +15%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -20%
  • ↑ confirmTx/lcp: +704%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +42%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +10%
  • ↓ bridgeUserActions/longTaskMaxDuration: -17%
  • ↓ bridgeUserActions/inp: -19%
  • ↓ bridgeUserActions/fcp: -20%
  • ↑ bridgeUserActions/lcp: +695%
  • ↑ bridgeUserActions/cls: +387%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↑ loadNewAccount/inp: +19%
  • ↑ loadNewAccount/fcp: +20%
  • ↑ loadNewAccount/lcp: +1250%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -13%
  • ↓ confirmTx/fcp: -31%
  • ↑ confirmTx/lcp: +1331%
  • ↑ bridgeUserActions/bridge_load_page: +260%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +124%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +55%
  • ↑ bridgeUserActions/inp: +69%
  • ↑ bridgeUserActions/fcp: +16%
  • ↑ bridgeUserActions/lcp: +1304%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.1s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +44%
  • ↑ startupStandardHome/load: +70%
  • ↑ startupStandardHome/domContentLoaded: +71%
  • ↓ startupStandardHome/firstPaint: -45%
  • ↓ startupStandardHome/backgroundConnect: -18%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +70%
  • ↑ startupStandardHome/setupStore: +82%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +67%
  • ↑ startupStandardHome/longTaskMaxDuration: +75%
  • ↑ startupStandardHome/tbt: +81%
  • ↓ startupStandardHome/inp: -18%
  • ↓ startupStandardHome/fcp: -58%
  • ↑ startupStandardHome/lcp: +88%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -22%
  • ↓ startupStandardHome/load: -16%
  • ↓ startupStandardHome/domContentLoaded: -18%
  • ↑ startupStandardHome/domInteractive: +34%
  • ↓ startupStandardHome/backgroundConnect: -11%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -16%
  • ↓ startupStandardHome/setupStore: -19%
  • ↑ startupStandardHome/fcp: +38%
  • ↓ startupStandardHome/lcp: -15%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +14%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +28%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +31%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +22%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -91%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -94%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -89%
  • ↓ onboardingImportWallet/tbt: -98%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +20%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -10%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -81%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -77%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -68%
  • ↓ dappPageLoad/domContentLoaded: -34%
  • ↓ dappPageLoad/firstPaint: -52%
  • ↓ dappPageLoad/firstContentfulPaint: -52%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.23 MiB +147 Bytes 0.00%
✅ ui 19.55 MiB +70 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB 0 Bytes 0.00%
✅ content scripts 3.2 MiB 0 Bytes 0.00%
✅ unzipped 79.97 MiB +222 Bytes 0.00%
✅ zip 24.03 MiB +61 Bytes 0.00%

@metamask-ci

metamask-ci Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor
Builds ready [32696c5] [reused from f56ca94]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 3 warn · 🔴 2 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43462475460 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -40%
  • ↓ loadNewAccount/fcp: -20%
  • ↑ loadNewAccount/lcp: +686%
  • ↑ loadNewAccount/cls: +294%
  • ↑ confirmTx/longTaskMaxDuration: +19%
  • ↑ confirmTx/tbt: +15%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -20%
  • ↑ confirmTx/lcp: +704%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +42%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +10%
  • ↓ bridgeUserActions/longTaskMaxDuration: -17%
  • ↓ bridgeUserActions/inp: -19%
  • ↓ bridgeUserActions/fcp: -20%
  • ↑ bridgeUserActions/lcp: +695%
  • ↑ bridgeUserActions/cls: +387%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↑ loadNewAccount/inp: +19%
  • ↑ loadNewAccount/fcp: +20%
  • ↑ loadNewAccount/lcp: +1250%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -13%
  • ↓ confirmTx/fcp: -31%
  • ↑ confirmTx/lcp: +1331%
  • ↑ bridgeUserActions/bridge_load_page: +260%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +124%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +55%
  • ↑ bridgeUserActions/inp: +69%
  • ↑ bridgeUserActions/fcp: +16%
  • ↑ bridgeUserActions/lcp: +1304%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.1s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +44%
  • ↑ startupStandardHome/load: +70%
  • ↑ startupStandardHome/domContentLoaded: +71%
  • ↓ startupStandardHome/firstPaint: -45%
  • ↓ startupStandardHome/backgroundConnect: -18%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +70%
  • ↑ startupStandardHome/setupStore: +82%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +67%
  • ↑ startupStandardHome/longTaskMaxDuration: +75%
  • ↑ startupStandardHome/tbt: +81%
  • ↓ startupStandardHome/inp: -18%
  • ↓ startupStandardHome/fcp: -58%
  • ↑ startupStandardHome/lcp: +88%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -22%
  • ↓ startupStandardHome/load: -16%
  • ↓ startupStandardHome/domContentLoaded: -18%
  • ↑ startupStandardHome/domInteractive: +34%
  • ↓ startupStandardHome/backgroundConnect: -11%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -16%
  • ↓ startupStandardHome/setupStore: -19%
  • ↑ startupStandardHome/fcp: +38%
  • ↓ startupStandardHome/lcp: -15%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +14%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +28%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +31%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +22%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -91%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -94%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -89%
  • ↓ onboardingImportWallet/tbt: -98%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +20%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -10%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -81%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -77%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -68%
  • ↓ dappPageLoad/domContentLoaded: -34%
  • ↓ dappPageLoad/firstPaint: -52%
  • ↓ dappPageLoad/firstContentfulPaint: -52%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.23 MiB +147 Bytes 0.00%
✅ ui 19.55 MiB +70 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB 0 Bytes 0.00%
✅ content scripts 3.2 MiB 0 Bytes 0.00%
✅ unzipped 79.97 MiB +222 Bytes 0.00%
✅ zip 24.03 MiB +61 Bytes 0.00%

@sonarqubecloud

Copy link
Copy Markdown

@sleepytanya
sleepytanya merged commit 542ef95 into release/13.58.0 Nov 13, 2026
131 checks passed
@sleepytanya
sleepytanya deleted the runway-cherry-pick-13.58.0-1794577070 branch November 13, 2026 16:54
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 13, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.58.0 on PR, as PR was cherry-picked in branch 13.58.0.

This branch was previously deployed

1 inactive deployment
pr-comment — 32696c57 Deployed Nov 13, 2026 by sleepytanya via Publish prerelease / Publish prerelease #174644
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 risk:medium team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants