Skip to content

Enforce transaction log limit - #558

Merged
kumavis merged 12 commits into
masterfrom
i390-TransactionLimit
Aug 23, 2016
Merged

kumavis merged 12 commits into
masterfrom
i390-TransactionLimit

Conversation

@danfinlay

Copy link
Copy Markdown
Contributor

Fixes #390

Adds a limit to our persisted transaction list, to avoid overloading our localStorage (eventually we'll move to something that can handle a large list, but for now our list is hardly comprehensive, so a limit doesn't seem that bad).

Also added a View more button to the transaction history, which looks like so (depending on whether there are txs or not):

screen shot 2016-08-18 at 4 22 14 pm

screen shot 2016-08-18 at 4 22 24 pm

Visible at the end of the transaction list, or if no transactions are listed, displayed right after the `No Transactions` message.
@danfinlay danfinlay changed the title I390 transaction limit Enforce transaction limit Aug 18, 2016
@danfinlay danfinlay changed the title Enforce transaction limit Enforce transaction log limit Aug 18, 2016
@kumavis

kumavis commented Aug 19, 2016

Copy link
Copy Markdown
Contributor

Shouldnt ever say "No Transaction History" and "show more", right?

@danfinlay

Copy link
Copy Markdown
Contributor Author

We don't know. We don't know of any history, but we can show more about their account, for example, incoming txs, or txs before this vault was created.

Maybe the wording can be improved.

@danfinlay

Copy link
Copy Markdown
Contributor Author

At the very least we both casually switched to Show More, which sounds more casual than View More.

@kumavis

kumavis commented Aug 19, 2016

Copy link
Copy Markdown
Contributor

This feels a little weird -- guess we just need to replace it later with a fancy optimized lazy-loading scroll view

@danfinlay

Copy link
Copy Markdown
Contributor Author

I agree, it's not ideal, but it prevents unknown repercussions with little enough effort that we can pursue our main goals before that layer of optimization.

  • Dan

On Aug 18, 2016, at 11:51 PM, kumavis notifications@github.com wrote:

This feels a little weird -- guess we just need to replace it later with a fancy optimized lazy-loading scroll view

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@danfinlay

Copy link
Copy Markdown
Contributor Author

I don't get what conflicts this branch has. I think Github is freaking out.

@frankiebee

Copy link
Copy Markdown
Contributor

Maybe a little info symbol would be nice with the tooltip. when you hover over it it tells you that it directs you to a site to see if you have any other transactions not recorded in history. I agree with Aaron that it looks weird that we say no history and then show more

@danfinlay

danfinlay commented Aug 22, 2016 •

Copy link
Copy Markdown
Contributor Author
  • Change "transactions" list header to "history"
  • Move the "view more" button into a little "info" icon next to the copy button.

Also:
- Also fixed bug that caused React warning when rendering the tx history.
- Renamed 'Transactions' to 'History', since it now has more than that.
@danfinlay

Copy link
Copy Markdown
Contributor Author

screen shot 2016-08-22 at 2 37 58 pm

screen shot 2016-08-22 at 2 37 51 pm

Updated, probably ready for a merge!

@kumavis
kumavis merged commit 07927b5 into master Aug 23, 2016
@kumavis
kumavis deleted the i390-TransactionLimit branch August 23, 2016 02:22
LabinatorSolutions pushed a commit to LabinatorSolutions/metamask-extension that referenced this pull request Nov 7, 2026
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Bumps the Solana, Stellar, and Tron wallet snaps to the versions
released in internal-snaps `22.0.0`:

- `@metamask/solana-wallet-snap`: `^7.2.0` → `^7.3.0`
- `@metamask/stellar-wallet-snap`: `^2.0.0` → `^2.1.0`
- `@metamask/tron-wallet-snap`: `^4.3.1` → `^4.4.0`

All three are backwards-compatible minor updates; no application code
changes are required.

### @metamask/solana-wallet-snap 7.3.0

- Remove the temporary fallback that injected `https://metamask.io` as
the request origin when `keyring_submitRequest` was called without one
([MetaMask#533](MetaMask/internal-snaps#533)).

### @metamask/stellar-wallet-snap 2.1.0

- `confirmSend` now throws when signing or submission fails after the
user confirms, instead of returning a JSON error response
([MetaMask#550](MetaMask/internal-snaps#550)).
- Bump `@stellar/stellar-sdk` from `^17.2.1` to `^17.4.0`
([MetaMask#545](MetaMask/internal-snaps#545)).
- Retry transient Token API, Price API, Security Alerts API, RPC, and
Horizon failures with bounded timeouts and circuit breaking
([MetaMask#534](MetaMask/internal-snaps#534),
[MetaMask#551](MetaMask/internal-snaps#551)).
- Fix `onAmountInput` to accept the optional destination as `toAddress`
instead of `to`
([MetaMask#558](MetaMask/internal-snaps#558)).

### @metamask/tron-wallet-snap 4.4.0

- Support `VoteWitnessContract` and `AccountPermissionUpdateContract`
transactions by upgrading TronWeb to 6.5.1
([MetaMask#561](MetaMask/internal-snaps#561)).
- Align transaction security warning copy and scan-loading behavior with
user preferences
([MetaMask#557](MetaMask/internal-snaps#557)).

## **Changelog**

CHANGELOG entry: null

## **Related issues**

n/a

## **Manual testing steps**

n/a

## **Screenshots/Recordings**

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants