Skip to content

Implement loading spinner during page loads #3

Closed

Description

@bitpshr

Since we switched from WebView to WKWebView, we lost the built-in loading spinner between page loads. We should re-enable one, or if that's not possible, replace the "refresh" icon with a loading spinner during page loads.

Activity

  1. brunobar79 commented on Jul 21, 2018

    @brunobar79
    Contributor

    Something that I like better than a spinner is be a progress bar between the url bar and the webview like chrome mobile has.
    I have implemented that one on the metamask-ios-core-example repo. I think I could easily port that functionality to the react-native-wkwebview if you agree

  2. bitpshr commented on Jul 21, 2018

    @bitpshr
    ContributorAuthor

    Sounds good @brunobar79. Not tied to any particular UX and that flow sounds nice.

  3. brunobar79 commented on Sep 7, 2018

    @brunobar79
    Contributor

    Closed via #113

  4. added a commit that references this issue on Aug 13, 2020
  5. added a commit that references this issue on Aug 18, 2020
  6. added a commit that references this issue on Apr 22, 2021
  7. added a commit that references this issue on Apr 22, 2021
  8. added a commit that references this issue on Jun 2, 2021
  9. added a commit that references this issue on Jun 17, 2021
  10. added a commit that references this issue on Jul 23, 2021
  11. added a commit that references this issue on Aug 5, 2021
  12. 1 remaining item

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions