Skip to content

Currency display wrong #567

Closed
Closed

Description

@omnat

Currency always displays in $ even if you set to GBP or EUR. Expected behaviour is that GBP should display £ and EUR should display € etc...

Note: Currency value conversion is happening correctly, this is about the display of the currency icon (£, €)

Activity

  1. brunobar79 commented on Apr 8, 2019

    @brunobar79
    Contributor

    @omnat & @cjeria Can we get to an agreement on how to consistently render currencies across the app?
    There are places were we have:
    $ 123 USD
    123 USD
    $123

    Take into account that not all currencies have symbol, and we're supporting some cryptocurrencies like DAI

  2. bdresser commented on Apr 17, 2019

    @bdresser
    Contributor

    should standardize treatment across the app so this can be modified easily

    let's go with 123 USD

  3. estebanmino commented on Apr 17, 2019

    @estebanmino
    Contributor

    From design QA call: we're going to use currency codes (dollar = USD)

  4. added this to the Public Beta milestone on Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions