Skip to content

fix: upgrade assets-controllers to v31 - #11412

Merged
sahar-fehri merged 26 commits into
mainfrom
feat/upgrade-assets-controllers-to-v31
Oct 8, 2024
Merged

sahar-fehri merged 26 commits into
mainfrom
feat/upgrade-assets-controllers-to-v31

Conversation

@sahar-fehri

@sahar-fehri sahar-fehri commented Sep 24, 2024 •

Copy link
Copy Markdown
Contributor

Description

PR to upgrade assets-controllers to v31.0.0

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Verifying NFT and Token detection:

Screen.Recording.2024-10-01.at.17.28.11.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri
sahar-fehri force-pushed the feat/upgrade-assets-controllers-to-v31 branch from 276e2a3 to afc3a92 Compare September 26, 2024 10:52
@socket-security

socket-security Bot commented Sep 26, 2024 •

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/assets-controllers@31.0.0 None 0 1.54 MB metamaskbot
npm/@metamask/polling-controller@7.0.0 None 0 123 kB metamaskbot

🚮 Removed packages: npm/@metamask/assets-controllers@30.0.0, npm/@metamask/polling-controller@6.0.2

View full report↗︎

@sahar-fehri sahar-fehri added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. team-assets Run Smoke E2E labels Sep 26, 2024
@github-actions

This comment was marked as outdated.

@sahar-fehri
sahar-fehri force-pushed the feat/upgrade-assets-controllers-to-v31 branch from 7c9494e to f27652f Compare September 26, 2024 13:40
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@sahar-fehri
sahar-fehri marked this pull request as ready for review September 26, 2024 15:31
@sahar-fehri
sahar-fehri requested a review from a team as a code owner September 26, 2024 15:31
@sahar-fehri
sahar-fehri requested a review from a team September 26, 2024 15:31
@sahar-fehri
sahar-fehri requested a review from a team as a code owner September 26, 2024 15:31
Comment thread app/core/Engine.ts Resolved
@github-actions

github-actions Bot commented Oct 7, 2024 •

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9d30780
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e1a48e3d-1098-42c2-9727-ea8010865c0e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Comment thread app/store/migrations/054.ts Resolved
gambinish
gambinish previously approved these changes Oct 8, 2024

@gambinish gambinish left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preemptively approving, but I think that we should sync up as a team before we get this merged 👍

tommasini
tommasini previously approved these changes Oct 8, 2024

@tommasini tommasini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a small comment on the test file!

Comment thread app/store/migrations/054.test.ts Resolved
@github-actions

github-actions Bot commented Oct 8, 2024 •

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: bd7dcd4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6c341864-e19e-496d-9dcd-b4a09c626194

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cryptodev-2s cryptodev-2s left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions

github-actions Bot commented Oct 8, 2024 •

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0622ce9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c9e28942-4aa4-4d92-a6e6-2e87b273ac47

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented Oct 8, 2024

Copy link
Copy Markdown

@sahar-fehri
sahar-fehri added this pull request to the merge queue Oct 8, 2024
@sahar-fehri
sahar-fehri removed this pull request from the merge queue due to a manual request Oct 8, 2024
@sahar-fehri
sahar-fehri added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 368fc19 Oct 8, 2024
@sahar-fehri
sahar-fehri deleted the feat/upgrade-assets-controllers-to-v31 branch October 8, 2024 20:22
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.34.0 team-assets

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants