Skip to content

Send Screen - #135

Merged
bitpshr merged 1 commit into
masterfrom
send-screen
Sep 20, 2018
Merged

bitpshr merged 1 commit into
masterfrom
send-screen

Conversation

@bitpshr

@bitpshr bitpshr commented Sep 20, 2018

Copy link
Copy Markdown
Contributor

Description

This pull request wires up the TransactionEditor in the SendScreen component. For now, a simple Alert was used to indicate success or failure.

preview

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #58

@bitpshr bitpshr changed the title Initial send screen implementation Send Screen Sep 20, 2018

@brunobar79 brunobar79 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 💯

Just one minor comment related to the UX / UI .

key={transactionKey}
hideData
mode={this.state.mode}
onCancel={this.onCancel}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "edit" view on the transaction screen shouldn't have a cancel button (makes sense for the popup version but not for the Send screen). One option is to have two different components for review and edit and pass different values internally so the footer renders the right buttons.

I'm ok if you wanna address it later, just create a separate github issue to keep track of it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the cancel button should say "clear" in this case (since that's what it technically does.) I'll leave it for now like you said pending new / up-to-date mock ups.

@bitpshr
bitpshr merged commit b57f97a into master Sep 20, 2018
@bitpshr
bitpshr deleted the send-screen branch September 20, 2018 22:54
@brunobar79

brunobar79 commented Sep 20, 2018 •

Copy link
Copy Markdown
Contributor

@bitpshr I'm wondering how did the unit test pass if there were no snapshot updates included in this PR. Any idea?

@bitpshr

bitpshr commented Sep 21, 2018 •

Copy link
Copy Markdown
Contributor Author

@brunobar79 oh weird, good catch. I know I ran npm run test:unit:update because I remember having to check the syntax. I looked at the snapshot test just now and something is off:

https://github.com/MetaMask/MetaMask/blob/master/app/components/SendScreen/__snapshots__/index.test.js.snap#L3

This is why running npm run test:unit:update results in no changes (even now on master after this landed) and why the unit tests still pass. I'll dig more.

rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@Qbandev Qbandev mentioned this pull request Aug 28, 2026
8 of 10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants