Repository navigation
Send Screen - #135
Send Screen#135
Conversation
brunobar79
left a comment
There was a problem hiding this comment.
Great work! 💯
Just one minor comment related to the UX / UI .
| key={transactionKey} | ||
| hideData | ||
| mode={this.state.mode} | ||
| onCancel={this.onCancel} |
There was a problem hiding this comment.
The "edit" view on the transaction screen shouldn't have a cancel button (makes sense for the popup version but not for the Send screen). One option is to have two different components for review and edit and pass different values internally so the footer renders the right buttons.
I'm ok if you wanna address it later, just create a separate github issue to keep track of it.
There was a problem hiding this comment.
Maybe the cancel button should say "clear" in this case (since that's what it technically does.) I'll leave it for now like you said pending new / up-to-date mock ups.
|
@bitpshr I'm wondering how did the unit test pass if there were no snapshot updates included in this PR. Any idea? |
|
@brunobar79 oh weird, good catch. I know I ran This is why running |
Description
This pull request wires up the TransactionEditor in the SendScreen component. For now, a simple Alert was used to indicate success or failure.
Checklist
Issue
Resolves #58