Skip to content

Eth personal sign - #180

Merged
estebanmino merged 11 commits into
masterfrom
eth-personal-sign
Dec 5, 2018
Merged

estebanmino merged 11 commits into
masterfrom
eth-personal-sign

Conversation

@estebanmino

@estebanmino estebanmino commented Nov 26, 2018 •

Copy link
Copy Markdown
Contributor

Description

This PR adds support for both eth_sign and personal_sign, using this MetaMask/core#29 version of GABA [BLOCKER].

eth-personal-sign

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #169
Resolves #189

@brunobar79 brunobar79 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing @estebanmino! 💪

I've added a couple of comments but nothing major.
Once you get GABA's PR merged in and the tests passing you can merge it in.

Comment thread app/components/BrowserHome/index.js Resolved
</View>
<View>
<Text>{strings('signature_request.balance_title')}</Text>
<Text style={styles.text}>{balance} ETH</Text>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be the global currency instead of ETH?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make this change for the whole app, we're using plain ETH everywhere

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Can you open an issue and mark this one as resolved?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Comment thread locales/en.json Resolved
Comment thread locales/es.json Resolved
@estebanmino estebanmino changed the title Eth personal sign [WAITING GABA] Eth personal sign Nov 27, 2018
@estebanmino estebanmino mentioned this pull request Dec 4, 2018
3 tasks
@brunobar79 brunobar79 changed the title [WAITING GABA] Eth personal sign Eth personal sign Dec 5, 2018
@estebanmino
estebanmino merged commit 44fd845 into master Dec 5, 2018
@estebanmino
estebanmino deleted the eth-personal-sign branch December 5, 2018 22:07
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* update browser url regex to match local url

* add gaba message manager

* add eth_sign support with minimal UI

* update eth sign UI as extension

* add and use personal_sign instead of eth_sign

* use keyrong personal sign message instead of sign message

* use strings unit eth instead of plain ETH rendering components

* fix account label not showing on signature request

* Update GABA version

* update snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants