Skip to content

Make Keypad a functional component - #2054

Merged
wachunei merged 4 commits into
developfrom
feature/keypad-component
Dec 11, 2020
Merged

wachunei merged 4 commits into
developfrom
feature/keypad-component

Conversation

@wachunei

@wachunei wachunei commented Dec 10, 2020 •

Copy link
Copy Markdown
Member

Description

This PR makes Keypad a functional component instead of only a collection of UI components.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #2032

@wachunei
wachunei marked this pull request as ready for review December 10, 2020 17:31
@wachunei
wachunei requested a review from a team as a code owner December 10, 2020 17:31
@estebanmino
estebanmino changed the base branch from develop to feature/swaps-quotes-view December 11, 2020 00:58
@estebanmino
estebanmino changed the base branch from feature/swaps-quotes-view to develop December 11, 2020 01:07

@estebanmino estebanmino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd merge this right away. is already QAed, just moving it to a component

@wachunei
wachunei merged commit eb939d5 into develop Dec 11, 2020
@wachunei
wachunei deleted the feature/keypad-component branch December 11, 2020 15:48
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move swaps keyboard to its own component

2 participants