Repository navigation
Make Keypad a functional component - #2054
Merged
Merged
Conversation
wachunei
marked this pull request as ready for review
December 10, 2020 17:31
estebanmino
changed the base branch from
develop
to
feature/swaps-quotes-view
December 11, 2020 00:58
estebanmino
changed the base branch from
feature/swaps-quotes-view
to
develop
December 11, 2020 01:07
estebanmino
approved these changes
Dec 11, 2020
estebanmino
left a comment
Contributor
There was a problem hiding this comment.
I'd merge this right away. is already QAed, just moving it to a component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes Keypad a functional component instead of only a collection of UI components.
Checklist
Issue
Resolves #2032