Skip to content

chore(runway): cherry-pick fix: bump bitcoin - #23493

Merged
sethkfman merged 1 commit into
release/7.60.1from
cherry-pick-7-60-1-90ac48c
Dec 1, 2025
Merged

sethkfman merged 1 commit into
release/7.60.1from
cherry-pick-7-60-1-90ac48c

Conversation

@runway-github

@runway-github runway-github Bot commented Dec 1, 2025 •

Copy link
Copy Markdown
Contributor

Description

Updates bitcoin to 1.8.0, which removes onRpcRequest method.

Changelog

CHANGELOG entry: Removed onRpcRequest
(#568)

Related issues

Fixes: Remove onRpcRequest.

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Update @metamask/bitcoin-wallet-snap from ^1.6.0 to ^1.8.0 and refresh yarn.lock.

  • Dependencies:
    • Bump @metamask/bitcoin-wallet-snap from ^1.6.0 to ^1.8.0 in package.json.
    • Update yarn.lock to reflect the new version.

Written by Cursor Bugbot for commit 6118426. This will update automatically on new commits. Configure here.

90ac48c

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

Updates bitcoin to 1.8.0, which removes onRpcRequest method.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: Removed `onRpcRequest`
([#568](MetaMask/snap-bitcoin-wallet#568))

Fixes: Remove `onRpcRequest`.

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

<!-- [screenshots/recordings] -->

<!-- [screenshots/recordings] -->

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Upgrade @metamask/bitcoin-wallet-snap from ^1.7.0 to ^1.8.0.
>
> - **Dependencies**:
> - Upgrade `@metamask/bitcoin-wallet-snap` to `^1.8.0` in
`package.json`.
>   - Update `yarn.lock` to reflect the new version.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
6b5cf54. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@github-actions

github-actions Bot commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Dec 1, 2025
@github-actions

github-actions Bot commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeCore, SmokeConfirmationsRedesigned, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeWalletUX, SmokeAssets, SmokeSwaps, SmokeStake, SmokeCard, SmokeNotifications, SmokeRewards, SmokePerps, SmokeRamps, SmokeMultiChainPermissions, SmokeAnalytics, SmokeMultiChainAPI, SmokePredictions
  • Risk Level: high
  • AI Confidence: %
click to see 🤖 AI reasoning details

Fallback: AI analysis did not complete successfully. Running all tests.

View GitHub Actions results

@sethkfman sethkfman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​bitcoin-wallet-snap@​1.6.0 ⏵ 1.8.01001008398 +1100

View full report

@sonarqubecloud

sonarqubecloud Bot commented Dec 1, 2025

Copy link
Copy Markdown

@sethkfman
sethkfman merged commit 51939bf into release/7.60.1 Dec 1, 2025
211 of 219 checks passed
@sethkfman
sethkfman deleted the cherry-pick-7-60-1-90ac48c branch December 1, 2025 19:47
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 1, 2025
@metamaskbot metamaskbot added the release-7.60.2 Issue or pull request that will be included in release 7.60.2 label Dec 2, 2025
@metamaskbot

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.60.2 on PR, as PR was cherry-picked in branch 7.60.2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.60.2 Issue or pull request that will be included in release 7.60.2 team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants