Skip to content

feat(vba): show a VBA details screen when onboarding completes - #36916

Merged
georgeweiler merged 2 commits into
mainfrom
feat/vba-onboarding-details-screen
Sep 28, 2026
Merged

georgeweiler merged 2 commits into
mainfrom
feat/vba-onboarding-details-screen

Conversation

@georgeweiler

@georgeweiler georgeweiler commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Description

When VBA onboarding finishes provisioning the Money account (hydrateVbaOnboarding returns autorampStatus: 'ready' → destinationId: 'complete'), the coordinator navigated straight to Money Home. Since the user is already in the Money area, a successful account creation looked like nothing happened — the onboarding sheet just closed with no confirmation.

This adds a terminal "Virtual bank account" details screen and routes to it on completion instead of silently returning to Money Home. It's currently a stub (title + description + a Done button that returns to Money Home); real account details will render here in a follow-up.

Changes

  • New screen VbaDetails.tsx (+ VbaDetails.test.tsx)
  • Register VbaOnboardingRoutes.DETAILS in routes.ts and VbaOnboardingNavigator.tsx
  • useVbaOnboardingRouting complete destination now navigates to the details screen (was Money Home)
  • virtual_bank_account.vba_details strings
  • Bump @metamask/ramps-controller to ^26.0.1 (relay-approved KYC gating fix from fix(ramps-controller): treat relay-approved KYC as approved in hydrate core#10497)

Changelog

CHANGELOG entry: Added a Virtual bank account details screen shown when VBA onboarding completes

Related issues

Refs: MetaMask/core#10497 — @metamask/ramps-controller fix (relay-approved KYC gating) required for the complete path to be reachable end-to-end. This client PR is independent and self-contained; the full flow lands now that ramps-controller is bumped to 26.0.1.

Manual testing steps

Feature: VBA onboarding completion

  Scenario: user completes VBA onboarding with a provisioned autoramp
    Given the user is KYC-approved and has a provisioned autoramp
    And the user is on Money Home

    When the user completes the VBA onboarding flow
    Then the "Virtual bank account" details screen is shown
    And the user is not silently returned to Money Home

  Scenario: user dismisses the VBA details screen
    Given the user is on the "Virtual bank account" details screen

    When the user taps "Done"
    Then the user is returned to Money Home

Screenshots/Recordings

Before

N/A — on completion the onboarding sheet closed and the user was returned to Money Home with no confirmation screen.

After

N/A — stub screen (title, description, Done button); real account details will be added in a follow-up.

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Scoped VBA onboarding navigation and a placeholder UI; no auth or payment logic changes beyond the ramps-controller patch bump.

Overview
When VBA onboarding finishes provisioning (destinationId: 'complete' / autorampStatus: 'ready'), users now land on a new Virtual bank account confirmation screen instead of being sent straight to Money Home (which felt like nothing happened).

The PR adds stub screen VbaDetails (title, copy, Done → Money Home), registers VbaOnboardingRoutes.DETAILS on the onboarding stack, and updates navigateToVbaOnboardingDestination and useOpenVbaOnboarding tests to route there. Adds virtual_bank_account.vba_details strings and bumps @metamask/ramps-controller to 26.0.1.

Reviewed by Cursor Bugbot for commit fb615ae. Bugbot is set up for automated code reviews on this repo. Configure here.

Previously, when `hydrateVbaOnboarding` returned `autorampStatus: 'ready'`
(`destinationId: 'complete'`), the coordinator navigated straight to Money
Home. Because the user was already in the Money area, a successful account
creation looked like nothing happened.

Add a terminal "Virtual bank account" details screen (currently a stub) and
route to it on completion. It has a Done button that returns to Money Home.
Account details will be rendered here in a follow-up.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@georgeweiler
georgeweiler requested a review from a team as a code owner September 26, 2026 13:19
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added size-M pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. labels Sep 26, 2026
@metamask-ci metamask-ci Bot added team-money-movement issues related to Money Movement features INVALID-PR-TEMPLATE PR's body doesn't match template labels Sep 26, 2026
@github-actions github-actions Bot added the risk:high AI analysis: high risk label Sep 26, 2026
meltingice1337
meltingice1337 previously approved these changes Sep 28, 2026
Pulls in the VBA KYC gating fix (relay-approved sessions treated as approved
in hydrateVbaOnboarding) released in @metamask/ramps-controller@26.0.1
(MetaMask/core#10497), so the onboarding "complete" path this screen renders
is reachable end to end.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​ramps-controller@​26.0.0 ⏵ 26.0.1100 +110079 +1100 +1100

View full report

@georgeweiler georgeweiler removed the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label Sep 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Smart E2E Test Selection

Selected E2E tags: ALL

AI Confidence: 100

E2E reasoning

Expand to read

The PR introduces:

  1. @metamask/ramps-controller patch bump (26.0.0 → 26.0.1) — A controller package version update in package.json. The hard rule seed mandates ALL tags for controller package updates. Even though it's a patch bump, ramps-controller changes can affect any Money/Ramp flow behavior.

  2. New VbaDetails screen — A new "Virtual Bank Account Details" screen added to the VBA onboarding navigator. This is a new UI screen in the Money/Ramp flow.

  3. Navigation behavior change in useVbaOnboardingRouting.ts — When VBA onboarding completes (destinationId === 'complete'), the app now navigates to the new VbaDetails screen instead of directly to Money home (Routes.HOME_TABS → Routes.MONEY.ROOT → Routes.MONEY.HOME). This is a behavioral change in the VBA onboarding completion flow.

  4. New route added — VbaOnboardingRoutes.DETAILS added to routes.ts and the navigator.

  5. New locale strings — vba_details section added to en.json.

The primary impact is on SmokeMoney (MetaMask Card and fiat on/off-ramp flows, VBA onboarding). However, the hard rule seed of ALL is maintained because:

  • The ramps-controller package update could have broader effects beyond just the VBA flow
  • The navigation change in the VBA onboarding completion path is a behavioral change that could affect existing SmokeMoney E2E tests that expect navigation to Money home after VBA onboarding completes
  • Conservative approach is warranted when a controller package is updated

If narrowing were appropriate (without the hard rule), only SmokeMoney would be the primary tag, with no additional dependent tags needed since this is a VBA onboarding screen (not a swap/confirmation flow).

Performance reasoning

Expand to read

The changes are focused on a new VBA onboarding details screen and a ramps-controller patch bump. There are no performance-sensitive flows affected — no asset loading, account list rendering, login/unlock, swap execution, or app launch paths are modified. The new VbaDetails screen is a simple static screen with a Done button. No performance test tags are warranted.

View run

@metamask-ci metamask-ci Bot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 28, 2026
@sonarqubecloud

Copy link
Copy Markdown

@georgeweiler
georgeweiler added this pull request to the merge queue Sep 28, 2026
Merged via the queue into main with commit d09f10e Sep 28, 2026
168 of 169 checks passed
@georgeweiler
georgeweiler deleted the feat/vba-onboarding-details-screen branch September 28, 2026 21:17
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 28, 2026
@metamask-ci metamask-ci Bot added the release-8.15.0 Issue or pull request that will be included in release 8.15.0 label Sep 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-8.15.0 Issue or pull request that will be included in release 8.15.0 risk:high AI analysis: high risk size-M team-money-movement issues related to Money Movement features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants