Repository navigation
feat(vba): show a VBA details screen when onboarding completes - #36916
Conversation
Previously, when `hydrateVbaOnboarding` returned `autorampStatus: 'ready'` (`destinationId: 'complete'`), the coordinator navigated straight to Money Home. Because the user was already in the Money area, a successful account creation looked like nothing happened. Add a terminal "Virtual bank account" details screen (currently a stub) and route to it on completion. It has a Done button that returns to Money Home. Account details will be rendered here in a follow-up. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Pulls in the VBA KYC gating fix (relay-approved sessions treated as approved in hydrateVbaOnboarding) released in @metamask/ramps-controller@26.0.1 (MetaMask/core#10497), so the onboarding "complete" path this screen renders is reachable end to end. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Smart E2E Test SelectionSelected E2E tags: ALL AI Confidence: 100 E2E reasoningExpand to readThe PR introduces:
The primary impact is on SmokeMoney (MetaMask Card and fiat on/off-ramp flows, VBA onboarding). However, the hard rule seed of ALL is maintained because:
If narrowing were appropriate (without the hard rule), only SmokeMoney would be the primary tag, with no additional dependent tags needed since this is a VBA onboarding screen (not a swap/confirmation flow). Performance reasoningExpand to readThe changes are focused on a new VBA onboarding details screen and a ramps-controller patch bump. There are no performance-sensitive flows affected — no asset loading, account list rendering, login/unlock, swap execution, or app launch paths are modified. The new VbaDetails screen is a simple static screen with a Done button. No performance test tags are warranted. |
|



Description
When VBA onboarding finishes provisioning the Money account (
hydrateVbaOnboardingreturnsautorampStatus: 'ready'→destinationId: 'complete'), the coordinator navigated straight to Money Home. Since the user is already in the Money area, a successful account creation looked like nothing happened — the onboarding sheet just closed with no confirmation.This adds a terminal "Virtual bank account" details screen and routes to it on completion instead of silently returning to Money Home. It's currently a stub (title + description + a Done button that returns to Money Home); real account details will render here in a follow-up.
Changes
VbaDetails.tsx(+VbaDetails.test.tsx)VbaOnboardingRoutes.DETAILSinroutes.tsandVbaOnboardingNavigator.tsxuseVbaOnboardingRoutingcompletedestination now navigates to the details screen (was Money Home)virtual_bank_account.vba_detailsstrings@metamask/ramps-controllerto^26.0.1(relay-approved KYC gating fix from fix(ramps-controller): treat relay-approved KYC as approved in hydrate core#10497)Changelog
CHANGELOG entry: Added a Virtual bank account details screen shown when VBA onboarding completes
Related issues
Refs: MetaMask/core#10497 —
@metamask/ramps-controllerfix (relay-approved KYC gating) required for thecompletepath to be reachable end-to-end. This client PR is independent and self-contained; the full flow lands now that ramps-controller is bumped to26.0.1.Manual testing steps
Screenshots/Recordings
Before
N/A — on completion the onboarding sheet closed and the user was returned to Money Home with no confirmation screen.
After
N/A — stub screen (title, description, Done button); real account details will be added in a follow-up.
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Scoped VBA onboarding navigation and a placeholder UI; no auth or payment logic changes beyond the ramps-controller patch bump.
Overview
When VBA onboarding finishes provisioning (
destinationId: 'complete'/autorampStatus: 'ready'), users now land on a new Virtual bank account confirmation screen instead of being sent straight to Money Home (which felt like nothing happened).The PR adds stub screen
VbaDetails(title, copy, Done → Money Home), registersVbaOnboardingRoutes.DETAILSon the onboarding stack, and updatesnavigateToVbaOnboardingDestinationanduseOpenVbaOnboardingtests to route there. Addsvirtual_bank_account.vba_detailsstrings and bumps@metamask/ramps-controllerto 26.0.1.Reviewed by Cursor Bugbot for commit fb615ae. Bugbot is set up for automated code reviews on this repo. Configure here.