Repository navigation
perf(login): add temporary aggregate3 codec benchmark - #38132
Prithpal-Sooriya wants to merge 1 commit into
Conversation
Copy the core aggregate3 codecs into a dev-only login control so a 300-call batch can be timed on Hermes before the production change. Co-authored-by: Cursor <cursoragent@cursor.com>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Smart E2E Test SelectionSelected E2E tags: No E2E tests selected AI Confidence: 95 E2E reasoningExpand to readThis PR adds a developer-only performance benchmarking tool for comparing aggregate3 ABI codecs (ethers vs viem vs handrolled). The key analysis points:
No existing E2E test flows are affected. The Login screen behavior in production builds is identical to before. No shared components, controllers, state management, or navigation flows were modified. This is a purely additive, dev-only change with zero production blast radius. Performance reasoningExpand to readThe performance benchmark utilities added in this PR ( |
|
Closing this experiment: no commits in 7 days. The branch is still there if you want to reopen it. |
Description
Temporary dev-only harness for comparing Multicall3
aggregate3codecs on Hermes, ahead of MetaMask/core#11010.The hand-rolled, viem, and stock Ethers codecs are copied into the app. A
__DEV__button on the login screen times a realistic 300-call balance batch and logsAGGREGATE3_BENCH. Measured results for a Xiaomi phone and an arm64 Android emulator, including a 1-CPU emulator run, are indocs/performance/aggregate3-codec-android.md.This does not change production balance fetching. It is marked DO-NOT-MERGE so it can be dropped once the codec choice is settled.
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Refs: MetaMask/core#11010
Manual testing steps
Screenshots/Recordings
Before
N/A
After
N/A
On-device numbers are in
docs/performance/aggregate3-codec-android.md.Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Made with Cursor