Repository navigation
chore: adopt kyc-controller 0.13.0 and ramps-controller 28.0.0 - #38322
Conversation
Dependency bump only, no app behaviour change. Split out from the three VBA/KYC analytics PRs (#38078, #38160, #38161) that consume these APIs, so the major ramps bump gets a platform review on its own, the lockfile moves once rather than three times, and those PRs can produce a meaningful lint:tsc result. The one breaking change in ramps-controller 28.0.0 needs no code here: RAMPS_CONTROLLER_REQUIRED_SERVICE_ACTIONS gained NeoBankService:listAutorampTransactions, and the ramps controller messenger already spreads that package-owned list instead of enumerating actions. Note for review: @metamask/transaction-pay-controller@30.2.0 still pins ramps-controller ^27.1.0, so the tree now carries both 27.1.0 and 28.0.0. The action shapes it references are unchanged in 28.0.0; the clean fix is a TPC release widening its range. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
PR template — items to address before "Ready for review"Warnings — informational, address before merging:
See docs/readme/ready-for-review.md for the full Definition of Ready for Review. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Smart E2E Test SelectionSelected E2E tags: ALL AI Confidence: 100 E2E reasoningExpand to readThis PR contains two controller version bumps in package.json:
The hard rule seed (controller-version-update) already mandated ALL tags due to controller package version updates. The major version bump of ramps-controller and the shared test fixture change justify running all smoke tests to ensure no regressions across any flow that depends on the controller state or the base fixture. |
ramps-controller 28.0.0 adds autorampTransactionRecords to
getDefaultRampsControllerState, so Engine.test.ts "matches initial state
fixture" failed on the missing key.
The key is persisted state with a {} default, so existing installs pick it
up on the next write and no migration is needed. KycController 0.13.0 adds
no state, and this fixture is the only file that snapshots the ramps state
shape.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
49c0f97
|



Description
Adopts the two controller releases that the VBA / KYC analytics work depends on, and nothing else. No app behaviour changes.
@metamask/kyc-controller^0.12.0→^0.13.0@metamask/ramps-controller^27.1.0→^28.0.0This is deliberately split out from the three analytics PRs that consume these APIs (#38078, #38160, #38161) for four reasons:
ramps-controlleris a major bump (27.1.0 → 28.0.0, also skipping 27.2.0). That is a Ramps/platform review, not an analytics review, and it should not be buried in a PR about Segment events.yarn.lock.lint:tscresult until this lands.The breaking change is a no-op for us
ramps-controller@28.0.0has one breaking change:No code change is needed here.
ramps-controller-messenger.tsalready spreads the package-owned list rather than enumerating actions:and
NeoBankServiceis registered as a messenger client inEngine.ts, so the new action is delegated automatically.Reviewer note:
ramps-controlleris now duplicated in the tree@metamask/transaction-pay-controller@30.2.0depends on@metamask/ramps-controller@^27.1.0, so this bump un-dedupes it:TPC references ramps in its messenger types (
RampsControllerGetOrderAction,RampsControllerGetQuoteWithFeesAction). Those action shapes are unchanged in 28.0.0 — the only breaking change was the constant above — andlint:tscpasses, so this is a bundle-size cost rather than a correctness one. Flagging it so it is a conscious decision: the clean fix is a TPC release that widens its range to^28.0.0, which can follow separately.Changelog
CHANGELOG entry: null
Related issues
Refs: MetaMask/core#11017
Refs: MetaMask/core#11041
Refs: MetaMask/core#11141
Manual testing steps
Screenshots/Recordings
N/A — dependency bump with no UI change.
Before
N/A
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
Not applicable: no runtime code changes. The one performance-relevant consequence is the duplicated
ramps-controllernoted above, which is a bundle-size effect rather than a runtime one.Pre-merge reviewer checklist
🤖 Generated with Claude Code
Note
Medium Risk
Major ramps-controller bump touches VBA/autoramp and KYC-adjacent flows; runtime wiring appears pre-covered, but regressions in money onboarding are still possible.
Overview
Dependency-only PR that upgrades
@metamask/kyc-controller(^0.12.0→^0.13.0) and@metamask/ramps-controller(^27.1.0→^28.0.0), with matchingyarn.lockresolution. No application logic changes beyond keeping tests aligned with the new controller default state.The test background snapshot adds
autorampTransactionRecords: {}underRampsController, matching new state shipped in ramps-controller 28.ramps-controller-messenger.tsalready spreadsRAMPS_CONTROLLER_REQUIRED_SERVICE_ACTIONS, so the 28.0 breaking requirement to delegateNeoBankService:listAutorampTransactionsdoes not need a separate host change here.This bump is split ahead of VBA/KYC analytics PRs that depend on these package APIs. Note that
transaction-pay-controllermay still pullramps-controller@27.x, so the tree can temporarily carry two versions until TPC widens its range.Reviewed by Cursor Bugbot for commit 49c0f97. Bugbot is set up for automated code reviews on this repo. Configure here.