Skip to content

chore(money): bump money-account-api-data-service to 2.3.1 - #38371

Merged
ffmcgee725 merged 2 commits into
mainfrom
chore/MUSD-1490_bump-money-api-data-service
Oct 28, 2026
Merged

ffmcgee725 merged 2 commits into
mainfrom
chore/MUSD-1490_bump-money-api-data-service

Conversation

@ffmcgee725

@ffmcgee725 ffmcgee725 commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Description

Bumps @metamask/money-account-api-data-service from 2.3.0 to 2.3.1, the release that validates Money Account SIWE challenges before signing (MetaMask/core#11112, shipped in core release 1370.0.0).

2.3.1 rebuilds the expected SIWE message from the challenge nonce and the parsed Issued At, and requires an exact match before the service calls KeyringController:signPersonalMessage. A challenge with a wrong domain, URI, address, statement, version, chain ID, nonce, or timestamp — or an expired/future challenge — now throws MoneyAccountApiResponseValidationError instead of producing a signature over content the user never approved.

No mobile source changes are required: moneyAccountApiDataServiceInit already passes the Env derived from MM_API_ENV, and the service derives its SIWE domain/URI from the same MONEY_ACCOUNT_API_URL_MAP. The lockfile resolves a single copy of the package for both the direct dependency and @metamask/money-account-balance-service.

Changelog

CHANGELOG entry: null

Related issues

Refs: MUSD-1490
Refs: MUSD-1483
Refs: MetaMask/core#11112

Manual testing steps

Feature: Money Account VBA transfers authenticate with a validated SIWE challenge

  Scenario: Valid challenge loads VBA activity
    Given a Money Account with VBA transfers and the VBA activity feature flags enabled
    When the user opens Money activity
    Then pending and completed VBA transfers load as before

  Scenario: Tampered challenge is rejected before signing
    Given the Money Account API returns a challenge message that does not match the SIWE template
    When the service requests VBA transfers
    Then no personal_sign request is made
    And the transfers query fails with MoneyAccountApiResponseValidationError

Automated coverage for both scenarios lives in the core package (money-account-api-data-service). Mobile unit tests for the service init, messenger, and Money VBA hooks pass. Not manually tested on device; this is a draft PR.

Screenshots/Recordings

Before

N/A — dependency bump, no UI change.

After

N/A — dependency bump, no UI change.

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
  • I've tested with a power user scenario
  • I've instrumented key operations with Sentry traces for production performance metrics

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Pulls in stricter pre-sign SIWE validation on Money Account API auth paths; valid flows should be unchanged, but any API/challenge mismatch will fail earlier with no personal_sign prompt.

Overview
Bumps @metamask/money-account-api-data-service from 2.3.0 to 2.3.1 in package.json and yarn.lock only—no mobile app source changes.

The new release tightens Money Account SIWE authentication: before calling KeyringController:signPersonalMessage, the service rebuilds the expected SIWE message from the challenge nonce and Issued At and requires an exact match. Tampered or invalid challenges (wrong domain, URI, address, nonce, timestamps, etc.) now throw MoneyAccountApiResponseValidationError instead of signing content the user never approved.

Existing wiring (e.g. moneyAccountApiDataServiceInit with MM_API_ENV → Env) stays the same; VBA transfers and other Money API flows pick up the validation automatically.

Reviewed by Cursor Bugbot for commit fd76adf. Bugbot is set up for automated code reviews on this repo. Configure here.

Adds SIWE challenge validation before the service signs a personal message (MetaMask/core#11112, MUSD-1490). Mobile needs no source changes: the service derives the expected template from the env it already receives via MM_API_ENV.

Refs: MUSD-1490
@ffmcgee725 ffmcgee725 self-assigned this Oct 28, 2026
@socket-security

socket-security Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​money-account-api-data-service@​2.3.0 ⏵ 2.3.199 +610080 +197 +1100

View full report

@ffmcgee725
ffmcgee725 marked this pull request as ready for review October 28, 2026 09:53
@ffmcgee725
ffmcgee725 enabled auto-merge October 28, 2026 09:54
@github-actions

Copy link
Copy Markdown
Contributor

Smart E2E Test Selection

Selected E2E tags: SmokeMoney

AI Confidence: 75

E2E reasoning

Expand to read

The PR makes a single patch version bump of @metamask/money-account-api-data-service from ^2.3.0 to ^2.3.1 in package.json and yarn.lock. The only internal change in the package is a sub-dependency bump of @metamask/utils from ^12.0.0 to ^12.0.1.

This package is named money-account-api-data-service, which directly relates to the MetaMask Card and money account features covered by the SmokeMoney tag. The SmokeMoney tag covers MetaMask Card home screen, Add Funds flows, Advanced Card Management, and ramps flows.

Risk is low because:

  1. This is a patch version bump (2.3.0 → 2.3.1), indicating a bug fix or minor improvement
  2. No application code was changed - only the dependency version
  3. The sub-dependency change (@metamask/utils 12.0.0 → 12.0.1) is also a patch bump
  4. No other packages were changed

The SmokeMoney tag is selected to validate that the Card/money account flows continue to work correctly after this dependency update. No other E2E areas are impacted by this change.

View run

@sonarqubecloud

Copy link
Copy Markdown

@ffmcgee725
ffmcgee725 added this pull request to the merge queue Oct 28, 2026
Merged via the queue into main with commit 9331839 Oct 28, 2026
128 checks passed
@ffmcgee725
ffmcgee725 deleted the chore/MUSD-1490_bump-money-api-data-service branch October 28, 2026 10:58
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 28, 2026
@metamask-ci metamask-ci Bot added the release-8.19.0 Issue or pull request that will be included in release 8.19.0 label Oct 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-8.19.0 Issue or pull request that will be included in release 8.19.0 size-XS team-earn

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants