Repository navigation
chore(money): bump money-account-api-data-service to 2.3.1 - #38371
Conversation
Adds SIWE challenge validation before the service signs a personal message (MetaMask/core#11112, MUSD-1490). Mobile needs no source changes: the service derives the expected template from the env it already receives via MM_API_ENV. Refs: MUSD-1490
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Smart E2E Test SelectionSelected E2E tags: SmokeMoney AI Confidence: 75 E2E reasoningExpand to readThe PR makes a single patch version bump of This package is named Risk is low because:
The |
|



Description
Bumps
@metamask/money-account-api-data-servicefrom2.3.0to2.3.1, the release that validates Money Account SIWE challenges before signing (MetaMask/core#11112, shipped in core release1370.0.0).2.3.1rebuilds the expected SIWE message from the challenge nonce and the parsedIssued At, and requires an exact match before the service callsKeyringController:signPersonalMessage. A challenge with a wrong domain, URI, address, statement, version, chain ID, nonce, or timestamp — or an expired/future challenge — now throwsMoneyAccountApiResponseValidationErrorinstead of producing a signature over content the user never approved.No mobile source changes are required:
moneyAccountApiDataServiceInitalready passes theEnvderived fromMM_API_ENV, and the service derives its SIWE domain/URI from the sameMONEY_ACCOUNT_API_URL_MAP. The lockfile resolves a single copy of the package for both the direct dependency and@metamask/money-account-balance-service.Changelog
CHANGELOG entry: null
Related issues
Refs: MUSD-1490
Refs: MUSD-1483
Refs: MetaMask/core#11112
Manual testing steps
Automated coverage for both scenarios lives in the core package (
money-account-api-data-service). Mobile unit tests for the service init, messenger, and Money VBA hooks pass. Not manually tested on device; this is a draft PR.Screenshots/Recordings
Before
N/A — dependency bump, no UI change.
After
N/A — dependency bump, no UI change.
Pre-merge author checklist
Performance checks (if applicable)
Pre-merge reviewer checklist
Note
Medium Risk
Pulls in stricter pre-sign SIWE validation on Money Account API auth paths; valid flows should be unchanged, but any API/challenge mismatch will fail earlier with no personal_sign prompt.
Overview
Bumps
@metamask/money-account-api-data-servicefrom2.3.0to2.3.1inpackage.jsonandyarn.lockonly—no mobile app source changes.The new release tightens Money Account SIWE authentication: before calling
KeyringController:signPersonalMessage, the service rebuilds the expected SIWE message from the challenge nonce andIssued Atand requires an exact match. Tampered or invalid challenges (wrong domain, URI, address, nonce, timestamps, etc.) now throwMoneyAccountApiResponseValidationErrorinstead of signing content the user never approved.Existing wiring (e.g.
moneyAccountApiDataServiceInitwithMM_API_ENV→Env) stays the same; VBA transfers and other Money API flows pick up the validation automatically.Reviewed by Cursor Bugbot for commit fd76adf. Bugbot is set up for automated code reviews on this repo. Configure here.