Repository navigation
feat: adopt SentinelApiService for transaction simulation - #38485
matthewwalsh0 wants to merge 1 commit into
Conversation
PR template — items to address before "Ready for review"Warnings — informational, address before merging:
See docs/readme/ready-for-review.md for the full Definition of Ready for Review. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Smart E2E Test SelectionSelected E2E tags: ALL AI Confidence: 100 E2E reasoningExpand to readThis PR makes two critical dependency changes:
The combination of a preview transaction controller version and a wallet package patch that modifies transaction simulation behavior creates broad regression risk across:
The hard rule seed (controller-version-update) already identified ALL as the appropriate selection. This analysis confirms that assessment — the transaction controller touches every on-chain flow in the app. |
|



Description
Adopts MetaMask/core#9476. With it,
TransactionControllersends all Sentinel simulation requests through theSentinelApiService:simulateTransactionsmessenger action.@metamask/transaction-controller.@metamask/wallet@18.0.0that delegatesSentinelApiService:simulateTransactionsto the wallet'sTransactionControllermessenger. This mirrors the core wallet change in #9476.AnalyticsController), wallet 20 (GeolocationController) and #10997 (NetworkEnablementController) migrations. Those are separate pieces of work.SentinelApiServiceis already registered on the root messenger withAuthenticationController:getBearerTokendelegated. Mobile doesn't usegetSimulationConfig, so no code changes are needed.Before merging, replace the preview build and the patch with released versions.
Changelog
CHANGELOG entry: null
Related issues
Refs: MetaMask/core#9476
Manual testing steps
Screenshots/Recordings
N/A
Before
N/A
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist