Repository navigation
chore(assets-controller): bump assets controller to 20.0.2 - #38486
Conversation
Replace assetsForPriceUpdate with syncAssetsPrices, and align bridge, transaction-controller, and transaction-pay so the app resolves a single @metamask/assets-controller 20.0.1. Co-authored-by: prithpal.sooriya <prithpal.sooriya@consensys.net>
Merge main and move @metamask/assets-controller to 20.0.2. Align bridge-controller 83.1.2, transaction-controller 72.3.0, and transaction-pay-controller 30.3.1 so the lockfile resolves a single copy. Co-authored-by: prithpal.sooriya <prithpal.sooriya@consensys.net>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning MetaMask internal reviewing guidelines:
|
Co-authored-by: prithpal.sooriya <prithpal.sooriya@consensys.net>
Smart E2E Test SelectionSelected E2E tags: ALL AI Confidence: 100 E2E reasoningExpand to readThis PR updates multiple @MetaMask controller packages:
The hard rule seed (controller-version-update) already mandated ALL tags. The transaction-controller change is behavioral (not just a bug fix) — it changes how EIP-7702 transactions are estimated and confirmed, which is a core transaction flow change. Running ALL smoke tags is the appropriate conservative approach given the breadth of controller changes and their potential impact across all wallet flows. |
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
transaction-controller 72.3.0 confirms the EIP-7702 upgrade on Anvil, so the activity row is "Smart account upgraded" instead of the pending title. Co-authored-by: prithpal.sooriya <prithpal.sooriya@consensys.net>
|



Description
Bumps
@metamask/assets-controllerfrom^20.0.0to^20.0.2.20.0.2(core#11078) keeps the 20.0.0 API. The only product change is a fix: balance batches use hand-rolled Multicall3aggregate3codecs, and the Ethers codecs stay in place for a byte-identical comparison.20.0.1is included on the way up. It moves the controller onto@metamask/assets-controllers^113.0.0,@metamask/transaction-controller^72.3.0, and@metamask/permission-controller^14.1.0.Mobile already calls
AssetsController.syncAssetsPriceson main, so this PR does not change call sites. Companion ranges move so Yarn resolves a single@metamask/assets-controller@20.0.2:@metamask/bridge-controller^83.1.1→^83.1.2(depends on assets-controller^20.0.1)@metamask/transaction-controller^72.2.1→^72.3.0, and the resolution pin72.2.1→72.3.0@metamask/transaction-pay-controller^30.3.0→^30.3.1Changelog
CHANGELOG entry: null
Related issues
Refs: N/A — dependency bump with no linked issue. Follow-up to #38308 and core#11078.
Manual testing steps
N/A — no screen or copy change.
20.0.2only replaces the Multicall3 balance-batch codec inside the controller, and the call sites already usesyncAssetsPrices.Screenshots/Recordings
N/A — no user-visible UI change.
Before
N/A
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Medium Risk
Pulls in transaction-controller 72.3.0, which changes how type-4 smart-account upgrades are estimated and surfaced in activity, alongside assets-controller balance-batch encoding changes.
Reviewed by Cursor Bugbot for commit e03cd81. Bugbot is set up for automated code reviews on this repo. Configure here.