Skip to content

chore(assets-controller): bump assets controller to 20.0.2 - #38486

Merged
Prithpal-Sooriya merged 5 commits into
mainfrom
cursor/bump-assets-controller-2bbc
Nov 2, 2026
Merged

Prithpal-Sooriya merged 5 commits into
mainfrom
cursor/bump-assets-controller-2bbc

Conversation

@Prithpal-Sooriya

@Prithpal-Sooriya Prithpal-Sooriya commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Description

Bumps @metamask/assets-controller from ^20.0.0 to ^20.0.2.

20.0.2 (core#11078) keeps the 20.0.0 API. The only product change is a fix: balance batches use hand-rolled Multicall3 aggregate3 codecs, and the Ethers codecs stay in place for a byte-identical comparison. 20.0.1 is included on the way up. It moves the controller onto @metamask/assets-controllers ^113.0.0, @metamask/transaction-controller ^72.3.0, and @metamask/permission-controller ^14.1.0.

Mobile already calls AssetsController.syncAssetsPrices on main, so this PR does not change call sites. Companion ranges move so Yarn resolves a single @metamask/assets-controller@20.0.2:

  • @metamask/bridge-controller ^83.1.1 → ^83.1.2 (depends on assets-controller ^20.0.1)
  • @metamask/transaction-controller ^72.2.1 → ^72.3.0, and the resolution pin 72.2.1 → 72.3.0
  • @metamask/transaction-pay-controller ^30.3.0 → ^30.3.1

Changelog

CHANGELOG entry: null

Related issues

Refs: N/A — dependency bump with no linked issue. Follow-up to #38308 and core#11078.

Manual testing steps

N/A — no screen or copy change. 20.0.2 only replaces the Multicall3 balance-batch codec inside the controller, and the call sites already use syncAssetsPrices.

Screenshots/Recordings

N/A — no user-visible UI change.

Before

N/A

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Open in Web Open in Cursor 

Note

Medium Risk
Pulls in transaction-controller 72.3.0, which changes how type-4 smart-account upgrades are estimated and surfaced in activity, alongside assets-controller balance-batch encoding changes.

Reviewed by Cursor Bugbot for commit e03cd81. Bugbot is set up for automated code reviews on this repo. Configure here.

cursoragent and others added 2 commits October 29, 2026 08:12
Replace assetsForPriceUpdate with syncAssetsPrices, and align bridge, transaction-controller, and transaction-pay so the app resolves a single @metamask/assets-controller 20.0.1.

Co-authored-by: prithpal.sooriya <prithpal.sooriya@consensys.net>
Merge main and move @metamask/assets-controller to 20.0.2. Align bridge-controller 83.1.2, transaction-controller 72.3.0, and transaction-pay-controller 30.3.1 so the lockfile resolves a single copy.

Co-authored-by: prithpal.sooriya <prithpal.sooriya@consensys.net>
@github-actions github-actions Bot added size-XS pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. labels Oct 29, 2026
@socket-security

socket-security Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

@socket-security

socket-security Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Warning

MetaMask internal reviewing guidelines:

  • Do not ignore-all
  • Each alert has instructions on how to review if you don't know what it means. If lost, ask your Security Liaison or the supply-chain group
  • Copy-paste ignore lines for specific packages or a group of one kind with a note on what research you did to deem it safe.
    @SocketSecurity ignore npm/PACKAGE@VERSION
Priority Alert  (click "▶" to expand/collapse) Action
Low priority
Potential code anomaly (AI signal): npm @metamask/transaction-pay-controller is 96.0% likely to have a medium risk anomaly

Notes: This code implements a server-quote transaction flow and is not clearly malware. It signs quote-provided typed data and sends signatures to a quote-provided endpoint, and submits quote-derived transactions with requireApproval:false; a malicious or compromised quote source could therefore cause unauthorized signing or transaction submission. No fixed domain, URL, IP, credential target, or environment-variable access is present in the fragment. Severity is medium to high depending on validation and trust controls outside this file.

Confidence: 0.96

Severity: 0.63

From: package.json → npm/@metamask/transaction-pay-controller@30.3.1

ℹ Read more on: This package | This alert | What is an AI-detected potential code anomaly?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: An AI system found a low-risk anomaly in this package. It may still be fine to use, but you should check that it is safe before proceeding.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@metamask/transaction-pay-controller@30.3.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn

View full report

Co-authored-by: prithpal.sooriya <prithpal.sooriya@consensys.net>
@Prithpal-Sooriya Prithpal-Sooriya removed the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label Oct 29, 2026
juanmigdr
juanmigdr previously approved these changes Oct 29, 2026

@juanmigdr juanmigdr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Smart E2E Test Selection

Selected E2E tags: ALL

AI Confidence: 100

E2E reasoning

Expand to read

This PR updates multiple @MetaMask controller packages:

  1. @metamask/transaction-controller 72.2.1 → 72.3.0: This is the primary driver. The batch-transaction.spec.ts smoke test was updated to reflect a behavioral change — transaction-controller 72.3.0 now estimates EIP-7702 type-4 upgrade transactions as a single outer transaction that Anvil confirms (success state), rather than leaving it pending. This directly impacts SmokeConfirmations (EIP-7702 batch transactions, smart account upgrade flows) and indirectly affects all flows that submit transactions (SmokeSwap, SmokeStake, SmokeMoney, SmokeWalletPlatform).

  2. @metamask/transaction-pay-controller ^30.3.0 → ^30.3.1: Patch bump affecting gas fee payment flows, relevant to SmokeConfirmations and SmokeSwap.

  3. @metamask/assets-controller ^20.0.0 → ^20.0.2: Patch bump affecting token/asset management, relevant to SmokeNetworkAbstractions, SmokeSwap, and SmokeWalletPlatform.

  4. @metamask/bridge-controller ^83.1.1 → ^83.1.2: Patch bump affecting bridge flows, relevant to SmokeSwap.

The hard rule seed (controller-version-update) already mandated ALL tags. The transaction-controller change is behavioral (not just a bug fix) — it changes how EIP-7702 transactions are estimated and confirmed, which is a core transaction flow change. Running ALL smoke tags is the appropriate conservative approach given the breadth of controller changes and their potential impact across all wallet flows.

View run

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

transaction-controller 72.3.0 confirms the EIP-7702 upgrade on Anvil, so the activity row is "Smart account upgraded" instead of the pending title.

Co-authored-by: prithpal.sooriya <prithpal.sooriya@consensys.net>
@sonarqubecloud

Copy link
Copy Markdown

@dawnseeker8 dawnseeker8 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Prithpal-Sooriya
Prithpal-Sooriya added this pull request to the merge queue Nov 2, 2026
Merged via the queue into main with commit 8bf4c1b Nov 2, 2026
146 checks passed
@Prithpal-Sooriya
Prithpal-Sooriya deleted the cursor/bump-assets-controller-2bbc branch November 2, 2026 04:06
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 2, 2026
@metamask-ci metamask-ci Bot added the release-8.20.0 Issue or pull request that will be included in release 8.20.0 label Nov 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-8.20.0 Issue or pull request that will be included in release 8.20.0 size-S team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants