Repository navigation
feat(kyc): KYC owns the vendor terms page - #38815
Draft
georgeweiler wants to merge 3 commits into
Draft
georgeweiler wants to merge 3 commits into
georgeweiler wants to merge 3 commits into
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
3 of 4 tasks
Contributor
Smart E2E Test SelectionSelected E2E tags: ALL AI Confidence: 100 E2E reasoningExpand to readHard-rule seed (en.json locale change) selects ALL, and I kept it as the floor. The en.json diff only adds new kyc_vendor_terms keys, so existing selectors are not affected. The app changes add KYC VendorTerms and Virtual Bank Account (Ramp) screens and navigation. The test-infra change is a comment-only edit in the component-view mocks. Actual risk is probably limited to Ramp/Money flows, but I did not check smoke specs for VBA coverage, so I did not narrow the selection. |
georgeweiler
force-pushed
the
gw/kyc-owns-vendor-terms
branch
from
November 4, 2026 01:52
8741d45 to
f76ea83
Compare
3 of 10 tasks
4 tasks done
cursor
Bot
force-pushed
the
gw/kyc-per-vendor-sessions
branch
from
November 10, 2026 18:54
a559e5b to
66a629e
Compare
VBA's opening screen used to double as Iron's terms page. Split it: VBA keeps the product pitch, and a new KYC-owned VendorTerms screen loads the vendor's catalog, stores acceptance on the KYC controller and reports back. - New KYC/Views/VendorTerms screen, parameterised by vendor; callers can add documents (VBA adds MoonPay's privacy policy) and receive viewed / accepted / failed events for their own analytics - useKycDisclaimers moves to KYC/hooks/useVendorDisclaimers and takes a vendor - VBA's opening screen continues into the KYC terms screen, hosted in the VBA navigator until the KYC module has its own navigator Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Move the local-user-secret prefetch onto VendorTerms with the catalog fetch, give the new route its own KYC screen-performance id, and port the opening-screen terms tests onto the terms screen. Co-authored-by: george.weiler <george.weiler@consensys.net>
cursor
Bot
force-pushed
the
gw/kyc-owns-vendor-terms
branch
from
November 10, 2026 19:45
f76ea83 to
5b2e4bc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #38814.
VBA's opening screen (
CreateVirtualBankAccount) did two jobs at once: it was VBA's product pitch and Iron's terms page. KYC should own each vendor's terms, so the next feature (Kalshi) can reuse the same screen. This PR splits the two jobs.KYC/Views/VendorTermsscreen, parameterised by vendor. It loads that vendor's catalog for the user's country, stores acceptance on the KYC controller (not yet submitted), and reports back. Callers can add documents (VBA adds MoonPay's privacy policy, TRAM-4169) and receive viewed / accepted / failed events to record their own analytics. The KYC screen imports nothing from VBA.useKycDisclaimersmoves toKYC/hooks/useVendorDisclaimersand takes the vendor.VbaKycVendorTermsroute.Assumption needing design sign-off: VBA keeps a separate opening screen, so onboarding gains one screen. The alternative is that the product content moves somewhere else.
Differences to review:
display_name. The old single-document "MoonPay's Terms and Conditions" label (TRAM-4169) is gone.kyc_vendor_terms.*).CreateVirtualBankAccountSelectorsIDstoVendorTermsSelectorsIDs.CI will fail for the same reason as #38814 (the core change in MetaMask/core#11399 isn't released), and some unit tests for the moved hook and the opening screen still need updating.
Changelog
CHANGELOG entry: Moved the bank account terms and conditions onto their own screen during virtual bank account setup
Related issues
Refs: MetaMask/core#11399
Manual testing steps
Verified on the iOS simulator against locally built core packages: the Money home card opens the product-only opening screen, "Get account details" opens the KYC terms screen (MoonPay's privacy policy plus Iron's catalog document), and "Agree and continue" stores
sessions.iron.vendorDisclaimersAcceptedwithsubmitted: false. Hydrate then reportsvendorTermsAcceptedLocally: true, and onboarding moves to the email step.Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
🤖 Generated with Claude Code
Description
Stacked on #38814. Rebased onto that branch after it was rebased onto main.
VBA's opening screen (
CreateVirtualBankAccount) did two jobs at once: it was VBA's product pitch and Iron's terms page. KYC should own each vendor's terms, so the next feature (Kalshi) can reuse the same screen. This PR splits the two jobs.KYC/Views/VendorTermsscreen, parameterised by vendor. It loads that vendor's catalog for the user's country, stores acceptance on the KYC controller (not yet submitted), and reports back. Callers can add documents (VBA adds MoonPay's privacy policy, TRAM-4169) and receive viewed / accepted / failed events to record their own analytics. The KYC screen imports nothing from VBA.useKycDisclaimersmoves toKYC/hooks/useVendorDisclaimersand takes the vendor.VbaKycVendorTermsroute.VendorTerms. The opening screen leaves its button busy after a successful continue, so Fabric does not re-parent the label while the screen is leaving.Assumption needing design sign-off: VBA keeps a separate opening screen, so onboarding gains one screen. The alternative is that the product content moves somewhere else.
Differences to review:
display_name. The old single-document "MoonPay's Terms and Conditions" label (TRAM-4169) is gone.kyc_vendor_terms.*).vendor_termsscreen-performance id. The terms screen reportskyc_vendor_terms.CreateVirtualBankAccountSelectorsIDstoVendorTermsSelectorsIDs.CI will fail for the same reason as #38814 (the core change in MetaMask/core#11399 isn't released).
Changelog
CHANGELOG entry: Moved the bank account terms and conditions onto their own screen during virtual bank account setup
Related issues
Refs: MetaMask/core#11399
Manual testing steps
Verified on the iOS simulator against locally built core packages, before this rebase: the Money home card opens the product-only opening screen, "Get account details" opens the KYC terms screen (MoonPay's privacy policy plus Iron's catalog document), and "Agree and continue" stores
sessions.iron.vendorDisclaimersAcceptedwithsubmitted: false. Hydrate then reportsvendorTermsAcceptedLocally: true, and onboarding moves to the email step.Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
🤖 Generated with Claude Code