Repository navigation
chore(settings): remove unused settings action creators - #38952
Conversation
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
Smart E2E Test SelectionSelected E2E tags: No E2E tests selected AI Confidence: 95 E2E reasoningExpand to readThe PR removes two action creators from app/actions/settings/index.js: |
|



Description
Remove two unused Redux action creators from
app/actions/settings/index.js. Owner set: (none). No user-facing behavior change.toggleDeviceNotificationhas no importers.NotificationServicestill dispatches theTOGGLE_DEVICE_NOTIFICATIONSstring, and the settings reducer still handles it, so only the unused creator is deleted.setTokenSortConfighere is the unused action creator.SET_TOKEN_SORT_CONFIGhas no other references.PreferencesController.setTokenSortConfigis a different method and is unchanged.Docs/comments updated: none
Changelog
CHANGELOG entry: null
Related issues
Refs: proactive dead-code cleanup (see #34030)
Manual testing steps
N/A — deletes code with no inbound references; verified with yarn lint:tsc, eslint and jest on affected directories (no snapshot changes).
Screenshots/Recordings
N/A — no UI change
Before
N/A — no UI change
After
N/A — no UI change
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Dead-code deletion with no inbound references and no user-facing behavior change.
Overview
Removes two unused Redux action creators from
app/actions/settings/index.js:toggleDeviceNotificationandsetTokenSortConfig.Nothing in the app imported these exports. Device notifications still work the same way—
NotificationServicedispatchesTOGGLE_DEVICE_NOTIFICATIONSdirectly and the settings reducer still handles that type. Token sort still goes throughPreferencesController.setTokenSortConfig; only the dead settings action (and itsSET_TOKEN_SORT_CONFIGtype) is gone.Reviewed by Cursor Bugbot for commit a70d9f5. Bugbot is set up for automated code reviews on this repo. Configure here.