Repository navigation
chore(streams): remove unused JSON stream transforms - #38953
Merged
Merged
Conversation
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
Contributor
Smart E2E Test SelectionSelected E2E tags: No E2E tests selected AI Confidence: 90 E2E reasoningExpand to readThis PR removes dead code from app/util/streams.js (jsonParseStream and jsonStringifyStream functions that used through2) and removes the through2 dependency from package.json/yarn.lock. Key findings:
Since no existing behavior is modified, no shared components are changed in a way that could break tests, and the critical setupMultiplex function is untouched, there is no need to run any E2E smoke tests for this change. The risk of breaking any existing E2E test is negligible. |
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
|
georgewrmarshall
enabled auto-merge
November 5, 2026 13:11
amandaye0h
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Remove two unused JSON stream transforms from
app/util/streams.js. Owner set: (none). No user-facing behavior change.setupMultiplexstays. SnapBridge and BackgroundBridge still use it. Thethrough2require existed only for the deleted transforms.Docs/comments updated: none
Changelog
CHANGELOG entry: null
Related issues
Refs: proactive dead-code cleanup (see #34030)
Manual testing steps
N/A — deletes code with no inbound references; verified with yarn lint:tsc, eslint and jest on affected directories (no snapshot changes).
Screenshots/Recordings
N/A — no UI change
Before
N/A — no UI change
After
N/A — no UI change
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Unused export removal with no inbound references; multiplex setup path is unchanged.
Overview
Removes dead code from
app/util/streams.js:jsonParseStream,jsonStringifyStream, and thethrough2dependency that existed only for those helpers.The module now exports only
setupMultiplex, which SnapBridge and BackgroundBridge still import. No call sites referenced the deleted transforms.Reviewed by Cursor Bugbot for commit 62e6418. Bugbot is set up for automated code reviews on this repo. Configure here.
Description
Remove two unused JSON stream transforms from
app/util/streams.js. Owner set: (none). No user-facing behavior change.setupMultiplexstays. SnapBridge and BackgroundBridge still use it. Thethrough2require and thethrough2package.json dependency existed only for the deleted transforms.yarn depcheckreports no unused dependencies after this change.Docs/comments updated: none
Changelog
CHANGELOG entry: null
Related issues
Refs: proactive dead-code cleanup (see #34030)
Manual testing steps
N/A — deletes code with no inbound references; verified with yarn lint:tsc, eslint and jest on affected directories (no snapshot changes).
Screenshots/Recordings
N/A — no UI change
Before
N/A — no UI change
After
N/A — no UI change
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist