Repository navigation
chore(delegation): remove unused hex helpers - #38955
Merged
georgewrmarshall merged 1 commit intoNov 6, 2026
Merged
Conversation
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
Contributor
Smart E2E Test SelectionSelected E2E tags: No E2E tests selected AI Confidence: 98 E2E reasoningExpand to readThe PR removes two unused exports from the Delegation module:
A codebase-wide grep confirms neither |
|
georgewrmarshall
enabled auto-merge
November 5, 2026 19:22
amandaye0h
approved these changes
Nov 6, 2026
georgewrmarshall
deleted the
cursor/remove-dead-code-delegation-20261105
branch
November 6, 2026 07:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Remove two unused delegation helpers. Owner set: (none). No user-facing behavior change.
Both symbols were added with the delegation-controller integration on 2025-10-14 and have no importers. The file
app/core/Delegation/delegation.tswas last changed on 2026-10-14 on unrelated lines.0xcef6d209does not appear anywhere else.Docs/comments updated: none
Changelog
CHANGELOG entry: null
Related issues
Refs: proactive dead-code cleanup (see #34030)
Manual testing steps
N/A — deletes code with no inbound references; verified with yarn lint:tsc, eslint and jest on affected directories (no snapshot changes).
Screenshots/Recordings
N/A — no UI change
Before
N/A — no UI change
After
N/A — no UI change
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Dead-code deletion only; delegation encoding and redemption paths are unchanged.
Overview
Removes two unused exports from the delegation core module with no inbound references and no behavior change.
REDEEM_DELEGATIONS_SELECTOR(0xcef6d209) is deleted fromdelegation.ts; redeem calldata still goes throughencodeRedeemDelegations, which derives the selector viatoFunctionSelector.isHexEqualis removed fromutils.ts; hex comparison elsewhere was not using this helper.Reviewed by Cursor Bugbot for commit f945f71. Bugbot is set up for automated code reviews on this repo. Configure here.